[
https://issues.apache.org/jira/browse/YARN-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391102#comment-14391102
]
Naganarasimha G R commented on YARN-2729:
-----------------------------------------
Thanks [~wangda] for the review,
bq. I think it will be fine if we don't launch timer (if don't launch timer is
just a simple change), or you can just set timer to a very big value that it
will never get launched.
yes its configurable, but was just trying to avoid another thread of timer if
not required and also was checking with you as i was not sure that it would
be a better approach to take some decision based on the value configured for
interval-ms (0 or -1 to not to launch the timer task) and i dint want to add
a new configuration to enable or disable the timer
bq. You already have a ScriptBasedNodeLabelsProvider, use it now and we can see
if there's chance to merge it to NodeHealthScriptRunner in the future (low
priority).
yep felt so... hence dint further work on it. :)
bq. And did you forgot add "ScriptBasedNodeLabelsProvider" in your latest patch?
my mistake will update along with the conclusion for the first point ....
> Support script based NodeLabelsProvider Interface in Distributed Node Label
> Configuration Setup
> -----------------------------------------------------------------------------------------------
>
> Key: YARN-2729
> URL: https://issues.apache.org/jira/browse/YARN-2729
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Reporter: Naganarasimha G R
> Assignee: Naganarasimha G R
> Fix For: 2.8.0
>
> Attachments: YARN-2729.20141023-1.patch, YARN-2729.20141024-1.patch,
> YARN-2729.20141031-1.patch, YARN-2729.20141120-1.patch,
> YARN-2729.20141210-1.patch, YARN-2729.20150309-1.patch,
> YARN-2729.20150322-1.patch, YARN-2729.20150401-1.patch
>
>
> Support script based NodeLabelsProvider Interface in Distributed Node Label
> Configuration Setup .
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
