[
https://issues.apache.org/jira/browse/YARN-3463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14500937#comment-14500937
]
Jian He commented on YARN-3463:
-------------------------------
- this.schedulableEntities != null can never happen? since each time it’s
re-creating a new Ordering class. I think we can just initialize
{{this.comparator}} and {{this.schedulableEntities}} inside FifoOrderingPolicy
constructor and remove the setComparator method
{code}
if (this.schedulableEntities != null) {
schedulableEntities.addAll(this.schedulableEntities);
}
{code}
- this should be inside the {removed} check ? otherwise any unknown container
completed will cause reordering
{code}
orderingPolicy.containerReleased(application, rmContainer);
{code}
- getStatusMessage -> getInfo ?
> Integrate OrderingPolicy Framework with CapacityScheduler
> ---------------------------------------------------------
>
> Key: YARN-3463
> URL: https://issues.apache.org/jira/browse/YARN-3463
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacityscheduler
> Reporter: Craig Welch
> Assignee: Craig Welch
> Attachments: YARN-3463.50.patch, YARN-3463.61.patch,
> YARN-3463.64.patch, YARN-3463.65.patch, YARN-3463.66.patch,
> YARN-3463.67.patch, YARN-3463.68.patch
>
>
> Integrate the OrderingPolicy Framework with the CapacityScheduler
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
