[
https://issues.apache.org/jira/browse/YARN-3484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14519636#comment-14519636
]
Hadoop QA commented on YARN-3484:
---------------------------------
\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 0m 0s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | release audit | 0m 15s | The applied patch does
not increase the total number of release audit warnings. |
| {color:blue}0{color} | shellcheck | 0m 15s | Shellcheck was not available. |
| | | 0m 23s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12729211/YARN-3484.002.patch |
| Optional Tests | shellcheck |
| git revision | trunk / 8f82970 |
| Java | 1.7.0_55 |
| uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/7542/console |
This message was automatically generated.
> Fix up yarn top shell code
> --------------------------
>
> Key: YARN-3484
> URL: https://issues.apache.org/jira/browse/YARN-3484
> Project: Hadoop YARN
> Issue Type: Bug
> Components: scripts
> Affects Versions: 3.0.0
> Reporter: Allen Wittenauer
> Assignee: Varun Vasudev
> Attachments: YARN-3484.001.patch, YARN-3484.002.patch
>
>
> We need to do some work on yarn top's shell code.
> a) Just checking for TERM isn't good enough. We really need to check the
> return on tput, especially since the output will not be a number but an error
> string which will likely blow up the java code in horrible ways.
> b) All the single bracket tests should be double brackets to force the bash
> built-in.
> c) I'd think I'd rather see the shell portion in a function since it's rather
> large. This will allow for args, etc, to get local'ized and clean up the
> case statement.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
