[
https://issues.apache.org/jira/browse/YARN-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14633469#comment-14633469
]
Devaraj K commented on YARN-3896:
---------------------------------
Thanks [~hex108] for the updated patch.
There are some comments about the test.
# Can we have a separate new test for this case instead of adding it with other
existing test?
# Can you avoid mentioning the JIRA ID in the comment?
{code:xml}+ // Simulate scenario from YARN-3896:{code}
# There are multiple sleep statements with hard coded values in the newly added
test code. Can you avoid these sleep with hard coded timeouts?
# And also If I try to run the test without source changes, test is failing
with this message "node shouldn't be null". Can we check for REBOOTED state
here?
> RMNode transitioned from RUNNING to REBOOTED because its response id had not
> been reset
> ---------------------------------------------------------------------------------------
>
> Key: YARN-3896
> URL: https://issues.apache.org/jira/browse/YARN-3896
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
> Reporter: Jun Gong
> Assignee: Jun Gong
> Attachments: YARN-3896.01.patch, YARN-3896.02.patch,
> YARN-3896.03.patch, YARN-3896.04.patch
>
>
> {noformat}
> 2015-07-03 16:49:39,075 INFO org.apache.hadoop.yarn.util.RackResolver:
> Resolved 10.208.132.153 to /default-rack
> 2015-07-03 16:49:39,075 INFO
> org.apache.hadoop.yarn.server.resourcemanager.ResourceTrackerService:
> Reconnect from the node at: 10.208.132.153
> 2015-07-03 16:49:39,075 INFO
> org.apache.hadoop.yarn.server.resourcemanager.ResourceTrackerService:
> NodeManager from node 10.208.132.153(cmPort: 8041 httpPort: 8080) registered
> with capability: <memory:6144, vCores:60, diskCapacity:213>, assigned nodeId
> 10.208.132.153:8041
> 2015-07-03 16:49:39,104 INFO
> org.apache.hadoop.yarn.server.resourcemanager.ResourceTrackerService: Too far
> behind rm response id:2506413 nm response id:0
> 2015-07-03 16:49:39,137 INFO
> org.apache.hadoop.yarn.server.resourcemanager.rmnode.RMNodeImpl: Deactivating
> Node 10.208.132.153:8041 as it is now REBOOTED
> 2015-07-03 16:49:39,137 INFO
> org.apache.hadoop.yarn.server.resourcemanager.rmnode.RMNodeImpl:
> 10.208.132.153:8041 Node Transitioned from RUNNING to REBOOTED
> {noformat}
> The node(10.208.132.153) reconnected with RM. When it registered with RM, RM
> set its lastNodeHeartbeatResponse's id to 0 asynchronously. But the node's
> heartbeat come before RM succeeded setting the id to 0.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
