[ https://issues.apache.org/jira/browse/YARN-3958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14640893#comment-14640893 ]
Hadoop QA commented on YARN-3958: --------------------------------- \\ \\ | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 17m 28s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 2 new or modified test files. | | {color:green}+1{color} | javac | 7m 40s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 9m 37s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 22s | The applied patch does not increase the total number of release audit warnings. | | {color:green}+1{color} | checkstyle | 1m 55s | There were no new checkstyle issues. | | {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 1m 20s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 3m 7s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | yarn tests | 0m 23s | Tests passed in hadoop-yarn-api. | | {color:green}+1{color} | yarn tests | 1m 56s | Tests passed in hadoop-yarn-common. | | | | 44m 24s | | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12747066/YARN-3958.03.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / fbd6063 | | hadoop-yarn-api test log | https://builds.apache.org/job/PreCommit-YARN-Build/8652/artifact/patchprocess/testrun_hadoop-yarn-api.txt | | hadoop-yarn-common test log | https://builds.apache.org/job/PreCommit-YARN-Build/8652/artifact/patchprocess/testrun_hadoop-yarn-common.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/8652/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/8652/console | This message was automatically generated. > TestYarnConfigurationFields should be moved to hadoop-yarn-api > -------------------------------------------------------------- > > Key: YARN-3958 > URL: https://issues.apache.org/jira/browse/YARN-3958 > Project: Hadoop YARN > Issue Type: Bug > Affects Versions: 2.7.0 > Reporter: Varun Saxena > Assignee: Varun Saxena > Attachments: YARN-3958.01.patch, YARN-3958.02.patch, > YARN-3958.03.patch > > > Currently TestYarnConfigurationFields is present in hadoop-yarn-common. The > test is for checking whether all the configurations declared in > YarnConfiguration exist in yarn-default.xml or not. > But as YarnConfiguration is in hadoop-yarn-api, if somebody changes this > file, it is not necessary that this test will be run. So if the developer > misses to update yarn-default.xml and patch is committed, it will lead to > unnecessary test failures after commit. -- This message was sent by Atlassian JIRA (v6.3.4#6332)