[
https://issues.apache.org/jira/browse/YARN-3958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14641558#comment-14641558
]
Varun Saxena commented on YARN-3958:
------------------------------------
[~ajisakaa],
Checked the test. You are correct.
But I think this would be a major change.
I have a concern that there might be some projects which might have induced
dependency in their pom on hadoop-yarn-api because they want to use
YarnConfiguration class. Pls note hadoop-yarn-api does not have dependency on
hadoop-yarn-common in its pom.xml
Change can be made but this should go in branch-2 then ?
Moreover, realistically will somebody add a YARN related config in
yarn-default.xml but not add it in YarnConfiguration class ?
I think unlikely. The reverse happens far more frequently.
So in branch-2 we can just move this test to hadoop-yarn-api and in trunk, move
YarnConfiguration to hadoop-yarn-common. Thoughts ?
> TestYarnConfigurationFields should be moved to hadoop-yarn-api
> --------------------------------------------------------------
>
> Key: YARN-3958
> URL: https://issues.apache.org/jira/browse/YARN-3958
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 2.7.0
> Reporter: Varun Saxena
> Assignee: Varun Saxena
> Attachments: YARN-3958.01.patch, YARN-3958.02.patch,
> YARN-3958.03.patch
>
>
> Currently TestYarnConfigurationFields is present in hadoop-yarn-common. The
> test is for checking whether all the configurations declared in
> YarnConfiguration exist in yarn-default.xml or not.
> But as YarnConfiguration is in hadoop-yarn-api, if somebody changes this
> file, it is not necessary that this test will be run. So if the developer
> misses to update yarn-default.xml and patch is committed, it will lead to
> unnecessary test failures after commit.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
