[
https://issues.apache.org/jira/browse/YARN-5018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297139#comment-15297139
]
Sangjin Lee commented on YARN-5018:
-----------------------------------
[~gtCarrera9], thanks for the patch! I think defining a state after
{{postPut()}} so that we can check it is a good idea. Having said that, I am a
little concerned that we'd now have two {{postPut()}} methods, one for
{{TimelineCollectorManager}} and the {{TimelineCollector}} itself. That might
make things more complicated than is necessary.
How about this? Instead of creating a separate {{TimelineCollector.postPut()}}
method and a boolean variable, how about delaying {{start}} ing the timeline
collector until after the existing {{TimelineCollectorManager.postPut()}}? The
timeline collector isn't really ready to use until {{postPut()}} is performed.
So I think it may make sense to start it *after* {{postPut()}} is called.
Then, instead of a boolean variable, we can call
{{AbstractService.isInState(State.STARTED)}}, right?
Would this idea work?
> Online aggregation logic should not run immediately after collectors got
> started
> --------------------------------------------------------------------------------
>
> Key: YARN-5018
> URL: https://issues.apache.org/jira/browse/YARN-5018
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Li Lu
> Assignee: Li Lu
> Labels: yarn-2928-1st-milestone
> Attachments: YARN-5018-YARN-2928.001.patch,
> YARN-5018-YARN-2928.002.patch, YARN-5018-YARN-2928.003.patch,
> YARN-5018-YARN-2928.004.patch
>
>
> In app level collector, we launch the aggregation logic immediately after the
> collector got started. However, at this time, important context data has yet
> to be published to the container. Also, if the aggregation result is empty,
> we do not need to publish them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
