[ https://issues.apache.org/jira/browse/YARN-5018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297449#comment-15297449 ]
Li Lu commented on YARN-5018: ----------------------------- Thanks [~sjlee0]! That looks fine. I can hide the logic of collector.postPut inside collector manager's post put. One thing is we only need the ready flag in AppLevelTimelineCollector. Although it's the only available option for now, we may still need to inquiry the type of the collector in collector manager to set that flag. I think this is still better than having a separate postPut method, though. > Online aggregation logic should not run immediately after collectors got > started > -------------------------------------------------------------------------------- > > Key: YARN-5018 > URL: https://issues.apache.org/jira/browse/YARN-5018 > Project: Hadoop YARN > Issue Type: Sub-task > Components: timelineserver > Reporter: Li Lu > Assignee: Li Lu > Labels: yarn-2928-1st-milestone > Attachments: YARN-5018-YARN-2928.001.patch, > YARN-5018-YARN-2928.002.patch, YARN-5018-YARN-2928.003.patch, > YARN-5018-YARN-2928.004.patch > > > In app level collector, we launch the aggregation logic immediately after the > collector got started. However, at this time, important context data has yet > to be published to the container. Also, if the aggregation result is empty, > we do not need to publish them. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org