[
https://issues.apache.org/jira/browse/YARN-5561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15554982#comment-15554982
]
Varun Saxena commented on YARN-5561:
------------------------------------
bq. That said, these REST end points are enhancement of getEntitties and
getEntity. So, do not want to change any of the query params associated with
app-attempts and container. In future, we never know what
metrics/configs/relationships would be stored in attempts/containers.
Well the intention behind my comment was that we will document these REST
endpoints separately. So for the user its a distinct endpoint. The fact that we
in turn redirect this call to entity table is internal implementation.
And if we indicate that you can apply config filters etc., it may indicate that
we store them for containers, app attempts which we don't. And if there is
something which we don't publish from RM/NM, I thought its pointless to have
filter for it. Your thoughts on the same ?
We currently do not restrict clients to publish even YARN specific entities so
they can potentially publish configs for it but I remember we had a JIRA
related to that i.e. do not allow arbitrary clients to publish YARN entities.
I do not have a very strong opinion on this though. Let us see what others
think.
bq. This is one of point of concern for code readability. May be we can capture
in document, but not in java class file. Thought?
We had initially decided we will add both javadoc and documentation. We however
want to trim down the documentation a bit because some query params are
repeated.
Let us keep it consistent no matter what we do. We can probably add non-javadoc
comments over REST methods so that developer can read them. As such REST
endpoints are already captured in documentation for outside users of ATS. I
remember [~rohithsharma] you had a JIRA for it. Maybe we can handle it there if
the team reaches a consensus on this. [~sjlee0], your opinion on this ?
> [Atsv2] : Support for ability to retrieve apps/app-attempt/containers and
> entities via REST
> -------------------------------------------------------------------------------------------
>
> Key: YARN-5561
> URL: https://issues.apache.org/jira/browse/YARN-5561
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelinereader
> Reporter: Rohith Sharma K S
> Assignee: Rohith Sharma K S
> Attachments: 0001-YARN-5561.YARN-5355.patch, YARN-5561.02.patch,
> YARN-5561.patch, YARN-5561.v0.patch
>
>
> ATSv2 model lacks retrieval of {{list-of-all-apps}},
> {{list-of-all-app-attempts}} and {{list-of-all-containers-per-attempt}} via
> REST API's. And also it is required to know about all the entities in an
> applications.
> It is pretty much highly required these URLs for Web UI.
> New REST URL would be
> # GET {{/ws/v2/timeline/apps}}
> # GET {{/ws/v2/timeline/apps/\{app-id\}/appattempts}}.
> # GET
> {{/ws/v2/timeline/apps/\{app-id\}/appattempts/\{attempt-id\}/containers}}
> # GET {{/ws/v2/timeline/apps/\{app id\}/entities}} should display list of
> entities that can be queried.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
