[
https://issues.apache.org/jira/browse/YARN-5561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15555831#comment-15555831
]
Sangjin Lee commented on YARN-5561:
-----------------------------------
{quote}
That said, these REST end points are enhancement of getEntitties and getEntity.
So, do not want to change any of the query params associated with app-attempts
and container. In future, we never know what metrics/configs/relationships
would be stored in attempts/containers.
{quote}
Regarding whether to retain things that are not needed for app attempts and so
on, I don't have a strong opinion either way, but I might lean slightly towards
leaving them in. Even with the existing queries for them today, we don't
strongly reject them even if they are specified for app attempts but simply
return empty data, right? Also, leaving them in might be slightly more
future-proof. Again these are not strong preferences.
in terms of documenting, let's just be consistent and add the javadoc. Being
consistent is probably a good thing here. If we decide later that javadoc is
superfluous, we could take them out in bulk.
[~rohithsharma], does this need to go into trunk or can it stay in YARN-5355?
If it is needed on trunk (which is the impression I got), then let's change it
to a top level JIRA and create a patch based on the trunk. Once it is committed
to the trunk, we can cherry-pick it onto YARN-5355 (and its associated branch-2
branch).
> [Atsv2] : Support for ability to retrieve apps/app-attempt/containers and
> entities via REST
> -------------------------------------------------------------------------------------------
>
> Key: YARN-5561
> URL: https://issues.apache.org/jira/browse/YARN-5561
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelinereader
> Reporter: Rohith Sharma K S
> Assignee: Rohith Sharma K S
> Attachments: 0001-YARN-5561.YARN-5355.patch, YARN-5561.02.patch,
> YARN-5561.patch, YARN-5561.v0.patch
>
>
> ATSv2 model lacks retrieval of {{list-of-all-apps}},
> {{list-of-all-app-attempts}} and {{list-of-all-containers-per-attempt}} via
> REST API's. And also it is required to know about all the entities in an
> applications.
> It is pretty much highly required these URLs for Web UI.
> New REST URL would be
> # GET {{/ws/v2/timeline/apps}}
> # GET {{/ws/v2/timeline/apps/\{app-id\}/appattempts}}.
> # GET
> {{/ws/v2/timeline/apps/\{app-id\}/appattempts/\{attempt-id\}/containers}}
> # GET {{/ws/v2/timeline/apps/\{app id\}/entities}} should display list of
> entities that can be queried.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
