Really nice cleanups, Francesco. Thank you. Please land it! Gary
https://codereview.appspot.com/6856075/diff/5001/test/test_app.js File test/test_app.js (left): https://codereview.appspot.com/6856075/diff/5001/test/test_app.js#oldcode44 test/test_app.js:44: // XXX Apparently removing a DOM node is asynchronous (on Chrome at least) Weird that this comment is not in trunk. Not worrying about it. I agree that the tests seem reliable on Chrome without this code, so ripping it out seems fine. https://codereview.appspot.com/6856075/ -- https://code.launchpad.net/~frankban/juju-gui/bug-1081803-tests-mutate-url/+merge/135670 Your team Juju GUI Hackers is requested to review the proposed merge of lp:~frankban/juju-gui/bug-1081803-tests-mutate-url into lp:juju-gui. -- Mailing list: https://launchpad.net/~yellow Post to : [email protected] Unsubscribe : https://launchpad.net/~yellow More help : https://help.launchpad.net/ListHelp
