*** Submitted: Tests mutating URL and not removing test nodes.
One of the hotkeys tests mutated the URL. Both tests in that test case also failed when run in isolation, and some variables were unused. Also fixed tests leaving elements in the DOM: as a consequence, "Environmenton excellent provider" was visible at the top of the page after a test run. Now the container used by those tests is removed after each test is run. Also removed an XXX saying that removing the elements in afterEach can be problematic. I've tried to reproduce the erroneus behavior described, running the test suite several times, without success. Anyway, removing in afterEach what was created in beforeEach is something we do everywhere in the tests. So, that XXX confused me a bit, any hint? To avoid flickering in the test page, I tried to hide the nodes used by tests where possible. R= CC= https://codereview.appspot.com/6856075 https://codereview.appspot.com/6856075/ -- https://code.launchpad.net/~frankban/juju-gui/bug-1081803-tests-mutate-url/+merge/135670 Your team Juju GUI Hackers is requested to review the proposed merge of lp:~frankban/juju-gui/bug-1081803-tests-mutate-url into lp:juju-gui. -- Mailing list: https://launchpad.net/~yellow Post to : [email protected] Unsubscribe : https://launchpad.net/~yellow More help : https://help.launchpad.net/ListHelp
