On 11/06/2014 18:24, Andrei Gherzan wrote: > > > On Wed, Jun 11, 2014 at 11:19 AM, Alex J Lennon > <ajlen...@dynamicdevices.co.uk <mailto:ajlen...@dynamicdevices.co.uk>> > wrote: > > > On 11/06/2014 08:47, Andrei Gherzan wrote: >> >> >> >> On Wed, Jun 11, 2014 at 2:27 AM, Alex J Lennon >> <ajlen...@dynamicdevices.co.uk >> <mailto:ajlen...@dynamicdevices.co.uk>> wrote: >> >> >> On 10/06/2014 19:59, Andrei Gherzan wrote: >>> Hello Alex. >>> >>> On Sun, Jun 8, 2014 at 1:50 PM, Alex J Lennon >>> <ajlen...@dynamicdevices.co.uk >>> <mailto:ajlen...@dynamicdevices.co.uk>> wrote: >>> >>> This changes the build slightly as there are some >>> #ifdefs in there for Raspberry Pi. >>> >>> Also the codec configuration file used by >>> gstreamer1.0-omx codecs, /etc/xdg/gstomx.conf, is set >>> correctly to core-name=/usr/lib/libopenmaxil.so >>> >>> Change-Id: I2352ecabfd053717d9ccd2d22422e7d4b7588ce4 >>> Signed-off-by: Alex J Lennon >>> <ajlen...@dynamicdevices.co.uk >>> <mailto:ajlen...@dynamicdevices.co.uk>> >>> --- >>> recipes-multimedia/gstreamer/gstreamer1.0-omx.inc >>> | 2 ++ >>> recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend >>> | 1 + >>> >>> >>> I was thinking we we really need two files for this... I >>> know that yocto has an inc too. But i don't know if that >>> really makes sense for one line. What do you think? >>> >> >> I came across Yocto best practice here. This is more or less >> why I provided a patch for consideration into Poky on this >> earlier today. It would help me, and I suspect other newbies, >> to have best practice expectations on how to put patches >> together somewhere up front, say in the README. >> >> "Do not merge .inc / .bb files" >> >> >> https://wiki.yoctoproject.org/wiki/Best_Known_Methods_(BKMs)_for_Package_Updating >> >> <https://wiki.yoctoproject.org/wiki/Best_Known_Methods_%28BKMs%29_for_Package_Updating> >> >> >> I understand. But I think that this is the case only for bb >> files. We are talking here about a bbappend in which case this >> would be pretty useless. Nobody reuses an inc for a bbappend - >> never seen something like that. > > e.g. I have gstreamer1.0-omx_git.bbappend here which reuses the > .inc file. I didn't contribute it as for some reason the git build > breaks and I need to look at why this is > > > So, you say that if you merge your inc file in the bbappend one, the > build breaks? It shouldn't really. I just tested and for me it works. >
Not quite. I mean that I am reusing the code in the .inc file in another .bbappend file, called gstreamer1.0-omx_git.bbappend This is identical to gstreamer1.0-omx_1.0.0.bbappend in that it just requires the inc file, so I don't have duplication of code. Targetting gstreamer-omx 1.0.0 at the RPi works fine, but when I tried targetting the git source at RPi the build broke, so I didn't provide that recipe to you. e.g. with my local.conf set to PREFERRED_VERSION_gstreamer1.0-omx = "git" the git build gives this cc1: error: .../tmp/sysroots/raspberrypi/usr/include/vc: No such file or directory [-Werror] cc1: error: .../tmp/sysroots/raspberrypi/usr/include/interface: No such file or directory [-Werror] cc1: error: .../tmp/sysroots/raspberrypi/usr/include/interface/vcos: No such file or directory [-Werror] cc1: error: .../tmp/sysroots/raspberrypi/usr/include/interface/vcos/pthreads: No such file or directory $ cc1: all warnings being treated as errors make[2]: *** [libgstomx_la-gstomxvideoenc.lo] Error 1 make[2]: *** Waiting for unfinished jobs.... I think there's something missing or some path not set correctly for the more recent gstreamer-omx code, but I haven't had a chance to look into it. > By the way, I would use _append_raspberrypi for this one too. > > > OK, I just tried this instead of the anonymous python method I created in the last patch-set. Perhaps I'm misunderstanding but, for example, we need GSTREAMER_1_0_OMX_TARGET set to 'rpi" when machine is raspberrypi When I try, GSTREAMER_1_0_OMX_TARGET_append_raspberrypi = "rpi" I end up with the original value 'bellagio' appended with 'rpi' to give 'bellagiorpi' Maybe I need something more like this? GSTREAMER_1_0_OMX_TARGET_override_raspberrypi = "rpi" Does such a mechanism exist in bitbake? Regards, Alex
-- _______________________________________________ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto