On Mon, Aug 21, 2006 at 02:52:28PM -0700, Eric Schrock wrote:
> Are you willing to talk about what you're working on? [...]
Soon:)
> [...] To summarize, is
> the following an accurate description of the fixes?
[...]
> 03:
> Comparison of 0 == NULL. Is this on a system where NULL is
> #defined to be ((void *)0)?
Yes, which seems to be more correct - NULL is a pointer, while 0 is not.
> 05:
>
> Not sure what this is about. Does the compiler not support
> mathematical operations on constants in a case statement?
> Although I like the if() else form much better for stylistic
> reasons.
gcc warns, that those values are too big to be used in switch/case, it
can only handle ints.
> 06:
>
> Can you explain this one?
Explained in the other mail.
> 07:
>
> Other platforms don't have { 0 } indicate a default initialized
> mutex (we've seen this porting other pieces of software as well).
Actually, on FreeBSD we initialize with some magic value to detect
missing initializations, multiple initializations with destruction, etc.
> At this point, I'm not sure whether we need to treat these patches as
> contributions or just bug reports. I'll ping someone more familiar with
> the process to find out whether you need to agree to the Sun Contributor
> Agreement at:
>
> http://www.opensolaris.org/os/about/sun_contributor_agreement
I think those changes are too minor bother anyone:)
--
Pawel Jakub Dawidek http://www.wheel.pl
pjd at FreeBSD.org http://www.FreeBSD.org
FreeBSD committer Am I Evil? Yes, I Am!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
URL:
<http://mail.opensolaris.org/pipermail/zfs-code/attachments/20060822/d0c85318/attachment.bin>
