[ https://issues.apache.org/jira/browse/ZOOKEEPER-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848202#action_12848202 ]
Henry Robinson commented on ZOOKEEPER-722: ------------------------------------------ Hi Ivan - Thanks for the patch - it looks good. Hudson can't apply it because - I think - you used git diff to generate the patch file which doesn't produce patch -p0 compatible patchfiles. Could you regenerate with git diff --no-prefix and resubmit? Hudson will be able to apply the patch then. Thanks. Henry > zkServer.sh uses sh's builtin echo on BSD, behaves incorrectly. > --------------------------------------------------------------- > > Key: ZOOKEEPER-722 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-722 > Project: Zookeeper > Issue Type: Bug > Components: scripts > Environment: Mac OS X > Reporter: Ivan Kelly > Priority: Minor > Attachments: zk-722.diff > > > zkServer.sh output the PID of the zookeeper process with: > echo -n $! > "$ZOOPIDFILE" > This uses -n which sh's builtin echo does not support. From echo's manpage. > <snip> > Some shells may provide a builtin echo command which is similar or > identical to this utility. Most notably, the builtin echo in sh(1) does not > accept > the -n option. Consult the builtin(1) manual page. > </snip> > This means that echo -n PID > ZOOPIDFILE will mean the contents of ZOOPIDFILE > will be "-n PID". This stops zkServer.sh stop from working correctly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.