[
https://issues.apache.org/jira/browse/ZOOKEEPER-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848418#action_12848418
]
Hadoop QA commented on ZOOKEEPER-722:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12439471/zk-722.diff
against trunk revision 925362.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/36/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/36/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/36/console
This message is automatically generated.
> zkServer.sh uses sh's builtin echo on BSD, behaves incorrectly.
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-722
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-722
> Project: Zookeeper
> Issue Type: Bug
> Components: scripts
> Affects Versions: 3.3.0
> Environment: Mac OS X
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Minor
> Fix For: 3.3.1, 3.4.0
>
> Attachments: zk-722.diff
>
>
> zkServer.sh output the PID of the zookeeper process with:
> echo -n $! > "$ZOOPIDFILE"
> This uses -n which sh's builtin echo does not support. From echo's manpage.
> <snip>
> Some shells may provide a builtin echo command which is similar or
> identical to this utility. Most notably, the builtin echo in sh(1) does not
> accept
> the -n option. Consult the builtin(1) manual page.
> </snip>
> This means that echo -n PID > ZOOPIDFILE will mean the contents of ZOOPIDFILE
> will be "-n PID". This stops zkServer.sh stop from working correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
