FYI, the enterprise policy landed in M124 (under "PrefixedVideoFullscreenApiAvailability"), and the deprecation trial will activate when M125 branches, on April 15th.
On Fri, Feb 2, 2024 at 12:16 PM Mike Taylor <miketa...@chromium.org> wrote: > LGTM3 > On 2/2/24 1:03 AM, Domenic Denicola wrote: > > LGTM2. Please be sure to update Chrome Status with the deprecation trial > timelines and removal milestones so that data gets fed into the feature > dashboard, beta blog posts, etc. > > On Fri, Feb 2, 2024 at 7:35 AM Thomas Guilbert <tguilb...@chromium.org> > wrote: > >> Thank you! >> >> I will be adding an enterprise policy to re-enable the APIs if necessary, >> as part of the enterprise review. Deprecating the enterprise policy will >> become the new objective after the proper amount of time has elapsed, >> before the code can be deleted for good. >> >> I will keep updating this thread as I make it further in the launch >> process. >> >> On Thu, Feb 1, 2024 at 2:24 PM Philip Jägenstedt <foo...@chromium.org> >> wrote: >> >>> Thank you Thomas! >>> >>> As far as I'm aware that's all of the paperwork completed, so LGTM1 to >>> disable the APIs by default and at the same time start a reverse origin >>> trial to re-enable them for 6 months. If you hear feedback requesting an >>> extension towards the end of those 6 months, please request an extension >>> for another 6 months. >>> >>> On Thu, Feb 1, 2024 at 12:43 AM Thomas Guilbert <tguilb...@google.com> >>> wrote: >>> >>>> Thanks for marking it for review! >>>> >>>> I submitted a request to review this change to the chromium enterprise >>>> mailing list. >>>> >>>> Thanks, >>>> Thomas >>>> >>>> On Wed, Jan 31, 2024 at 1:08 PM Mike Taylor <miketa...@chromium.org> >>>> wrote: >>>> >>>>> Yep - seems that's the cause of confusion. In your first email, >>>>> https://chromestatus.com/feature/5259513871466496 is linked from the >>>>> bottom, so our review tooling is presenting that to us. But I've just >>>>> flagged the new one so it will show up as well. >>>>> >>>>> thanks! >>>>> On 1/31/24 2:41 PM, Thomas Guilbert wrote: >>>>> >>>>> I requested privacy/security/debuggability on the video element >>>>> fullscreen API deprecation feature >>>>> <https://chromestatus.com/feature/5111638103687168?gate=5204167302053888> >>>>> last >>>>> week. Privacy and debuggability are approved, just waiting on security. >>>>> >>>>> Mike, are you talking about requesting those gates on the original >>>>> Prefixed Fullscreen API feature >>>>> <https://chromestatus.com/feature/5259513871466496>? I don't have >>>>> edit rights on that Chrome status entry, and upon closer look, it relates >>>>> to `webkitRequestFullscreen`, which is not covered by this deprecation >>>>> intent. >>>>> >>>>> > [...] requesting enterprise signoff [...] >>>>> Is this a field on the chrome status entry? It doesn't show up for me. >>>>> Or is this about emailing the list mentioned here >>>>> <https://www.chromium.org/developers/enterprise-changes/#1-give-enterprises-visibility> >>>>> ? >>>>> >>>>> Thanks, >>>>> Thomas >>>>> >>>>> >>>>> >>>>> On Wed, Jan 31, 2024 at 8:54 AM Philip Jägenstedt <foo...@chromium.org> >>>>> wrote: >>>>> >>>>>> Apologies in advance for excessive paperwork, but can you also put >>>>>> https://chromestatus.com/feature/5111638103687168 through the >>>>>> process, requesting enterprise signoff in particular? Enterprise folks >>>>>> could depend on this and might need to take some extra action, and a >>>>>> "Feature deprecation" entry is the only way we can flag that. >>>>>> >>>>>> On Wed, Jan 31, 2024 at 5:44 PM Mike Taylor <miketa...@chromium.org> >>>>>> wrote: >>>>>> >>>>>>> Gentle reminder to follow up on requesting >>>>>>> privacy/security/debuggability approvals in chromestatus (which is >>>>>>> currently blocking LGTMs). >>>>>>> >>>>>>> On Wednesday, January 24, 2024 at 7:23:28 AM UTC-5 Mike Taylor wrote: >>>>>>> >>>>>>>> Would you mind requesting reviews for the various gates (privacy, >>>>>>>> security, debuggability) for an OT/DT in your chromestatus entry? >>>>>>>> On 1/19/24 10:43 PM, Thomas Guilbert wrote: >>>>>>>> >>>>>>>> Contact emails >>>>>>>> >>>>>>>> tguilb...@chromium.org >>>>>>>> >>>>>>>> Explainer >>>>>>>> >>>>>>>> None >>>>>>>> >>>>>>>> Specification >>>>>>>> >>>>>>>> https://fullscreen.spec.whatwg.org/#dom-document-fullscreenenabled >>>>>>>> >>>>>>>> Summary >>>>>>>> There was an attempt in 2014 >>>>>>>> <https://groups.google.com/a/chromium.org/g/blink-dev/c/Bxe7DnDVRZ0/m/5K61HQPrNK4J> >>>>>>>> to deprecate and remove the HTMLVideoElement-specific Prefixed >>>>>>>> Fullscreen >>>>>>>> APIs. This meant removing the following APIs from HTMLVideoElement: >>>>>>>> >>>>>>>> readonly attribute boolean webkitSupportsFullscreen; >>>>>>>> readonly attribute boolean webkitDisplayingFullscreen; >>>>>>>> void webkitEnterFullscreen(); >>>>>>>> void webkitExitFullscreen(); >>>>>>>> // Note the different capitalization of the "S" in FullScreen. >>>>>>>> void webkitEnterFullScreen(); >>>>>>>> void webkitExitFullScreen(); >>>>>>>> >>>>>>>> The overall usage of these APIs is low, and has trended downwards >>>>>>>> over time. Here are the latest usage numbers, as a % of total page >>>>>>>> loads: >>>>>>>> >>>>>>>> PrefixedVideoSupportsFullscreen: 0.025% >>>>>>>> PrefixedVideoDisplayingFullscreen: 0.082% >>>>>>>> PrefixedVideoEnterFullscreen: 0.001% >>>>>>>> PrefixedVideoExitFullscreen: 0.010% >>>>>>>> PrefixedVideoEnterFullScreen: 0.001% >>>>>>>> PrefixedVideoExitFullScreen: 0.000% >>>>>>>> >>>>>>>> >>>>>>>> There has been an unfortunate uptick in the past 2 years for the >>>>>>>> two following APIs, which means that it's best to remove them now, >>>>>>>> before >>>>>>>> they see a wider adoption. These numbers might be going up because the >>>>>>>> prefixed APIs are also present on iOS. >>>>>>>> >>>>>>>> https://chromestatus.com/metrics/feature/timeline/popularity/166 >>>>>>>> https://chromestatus.com/metrics/feature/timeline/popularity/167 >>>>>>>> >>>>>>>> There is an alternative set of APIs supported by all browsers that >>>>>>>> web authors can use. >>>>>>>> >>>>>>>> The full history of the removal attempt is here: crbug.com/346236 >>>>>>>> >>>>>>>> >>>>>>>> Goals for experimentation >>>>>>>> >>>>>>>> The primary goal of the deprecation trial is to reduce the amount >>>>>>>> of broken user-visible experiences as the prefixed fullscreen APIs are >>>>>>>> removed, and to give time to web authors to transition to the modern >>>>>>>> API >>>>>>>> (which has been available for 5 years). >>>>>>>> >>>>>>>> >>>>>>>> The un-prefixed fullscreen APIs have been available since Chrome >>>>>>>> M71. >>>>>>>> >>>>>>>> Experiment timeline >>>>>>>> >>>>>>>> TBD, with a proposed 3 months duration >>>>>>>> >>>>>>>> Blink component >>>>>>>> >>>>>>>> Blink>Fullscreen >>>>>>>> Blink>Media>Video >>>>>>>> >>>>>>>> TAG review >>>>>>>> >>>>>>>> None >>>>>>>> >>>>>>>> TAG review status >>>>>>>> >>>>>>>> Not applicable >>>>>>>> >>>>>>>> Risks >>>>>>>> Interoperability and Compatibility >>>>>>>> >>>>>>>> Web Compatibility: >>>>>>>> >>>>>>>> Removing non-standard APIs should overall help web compatibility, >>>>>>>> and encourage web authors to use the unprefixed APIs. Some experiences >>>>>>>> might be broken by this change, thus justifying this deprecation >>>>>>>> trial. The >>>>>>>> API has been deprecated for a significant amount of time however, and >>>>>>>> usage >>>>>>>> has gone down. >>>>>>>> >>>>>>>> This would only be an issue for websites that *only* support the >>>>>>>> prefixed APIs. >>>>>>>> >>>>>>>> >>>>>>>> Interoperability: >>>>>>>> >>>>>>>> >>>>>>>> All browsers have shipped the new APIs, most of them using an >>>>>>>> unprefixed version (Safari on iOS being the only remaining >>>>>>>> prefixed-only >>>>>>>> API). See also >>>>>>>> https://developer.mozilla.org/en-US/docs/Web/API/Element/requestFullscreen#browser_compatibility >>>>>>>> >>>>>>>> >>>>>>>> Gecko: >>>>>>>> >>>>>>>> >>>>>>>> WebKit: >>>>>>>> >>>>>>>> Web developers: >>>>>>>> >>>>>>>> Other signals: >>>>>>>> >>>>>>>> Activation >>>>>>>> >>>>>>>> Impact on the Ads ecosystem: >>>>>>>> >>>>>>>> N/A >>>>>>>> >>>>>>>> >>>>>>>> WebView application risks >>>>>>>> >>>>>>>> Does this intent deprecate or change behavior of existing APIs, >>>>>>>> such that it has potentially high risk for Android WebView-based >>>>>>>> applications? >>>>>>>> >>>>>>>> Potentially. The deprecation trial should give a heads up and >>>>>>>> appropriate time for apps to switch over to the unprefixed APIs. >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Ongoing technical constraints >>>>>>>> >>>>>>>> None >>>>>>>> >>>>>>>> >>>>>>>> Debuggability >>>>>>>> >>>>>>>> N/A >>>>>>>> >>>>>>>> Will this feature be supported on all six Blink platforms (Windows, >>>>>>>> Mac, Linux, Chrome OS, Android, and Android WebView)? >>>>>>>> >>>>>>>> Yes - the prefixed API will be removed across all platforms. >>>>>>>> >>>>>>>> Is this feature fully tested by web-platform-tests >>>>>>>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>>>>>>> ? >>>>>>>> >>>>>>>> Yes >>>>>>>> >>>>>>>> WPTs testing the prefixes are removed: >>>>>>>> https://github.com/web-platform-tests/wpt/blob/master/fullscreen/api/historical.html >>>>>>>> >>>>>>>> WPTs testing the new API: >>>>>>>> https://github.com/web-platform-tests/wpt/tree/master/fullscreen/api >>>>>>>> >>>>>>>> >>>>>>>> Flag name on chrome://flags >>>>>>>> >>>>>>>> None >>>>>>>> >>>>>>>> Finch feature name >>>>>>>> >>>>>>>> PrefixedVideoFullscreen >>>>>>>> >>>>>>>> Non-finch justification >>>>>>>> >>>>>>>> None >>>>>>>> >>>>>>>> Requires code in //chrome? >>>>>>>> >>>>>>>> False >>>>>>>> >>>>>>>> Launch bug >>>>>>>> >>>>>>>> None >>>>>>>> >>>>>>>> Estimated milestones >>>>>>>> >>>>>>>> DevTrial on desktop >>>>>>>> >>>>>>>> 123 >>>>>>>> >>>>>>>> DevTrial on Android >>>>>>>> >>>>>>>> 123 >>>>>>>> >>>>>>>> >>>>>>>> Link to entry on the Chrome Platform Status >>>>>>>> >>>>>>>> https://chromestatus.com/feature/5259513871466496 >>>>>>>> >>>>>>>> -- >>>>>>>> >>>>>>>> You received this message because you are subscribed to the Google >>>>>>>> Groups "blink-dev" group. >>>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>>> send an email to blink-dev+unsubscr...@chromium.org. >>>>>>>> To view this discussion on the web visit >>>>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABrVPoa373%3Dnxuc%2BTe_h9e0WdS53_oAyUEa%2B4j0v2xWgJ2MFcw%40mail.gmail.com >>>>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABrVPoa373%3Dnxuc%2BTe_h9e0WdS53_oAyUEa%2B4j0v2xWgJ2MFcw%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>>>>> . >>>>>>>> >>>>>>>> -- >>>>>>> You received this message because you are subscribed to the Google >>>>>>> Groups "blink-dev" group. >>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>> send an email to blink-dev+unsubscr...@chromium.org. >>>>>>> To view this discussion on the web visit >>>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/b1babe80-69c0-4f5e-b6f8-9d6c1ca20d9an%40chromium.org >>>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/b1babe80-69c0-4f5e-b6f8-9d6c1ca20d9an%40chromium.org?utm_medium=email&utm_source=footer> >>>>>>> . >>>>>>> >>>>>> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABrVPoZW7%2B11bA89iRbRPBT4%2BEHDtUA0GRaud0zY9NrZwjmMRA%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABrVPoZW7%2B11bA89iRbRPBT4%2BEHDtUA0GRaud0zY9NrZwjmMRA%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABrVPoYRWNA_eNe9wsCYfeOEDQragJ_NMab%3DqxJ58CE6MCippg%40mail.gmail.com.
