Hi, Shengkai Thanks for your feedback and suggestion, it looks very useful for this proposal, regarding your question I made the following optimization:
> *WorkflowScheduler* > 1. How to get the exception details if `modifyRefreshWorkflow` fails? > 2. Could you give us an example about how to configure the scheduler? 1. Added a new WorkflowException, WorkflowScheduler's related method signature will throw WorkflowException, when creating or modifying Workflow encountered an exception, so that the framework will sense and deal with it. 2. Added a new Configuration section, introduced a new Option, and gave an example of how to define the Scheduler in flink-conf.yaml. > *SQL Gateway* > 1. SqlGatewayService requires Session as the input, but the REST API doesn't need any Session information. > 2. Use "-" instead of "_" in the REST URI and camel case for fields in request/response > 3. Do we need scheduleTime and scheduleTimeFormat together? 1. If it is designed as a synchronous API, it may lead to network jitter, thread resource exhaustion and other problems, which I have not considered before. The asynchronous API, although increasing the cost of use for the user, is friendly to the SqlGatewayService, as well as the Client thread resources. In summary as discussed offline, so I also tend to think that all APIs of SqlGateway should be unified, and all should be asynchronous APIs, and bound to session. I have updated the REST API section in FLIP. 2. thanks for the reminder, it has been updated 3. After rethinking, I think it can indeed be simpler, there is no need to pass in a custom time format, scheduleTime can be unified to the SQL standard timestamp format: 'yyyy-MM-dd HH:mm:ss', it is able to satisfy the time related needs of materialized table. Based on your feedback, I have optimized and updated the FLIP related section. Best, Ron Shengkai Fang <fskm...@gmail.com> 于2024年4月28日周日 15:47写道： > Hi, Liu. > > Thanks for your proposal. I have some questions about the FLIP: > > *WorkflowScheduler* > > 1. How to get the exception details if `modifyRefreshWorkflow` fails? > 2. Could you give us an example about how to configure the scheduler? > > *SQL Gateway* > > 1. SqlGatewayService requires Session as the input, but the REST API > doesn't need any Session information. > > From the perspective of a gateway developer, I tend to unify the API of the > SQL gateway, binding all concepts to the session. On the one hand, this > approach allows us to reduce maintenance and understanding costs, as we > only need to maintain one set of architecture to complete basic concepts. > On the other hand, the benefits of an asynchronous architecture are > evident: we maintain state on the server side. If the request is a long > connection, even in the face of network layer jitter, we can still find the > original result through session and operation handles. > > Using asynchronous APIs may increase the development cost for users, but > from a platform perspective, if a request remains in a blocking state for a > long time, it also becomes a burden on the platform's JVM. This is because > thread switching and maintenance require certain resources. > > 2. Use "-" instead of "_" in the REST URI and camel case for fields in > request/response > > Please follow the Flink REST Design. > > 3. Do we need scheduleTime and scheduleTimeFormat together? > > I think we can use SQL timestamp format or ISO timestamp format. It is not > necessary to pass time in any specific format. > > https://en.wikipedia.org/wiki/ISO_8601 > > Best, > Shengkai >
