Hi Justin, It would be accurate because, most of our code is based off PostgreSQL. AGE is an openCypher language implementation built into PostgreSQL via their extension mechanism. It follows how PostgreSQL implements the SQL language.
Additionally, we modify their parse and query trees in order to implement the openCypher grammar and grammar transforms. This means using and modifying their code to work in the new functionality. For the transform phase, we have to follow how PostgreSQL transforms their nodes so that we can properly transform ours. A lot of times, we have to copy and modify some of their static functions to allow us to correctly handle specific cases. Our C files also include their C headers for access to public functions. So, nearly every file has some PostgreSQL code in it, to some extent. There are a few exceptions, but they are in the minority. I would just rather error on the safe side because, due to using their structures and functions, code that isn't PostgreSQL code can look just like PostgreSQL code. John On 2021/11/02 00:11:06 Justin Mclean wrote: > Hi, > > > Most of our code uses or is inspired by PostgreSQL's code, in some modified > > form or another. Additionally, we try to have our code work tightly with > > their code in order to reduce replication of code. As a core developer, and > > from your input, I wouldn't be comfortable with anything less than > > including PostgreSQL's license (along with ASF) in nearly all of our source > > files - to be safe. Would this be satisfactory to you? > > That would be safe I guess, but would it be accurate? I also don’t think that > is in line with ASF policy on file headers. In general, code developed at the > ASF should have an ASF header, 3rd party code or code copied from elsewhere > should have the original header on it. Is it that hard to work out what code > was copied and what code was not? > > > My understanding of what you are saying about the Bitnine license is to > > leave it out. As Bitnine donated this code to ASF and merely stating it in > > the LICENSE or NOTICE file should be sufficient. Would this be satisfactory > > to you? > > As per ASF policy it should be mentioned in NOTICE. > > Kind Regards, > Justin > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
