Hi Zikuan, Just for the record, adding the license *near* the beginning, as was done with yarn-3.4.1.cjs, is perfectly fine. It just needs to be easily found.
That is, there is no need for the license to be the first text, as long as it is not after the real content. Warm regards, Craig > On Nov 16, 2023, at 01:59, Zikuan An <abe...@apache.org> wrote: > > Hi Felix, > > The file config-ui/.yarn/releases/yarn-3.4.1.cjs is used to specify the > yarn version and is a generated file. I added the BSD License > <https://raw.githubusercontent.com/apache/incubator-devlake/v0.19.0-rc2/config-ui/.yarn/releases/yarn-3.4.1.cjs>, > but it cannot be added at the beginning of the file because adding it at > the beginning will make the file unusable. > > Best, > Zikuan An > > Felix Cheung <felixche...@apache.org> 于2023年11月16日周四 10:22写道： > >> +1 binding >> >> - incubating in name >> - signature and hash fine >> - DISCLAIMER is fine >> - LICENSE and NOTICE are fine >> - No unexpected binary files >> - All source files have ASF headers >> >> what is this file config-ui/.yarn/releases/yarn-3.4.1.cjs - seems to have >> code in it (and it does not have a license header) >> >> >> On Wed, Nov 15, 2023 at 6:17 AM Willem Jiang <willem.ji...@gmail.com> >> wrote: >> >>> +1(binding). >>> >>> Here is what I checked: >>> - The checksums and signatures are validated. >>> - The LICENSE and NOTICE files look good to me. >>> - There is a DISCLAIMER file about incubating. >>> - No binary files in the source release. >>> >>> Willem Jiang >>> >>> Twitter: willemjiang >>> Weibo: 姜宁willem >>> >>> On Fri, Nov 10, 2023 at 10:28 PM Zikuan An <abe...@apache.org> wrote: >>>> >>>> Hello everyone, >>>> >>>> This is a call for the vote to release Apache DevLake (Incubating) >>>> v0.19.0-rc2. >>>> The Apache DevLake community has voted on and approved a proposal to >>>> release Apache DevLake (Incubating) version v0.19.0-rc2. >>>> >>>> >>>> We now kindly request the Incubator PMC members review and vote on this >>>> incubator release. >>>> >>>> Community vote thread: >>>> >>>> https://lists.apache.org/thread/zqhrctqz39xyslfjsd0zz30gtdbv4t20 >>>> >>>> >>>> Community vote result thread: >>>> >>>> https://lists.apache.org/thread/g06ns1vbqopyw6r460m25pvcvwh932s6 >>>> >>>> >>>> The release candidates: >>>> >>>> >>> >> https://dist.apache.org/repos/dist/dev/incubator/devlake/0.19.0-incubating-rc2 >>>> >>>> >>>> Git tag for the release: >>>> >>>> https://github.com/apache/incubator-devlake/releases/tag/v0.19.0-rc2 >>>> >>>> >>>> Keys to verify the Release Candidate: >>>> >>>> https://downloads.apache.org/incubator/devlake/KEYS >>>> >>>> >>>> How to build: >>>> >>>> https://devlake.apache.org/docs/DeveloperManuals/DeveloperSetup >>>> >>>> >>>> The vote will be open for at least 72 hours or until the necessary >> number >>>> of votes is reached. >>>> >>>> Please vote accordingly: >>>> [ ] +1 approve >>>> [ ] +0 no opinion >>>> [ ] -1 disapprove with the reason >>>> >>>> >>>> Thanks >>>> >>>> Zikuan An >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >>> For additional commands, e-mail: general-h...@incubator.apache.org >>> >>> >> Craig L Russell c...@apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
