hi xuanwo, The repository in the link you posted is incorrect usage. Although it has specified the yarn version in package.json, and yarn.lock also indicates this version, when the user actually uses it, since yarn2 depends on this file, if Not specifying yarnPath will cause yarn to be installed directly using npm, and the uploaded yarn.lock will become invalid. This will lead to changes in dependent versions and cause many other problems.
On 2023/11/21 00:26:53 Xuanwo wrote: > For example, we can specify "packageManager" in package.json so that we don't > need to include this binary in code: > > https://github.com/apache/incubator-opendal/blob/main/website/package.json#L44C4-L44C18 > > On Tue, Nov 21, 2023, at 08:22, Xuanwo wrote: > >> - It is unclear what license yarn-3.4.1.cjs is under - why not just say > >> it contains multiple pieces of 3rd party code under different licenses? > > > > yarn-3.4.1.cjs js a binary too. How about use `corepack` to ensure we are > > using > > the same version of yarn instead? > > > > For more inforamtion about corepack: https://nodejs.org/api/corepack.html > > > > On Tue, Nov 21, 2023, at 06:01, Justin Mclean wrote: > >> Hi, > >> > >> I think a little more work is needed: > >> - It is unclear what license yarn-3.4.1.cjs is under - why not just say > >> it contains multiple pieces of 3rd party code under different licenses? > >> - You are misisng the BSD license for Yarn. The full text of the > >> license needs to be included. > >> - You still need to, as required by the license, include the full text > >> of the MIT licenses, which include the copyright line. > >> - What code is "Copyright (c) 2015, Rebecca Turner”, and what license > >> is it under? > >> - What code is "Copyright Joyent, Inc. and other Node contributors.”, > >> and what license is it under? > >> - What code is "Copyright Node.js contributors. All rights reserved.", > >> and what license is it under? > >> - What code is "Copyright (c) 2014 Blake Embrey > >> (he...@blakeembrey.com)”, and what license is it under? > >> > >> Kind Regards, > >> Justin > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > >> For additional commands, e-mail: general-h...@incubator.apache.org > > > > -- > > Xuanwo > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > -- > Xuanwo > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
