Hi Justin, On behalf of the Apache DevLake community,
we made corrections based on your comments in v0.19.0-rc2. So we want to invite you to vote for v0.19.0-rc3 first. The voting thread is available at: https://lists.apache.org/thread/ymth9hgp6p82pclcbtght4cpdvyvz5mf Thank you very much for your time and contribution as an IPMC mentor. Your guidance and support for the Apache DevLake project is invaluable. Best, Zikuan An Zikuan An <abe...@apache.org> 于2023年11月21日周二 13:47写道： > Hi Justin, > > Thank you once again for your valuable insights. > Based on your previous suggestions, I have made some updates to the > version. > I would greatly appreciate it if you could kindly review it once more to > ensure everything is in order. > Your expertise and guidance in this matter are immensely appreciated. > > You can find the updated version here: > https://github.com/apache/incubator-devlake/pull/6483/files > > Kind Regards, > Zikuan > > > Justin Mclean <jus...@classsoftware.com> 于2023年11月21日周二 06:02写道： > >> Hi, >> >> I think a little more work is needed: >> - It is unclear what license yarn-3.4.1.cjs is under - why not just say >> it contains multiple pieces of 3rd party code under different licenses? >> - You are misisng the BSD license for Yarn. The full text of the license >> needs to be included. >> - You still need to, as required by the license, include the full text of >> the MIT licenses, which include the copyright line. >> - What code is "Copyright (c) 2015, Rebecca Turner”, and what license is >> it under? >> - What code is "Copyright Joyent, Inc. and other Node contributors.”, and >> what license is it under? >> - What code is "Copyright Node.js contributors. All rights reserved.", >> and what license is it under? >> - What code is "Copyright (c) 2014 Blake Embrey (he...@blakeembrey.com)”, >> and what license is it under? >> >> Kind Regards, >> Justin >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> For additional commands, e-mail: general-h...@incubator.apache.org >> >>
