Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/23086#discussion_r236858449
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2ScanExec.scala
---
@@ -54,27 +53,17 @@ case class DataSourceV2ScanExec(
Seq(output, source, options).hashCode()
}
- override def outputPartitioning: physical.Partitioning = readSupport
match {
+ override def outputPartitioning: physical.Partitioning = scan match {
--- End diff --
Should `SupportsReportPartitioning` extend `Batch` instead of `Scan`? Then
this physical node could just be passed the `Batch` and not the `Scan`,
`PartitionReaderFactory`, and partitions.
In fact, I think that this node only requires `output:
Seq[AttributeReference], batch: Batch`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
