Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/23086#discussion_r236858793
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
---
@@ -116,16 +116,20 @@ object DataSourceV2Strategy extends Strategy {
|Output: ${output.mkString(", ")}
""".stripMargin)
- val scan = DataSourceV2ScanExec(
+ val batch = scan.toBatch
+ val partitions = batch.planInputPartitions()
+ val readerFactory = batch.createReaderFactory()
+ val plan = DataSourceV2ScanExec(
--- End diff --
I mentioned this above, but I think that DataSoruceV2ScanExec only needs to
be passed `output` and `batch`. That is, unless there is a benefit to calling
`planInputPartitions` here, like an earlier failure?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
