On Fri, 24 May 2024 15:12:28 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request with a new target base due to a
> Moving array construction within BigInteger.implMultiplyToLen intrinsic
> candidate to its caller simplifies the intrinsic implementation in JIT
> compiler.
Yudi Zheng has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the
On Thu, 23 May 2024 10:12:17 GMT, Bhavana Kilambi wrote:
>> Yudi Zheng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> address comments.
>
> src/hotspot/share/opto/library_call.cpp line 5925:
>
>> 5923: // Set the original stack and
On Wed, 22 May 2024 14:47:43 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional
>
On Wed, 22 May 2024 14:47:43 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional
>
On Wed, 22 May 2024 14:47:43 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional
>
On Wed, 22 May 2024 14:47:43 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional
>
On Wed, 22 May 2024 14:47:43 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional
>
On Wed, 22 May 2024 14:47:43 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional
>
On Wed, 22 May 2024 14:47:43 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional
>
On Wed, 22 May 2024 14:28:41 GMT, Yudi Zheng wrote:
>> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 4693:
>>
>>> 4691: const Register xlen = r1;
>>> 4692: const Register z = r2;
>>> 4693: const Register zlen = r3;
>>
>> LibraryCallKit::inline_squareToLen() is still
On Wed, 22 May 2024 14:47:43 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional
>
On Wed, 17 Apr 2024 20:04:44 GMT, Dean Long wrote:
>> Yudi Zheng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> address comment.
>
> src/hotspot/cpu/x86/macroAssembler_x86.cpp line 6662:
>
>> 6660: push(tmp5);
>> 6661:
>> 6662:
> Moving array construction within BigInteger.implMultiplyToLen intrinsic
> candidate to its caller simplifies the intrinsic implementation in JIT
> compiler.
Yudi Zheng has updated the pull request incrementally with one additional
commit since the last revision:
address comments.
On Mon, 20 May 2024 10:41:36 GMT, Bhavana Kilambi wrote:
>> @dafedafe @dean-long please take a look and let me know if there are further
>> issues, thanks!
>
> Hi @mur47x111, do you happen to have any performance results with this patch?
@Bhavana-Kilambi the performance result for x86 is at
On Wed, 17 Apr 2024 19:33:01 GMT, Dean Long wrote:
>> Yudi Zheng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> address comment.
>
> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 4670:
>
>> 4668: const Register tmp5 =
On Wed, 17 Apr 2024 12:37:01 GMT, Yudi Zheng wrote:
>> `multiply_to_len` seems to be used by `generate_squareToLen` as well for
>> aarch64 and riscv but `zlen` is still passed in a register.
>>
>>
On Wed, 17 Apr 2024 12:35:54 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional
>
On Wed, 17 Apr 2024 12:35:54 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional
>
On Wed, 17 Apr 2024 19:45:02 GMT, Dean Long wrote:
>> Yudi Zheng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> address comment.
>
> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 4702:
>
>> 4700: const Register tmp5 =
On Wed, 17 Apr 2024 12:35:54 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional
>
On Wed, 17 Apr 2024 12:35:54 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional
>
On Tue, 26 Mar 2024 15:59:33 GMT, Damon Fenacci wrote:
>> Yudi Zheng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> address comment.
>
> `multiply_to_len` seems to be used by `generate_squareToLen` as well for
> aarch64 and riscv but
On Tue, 26 Mar 2024 15:59:33 GMT, Damon Fenacci wrote:
>> Yudi Zheng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> address comment.
>
> `multiply_to_len` seems to be used by `generate_squareToLen` as well for
> aarch64 and riscv but
> Moving array construction within BigInteger.implMultiplyToLen intrinsic
> candidate to its caller simplifies the intrinsic implementation in JIT
> compiler.
Yudi Zheng has updated the pull request incrementally with one additional
commit since the last revision:
address comment.
> Moving array construction within BigInteger.implMultiplyToLen intrinsic
> candidate to its caller simplifies the intrinsic implementation in JIT
> compiler.
Yudi Zheng has updated the pull request incrementally with one additional
commit since the last revision:
address comment.
On Tue, 19 Mar 2024 21:09:31 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional
>
> Moving array construction within BigInteger.implMultiplyToLen intrinsic
> candidate to its caller simplifies the intrinsic implementation in JIT
> compiler.
Yudi Zheng has updated the pull request incrementally with one additional
commit since the last revision:
address comment.
On Tue, 19 Mar 2024 19:06:36 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional
>
On Tue, 19 Mar 2024 19:06:36 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional
>
> Moving array construction within BigInteger.implMultiplyToLen intrinsic
> candidate to its caller simplifies the intrinsic implementation in JIT
> compiler.
Yudi Zheng has updated the pull request incrementally with one additional
commit since the last revision:
address comment.
On Mon, 18 Mar 2024 16:55:28 GMT, Damon Fenacci wrote:
> Quite a simplification! Have you checked if there are any performance
> differences?
Ran
https://github.com/oracle/graal/blob/master/compiler/src/org.graalvm.micro.benchmarks/src/micro/benchmarks/BigIntegerBenchmark.java
The results are
On Tue, 12 Mar 2024 10:44:54 GMT, Yudi Zheng wrote:
> Moving array construction within BigInteger.implMultiplyToLen intrinsic
> candidate to its caller simplifies the intrinsic implementation in JIT
> compiler.
src/hotspot/share/opto/library_call.cpp line 5934:
> 5932: // 'y_start'
On Tue, 12 Mar 2024 10:44:54 GMT, Yudi Zheng wrote:
> Moving array construction within BigInteger.implMultiplyToLen intrinsic
> candidate to its caller simplifies the intrinsic implementation in JIT
> compiler.
src/java.base/share/classes/java/math/BigInteger.java line 1836:
> 1834:
> 1835:
On Tue, 12 Mar 2024 10:44:54 GMT, Yudi Zheng wrote:
> Moving array construction within BigInteger.implMultiplyToLen intrinsic
> candidate to its caller simplifies the intrinsic implementation in JIT
> compiler.
Quite a simplification!
Have you checked if there are any performance differences?
35 matches
Mail list logo
