Re: Timetable for APR 1.5 release?
2013-11-12 18:02 Jeff Trawick napisał(a): Are there any known issues? Please fix remaining part of bug #55690 and backport full fix (r1535027, r1535157, rXXX) to 1.5.x branch. https://issues.apache.org/bugzilla/show_bug.cgi?id=55690 -- Arfrever Frehtes Taifersar Arahesis signature.asc Description: This is a digitally signed message part.
Re: Timetable for APR 1.5 release?
On Wed, Nov 13, 2013 at 3:42 AM, Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com wrote: 2013-11-12 18:02 Jeff Trawick napisał(a): Are there any known issues? Please fix remaining part of bug #55690 and backport full fix (r1535027, r1535157, rXXX) to 1.5.x branch. https://issues.apache.org/bugzilla/show_bug.cgi?id=55690 I'm working on that now. Thanks for the heads-up. -- Arfrever Frehtes Taifersar Arahesis -- Born in Roswell... married an alien... http://emptyhammock.com/
Re: Timetable for APR 1.5 release?
On Wed, Nov 13, 2013 at 6:45 AM, Jeff Trawick traw...@gmail.com wrote: On Wed, Nov 13, 2013 at 3:42 AM, Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com wrote: 2013-11-12 18:02 Jeff Trawick napisał(a): Are there any known issues? Please fix remaining part of bug #55690 and backport full fix (r1535027, r1535157, rXXX) to 1.5.x branch. https://issues.apache.org/bugzilla/show_bug.cgi?id=55690 I'm working on that now. Thanks for the heads-up. Done... Can you retest from the HEAD of apr 1.5.x? -- Arfrever Frehtes Taifersar Arahesis -- Born in Roswell... married an alien... http://emptyhammock.com/ -- Born in Roswell... married an alien... http://emptyhammock.com/
Re: Timetable for APR 1.5 release?
On Tue, Oct 1, 2013 at 8:26 AM, Jeff Trawick traw...@gmail.com wrote: On Tue, Oct 1, 2013 at 7:32 AM, Jim Jagielski j...@jagunet.com wrote: Subj sez it all. I've never been RM for APR but am willing to do this one... I'm happy to take care of the RM work. Some things I'm interested in checking on for 1.5.x: * Compare 1.4.x-1.5.x and see if anything was missed. (I'm pretty sure that there are some .h fixes that skipped 1.5.x; dunno what else.) * Add the cmake support. (I purposefully skipped the 1.5.x branch when there was constant activity.) * Put in a couple of fixes for Cygwin that somebody opened bugs for in the last week or so. * Test MinGW static and shared builds in conjunction with APR-util 1.5.x. (Should be okay; some fixes for shared never hit the 1.4.x branch, so it would be good to ensure this is finally working.) * Check for anything whatsoever that could be merged from trunk and see what to do, as presumably there won't be another opportunity for a while. It would be good for TR to be no sooner than next Monday. Wow, that was a long time ago. I suspect that we're ready. I'd love to write some [at least skeletal] docs and testcases for skiplist but I don't have time, and I suppose that adding another test*.c file is asking for trouble on one platform or another. Are there any known issues? I'll try hard to TR apr and apr-util tomorrow otherwise, or help then with any identified issues. Any other thoughts on what to look at before TR of the first 1.5.x release? -- Born in Roswell... married an alien... http://emptyhammock.com/ -- Born in Roswell... married an alien... http://emptyhammock.com/
Re: Timetable for APR 1.5 release?
+1 from me. On Oct 29, 2013, at 2:16 PM, William A. Rowe Jr. wr...@rowe-clan.net wrote: On Tue, 29 Oct 2013 19:07:32 +0100 Guenter Knauf fua...@apache.org wrote: On 29.10.2013 18:56, William A. Rowe Jr. wrote: Nope - simply /DCROSS_COMPILE in the [lib]apr.dsp/.mak files rather than pre-copying apr.h. I don't think that using apr feature detection and headers buys us anything in compiling code which should 'just work' on any compiler still in use in this century :) I suggested this already longer time ago for httpd as well - but only Stefan agreed so far ... as you seem to agree now as well we're 3 and I think we should push a change which removes APR dependency entirely from gen_test_char.c for all httpd + APR brances and make the code more simple. +1
Re: Timetable for APR 1.5 release?
Just to verify what I should be testing - and - is it too late to get
something added for packaging?
I assume that for httpd-2.4.X that should build with only apr-1.5.X
(preferred), or with apr-1.4.some-minimum + apr-util-1.5.X
What I would like to add is the buildaix scripts - similar to what I did
for httpd, or at a minimum, the layout.AIX.
As apr has compiler dependancies (if you change complier you must rebuild
apr) I would prefer to have the build script that changes the package name
dependent on the compiler.
A nice start would be the AIX layout.
michael@x054:[/data/prj/apache/apr/apr-1.5.x-save]jsvn diff config.layout
Index: config.layout
===
--- config.layout (revision 1536612)
+++ config.layout (working copy)
@@ -229,3 +229,26 @@
infodir: ${exec_prefix}/share/info
libsuffix:-${APR_MAJOR_VERSION}
/Layout
+
+# AIX layout
+Layout AIX
+prefix:/opt
+exec_prefix: /opt
+datadir: /var/apr
+localstatedir: /var
+sysconfdir:${localstatedir}/apr/etc
+mandir:/usr/share/man
+bindir:${exec_prefix}/bin
+sbindir: ${exec_prefix}/sbin
+includedir:${exec_prefix}/include
+libdir:${exec_prefix}/lib
+libexecdir:${exec_prefix}/libexec
+errordir: ${datadir}/error
+iconsdir: ${datadir}/icons
+htdocsdir: ${datadir}/htdocs
+manualdir: ${datadir}/manual
+runtimedir:${localstatedir}/run
+logfiledir:${localstatedir}/logs
+proxycachedir: ${localstatedir}/proxy
+installbuilddir: ${localstatedir}/build
+/Layout
On Mon, Oct 28, 2013 at 10:37 PM, William A. Rowe Jr.
wr...@rowe-clan.netwrote:
On Mon, 28 Oct 2013 16:58:45 -0400
Jeff Trawick traw...@gmail.com wrote:
On Mon, Oct 28, 2013 at 4:54 PM, William A. Rowe Jr.
wr...@rowe-clan.netwrote:
On Mon, 28 Oct 2013 13:01:09 -0400
Jeff Trawick traw...@gmail.com wrote:
On Mon, Oct 28, 2013 at 12:50 PM, Gregg Smith g...@gknw.net
wrote:
Just a note,
On 10/19/2013 10:32 AM, Gregg Smith wrote:
On 10/19/2013 7:26 AM, Jeff Trawick wrote:
On Thu, Oct 17, 2013 at 11:08 PM, Gregg Smith g...@gknw.net
mailto: g...@gknw.net wrote:
I'd like to first rid the 1.5 traditional Windows build
of the Release9x Debug9x targets. Anyone against this?
no concerns here; is there code that can get deleted too?
probably, I would assume so, I haven't ran it down that far
yet.
I did not do this after all nor do I think I am brave enough to.
apr_escape, testescape and gen_test_char were added into the
build with r1534053.
.mak/.dep files were added in r1534516.
We should be ready to go on the Windows side now.
So, given that 1.5 remains compatible with 1.4... but projects which
build APR themselves will have to adapt to the new gen_test_char or
we need to make the suggested change, let's just take the httpd
example.
Does it make more sense for httpd 2.2 Makefile.win to detect the
presence of gen_test_char and build it when encountered, or does it
make more sense to compile-link-invoke gen_test_char.c? I'm happy
to make the respective change later tonight or tomorrow, based on
consensus.
Is the Windows build interface of apr 1.5.x different such that
httpd's Makefile.win would care?
httpd itself doesn't use apr escape and shouldn't care that apr
happens to have a build utility of the same name as one of its own
(or something is borked).
The httpd 2.2 Makefile.win build invokes the pcre, expat, apr, apr-iconv
and apr-util builds project-by-project, it doesn't use any corresponding
top-level build mechanics. This was one aspect that was greatly improved
by moving to the httpd-2.4 model.
If httpd doesn't pre-build gen_test_char before apr.mak, then the apr
build will fail, unless we nest the new gen_test_char pre-build.
I think the better solution for a one-source file, source generation
app is to embed that build into the [lib]apr.dsp/mak files for now.
But as an alternative, we can teach httpd 2.2 Makefile.win to anticipate
this requirement if that project is present. That would mean that 1.5
apr wouldn't build with older httpd 2.2 releases, only the next release
onwards.
Re: Timetable for APR 1.5 release?
On Tue, Oct 29, 2013 at 5:21 AM, Michael Felt mamf...@gmail.com wrote:
Just to verify what I should be testing - and - is it too late to get
something added for packaging?
I assume that for httpd-2.4.X that should build with only apr-1.5.X
(preferred), or with apr-1.4.some-minimum + apr-util-1.5.X
httpd 2.4.next will require apr-1.5.x only if using the event MPM (I doubt
that works on AIX anyway).
But many if not most will be using the latest apr and apr-util.
What I would like to add is the buildaix scripts - similar to what I did
for httpd, or at a minimum, the layout.AIX.
As apr has compiler dependancies (if you change complier you must rebuild
apr) I would prefer to have the build script that changes the package name
dependent on the compiler.
A nice start would be the AIX layout.
michael@x054:[/data/prj/apache/apr/apr-1.5.x-save]jsvn diff config.layout
Index: config.layout
===
Does this work with apr trunk? It needs to be committed there first, then
to 1.5.x.
--- config.layout (revision 1536612)
+++ config.layout (working copy)
@@ -229,3 +229,26 @@
infodir: ${exec_prefix}/share/info
libsuffix:-${APR_MAJOR_VERSION}
/Layout
+
+# AIX layout
+Layout AIX
+prefix:/opt
+exec_prefix: /opt
+datadir: /var/apr
+localstatedir: /var
+sysconfdir:${localstatedir}/apr/etc
+mandir:/usr/share/man
+bindir:${exec_prefix}/bin
+sbindir: ${exec_prefix}/sbin
+includedir:${exec_prefix}/include
+libdir:${exec_prefix}/lib
+libexecdir:${exec_prefix}/libexec
+errordir: ${datadir}/error
+iconsdir: ${datadir}/icons
+htdocsdir: ${datadir}/htdocs
+manualdir: ${datadir}/manual
+runtimedir:${localstatedir}/run
+logfiledir:${localstatedir}/logs
+proxycachedir: ${localstatedir}/proxy
+installbuilddir: ${localstatedir}/build
+/Layout
Is it necessary to control all of these from the layout? There are
significantly more settings, generally httpd-specific, than the other
layouts have.
proxycachedir? That sounds like Apache 1.3 to me. What uses that?
On Mon, Oct 28, 2013 at 10:37 PM, William A. Rowe Jr. wr...@rowe-clan.net
wrote:
On Mon, 28 Oct 2013 16:58:45 -0400
Jeff Trawick traw...@gmail.com wrote:
On Mon, Oct 28, 2013 at 4:54 PM, William A. Rowe Jr.
wr...@rowe-clan.netwrote:
On Mon, 28 Oct 2013 13:01:09 -0400
Jeff Trawick traw...@gmail.com wrote:
On Mon, Oct 28, 2013 at 12:50 PM, Gregg Smith g...@gknw.net
wrote:
Just a note,
On 10/19/2013 10:32 AM, Gregg Smith wrote:
On 10/19/2013 7:26 AM, Jeff Trawick wrote:
On Thu, Oct 17, 2013 at 11:08 PM, Gregg Smith g...@gknw.net
mailto: g...@gknw.net wrote:
I'd like to first rid the 1.5 traditional Windows build
of the Release9x Debug9x targets. Anyone against this?
no concerns here; is there code that can get deleted too?
probably, I would assume so, I haven't ran it down that far
yet.
I did not do this after all nor do I think I am brave enough to.
apr_escape, testescape and gen_test_char were added into the
build with r1534053.
.mak/.dep files were added in r1534516.
We should be ready to go on the Windows side now.
So, given that 1.5 remains compatible with 1.4... but projects which
build APR themselves will have to adapt to the new gen_test_char or
we need to make the suggested change, let's just take the httpd
example.
Does it make more sense for httpd 2.2 Makefile.win to detect the
presence of gen_test_char and build it when encountered, or does it
make more sense to compile-link-invoke gen_test_char.c? I'm happy
to make the respective change later tonight or tomorrow, based on
consensus.
Is the Windows build interface of apr 1.5.x different such that
httpd's Makefile.win would care?
httpd itself doesn't use apr escape and shouldn't care that apr
happens to have a build utility of the same name as one of its own
(or something is borked).
The httpd 2.2 Makefile.win build invokes the pcre, expat, apr, apr-iconv
and apr-util builds project-by-project, it doesn't use any corresponding
top-level build mechanics. This was one aspect that was greatly improved
by moving to the httpd-2.4 model.
If httpd doesn't pre-build gen_test_char before apr.mak, then the apr
build will fail, unless we nest the new gen_test_char pre-build.
I think the better solution for a one-source file, source generation
app is to embed that build into the [lib]apr.dsp/mak files for now.
But as an alternative, we can teach httpd 2.2 Makefile.win to anticipate
this requirement if that project is present. That would mean that 1.5
apr wouldn't build with older httpd
Re: Timetable for APR 1.5 release?
On Mon, 28 Oct 2013 18:00:26 -0700 Gregg Smith g...@gknw.net wrote: On 10/28/2013 2:37 PM, William A. Rowe Jr. wrote: On Mon, 28 Oct 2013 16:58:45 -0400 Jeff Trawicktraw...@gmail.com wrote: On Mon, Oct 28, 2013 at 4:54 PM, William A. Rowe Jr. wr...@rowe-clan.netwrote: On Mon, 28 Oct 2013 13:01:09 -0400 Jeff Trawicktraw...@gmail.com wrote: On Mon, Oct 28, 2013 at 12:50 PM, Gregg Smithg...@gknw.net wrote: Just a note, On 10/19/2013 10:32 AM, Gregg Smith wrote: On 10/19/2013 7:26 AM, Jeff Trawick wrote: On Thu, Oct 17, 2013 at 11:08 PM, Gregg Smithg...@gknw.net mailto: g...@gknw.net wrote: I'd like to first rid the 1.5 traditional Windows build of the Release9x Debug9x targets. Anyone against this? no concerns here; is there code that can get deleted too? probably, I would assume so, I haven't ran it down that far yet. I did not do this after all nor do I think I am brave enough to. apr_escape, testescape and gen_test_char were added into the build with r1534053. .mak/.dep files were added in r1534516. We should be ready to go on the Windows side now. So, given that 1.5 remains compatible with 1.4... but projects which build APR themselves will have to adapt to the new gen_test_char or we need to make the suggested change, let's just take the httpd example. Does it make more sense for httpd 2.2 Makefile.win to detect the presence of gen_test_char and build it when encountered, or does it make more sense to compile-link-invoke gen_test_char.c? I'm happy to make the respective change later tonight or tomorrow, based on consensus. Is the Windows build interface of apr 1.5.x different such that httpd's Makefile.win would care? httpd itself doesn't use apr escape and shouldn't care that apr happens to have a build utility of the same name as one of its own (or something is borked). The httpd 2.2 Makefile.win build invokes the pcre, expat, apr, apr-iconv and apr-util builds project-by-project, it doesn't use any corresponding top-level build mechanics. This was one aspect that was greatly improved by moving to the httpd-2.4 model. If httpd doesn't pre-build gen_test_char before apr.mak, then the apr build will fail, unless we nest the new gen_test_char pre-build. I think the better solution for a one-source file, source generation app is to embed that build into the [lib]apr.dsp/mak files for now. But as an alternative, we can teach httpd 2.2 Makefile.win to anticipate this requirement if that project is present. That would mean that 1.5 apr wouldn't build with older httpd 2.2 releases, only the next release onwards. This is done. The stumble point is that apr.h must be there to compile gen_test_char.c and it must be run before ar_escape.c is compiled. So after a lot of trying different ways to do this and get everything to fire off at the right point in time, I just had to sandwich it all during the creation of apr.h. This works in both apr.mak and libspr.mak as well. Suggestion - should we simply use the CROSS_COMPILE path when building for win32 .dsp/.mak files, instead?
Re: Timetable for APR 1.5 release?
On 10/29/2013 9:00 AM, William A. Rowe Jr. wrote: On Mon, 28 Oct 2013 18:00:26 -0700 Gregg Smithg...@gknw.net wrote: On 10/28/2013 2:37 PM, William A. Rowe Jr. wrote: On Mon, 28 Oct 2013 16:58:45 -0400 Jeff Trawicktraw...@gmail.com wrote: On Mon, Oct 28, 2013 at 4:54 PM, William A. Rowe Jr. wr...@rowe-clan.netwrote: On Mon, 28 Oct 2013 13:01:09 -0400 Jeff Trawicktraw...@gmail.com wrote: On Mon, Oct 28, 2013 at 12:50 PM, Gregg Smithg...@gknw.net wrote: Just a note, On 10/19/2013 10:32 AM, Gregg Smith wrote: On 10/19/2013 7:26 AM, Jeff Trawick wrote: On Thu, Oct 17, 2013 at 11:08 PM, Gregg Smithg...@gknw.net mailto: g...@gknw.net wrote: I'd like to first rid the 1.5 traditional Windows build of the Release9x Debug9x targets. Anyone against this? no concerns here; is there code that can get deleted too? probably, I would assume so, I haven't ran it down that far yet. I did not do this after all nor do I think I am brave enough to. apr_escape, testescape and gen_test_char were added into the build with r1534053. .mak/.dep files were added in r1534516. We should be ready to go on the Windows side now. So, given that 1.5 remains compatible with 1.4... but projects which build APR themselves will have to adapt to the new gen_test_char or we need to make the suggested change, let's just take the httpd example. Does it make more sense for httpd 2.2 Makefile.win to detect the presence of gen_test_char and build it when encountered, or does it make more sense to compile-link-invoke gen_test_char.c? I'm happy to make the respective change later tonight or tomorrow, based on consensus. Is the Windows build interface of apr 1.5.x different such that httpd's Makefile.win would care? httpd itself doesn't use apr escape and shouldn't care that apr happens to have a build utility of the same name as one of its own (or something is borked). The httpd 2.2 Makefile.win build invokes the pcre, expat, apr, apr-iconv and apr-util builds project-by-project, it doesn't use any corresponding top-level build mechanics. This was one aspect that was greatly improved by moving to the httpd-2.4 model. If httpd doesn't pre-build gen_test_char before apr.mak, then the apr build will fail, unless we nest the new gen_test_char pre-build. I think the better solution for a one-source file, source generation app is to embed that build into the [lib]apr.dsp/mak files for now. But as an alternative, we can teach httpd 2.2 Makefile.win to anticipate this requirement if that project is present. That would mean that 1.5 apr wouldn't build with older httpd 2.2 releases, only the next release onwards. This is done. The stumble point is that apr.h must be there to compile gen_test_char.c and it must be run before ar_escape.c is compiled. So after a lot of trying different ways to do this and get everything to fire off at the right point in time, I just had to sandwich it all during the creation of apr.h. This works in both apr.mak and libspr.mak as well. Suggestion - should we simply use the CROSS_COMPILE path when building for win32 .dsp/.mak files, instead? You mean using the CMake and dropping the Traditional build completely? -1 I currently do not see the problem with having both at this time. Of course, I am only one voice here. Once 1.5 is tagged I do not forsee any further problems arising since this should all be set in stone till 1.next/2.0.
Re: Timetable for APR 1.5 release?
On Tue, 29 Oct 2013 10:32:03 -0700 Gregg Smith g...@gknw.net wrote: Suggestion - should we simply use the CROSS_COMPILE path when building for win32 .dsp/.mak files, instead? You mean using the CMake and dropping the Traditional build completely? -1 Nope - simply /DCROSS_COMPILE in the [lib]apr.dsp/.mak files rather than pre-copying apr.h. I don't think that using apr feature detection and headers buys us anything in compiling code which should 'just work' on any compiler still in use in this century :) I currently do not see the problem with having both at this time. Of course, I am only one voice here. Once 1.5 is tagged I do not forsee any further problems arising since this should all be set in stone till 1.next/2.0. I agree they can coexist for a time. I was hoping that, in due time, CMake can be cooerced (even on unix) to emit generic VC .mak files we can replace the existing apr .mak files with, rather than using the exported .dsp files, and still avoiding a -requirement- for every user to install CMake themselves. But that means delegating feature detection for later rather than during CMake build file construction. It should be fairly straightforward to do with pre-filling anticipated dummy values into the CMake invocation, but something I hadn't had time to experiment with, just yet.
Re: Timetable for APR 1.5 release?
On Tue, 29 Oct 2013 10:32:03 -0700 Gregg Smith g...@gknw.net wrote: Suggestion - should we simply use the CROSS_COMPILE path when building for win32 .dsp/.mak files, instead? You mean using the CMake and dropping the Traditional build completely? -1 I currently do not see the problem with having both at this time. Of course, I am only one voice here. Once 1.5 is tagged I do not forsee any further problems arising since this should all be set in stone till 1.next/2.0. Nope - simply /DCROSS_COMPILE in the [lib]apr.dsp/.mak files rather than pre-copying apr.h. I don't think that using apr feature detection and headers buys us anything in compiling code which should 'just work' on any compiler still in use in this century :) ... I meant this strictly for gen_test_char.c source, of course.
Re: Timetable for APR 1.5 release?
On 29.10.2013 18:56, William A. Rowe Jr. wrote: Nope - simply /DCROSS_COMPILE in the [lib]apr.dsp/.mak files rather than pre-copying apr.h. I don't think that using apr feature detection and headers buys us anything in compiling code which should 'just work' on any compiler still in use in this century :) I suggested this already longer time ago for httpd as well - but only Stefan agreed so far ... as you seem to agree now as well we're 3 and I think we should push a change which removes APR dependency entirely from gen_test_char.c for all httpd + APR brances and make the code more simple. Gün.
Re: Timetable for APR 1.5 release?
On 10/29/2013 10:56 AM, William A. Rowe Jr. wrote: On Tue, 29 Oct 2013 10:32:03 -0700 Gregg Smithg...@gknw.net wrote: Suggestion - should we simply use the CROSS_COMPILE path when building for win32 .dsp/.mak files, instead? You mean using the CMake and dropping the Traditional build completely? -1 I currently do not see the problem with having both at this time. Of course, I am only one voice here. Once 1.5 is tagged I do not forsee any further problems arising since this should all be set in stone till 1.next/2.0. Nope - simply /DCROSS_COMPILE in the [lib]apr.dsp/.mak files rather than pre-copying apr.h. I don't think that using apr feature detection and headers buys us anything in compiling code which should 'just work' on any compiler still in use in this century :) ... I meant this strictly for gen_test_char.c source, of course. OK, I see what you are saying now and that should help some. gen_test_char.c still has to be compiled then run before the compile of apr_escape.c. What I do not want to have to do is use a separate project for gen_test_char like it is in httpd.
Re: Timetable for APR 1.5 release?
On Tue, 29 Oct 2013 19:07:32 +0100 Guenter Knauf fua...@apache.org wrote: On 29.10.2013 18:56, William A. Rowe Jr. wrote: Nope - simply /DCROSS_COMPILE in the [lib]apr.dsp/.mak files rather than pre-copying apr.h. I don't think that using apr feature detection and headers buys us anything in compiling code which should 'just work' on any compiler still in use in this century :) I suggested this already longer time ago for httpd as well - but only Stefan agreed so far ... as you seem to agree now as well we're 3 and I think we should push a change which removes APR dependency entirely from gen_test_char.c for all httpd + APR brances and make the code more simple. +1
Re: Timetable for APR 1.5 release?
On 10/29/2013 11:07 AM, Guenter Knauf wrote: On 29.10.2013 18:56, William A. Rowe Jr. wrote: Nope - simply /DCROSS_COMPILE in the [lib]apr.dsp/.mak files rather than pre-copying apr.h. I don't think that using apr feature detection and headers buys us anything in compiling code which should 'just work' on any compiler still in use in this century :) I suggested this already longer time ago for httpd as well - but only Stefan agreed so far ... as you seem to agree now as well we're 3 and I think we should push a change which removes APR dependency entirely from gen_test_char.c for all httpd + APR brances and make the code more simple. +1
Re: Timetable for APR 1.5 release?
Just a note, On 10/19/2013 10:32 AM, Gregg Smith wrote: On 10/19/2013 7:26 AM, Jeff Trawick wrote: On Thu, Oct 17, 2013 at 11:08 PM, Gregg Smith g...@gknw.net mailto:g...@gknw.net wrote: I'd like to first rid the 1.5 traditional Windows build of the Release9x Debug9x targets. Anyone against this? no concerns here; is there code that can get deleted too? probably, I would assume so, I haven't ran it down that far yet. I did not do this after all nor do I think I am brave enough to. apr_escape, testescape and gen_test_char were added into the build with r1534053. .mak/.dep files were added in r1534516. We should be ready to go on the Windows side now.
Re: Timetable for APR 1.5 release?
On Mon, Oct 28, 2013 at 12:50 PM, Gregg Smith g...@gknw.net wrote: Just a note, On 10/19/2013 10:32 AM, Gregg Smith wrote: On 10/19/2013 7:26 AM, Jeff Trawick wrote: On Thu, Oct 17, 2013 at 11:08 PM, Gregg Smith g...@gknw.net mailto: g...@gknw.net wrote: I'd like to first rid the 1.5 traditional Windows build of the Release9x Debug9x targets. Anyone against this? no concerns here; is there code that can get deleted too? probably, I would assume so, I haven't ran it down that far yet. I did not do this after all nor do I think I am brave enough to. apr_escape, testescape and gen_test_char were added into the build with r1534053. .mak/.dep files were added in r1534516. We should be ready to go on the Windows side now. Thanks a bunch. I found a MinGW build failure this a.m. which I'll fix in the next day or so. Other than that, I don't know what else needs to be solved. It would be appropriate to have documentation and at least a minimal testcase for skiplist, but I guess that isn't absolutely necessary. -- Born in Roswell... married an alien... http://emptyhammock.com/
Re: Timetable for APR 1.5 release?
On Mon, 28 Oct 2013 13:01:09 -0400 Jeff Trawick traw...@gmail.com wrote: On Mon, Oct 28, 2013 at 12:50 PM, Gregg Smith g...@gknw.net wrote: Just a note, On 10/19/2013 10:32 AM, Gregg Smith wrote: On 10/19/2013 7:26 AM, Jeff Trawick wrote: On Thu, Oct 17, 2013 at 11:08 PM, Gregg Smith g...@gknw.net mailto: g...@gknw.net wrote: I'd like to first rid the 1.5 traditional Windows build of the Release9x Debug9x targets. Anyone against this? no concerns here; is there code that can get deleted too? probably, I would assume so, I haven't ran it down that far yet. I did not do this after all nor do I think I am brave enough to. apr_escape, testescape and gen_test_char were added into the build with r1534053. .mak/.dep files were added in r1534516. We should be ready to go on the Windows side now. So, given that 1.5 remains compatible with 1.4... but projects which build APR themselves will have to adapt to the new gen_test_char or we need to make the suggested change, let's just take the httpd example. Does it make more sense for httpd 2.2 Makefile.win to detect the presence of gen_test_char and build it when encountered, or does it make more sense to compile-link-invoke gen_test_char.c? I'm happy to make the respective change later tonight or tomorrow, based on consensus.
Re: Timetable for APR 1.5 release?
On Mon, Oct 28, 2013 at 4:54 PM, William A. Rowe Jr. wr...@rowe-clan.netwrote: On Mon, 28 Oct 2013 13:01:09 -0400 Jeff Trawick traw...@gmail.com wrote: On Mon, Oct 28, 2013 at 12:50 PM, Gregg Smith g...@gknw.net wrote: Just a note, On 10/19/2013 10:32 AM, Gregg Smith wrote: On 10/19/2013 7:26 AM, Jeff Trawick wrote: On Thu, Oct 17, 2013 at 11:08 PM, Gregg Smith g...@gknw.net mailto: g...@gknw.net wrote: I'd like to first rid the 1.5 traditional Windows build of the Release9x Debug9x targets. Anyone against this? no concerns here; is there code that can get deleted too? probably, I would assume so, I haven't ran it down that far yet. I did not do this after all nor do I think I am brave enough to. apr_escape, testescape and gen_test_char were added into the build with r1534053. .mak/.dep files were added in r1534516. We should be ready to go on the Windows side now. So, given that 1.5 remains compatible with 1.4... but projects which build APR themselves will have to adapt to the new gen_test_char or we need to make the suggested change, let's just take the httpd example. Does it make more sense for httpd 2.2 Makefile.win to detect the presence of gen_test_char and build it when encountered, or does it make more sense to compile-link-invoke gen_test_char.c? I'm happy to make the respective change later tonight or tomorrow, based on consensus. Is the Windows build interface of apr 1.5.x different such that httpd's Makefile.win would care? httpd itself doesn't use apr escape and shouldn't care that apr happens to have a build utility of the same name as one of its own (or something is borked). -- Born in Roswell... married an alien... http://emptyhammock.com/
Re: Timetable for APR 1.5 release?
On Mon, 28 Oct 2013 16:58:45 -0400 Jeff Trawick traw...@gmail.com wrote: On Mon, Oct 28, 2013 at 4:54 PM, William A. Rowe Jr. wr...@rowe-clan.netwrote: On Mon, 28 Oct 2013 13:01:09 -0400 Jeff Trawick traw...@gmail.com wrote: On Mon, Oct 28, 2013 at 12:50 PM, Gregg Smith g...@gknw.net wrote: Just a note, On 10/19/2013 10:32 AM, Gregg Smith wrote: On 10/19/2013 7:26 AM, Jeff Trawick wrote: On Thu, Oct 17, 2013 at 11:08 PM, Gregg Smith g...@gknw.net mailto: g...@gknw.net wrote: I'd like to first rid the 1.5 traditional Windows build of the Release9x Debug9x targets. Anyone against this? no concerns here; is there code that can get deleted too? probably, I would assume so, I haven't ran it down that far yet. I did not do this after all nor do I think I am brave enough to. apr_escape, testescape and gen_test_char were added into the build with r1534053. .mak/.dep files were added in r1534516. We should be ready to go on the Windows side now. So, given that 1.5 remains compatible with 1.4... but projects which build APR themselves will have to adapt to the new gen_test_char or we need to make the suggested change, let's just take the httpd example. Does it make more sense for httpd 2.2 Makefile.win to detect the presence of gen_test_char and build it when encountered, or does it make more sense to compile-link-invoke gen_test_char.c? I'm happy to make the respective change later tonight or tomorrow, based on consensus. Is the Windows build interface of apr 1.5.x different such that httpd's Makefile.win would care? httpd itself doesn't use apr escape and shouldn't care that apr happens to have a build utility of the same name as one of its own (or something is borked). The httpd 2.2 Makefile.win build invokes the pcre, expat, apr, apr-iconv and apr-util builds project-by-project, it doesn't use any corresponding top-level build mechanics. This was one aspect that was greatly improved by moving to the httpd-2.4 model. If httpd doesn't pre-build gen_test_char before apr.mak, then the apr build will fail, unless we nest the new gen_test_char pre-build. I think the better solution for a one-source file, source generation app is to embed that build into the [lib]apr.dsp/mak files for now. But as an alternative, we can teach httpd 2.2 Makefile.win to anticipate this requirement if that project is present. That would mean that 1.5 apr wouldn't build with older httpd 2.2 releases, only the next release onwards.
Re: Timetable for APR 1.5 release?
On Thu, Oct 17, 2013 at 11:08 PM, Gregg Smith g...@gknw.net wrote: On 10/17/2013 7:49 AM, Jeff Trawick wrote: On Wed, Oct 16, 2013 at 9:22 AM, Jeff Trawick traw...@gmail.com mailto: traw...@gmail.com wrote: On Tue, Oct 1, 2013 at 8:26 AM, Jeff Trawick traw...@gmail.com mailto:traw...@gmail.com wrote: On Tue, Oct 1, 2013 at 7:32 AM, Jim Jagielski j...@jagunet.com mailto:j...@jagunet.com wrote: Subj sez it all. I've never been RM for APR but am willing to do this one... I'm happy to take care of the RM work. Some things I'm interested in checking on for 1.5.x: * Compare 1.4.x-1.5.x and see if anything was missed. (I'm pretty sure that there are some .h fixes that skipped 1.5.x; dunno what else.) * Add the cmake support. (I purposefully skipped the 1.5.x branch when there was constant activity.) * Put in a couple of fixes for Cygwin that somebody opened bugs for in the last week or so. * Test MinGW static and shared builds in conjunction with APR-util 1.5.x. (Should be okay; some fixes for shared never hit the 1.4.x branch, so it would be good to ensure this is finally working.) * Check for anything whatsoever that could be merged from trunk and see what to do, as presumably there won't be another opportunity for a while. It would be good for TR to be no sooner than next Monday. Any other thoughts on what to look at before TR of the first 1.5.x release? -- Born in Roswell... married an alien... http://emptyhammock.com/ I haven't forgotten :) I want to wrap up the apr_shm stuff on Windows and finish working through appropriate fixes that aren't in 1.5.x. Additionally, the traditional Windows build system is not ready in the 1.5.x branch but maybe some kind soul will be able to take care of that. BTW, the stuff that seems to be missing from the traditional Windows build system in the 1.5.x branch is * apr_escape stuff including gen_test_char (I think trunk has this in the Windows build system) No, I see nothing in trunk for either. oops, sorry :( I'd like to first rid the 1.5 traditional Windows build of the Release9x Debug9x targets. Anyone against this? no concerns here; is there code that can get deleted too? gen_test_char is straight forward enough, generates apr_escape_test_char.h which is included in apr_escape.c. I am however compelled to think of httpd and this gets tricky when building httpd in it's traditional build (since apr is built during the httpd build) if I need to first build gen_test_char so I can generate the header before compiling the libs. Since this is not needed in APR 1.5, to do this in httpd may create a requirement for APR 1.5 in httpd. Not sure that's a bad thing. I'm confused. httpd still has its own gen_test_char when generates a certain .h, and apr now has one that generates a different .h. Why wouldn't the build continue to run both programs when building httpd 2.4 in conjunction with apr 1.5? (I assume that in the future httpd trunk will consume apr_escape and not need both, but we're not there yet.) There is a existing pre-generated apr_escape_test_char.h in apr/include/private but if differs slightly from the output I get when I run gen_test_char on Windows. What I do get is consistent over the 3 different Windows versions on three different computers and two different versions of MSVC. The difference between them is; -32,30,30,30,30,30,30,30,30,30,**31,30,30,30,30,30,30,30,30,30, -30,30,30,30,30,30,30,30,30,30,**30,30,6,16,63,22,17,22,49,17, +32,30,30,30,30,30,30,30,30,30,**31,30,30,31,30,30,30,30,30,30, +30,30,30,30,30,30,30,30,30,30,**30,30,6,16,63,22,17,23,49,17, What this means is that \r and % are escaped on Windows and OS/2 when performing shell escaping, but are not on other platforms. Regardless of which I compile with (existing or freshly generated), testescape succeeds. So I seem to have a few options and not sure which way to turn. 1. build and run gen_test_char before compiling APR. This would need to be duplicated in httpd which would create the requirement for APR 1.5. help me out here (I seem them as completely independent steps which happen to perform a similar function) 2. Pre-generate on Windows apr_escape_test_char.h(w) and add to apr/include/private in svn which could be dealt with during the APR build just like apr.h is in Windows (simple and will not affect httpd build). if committing one for Unix works then that would work too 3. Use the pre-generated one in apr/include/private (simpler and will not affect httpd build). need those extra chars escaped for shell AFAIK I'm leaning toward #2. Comments? * generated makefiles Can do. Regards, Gregg -- Born
Re: Timetable for APR 1.5 release?
On 10/19/2013 7:26 AM, Jeff Trawick wrote: On Thu, Oct 17, 2013 at 11:08 PM, Gregg Smith g...@gknw.net mailto:g...@gknw.net wrote: On 10/17/2013 7:49 AM, Jeff Trawick wrote: On Wed, Oct 16, 2013 at 9:22 AM, Jeff Trawick traw...@gmail.com mailto:traw...@gmail.com mailto:traw...@gmail.com mailto:traw...@gmail.com wrote: On Tue, Oct 1, 2013 at 8:26 AM, Jeff Trawick traw...@gmail.com mailto:traw...@gmail.com mailto:traw...@gmail.com mailto:traw...@gmail.com wrote: On Tue, Oct 1, 2013 at 7:32 AM, Jim Jagielski j...@jagunet.com mailto:j...@jagunet.com mailto:j...@jagunet.com mailto:j...@jagunet.com wrote: Subj sez it all. I've never been RM for APR but am willing to do this one... I'm happy to take care of the RM work. Some things I'm interested in checking on for 1.5.x: * Compare 1.4.x-1.5.x and see if anything was missed. (I'm pretty sure that there are some .h fixes that skipped 1.5.x; dunno what else.) * Add the cmake support. (I purposefully skipped the 1.5.x branch when there was constant activity.) * Put in a couple of fixes for Cygwin that somebody opened bugs for in the last week or so. * Test MinGW static and shared builds in conjunction with APR-util 1.5.x. (Should be okay; some fixes for shared never hit the 1.4.x branch, so it would be good to ensure this is finally working.) * Check for anything whatsoever that could be merged from trunk and see what to do, as presumably there won't be another opportunity for a while. It would be good for TR to be no sooner than next Monday. Any other thoughts on what to look at before TR of the first 1.5.x release? -- Born in Roswell... married an alien... http://emptyhammock.com/ I haven't forgotten :) I want to wrap up the apr_shm stuff on Windows and finish working through appropriate fixes that aren't in 1.5.x. Additionally, the traditional Windows build system is not ready in the 1.5.x branch but maybe some kind soul will be able to take care of that. BTW, the stuff that seems to be missing from the traditional Windows build system in the 1.5.x branch is * apr_escape stuff including gen_test_char (I think trunk has this in the Windows build system) No, I see nothing in trunk for either. oops, sorry :( I'd like to first rid the 1.5 traditional Windows build of the Release9x Debug9x targets. Anyone against this? no concerns here; is there code that can get deleted too? probably, I would assume so, I haven't ran it down that far yet. gen_test_char is straight forward enough, generates apr_escape_test_char.h which is included in apr_escape.c. I am however compelled to think of httpd and this gets tricky when building httpd in it's traditional build (since apr is built during the httpd build) if I need to first build gen_test_char so I can generate the header before compiling the libs. Since this is not needed in APR 1.5, to do this in httpd may create a requirement for APR 1.5 in httpd. Not sure that's a bad thing. I'm confused. httpd still has its own gen_test_char when generates a certain .h, and apr now has one that generates a different .h. Why wouldn't the build continue to run both programs when building httpd 2.4 in conjunction with apr 1.5? (I assume that in the future httpd trunk will consume apr_escape and not need both, but we're not there yet.) httpd is a bunch of projects run in a certain order, gen_test_char is just one of the many projects as is apr. apr is just a single project, to build it's gen_test_char is another project that would need to be added to the httpd build, or so was my 1 dimensional thinking at the time. I've since realized it can be done w/o being a separate project. So false alarm, my bad, sorry.
Re: Timetable for APR 1.5 release?
On Wed, Oct 16, 2013 at 9:22 AM, Jeff Trawick traw...@gmail.com wrote: On Tue, Oct 1, 2013 at 8:26 AM, Jeff Trawick traw...@gmail.com wrote: On Tue, Oct 1, 2013 at 7:32 AM, Jim Jagielski j...@jagunet.com wrote: Subj sez it all. I've never been RM for APR but am willing to do this one... I'm happy to take care of the RM work. Some things I'm interested in checking on for 1.5.x: * Compare 1.4.x-1.5.x and see if anything was missed. (I'm pretty sure that there are some .h fixes that skipped 1.5.x; dunno what else.) * Add the cmake support. (I purposefully skipped the 1.5.x branch when there was constant activity.) * Put in a couple of fixes for Cygwin that somebody opened bugs for in the last week or so. * Test MinGW static and shared builds in conjunction with APR-util 1.5.x. (Should be okay; some fixes for shared never hit the 1.4.x branch, so it would be good to ensure this is finally working.) * Check for anything whatsoever that could be merged from trunk and see what to do, as presumably there won't be another opportunity for a while. It would be good for TR to be no sooner than next Monday. Any other thoughts on what to look at before TR of the first 1.5.x release? -- Born in Roswell... married an alien... http://emptyhammock.com/ I haven't forgotten :) I want to wrap up the apr_shm stuff on Windows and finish working through appropriate fixes that aren't in 1.5.x. Additionally, the traditional Windows build system is not ready in the 1.5.x branch but maybe some kind soul will be able to take care of that. BTW, the stuff that seems to be missing from the traditional Windows build system in the 1.5.x branch is * apr_escape stuff including gen_test_char (I think trunk has this in the Windows build system) * generated makefiles -- Born in Roswell... married an alien... http://emptyhammock.com/ -- Born in Roswell... married an alien... http://emptyhammock.com/
Re: Timetable for APR 1.5 release?
On 10/17/2013 7:49 AM, Jeff Trawick wrote: On Wed, Oct 16, 2013 at 9:22 AM, Jeff Trawick traw...@gmail.com mailto:traw...@gmail.com wrote: On Tue, Oct 1, 2013 at 8:26 AM, Jeff Trawick traw...@gmail.com mailto:traw...@gmail.com wrote: On Tue, Oct 1, 2013 at 7:32 AM, Jim Jagielski j...@jagunet.com mailto:j...@jagunet.com wrote: Subj sez it all. I've never been RM for APR but am willing to do this one... I'm happy to take care of the RM work. Some things I'm interested in checking on for 1.5.x: * Compare 1.4.x-1.5.x and see if anything was missed. (I'm pretty sure that there are some .h fixes that skipped 1.5.x; dunno what else.) * Add the cmake support. (I purposefully skipped the 1.5.x branch when there was constant activity.) * Put in a couple of fixes for Cygwin that somebody opened bugs for in the last week or so. * Test MinGW static and shared builds in conjunction with APR-util 1.5.x. (Should be okay; some fixes for shared never hit the 1.4.x branch, so it would be good to ensure this is finally working.) * Check for anything whatsoever that could be merged from trunk and see what to do, as presumably there won't be another opportunity for a while. It would be good for TR to be no sooner than next Monday. Any other thoughts on what to look at before TR of the first 1.5.x release? -- Born in Roswell... married an alien... http://emptyhammock.com/ I haven't forgotten :) I want to wrap up the apr_shm stuff on Windows and finish working through appropriate fixes that aren't in 1.5.x. Additionally, the traditional Windows build system is not ready in the 1.5.x branch but maybe some kind soul will be able to take care of that. BTW, the stuff that seems to be missing from the traditional Windows build system in the 1.5.x branch is * apr_escape stuff including gen_test_char (I think trunk has this in the Windows build system) No, I see nothing in trunk for either. I'd like to first rid the 1.5 traditional Windows build of the Release9x Debug9x targets. Anyone against this? gen_test_char is straight forward enough, generates apr_escape_test_char.h which is included in apr_escape.c. I am however compelled to think of httpd and this gets tricky when building httpd in it's traditional build (since apr is built during the httpd build) if I need to first build gen_test_char so I can generate the header before compiling the libs. Since this is not needed in APR 1.5, to do this in httpd may create a requirement for APR 1.5 in httpd. Not sure that's a bad thing. There is a existing pre-generated apr_escape_test_char.h in apr/include/private but if differs slightly from the output I get when I run gen_test_char on Windows. What I do get is consistent over the 3 different Windows versions on three different computers and two different versions of MSVC. The difference between them is; -32,30,30,30,30,30,30,30,30,30,31,30,30,30,30,30,30,30,30,30, -30,30,30,30,30,30,30,30,30,30,30,30,6,16,63,22,17,22,49,17, +32,30,30,30,30,30,30,30,30,30,31,30,30,31,30,30,30,30,30,30, +30,30,30,30,30,30,30,30,30,30,30,30,6,16,63,22,17,23,49,17, Regardless of which I compile with (existing or freshly generated), testescape succeeds. So I seem to have a few options and not sure which way to turn. 1. build and run gen_test_char before compiling APR. This would need to be duplicated in httpd which would create the requirement for APR 1.5. 2. Pre-generate on Windows apr_escape_test_char.h(w) and add to apr/include/private in svn which could be dealt with during the APR build just like apr.h is in Windows (simple and will not affect httpd build). 3. Use the pre-generated one in apr/include/private (simpler and will not affect httpd build). I'm leaning toward #2. Comments? * generated makefiles Can do. Regards, Gregg
Re: Timetable for APR 1.5 release?
On Tue, Oct 1, 2013 at 8:26 AM, Jeff Trawick traw...@gmail.com wrote: On Tue, Oct 1, 2013 at 7:32 AM, Jim Jagielski j...@jagunet.com wrote: Subj sez it all. I've never been RM for APR but am willing to do this one... I'm happy to take care of the RM work. Some things I'm interested in checking on for 1.5.x: * Compare 1.4.x-1.5.x and see if anything was missed. (I'm pretty sure that there are some .h fixes that skipped 1.5.x; dunno what else.) * Add the cmake support. (I purposefully skipped the 1.5.x branch when there was constant activity.) * Put in a couple of fixes for Cygwin that somebody opened bugs for in the last week or so. * Test MinGW static and shared builds in conjunction with APR-util 1.5.x. (Should be okay; some fixes for shared never hit the 1.4.x branch, so it would be good to ensure this is finally working.) * Check for anything whatsoever that could be merged from trunk and see what to do, as presumably there won't be another opportunity for a while. It would be good for TR to be no sooner than next Monday. Any other thoughts on what to look at before TR of the first 1.5.x release? -- Born in Roswell... married an alien... http://emptyhammock.com/ I haven't forgotten :) I want to wrap up the apr_shm stuff on Windows and finish working through appropriate fixes that aren't in 1.5.x. Additionally, the traditional Windows build system is not ready in the 1.5.x branch but maybe some kind soul will be able to take care of that. -- Born in Roswell... married an alien... http://emptyhammock.com/
Re: Timetable for APR 1.5 release?
On Wed, Oct 16, 2013 at 9:27 AM, Dirkjan Ochtman dirk...@ochtman.nl wrote: On Wed, Oct 16, 2013 at 3:22 PM, Jeff Trawick traw...@gmail.com wrote: I haven't forgotten :) I want to wrap up the apr_shm stuff on Windows and finish working through appropriate fixes that aren't in 1.5.x. Additionally, the traditional Windows build system is not ready in the 1.5.x branch but maybe some kind soul will be able to take care of that. Sorry if I'm nagging, but did you see my message on SHA2 from last week? If sending such a message is the wrong way about getting this done, please let me know what the right way might be. Cheers, Dirkjan I'll respond on the other thread. -- Born in Roswell... married an alien... http://emptyhammock.com/
Re: Timetable for APR 1.5 release?
On 02 Oct 2013, at 3:40 PM, Jeff Trawick traw...@gmail.com wrote: There is also the apr_escape API from v2.0 which has not been backported yet. That doesn't work on Windows; relies (or just uses?) some non-portable escape sequence... I see the warnings roll by during compile and the testcase fails but I haven't taken the time to investigate. Another ping on those details. The apr_escape API consists simply of code that has been historically scattered around the httpd codebase, none of the code is new. If there are warnings on Windows it could be caused by #ifdef's not correctly specified or something similar, without seeing any of the warnings though I cannot comment. In the mean time I will backport the API to get the ball rolling. Regards, Graham --
Re: Timetable for APR 1.5 release?
(whoops, meant to respond to both places; I hate this list setup) On Wed, Oct 9, 2013 at 3:33 PM, Jeff Trawick traw...@gmail.com wrote: On Wed, Oct 9, 2013 at 3:17 PM, Graham Leggett minf...@sharp.fm wrote: On 02 Oct 2013, at 3:40 PM, Jeff Trawick traw...@gmail.com wrote: There is also the apr_escape API from v2.0 which has not been backported yet. That doesn't work on Windows; relies (or just uses?) some non-portable escape sequence... I see the warnings roll by during compile and the testcase fails but I haven't taken the time to investigate. Another ping on those details. I posted a patch to dev@apr with subject [PATCH] apr escape API, portability issues seen on Windows. The apr_escape API consists simply of code that has been historically scattered around the httpd codebase, none of the code is new. If there are warnings on Windows it could be caused by #ifdef's not correctly specified or something similar, without seeing any of the warnings though I cannot comment. In the mean time I will backport the API to get the ball rolling. Please don't put the gcc extension escape sequence into a stable branch without protecting the code from other compilers. Really, all of the code affected by the patch needs to be considered first. Regards, Graham -- -- Born in Roswell... married an alien... http://emptyhammock.com/ -- Born in Roswell... married an alien... http://emptyhammock.com/
Re: Timetable for APR 1.5 release?
On Thu, Oct 3, 2013 at 12:31 PM, Mike Rumph mike.ru...@oracle.com wrote: Thanks Rainer, The backport looks good! Perhaps you could also consider applying my doc patch for apr_buckets.h in bug 55115. - https://issues.apache.org/**bugzilla/show_bug.cgi?id=55115https://issues.apache.org/bugzilla/show_bug.cgi?id=55115 It is a small doc change, but corrects a misconception that could mislead a module writer. On my list in case nobody else takes care of it first. Thanks! Take care, Mike Rumph On 10/3/2013 6:42 AM, Rainer Jung wrote: On 02.10.2013 16:19, Mike Rumph wrote: Hello Jeff, Since you are considering a release of APR 1.5. This might be a good time to backport the APR documentation patch from revision 1496407. The second patch in bug 55133 will apply to the APR 1.5.x branch. - https://issues.apache.org/**bugzilla/show_bug.cgi?id=55133https://issues.apache.org/bugzilla/show_bug.cgi?id=55133 This contains about 30 documentation corrections. I've merged r1496407 to apr/apu. Please double check. Thanks! Rainer -- Born in Roswell... married an alien... http://emptyhammock.com/
Re: Timetable for APR 1.5 release?
On 02.10.2013 16:19, Mike Rumph wrote: Hello Jeff, Since you are considering a release of APR 1.5. This might be a good time to backport the APR documentation patch from revision 1496407. The second patch in bug 55133 will apply to the APR 1.5.x branch. - https://issues.apache.org/bugzilla/show_bug.cgi?id=55133 This contains about 30 documentation corrections. I've merged r1496407 to apr/apu. Please double check. Thanks! Rainer
Re: Timetable for APR 1.5 release?
On 01.10.2013 14:26, Jeff Trawick wrote: Some things I'm interested in checking on for 1.5.x: * Compare 1.4.x-1.5.x and see if anything was missed. (I'm pretty sure that there are some .h fixes that skipped 1.5.x; dunno what else.) I did a comparison and reduced the delta. As far as I can see it is: - No *.mak and *.dep files in 1.5.x, they exist in 1.4.x: Only in 1.4.x: apr.dep Only in 1.4.x: apr.mak Only in 1.4.x/build: aprapp.dep Only in 1.4.x/build: aprapp.mak Only in 1.4.x/build: libaprapp.dep Only in 1.4.x/build: libaprapp.mak Only in 1.4.x: libapr.dep Only in 1.4.x: libapr.mak Regards, Rainer
Re: Timetable for APR 1.5 release?
Thanks Rainer, The backport looks good! Perhaps you could also consider applying my doc patch for apr_buckets.h in bug 55115. - https://issues.apache.org/bugzilla/show_bug.cgi?id=55115 It is a small doc change, but corrects a misconception that could mislead a module writer. Take care, Mike Rumph On 10/3/2013 6:42 AM, Rainer Jung wrote: On 02.10.2013 16:19, Mike Rumph wrote: Hello Jeff, Since you are considering a release of APR 1.5. This might be a good time to backport the APR documentation patch from revision 1496407. The second patch in bug 55133 will apply to the APR 1.5.x branch. - https://issues.apache.org/bugzilla/show_bug.cgi?id=55133 This contains about 30 documentation corrections. I've merged r1496407 to apr/apu. Please double check. Thanks! Rainer
Re: Timetable for APR 1.5 release?
I also did a by-dir diff, which is easier... in this way, you can see the actual changes. Still not fully baked, but this provides insight... http://people.apache.org/~jim/patches/apr-15-trunk/ On Oct 3, 2013, at 12:53 PM, Jim Jagielski j...@jagunet.com wrote: On Oct 1, 2013, at 8:26 AM, Jeff Trawick traw...@gmail.com wrote: * Check for anything whatsoever that could be merged from trunk and see what to do, as presumably there won't be another opportunity for a while. The diff between 1.5 and trunk is pretty large, but here is a diff file with the apr0util stuff deleted from it... Some things (like the shm stuff) looks ez, but this is QUITE a large list to go thru by Monday.
Re: Timetable for APR 1.5 release?
On Thu, Oct 3, 2013 at 12:53 PM, Jim Jagielski j...@jagunet.com wrote: On Oct 1, 2013, at 8:26 AM, Jeff Trawick traw...@gmail.com wrote: * Check for anything whatsoever that could be merged from trunk and see what to do, as presumably there won't be another opportunity for a while. The diff between 1.5 and trunk is pretty large, but here is a diff file with the apr0util stuff deleted from it... Some things (like the shm stuff) looks ez, but this is QUITE a large list to go thru by Monday. Monday was the earliest possible I could imagine... A bit later is better :) -- Born in Roswell... married an alien... http://emptyhammock.com/
Re: Timetable for APR 1.5 release?
On Oct 1, 2013, at 8:26 AM, Jeff Trawick traw...@gmail.com wrote: On Tue, Oct 1, 2013 at 7:32 AM, Jim Jagielski j...@jagunet.com wrote: Subj sez it all. I've never been RM for APR but am willing to do this one... I'm happy to take care of the RM work. Sure, no prob. Let me know if that doesn't work out... Some things I'm interested in checking on for 1.5.x: * Compare 1.4.x-1.5.x and see if anything was missed. (I'm pretty sure that there are some .h fixes that skipped 1.5.x; dunno what else.) I'll do as well. * Add the cmake support. (I purposefully skipped the 1.5.x branch when there was constant activity.) +1 * Put in a couple of fixes for Cygwin that somebody opened bugs for in the last week or so. * Test MinGW static and shared builds in conjunction with APR-util 1.5.x. (Should be okay; some fixes for shared never hit the 1.4.x branch, so it would be good to ensure this is finally working.) * Check for anything whatsoever that could be merged from trunk and see what to do, as presumably there won't be another opportunity for a while. It would be good for TR to be no sooner than next Monday. ++1 Any other thoughts on what to look at before TR of the first 1.5.x release? -- Born in Roswell... married an alien... http://emptyhammock.com/
Re: Timetable for APR 1.5 release?
On Oct 1, 2013, at 8:35 AM, Brian J. France br...@brianfrance.com wrote: On Oct 1, 2013, at 8:26 AM, Jeff Trawick traw...@gmail.com wrote: On Tue, Oct 1, 2013 at 7:32 AM, Jim Jagielski j...@jagunet.com wrote: Subj sez it all. I've never been RM for APR but am willing to do this one... I'm happy to take care of the RM work. Some things I'm interested in checking on for 1.5.x: * Compare 1.4.x-1.5.x and see if anything was missed. (I'm pretty sure that there are some .h fixes that skipped 1.5.x; dunno what else.) * Add the cmake support. (I purposefully skipped the 1.5.x branch when there was constant activity.) * Put in a couple of fixes for Cygwin that somebody opened bugs for in the last week or so. * Test MinGW static and shared builds in conjunction with APR-util 1.5.x. (Should be okay; some fixes for shared never hit the 1.4.x branch, so it would be good to ensure this is finally working.) * Check for anything whatsoever that could be merged from trunk and see what to do, as presumably there won't be another opportunity for a while. It would be good for TR to be no sooner than next Monday. Any other thoughts on what to look at before TR of the first 1.5.x release? Could we back port the file rotating stuff? http://svn.apache.org/viewvc?view=revisionrevision=905970 I am about to import 1.4 into our builds at work and would jump straight to 1.5 if it had the rotation stuff (would remove our own rotation patches). Certainly this needs Win32 patches, doesn't it?
Re: Timetable for APR 1.5 release?
On Oct 2, 2013, at 7:23 AM, Jim Jagielski j...@jagunet.com wrote: On Oct 1, 2013, at 8:35 AM, Brian J. France br...@brianfrance.com wrote: On Oct 1, 2013, at 8:26 AM, Jeff Trawick traw...@gmail.com wrote: On Tue, Oct 1, 2013 at 7:32 AM, Jim Jagielski j...@jagunet.com wrote: Subj sez it all. I've never been RM for APR but am willing to do this one... I'm happy to take care of the RM work. Some things I'm interested in checking on for 1.5.x: * Compare 1.4.x-1.5.x and see if anything was missed. (I'm pretty sure that there are some .h fixes that skipped 1.5.x; dunno what else.) * Add the cmake support. (I purposefully skipped the 1.5.x branch when there was constant activity.) * Put in a couple of fixes for Cygwin that somebody opened bugs for in the last week or so. * Test MinGW static and shared builds in conjunction with APR-util 1.5.x. (Should be okay; some fixes for shared never hit the 1.4.x branch, so it would be good to ensure this is finally working.) * Check for anything whatsoever that could be merged from trunk and see what to do, as presumably there won't be another opportunity for a while. It would be good for TR to be no sooner than next Monday. Any other thoughts on what to look at before TR of the first 1.5.x release? Could we back port the file rotating stuff? http://svn.apache.org/viewvc?view=revisionrevision=905970 I am about to import 1.4 into our builds at work and would jump straight to 1.5 if it had the rotation stuff (would remove our own rotation patches). Certainly this needs Win32 patches, doesn't it? Yes, it would. I guess we never worked on that side of things.
Re: Timetable for APR 1.5 release?
On 01 Oct 2013, at 2:26 PM, Jeff Trawick traw...@gmail.com wrote: I'm happy to take care of the RM work. Some things I'm interested in checking on for 1.5.x: * Compare 1.4.x-1.5.x and see if anything was missed. (I'm pretty sure that there are some .h fixes that skipped 1.5.x; dunno what else.) There is also the apr_escape API from v2.0 which has not been backported yet. Regards, Graham --
Re: Timetable for APR 1.5 release?
On Wed, Oct 2, 2013 at 9:37 AM, Graham Leggett minf...@sharp.fm wrote: On 01 Oct 2013, at 2:26 PM, Jeff Trawick traw...@gmail.com wrote: I'm happy to take care of the RM work. Some things I'm interested in checking on for 1.5.x: * Compare 1.4.x-1.5.x and see if anything was missed. (I'm pretty sure that there are some .h fixes that skipped 1.5.x; dunno what else.) There is also the apr_escape API from v2.0 which has not been backported yet. That doesn't work on Windows; relies (or just uses?) some non-portable escape sequence... I see the warnings roll by during compile and the testcase fails but I haven't taken the time to investigate. Regards, Graham -- -- Born in Roswell... married an alien... http://emptyhammock.com/
Re: Timetable for APR 1.5 release?
Hello Jeff, Since you are considering a release of APR 1.5. This might be a good time to backport the APR documentation patch from revision 1496407. The second patch in bug 55133 will apply to the APR 1.5.x branch. - https://issues.apache.org/bugzilla/show_bug.cgi?id=55133 This contains about 30 documentation corrections. Thanks, Mike On 10/2/2013 6:40 AM, Jeff Trawick wrote: On Wed, Oct 2, 2013 at 9:37 AM, Graham Leggett minf...@sharp.fm mailto:minf...@sharp.fm wrote: On 01 Oct 2013, at 2:26 PM, Jeff Trawick traw...@gmail.com mailto:traw...@gmail.com wrote: I'm happy to take care of the RM work. Some things I'm interested in checking on for 1.5.x: * Compare 1.4.x-1.5.x and see if anything was missed. (I'm pretty sure that there are some .h fixes that skipped 1.5.x; dunno what else.) There is also the apr_escape API from v2.0 which has not been backported yet. That doesn't work on Windows; relies (or just uses?) some non-portable escape sequence... I see the warnings roll by during compile and the testcase fails but I haven't taken the time to investigate. Regards, Graham -- -- Born in Roswell... married an alien... http://emptyhammock.com/
Re: Timetable for APR 1.5 release?
On 02 Oct 2013, at 3:40 PM, Jeff Trawick traw...@gmail.com wrote: There is also the apr_escape API from v2.0 which has not been backported yet. That doesn't work on Windows; relies (or just uses?) some non-portable escape sequence... I see the warnings roll by during compile and the testcase fails but I haven't taken the time to investigate. Can you post more details? Don't have any access to Windows, but can take a look at the warnings. Regards, Graham --
