Re: [DISCUSS] Personal branches under apache/kafka
+1 to delete personal branches Also +1 to Matthias to disable push if the branch is nonexistent > committers for various > reasons, bugfix, tests. That is interesting. Can anyone share the details here? I’d like to know the bug/test which need to have a branch. Chia-Ping > Mickael Maison 於 2024年3月14日 凌晨2:02 寫道： > > Hi, > > We have accumulated a number of personal branches in the github > repository: https://github.com/apache/kafka/branches/all > > All these branches have been created by committers for various > reasons, bugfix, tests. > > I wonder if we should avoid creating branches in the apache repository > (always use your own fork like regular contributors) and in the rare > cases this is necessary ensure we delete them once done? This way we > would only have branches for the various releases (3.7, 3.6, etc). > > What do you think? > > Thanks, > Mickael
Re: [DISCUSS] Personal branches under apache/kafka
An alternative would be to have a convention for personal branches. For example "tmp/ijuma/blah". I don't have a strong opinion, but it seems useful if people want to collaborate on a branch. Ismael On Wed, Mar 13, 2024 at 11:02 AM Mickael Maison wrote: > Hi, > > We have accumulated a number of personal branches in the github > repository: https://github.com/apache/kafka/branches/all > > All these branches have been created by committers for various > reasons, bugfix, tests. > > I wonder if we should avoid creating branches in the apache repository > (always use your own fork like regular contributors) and in the rare > cases this is necessary ensure we delete them once done? This way we > would only have branches for the various releases (3.7, 3.6, etc). > > What do you think? > > Thanks, > Mickael >
Re: [DISCUSS] Personal branches under apache/kafka
+1 Sounds like a good idea to me. -Bill On Wed, Mar 13, 2024 at 2:55 PM Matthias J. Sax wrote: > +1 > > Should be fine to just delete all of them (as long as nobody raised > objections). > > Not sure if we could enable some protection GitHub side that disallow to > push into non-existing branches and thus avoids accidental branch creation? > > > -Matthias > > On 3/13/24 11:39 AM, Josep Prat wrote: > > Hi Michael, > > > > I think it's a good idea. Only "official" branches should exist in the > > upstream repo. > > I guess the only exception would be if a massive feature would be done by > > different individuals collaborating and they would need a "neutral" place > > for the branch to be. But This didn't happen yet and I doubt it will in > the > > near future. > > > > Best, > > > > --- > > Josep Prat > > Open Source Engineering Director, aivenjosep.p...@aiven.io | > > +491715557497 | aiven.io > > Aiven Deutschland GmbH > > Alexanderufer 3-7, 10117 Berlin > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > Amtsgericht Charlottenburg, HRB 209739 B > > > > On Wed, Mar 13, 2024, 19:27 José Armando García Sancio > > wrote: > > > >> On Wed, Mar 13, 2024 at 11:02 AM Mickael Maison > >> wrote: > >>> What do you think? > >> > >> I agree. I wouldn't be surprised if these branches (not trunk or > >> release branches) were created by mistake by the committer. > >> > >> Thanks, > >> -- > >> -José > >> > > >
Re: [DISCUSS] Personal branches under apache/kafka
+1 Should be fine to just delete all of them (as long as nobody raised objections). Not sure if we could enable some protection GitHub side that disallow to push into non-existing branches and thus avoids accidental branch creation? -Matthias On 3/13/24 11:39 AM, Josep Prat wrote: Hi Michael, I think it's a good idea. Only "official" branches should exist in the upstream repo. I guess the only exception would be if a massive feature would be done by different individuals collaborating and they would need a "neutral" place for the branch to be. But This didn't happen yet and I doubt it will in the near future. Best, --- Josep Prat Open Source Engineering Director, aivenjosep.p...@aiven.io | +491715557497 | aiven.io Aiven Deutschland GmbH Alexanderufer 3-7, 10117 Berlin Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen Amtsgericht Charlottenburg, HRB 209739 B On Wed, Mar 13, 2024, 19:27 José Armando García Sancio wrote: On Wed, Mar 13, 2024 at 11:02 AM Mickael Maison wrote: What do you think? I agree. I wouldn't be surprised if these branches (not trunk or release branches) were created by mistake by the committer. Thanks, -- -José
Re: [DISCUSS] Personal branches under apache/kafka
Hi Michael, I think it's a good idea. Only "official" branches should exist in the upstream repo. I guess the only exception would be if a massive feature would be done by different individuals collaborating and they would need a "neutral" place for the branch to be. But This didn't happen yet and I doubt it will in the near future. Best, --- Josep Prat Open Source Engineering Director, aivenjosep.p...@aiven.io | +491715557497 | aiven.io Aiven Deutschland GmbH Alexanderufer 3-7, 10117 Berlin Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen Amtsgericht Charlottenburg, HRB 209739 B On Wed, Mar 13, 2024, 19:27 José Armando García Sancio wrote: > On Wed, Mar 13, 2024 at 11:02 AM Mickael Maison > wrote: > > What do you think? > > I agree. I wouldn't be surprised if these branches (not trunk or > release branches) were created by mistake by the committer. > > Thanks, > -- > -José >
Re: [DISCUSS] Personal branches under apache/kafka
On Wed, Mar 13, 2024 at 11:02 AM Mickael Maison wrote: > What do you think? I agree. I wouldn't be surprised if these branches (not trunk or release branches) were created by mistake by the committer. Thanks, -- -José
