Re: [VOTE] Release Apache YuniKorn (Incubating) 0.11.0 (RC2)

[Wangda Tan]

+1 from me:

Checked:
- incubating in name
- both of Signatures/hashes are good
- LICENSE/NOTICE good
- No unexpected binary files
- Checked all source files have ASF headers
- Compilable from source

-Wangda

On Sun, Aug 8, 2021 at 11:18 PM Xun Liu  wrote:

> hi Weiwei Yang
>
> Thank you for your prompt reply.
> +1 (non-binding) from me.
>
> Best regards
> Xun Liu
>
> On Mon, Aug 9, 2021 at 1:51 PM Weiwei Yang  wrote:
>
> > hi Xun, Justin
> >
> > Thanks for the suggestion!
> > I have created https://issues.apache.org/jira/browse/YUNIKORN-789 to
> > address this.
> >
> > On Sun, Aug 8, 2021 at 10:48 PM Justin Mclean 
> > wrote:
> >
> > > Hi,
> > >
> > > > I have a question.
> > > > I did not see the two files `NOTICE` and `DISCLAIMER` in the
> > > > [1],[2],[3],[4] repo of incubator-yunikorn.
> > >
> > > It would be good if they are there, but what matters is if they end up
> in
> > > the release artefacts.
> > >
> > > Thanks,
> > > Justin
> > > -
> > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > > For additional commands, e-mail: general-h...@incubator.apache.org
> > >
> > >
> >
>

Re: [VOTE] Release Apache YuniKorn (Incubating) 0.11.0 (RC2)

[Xun Liu]

hi Weiwei Yang

Thank you for your prompt reply.
+1 (non-binding) from me.

Best regards
Xun Liu

On Mon, Aug 9, 2021 at 1:51 PM Weiwei Yang  wrote:

> hi Xun, Justin
>
> Thanks for the suggestion!
> I have created https://issues.apache.org/jira/browse/YUNIKORN-789 to
> address this.
>
> On Sun, Aug 8, 2021 at 10:48 PM Justin Mclean 
> wrote:
>
> > Hi,
> >
> > > I have a question.
> > > I did not see the two files `NOTICE` and `DISCLAIMER` in the
> > > [1],[2],[3],[4] repo of incubator-yunikorn.
> >
> > It would be good if they are there, but what matters is if they end up in
> > the release artefacts.
> >
> > Thanks,
> > Justin
> > -
> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > For additional commands, e-mail: general-h...@incubator.apache.org
> >
> >
>

Re: [VOTE] Release Apache YuniKorn (Incubating) 0.11.0 (RC2)

[Weiwei Yang]

hi Xun, Justin

Thanks for the suggestion!
I have created https://issues.apache.org/jira/browse/YUNIKORN-789 to
address this.

On Sun, Aug 8, 2021 at 10:48 PM Justin Mclean 
wrote:

> Hi,
>
> > I have a question.
> > I did not see the two files `NOTICE` and `DISCLAIMER` in the
> > [1],[2],[3],[4] repo of incubator-yunikorn.
>
> It would be good if they are there, but what matters is if they end up in
> the release artefacts.
>
> Thanks,
> Justin
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>

Re: [VOTE] Release Apache YuniKorn (Incubating) 0.11.0 (RC2)

[Justin Mclean]

Hi,

> I have a question.
> I did not see the two files `NOTICE` and `DISCLAIMER` in the
> [1],[2],[3],[4] repo of incubator-yunikorn.

It would be good if they are there, but what matters is if they end up in the 
release artefacts.

Thanks,
Justin
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache YuniKorn (Incubating) 0.11.0 (RC2)

[Xun Liu]

+0 (non-binding) from me, I have checked the following items:

- Incubating in name
- LICENSE are fine
- All links are valid
- No unexpected binary files
- All ASF files have ASF headers
- Built docker images from the source

I have a question.
I did not see the two files `NOTICE` and `DISCLAIMER` in the
[1],[2],[3],[4] repo of incubator-yunikorn.
If it is my misunderstanding, please ignore it. :-)

[1] https://github.com/apache/incubator-yunikorn-k8shim
[2] https://github.com/apache/incubator-yunikorn-scheduler-interface
[3] https://github.com/apache/incubator-yunikorn-core
[4] https://github.com/apache/incubator-yunikorn-web

Best regards
Xun Liu

On Mon, Aug 9, 2021 at 12:19 PM Justin Mclean 
wrote:

> HI,
>
> +1 (binding)
>
> I checked:
> - incubating in name
> - signatures and hashes are good
> - LICENSE and NOTICE file
> - no unexpected binary files
> - all source files have ASF headers
> - can compile from source
>
> Kind Regards,
> Justin
>
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>

Re: [VOTE] Release Apache YuniKorn (Incubating) 0.11.0 (RC2)

[Justin Mclean]

HI,

+1 (binding)

I checked:
- incubating in name
- signatures and hashes are good
- LICENSE and NOTICE file
- no unexpected binary files
- all source files have ASF headers
- can compile from source

Kind Regards,
Justin

-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache YuniKorn (Incubating) 0.11.0 (RC2)

[Felix Cheung]

+1
I checked that issues from RC1 are fixed


On Fri, Aug 6, 2021 at 6:43 AM Julia Kinga Marton
 wrote:

> Hello IPMC
>
> The Apache YuniKorn community has voted and approved the release of Apache
> YuniKorn (incubating) 0.11.0 (RC2). We now kindly request the IPMC members
> review
> and vote for this release.
>
> YuniKorn is a standalone, universal resource scheduler that can support
> both long-running and batch workloads. The current release provides some
> gang-scheduling improvements, REST API extensions,UI usability
> enhancements, license improvements etc.
>
> YuniKorn community vote thread:
>
> https://lists.apache.org/thread.html/r97f089bc29e28a991fc3c882fc47014ca3ef77536d8c976f1f4a3573%40%3Cdev.yunikorn.apache.org%3E
>
> Vote result thread:
>
> https://lists.apache.org/thread.html/r2d45645f738608b37449f2e3be72c3ffa9c9405c4d65f36013d72305%40%3Cdev.yunikorn.apache.org%3E
>
> Issues included in this release:
> https://issues.apache.org/jira/projects/YUNIKORN/versions/12350025
>
> The release candidate:
> https://dist.apache.org/repos/dist/dev/incubator/yunikorn/0.11/
>
> This release has been signed with a PGP available
> here:https://dist.apache.org/repos/dist/dev/incubator/yunikorn/KEYS
>
> Git tag for the release:
>   - https://github.com/apache/incubator-yunikorn-core/tree/v0.11.0
>   - https://github.com/apache/incubator-yunikorn-k8shim/tree/v0.11.0
>   -
>
> https://github.com/apache/incubator-yunikorn-scheduler-interface/tree/v0.11.0
>   - https://github.com/apache/incubator-yunikorn-web/tree/v0.11.0
>
> The vote will be open for at least 72 hours or until the necessary number
> of votes is reached.
>
> Please vote accordingly:
> [ ] +1 Approve the release of Apache YuniKorn (Incubating) 0.11.0
> [ ] +0
> [ ] -1 Do not approve (please specify the reason)
>
> Thanks,
> Kinga Marton
> Apache YuniKorn (Incubating)
>

Re: [VOTE] Release Apache YuniKorn (Incubating) 0.11.0

[Justin Mclean]

Hi,

> the ./web component is in the release but I don't see its dependencies
> (even as MIT licensed) listed?

Dependancies don’t need to be mentioned in the LICENSE file if they don’t end 
up in the source release.

Kind Regards,
Justin
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache YuniKorn (Incubating) 0.11.0

[Felix Cheung]

Similar questions from me

- incubating in name
- signature and hash fine
- DISCLAIMER is fine
- No unexpected binary files

- LICENSE and NOTICE
the ./web component is in the release but I don't see its dependencies
(even as MIT licensed) listed?
Is anything bundled in there?


- these source files do not have ASF headers
./k8shim/test/e2e/predicates/predicates_suite_test.go
./k8shim/test/e2e/predicates/predicates_test.go
./core/pkg/scheduler/mock_plugin_test.go

the project has the normal disclaimer, so I'd think issues with LICENSE and
ASF header applies.
https://incubator.apache.org/guides/releasemanagement.html#choice_of_disclaimers


On Fri, Jul 30, 2021 at 2:31 AM Wilfred Spiegelenburg
 wrote:

> We are not using any of the polyfills except for the one that is mandatory
> (zone.js) which is part of the angular framework.
> The angular framework is not part of the source tar. The zone.js file is
> also not part of the source tar.
>
> The polyfills.ts file just defines that it will be imported when you build
> the app.
> After cleanup the polyfills.ts file would be a license header and 1 import
> statement.
>
> Is that acceptable?
>
> Wilfred
>
> > On 30 Jul 2021, at 18:55, Justin Mclean 
> wrote:
> >
> > Hi,
> >
> >> The base settings are code generated. The software that generates these
> base setting is angular. It shows up as a MIT license [1].
> >> The file content after the generation is part of the created project
> which then gets customised.
> >
> >
> > You might want to double check that. A quick glance that this page [1]
> mentions polyfills that are either public domain, MIT or Apache licensed.
> Obviously all of these licenses are compatible but it would be good to know
> which it is.
> >
> > Kind Regards,
> > Justin
> >
> > 1. https://angular.io/guide/browser-support
> > -
> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > For additional commands, e-mail: general-h...@incubator.apache.org
> >
>
> Wilfred Spiegelenburg
> Staff Software Engineer
>  
>

Re: [VOTE] Release Apache YuniKorn (Incubating) 0.11.0

[Wilfred Spiegelenburg]

We are not using any of the polyfills except for the one that is mandatory 
(zone.js) which is part of the angular framework.
The angular framework is not part of the source tar. The zone.js file is also 
not part of the source tar.

The polyfills.ts file just defines that it will be imported when you build the 
app.
After cleanup the polyfills.ts file would be a license header and 1 import 
statement.

Is that acceptable?

Wilfred

> On 30 Jul 2021, at 18:55, Justin Mclean  wrote:
> 
> Hi,
> 
>> The base settings are code generated. The software that generates these base 
>> setting is angular. It shows up as a MIT license [1].
>> The file content after the generation is part of the created project which 
>> then gets customised.
> 
> 
> You might want to double check that. A quick glance that this page [1] 
> mentions polyfills that are either public domain, MIT or Apache licensed. 
> Obviously all of these licenses are compatible but it would be good to know 
> which it is.
> 
> Kind Regards,
> Justin
> 
> 1. https://angular.io/guide/browser-support
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
> 

Wilfred Spiegelenburg
Staff Software Engineer
 

Re: [VOTE] Release Apache YuniKorn (Incubating) 0.11.0

[Justin Mclean]

Hi,

> The base settings are code generated. The software that generates these base 
> setting is angular. It shows up as a MIT license [1].
> The file content after the generation is part of the created project which 
> then gets customised.


You might want to double check that. A quick glance that this page [1] mentions 
polyfills that are either public domain, MIT or Apache licensed. Obviously all 
of these licenses are compatible but it would be good to know which it is.

Kind Regards,
Justin

1. https://angular.io/guide/browser-support
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache YuniKorn (Incubating) 0.11.0

[Wilfred Spiegelenburg]

> On 30 Jul 2021, at 18:22, Justin Mclean  wrote:
> 
> Hi,
> 
>> [3] is a settings file. The comments should have been cleaned up when the 
>> settings were customised.
> 
> Presumably the file (and it comments) are copyright to someone and under some 
> license? Do you know who/what that is?
> 

The base settings are code generated. The software that generates these base 
setting is angular. It shows up as a MIT license [1].
The file content after the generation is part of the created project which then 
gets customised.

Wilfred

[1] https://angular.io/license


-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache YuniKorn (Incubating) 0.11.0

[Justin Mclean]

Hi,

> [3] is a settings file. The comments should have been cleaned up when the 
> settings were customised.

Presumably the file (and it comments) are copyright to someone and under some 
license? Do you know who/what that is?

Thanks,
Justin

Re: [VOTE] Release Apache YuniKorn (Incubating) 0.11.0

[Wilfred Spiegelenburg]

[1] was added as part of jira YUNIKORN-505.
[2] was added as part of jira YUNIKORN-427.

Both are apache files: jiras have been logged to add the headers.

[3] is a settings file. The comments should have been cleaned up when the 
settings were customised.

I have filed a jira for the cleanup. The file was already in YuniKorn v0.10

Wilfred 

> On 30 Jul 2021, at 15:46, Justin Mclean  wrote:
> 
> Hi,
> 
> -1 (binding) as there files missing headers and a possible license issue. If 
> the licenses of these files are clarified my vote can change.
> 
> I checked:
> - incubating in name
> - signatures and hashes are fine
> - DISCLAIMER exists
> - LICENSE may be OK, except this file? [3]
> -  NOTICE is fine
> - No unexpected binary files
> - A couple of files are missing ASF headers
> 
> A couple of files are missing ASF headers, where did they come from and how 
> are these licensed? [1][2]
> 
> Is this file actually an ASF file or is it a 3rd party file? [3] If it a 3rd 
> party file how is it licensed?
> 
> Kind Regards,
> Justin
> 
> 1.  /core/pkg/scheduler/mock_plugin_test.go
> 2.  /k8shim/test/e2e/predicates/predicates_test.go
> 3. /web/src/polyfills.ts
> 
> 
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
> 

Wilfred Spiegelenburg
Staff Software Engineer
 

Re: [VOTE] Release Apache YuniKorn (Incubating) 0.11.0

[Justin Mclean]

Hi,

-1 (binding) as there files missing headers and a possible license issue. If 
the licenses of these files are clarified my vote can change.

I checked:
- incubating in name
- signatures and hashes are fine
- DISCLAIMER exists
- LICENSE may be OK, except this file? [3]
-  NOTICE is fine
- No unexpected binary files
- A couple of files are missing ASF headers

A couple of files are missing ASF headers, where did they come from and how are 
these licensed? [1][2]

Is this file actually an ASF file or is it a 3rd party file? [3] If it a 3rd 
party file how is it licensed?

Kind Regards,
Justin

1.  /core/pkg/scheduler/mock_plugin_test.go
2.  /k8shim/test/e2e/predicates/predicates_test.go
3. /web/src/polyfills.ts


-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache YuniKorn (Incubating) 0.11.0

[Chao Zhang]

+1 (non-binding) from me, I checked the following items:

1. LICENSE and NOTICE files exist
2. All links abovementioned are valid
3. Signature and checksum are good
4. Successfully built the image on my Fedora32.

Best regards
Chao Zhang

https://github.com/tokers

On Thu, Jul 29, 2021 at 4:04 PM Julia Kinga Marton  wrote:
>
> Hello IPMC
>
> The Apache YuniKorn community has voted and approved the release Apache
> YuniKorn (incubating) 0.11.0. We now kindly request the IPMC members review
> and vote for this release.
>
> YuniKorn is a standalone, universal resource scheduler that can support
> both long-running and batch workloads. The current release provides some
> gang-scheduling improvements, REST API extensions,UI usability enhancements 
> etc.
>
> YuniKorn community vote
> thread:https://lists.apache.org/thread.html/r0037975be6fa14069f83a724aa3f8e4d3e9654e374228768ba22aceb%40%3Cdev.yunikorn.apache.org%3E
>
> Vote result 
> thread:https://lists.apache.org/thread.html/r568f7d7ae4520faec90443b2c7d6b54e05ab7faf2042a30a2858e23d%40%3Cdev.yunikorn.apache.org%3E
>
> Issues included in this
> release:https://issues.apache.org/jira/projects/YUNIKORN/versions/12350025
>
> The release 
> candidate:https://dist.apache.org/repos/dist/dev/incubator/yunikorn/0.11/
>
> This release has been signed with a PGP available
> here:https://dist.apache.org/repos/dist/dev/incubator/yunikorn/KEYS
>
> Git tag for the release:
>   - https://github.com/apache/incubator-yunikorn-core/tree/v0.11.0
>   - https://github.com/apache/incubator-yunikorn-k8shim/tree/v0.11.0
>   
> -https://github.com/apache/incubator-yunikorn-scheduler-interface/tree/v0.11.0
>   - https://github.com/apache/incubator-yunikorn-web/tree/v0.11.0
>
> The vote will be open for at least 72 hours or until the necessary number
> of votes is reached.
>
> Please vote accordingly:
> [ ] +1 Approve the release of Apache YuniKorn (Incubating) 0.11.0
> [ ] +0
> [ ] -1 Do not approve (please specify the reason)
>
> Thanks,
> Kinga Marton
> Apache YuniKorn (Incubating)

-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache YuniKorn (Incubating) 0.11.0

[Xun Liu]

+1 (non-binding) from me, I have checked the following items:

- Incubating in name
- LICENSE and NOTICE is fine
- All links are valid
- No unexpected binary files
- All ASF files have ASF headers
- Build from scratch
- Built images from the source
- Ran all unit tests

Best regards
Xun Liu

On Thu, Jul 29, 2021 at 4:03 PM Julia Kinga Marton 
wrote:

> Hello IPMC
>
> The Apache YuniKorn community has voted and approved the release Apache
> YuniKorn (incubating) 0.11.0. We now kindly request the IPMC members review
> and vote for this release.
>
> YuniKorn is a standalone, universal resource scheduler that can support
> both long-running and batch workloads. The current release provides some
> gang-scheduling improvements, REST API extensions,UI usability
> enhancements etc.
>
> YuniKorn community vote
> thread:
> https://lists.apache.org/thread.html/r0037975be6fa14069f83a724aa3f8e4d3e9654e374228768ba22aceb%40%3Cdev.yunikorn.apache.org%3E
>
> Vote result thread:
> https://lists.apache.org/thread.html/r568f7d7ae4520faec90443b2c7d6b54e05ab7faf2042a30a2858e23d%40%3Cdev.yunikorn.apache.org%3E
>
> Issues included in this
> release:https://issues.apache.org/jira/projects/YUNIKORN/versions/12350025
>
> The release candidate:
> https://dist.apache.org/repos/dist/dev/incubator/yunikorn/0.11/
>
> This release has been signed with a PGP available
> here:https://dist.apache.org/repos/dist/dev/incubator/yunikorn/KEYS
>
> Git tag for the release:
>   - https://github.com/apache/incubator-yunikorn-core/tree/v0.11.0
>   - https://github.com/apache/incubator-yunikorn-k8shim/tree/v0.11.0
>   -
> https://github.com/apache/incubator-yunikorn-scheduler-interface/tree/v0.11.0
>   - https://github.com/apache/incubator-yunikorn-web/tree/v0.11.0
>
> The vote will be open for at least 72 hours or until the necessary number
> of votes is reached.
>
> Please vote accordingly:
> [ ] +1 Approve the release of Apache YuniKorn (Incubating) 0.11.0
> [ ] +0
> [ ] -1 Do not approve (please specify the reason)
>
> Thanks,
> Kinga Marton
> Apache YuniKorn (Incubating)
>