[kudu-CR] WIP: Add basic support for unix sockets

2020-04-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15691 Change subject: WIP: Add basic support for unix sockets .. WIP: Add basic support for unix sockets so far can't seem to reproduce any

[kudu-CR] net: make Sockaddr more generic for other address families

2020-04-08 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15690 to look at the new patch set (#2). Change subject: net: make Sockaddr more generic for other address families

[kudu-CR] net: make Sockaddr more generic for other address families

2020-04-08 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15690 to review the following change. Change subject: net: make Sockaddr more generic for other address families

[kudu-CR] tserver: add locking around an RPC's usage of a Scanner

2020-04-08 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15677 to look at the new patch set (#2). Change subject: tserver: add locking around an RPC's usage of a Scanner

[kudu-CR] columnar serialization: avoid preallocating 8MB per column

2020-04-07 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15679 to look at the new patch set (#2). Change subject: columnar_serialization: avoid preallocating 8MB per column

[kudu-CR] columnar serialization: fix optimized GCC build

2020-04-07 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15680 to look at the new patch set (#2). Change subject: columnar_serialization: fix optimized GCC build

[kudu-CR] columnar serialization: fix build on older gccs

2020-04-07 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15680 to review the following change. Change subject: columnar_serialization: fix build on older gccs ..

[kudu-CR] columnar serialization: avoid preallocating 8MB per column

2020-04-07 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15679 to review the following change. Change subject: columnar_serialization: avoid preallocating 8MB per column

[kudu-CR] Avoid calling Schema::find column() once per RowBlock in columnar serialization

2020-04-07 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15678 to review the following change. Change subject: Avoid calling Schema::find_column() once per RowBlock in columnar serialization

[kudu-CR] cfile: clean up encoding-test to use fewer templates

2020-04-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15044 ) Change subject: cfile: clean up encoding-test to use fewer templates .. Patch Set 3: (2 comments)

[kudu-CR] tserver: add locking around an RPC's usage of a Scanner

2020-04-07 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15677 to review the following change. Change subject: tserver: add locking around an RPC's usage of a Scanner .. tserver:

[kudu-CR] wire protocol: change columnar serialization of varlen data to match Arrow

2020-04-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15660 ) Change subject: wire_protocol: change columnar serialization of varlen data to match Arrow .. wire_protocol: change columnar

[kudu-CR] wire protocol: change columnar serialization of varlen data to match Arrow

2020-04-07 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Andrew Wong, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15660 to look at the new patch set (#4). Change subject: wire_protocol: change columnar serialization of varlen data to match Arrow

[kudu-CR] wire protocol: change columnar serialization of varlen data to match Arrow

2020-04-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15660 ) Change subject: wire_protocol: change columnar serialization of varlen data to match Arrow .. Patch Set 3: (4 comments)

[kudu-CR] wire protocol: change columnar serialization of varlen data to match Arrow

2020-04-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15660 ) Change subject: wire_protocol: change columnar serialization of varlen data to match Arrow .. Patch Set 3: (1 comment)

[kudu-CR] wire protocol: change columnar serialization of varlen data to match Arrow

2020-04-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15660 ) Change subject: wire_protocol: change columnar serialization of varlen data to match Arrow .. Patch Set 3: (7 comments)

[kudu-CR] util: remove duplicate results from DNS resolution

2020-04-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15665 ) Change subject: util: remove duplicate results from DNS resolution .. util: remove duplicate results from DNS resolution On

[kudu-CR] util: remove duplicate results from DNS resolution

2020-04-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15665 ) Change subject: util: remove duplicate results from DNS resolution .. Patch Set 1: (1 comment)

[kudu-CR] util: remove duplicate results from DNS resolution

2020-04-06 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15665 to review the following change. Change subject: util: remove duplicate results from DNS resolution .. util: remove

[kudu-CR] WIP: support for passing arrow data to python

2020-04-06 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15661 to look at the new patch set (#2). Change subject: WIP: support for passing arrow data to python

[kudu-CR] WIP: support for passing arrow data to python

2020-04-06 Thread Todd Lipcon (Code Review)
Hello Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15661 to review the following change. Change subject: WIP: support for passing arrow data to python .. WIP: support for

[kudu-CR] wire protocol: change columnar serialization of varlen data to match Arrow

2020-04-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15660 ) Change subject: wire_protocol: change columnar serialization of varlen data to match Arrow .. Patch Set 2: (2 comments)

[kudu-CR] wire protocol: change columnar serialization of varlen data to match Arrow

2020-04-06 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15660 to look at the new patch set (#3). Change subject: wire_protocol: change columnar serialization of varlen data to match Arrow

[kudu-CR] wire protocol: change columnar serialization of varlen data to match Arrow

2020-04-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15660 ) Change subject: wire_protocol: change columnar serialization of varlen data to match Arrow .. Patch Set 2: (6 comments)

[kudu-CR] wire protocol: change columnar serialization of varlen data to match Arrow

2020-04-06 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15660 to look at the new patch set (#2). Change subject: wire_protocol: change columnar serialization of varlen data to match Arrow

[kudu-CR] wire protocol: change columnar serialization of varlen data to match Arrow

2020-04-06 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15660 to review the following change. Change subject: wire_protocol: change columnar serialization of varlen data to match Arrow

[kudu-CR] columnar serialization: use AVX2 for int32 and int64 copying

2020-04-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15634 ) Change subject: columnar_serialization: use AVX2 for int32 and int64 copying .. columnar_serialization: use AVX2 for int32 and

[kudu-CR] columnar serialization: use AVX2 for int32 and int64 copying

2020-04-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/15634 ) Change subject: columnar_serialization: use AVX2 for int32 and int64 copying .. Removed reviewer Kudu Jenkins with the following

[kudu-CR] rowblock: use BMI instruction set when available for GetSelectedRows

2020-04-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15635 ) Change subject: rowblock: use BMI instruction set when available for GetSelectedRows .. rowblock: use BMI instruction set when

[kudu-CR] columnar serialization: use AVX2 for int32 and int64 copying

2020-04-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15634 ) Change subject: columnar_serialization: use AVX2 for int32 and int64 copying .. Patch Set 3: Verified+1 the release build failed

[kudu-CR] columnar serialization: use AVX2 for int32 and int64 copying

2020-04-04 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Andrew Wong, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15634 to look at the new patch set (#3). Change subject: columnar_serialization: use AVX2 for int32 and int64 copying

[kudu-CR] columnar serialization: use AVX2 for int32 and int64 copying

2020-04-02 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Andrew Wong, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15634 to look at the new patch set (#2). Change subject: columnar_serialization: use AVX2 for int32 and int64 copying

[kudu-CR] rowblock: use BMI instruction set when available for GetSelectedRows

2020-04-02 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Andrew Wong, Kudu Jenkins, Andrew Wong, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15635 to look at the new patch set (#2). Change subject: rowblock: use BMI instruction set when available for

[kudu-CR] rowblock: use BMI instruction set when available for GetSelectedRows

2020-04-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15635 ) Change subject: rowblock: use BMI instruction set when available for GetSelectedRows .. Patch Set 1: (4 comments)

[kudu-CR] columnar serialization: use AVX2 for int32 and int64 copying

2020-04-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15634 ) Change subject: columnar_serialization: use AVX2 for int32 and int64 copying .. Patch Set 1: (13 comments)

[kudu-CR] rowblock: use BMI instruction set when available for GetSelectedRows

2020-04-01 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15635 to review the following change. Change subject: rowblock: use BMI instruction set when available for GetSelectedRows

[kudu-CR] columnar serialization: use AVX2 for int32 and int64 copying

2020-04-01 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15634 to review the following change. Change subject: columnar_serialization: use AVX2 for int32 and int64 copying

[kudu-CR] client: add support for columnar format scan

2020-04-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15622 ) Change subject: client: add support for columnar format scan .. client: add support for columnar format scan Change-Id:

[kudu-CR] client: add support for columnar format scan

2020-04-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15622 ) Change subject: client: add support for columnar format scan .. Patch Set 3: (1 comment)

[kudu-CR] client: add support for columnar format scan

2020-04-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15622 ) Change subject: client: add support for columnar format scan .. Patch Set 2: (12 comments)

[kudu-CR] client: add support for columnar format scan

2020-04-01 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15622 to look at the new patch set (#3). Change subject: client: add support for columnar format scan

[kudu-CR] client: add support for columnar format scan

2020-03-31 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15622 to look at the new patch set (#2). Change subject: client: add support for columnar format scan

[kudu-CR] tserver: add support for returning scan result in columnar layout

2020-03-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15602 ) Change subject: tserver: add support for returning scan result in columnar layout .. tserver: add support for returning scan

[kudu-CR] client: add support for columnar format scan

2020-03-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15622 ) Change subject: client: add support for columnar format scan .. Patch Set 1: (1 comment)

[kudu-CR] tserver: add support for returning scan result in columnar layout

2020-03-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15602 ) Change subject: tserver: add support for returning scan result in columnar layout .. Patch Set 4: Verified+1 Test failure was

[kudu-CR] tserver: add support for returning scan result in columnar layout

2020-03-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: tserver: add support for returning scan result in columnar layout .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit

[kudu-CR] client: add support for columnar format scan

2020-03-31 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15622 to review the following change. Change subject: client: add support for columnar format scan .. client:

[kudu-CR] tserver: add support for returning scan result in columnar layout

2020-03-31 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15602 to look at the new patch set (#4). Change subject: tserver: add support for returning scan result in columnar layout

[kudu-CR] tserver: add support for returning scan result in columnar layout

2020-03-31 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15602 to look at the new patch set (#3). Change subject: tserver: add support for returning scan result in columnar layout

[kudu-CR] tserver: add support for returning scan result in columnar layout

2020-03-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15602 ) Change subject: tserver: add support for returning scan result in columnar layout .. Patch Set 3: (11 comments)

[kudu-CR] Add functionality to serialize a RowBlock into columnar format

2020-03-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15560 ) Change subject: Add functionality to serialize a RowBlock into columnar format .. Add functionality to serialize a RowBlock into

[kudu-CR] tserver: add support for returning scan result in columnar layout

2020-03-30 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15602 to look at the new patch set (#2). Change subject: tserver: add support for returning scan result in columnar layout

[kudu-CR] tserver: add support for returning scan result in columnar layout

2020-03-30 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15602 to review the following change. Change subject: tserver: add support for returning scan result in columnar layout ..

[kudu-CR] Add functionality to serialize a RowBlock into columnar format

2020-03-30 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15560 to look at the new patch set (#7). Change subject: Add functionality to serialize a RowBlock into columnar format

[kudu-CR] Add functionality to serialize a RowBlock into columnar format

2020-03-30 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15560 to look at the new patch set (#6). Change subject: Add functionality to serialize a RowBlock into columnar format

[kudu-CR] Add functionality to serialize a RowBlock into columnar format

2020-03-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15560 ) Change subject: Add functionality to serialize a RowBlock into columnar format .. Patch Set 5: (10 comments)

[kudu-CR] Add functionality to serialize a RowBlock into columnar format

2020-03-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15560 ) Change subject: Add functionality to serialize a RowBlock into columnar format .. Patch Set 5: (7 comments)

[kudu-CR] Add functionality to serialize a RowBlock into columnar format

2020-03-26 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15560 to look at the new patch set (#5). Change subject: Add functionality to serialize a RowBlock into columnar format

[kudu-CR] rowblock: improve GetSelectedRows API

2020-03-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15559 ) Change subject: rowblock: improve GetSelectedRows API .. rowblock: improve GetSelectedRows API The earlier commit used a

[kudu-CR] rowblock: improve GetSelectedRows API

2020-03-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15559 ) Change subject: rowblock: improve GetSelectedRows API .. Patch Set 3: (1 comment)

[kudu-CR] Add core algorithms for columnar serialization

2020-03-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15556 ) Change subject: Add core algorithms for columnar serialization .. Add core algorithms for columnar serialization This adds the

[kudu-CR] Add functionality to serialize a RowBlock into columnar format

2020-03-26 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15560 to look at the new patch set (#4). Change subject: Add functionality to serialize a RowBlock into columnar format

[kudu-CR] Add core algorithms for columnar serialization

2020-03-26 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Alexey Serbin, Andrew Wong, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15556 to look at the new patch set (#5). Change subject: Add core algorithms for columnar serialization

[kudu-CR] Add functionality to serialize a RowBlock into columnar format

2020-03-26 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15560 to look at the new patch set (#3). Change subject: Add functionality to serialize a RowBlock into columnar format

[kudu-CR] Add functionality to serialize a RowBlock into columnar format

2020-03-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15560 ) Change subject: Add functionality to serialize a RowBlock into columnar format .. Patch Set 2: (3 comments)

[kudu-CR] Add core algorithms for columnar serialization

2020-03-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15556 ) Change subject: Add core algorithms for columnar serialization .. Patch Set 4: (7 comments)

[kudu-CR] Add core algorithms for columnar serialization

2020-03-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15556 ) Change subject: Add core algorithms for columnar serialization .. Patch Set 4: (5 comments)

[kudu-CR] Add core algorithms for columnar serialization

2020-03-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15556 ) Change subject: Add core algorithms for columnar serialization .. Patch Set 3: (3 comments)

[kudu-CR] Add core algorithms for columnar serialization

2020-03-25 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15556 to look at the new patch set (#4). Change subject: Add core algorithms for columnar serialization

[kudu-CR] rowblock: improve GetSelectedRows API

2020-03-25 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15559 to review the following change. Change subject: rowblock: improve GetSelectedRows API .. rowblock:

[kudu-CR] Add functionality to serialize a RowBlock into columnar format

2020-03-25 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15560 to review the following change. Change subject: Add functionality to serialize a RowBlock into columnar format

[kudu-CR] Add core algorithms for columnar serialization

2020-03-25 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15556 to look at the new patch set (#3). Change subject: Add core algorithms for columnar serialization

[kudu-CR] Fix loop unroll pragma for GCC < 8

2020-03-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15558 ) Change subject: Fix loop unroll pragma for GCC < 8 .. Patch Set 1: Verified+1 java test failure -- To view, visit

[kudu-CR] Fix loop unroll pragma for GCC < 8

2020-03-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: Fix loop unroll pragma for GCC < 8 .. Removed -Verified by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15558 To unsubscribe, visit

[kudu-CR] Fix loop unroll pragma for GCC < 8

2020-03-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: Fix loop unroll pragma for GCC < 8 .. Removed -Verified by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15558 To unsubscribe, visit

[kudu-CR] Fix loop unroll pragma for GCC < 8

2020-03-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: Fix loop unroll pragma for GCC < 8 .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15558 To unsubscribe, visit

[kudu-CR] Add core algorithms for columnar serialization

2020-03-25 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15556 to look at the new patch set (#2). Change subject: Add core algorithms for columnar serialization

[kudu-CR] Fix loop unroll pragma for GCC < 8

2020-03-25 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15558 to review the following change. Change subject: Fix loop unroll pragma for GCC < 8 .. Fix loop unroll pragma for GCC

[kudu-CR] wire protocol: some simplification and optimization for rowwise encoding

2020-03-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15550 ) Change subject: wire_protocol: some simplification and optimization for rowwise encoding .. wire_protocol: some simplification

[kudu-CR] wire protocol: some simplification and optimization for rowwise encoding

2020-03-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: wire_protocol: some simplification and optimization for rowwise encoding .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit

[kudu-CR] wire protocol: some simplification and optimization for rowwise encoding

2020-03-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: wire_protocol: some simplification and optimization for rowwise encoding .. Removed -Verified by Kudu Jenkins (120) -- To view, visit

[kudu-CR] wire protocol: some simplification and optimization for rowwise encoding

2020-03-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15550 ) Change subject: wire_protocol: some simplification and optimization for rowwise encoding .. Patch Set 3: Verified+1 k, skipping IWYU

[kudu-CR] wire protocol: some simplification and optimization for rowwise encoding

2020-03-25 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15550 to look at the new patch set (#3). Change subject: wire_protocol: some simplification and optimization for rowwise encoding

[kudu-CR] Add core algorithms for columnar serialization

2020-03-25 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15556 to review the following change. Change subject: Add core algorithms for columnar serialization .. Add

[kudu-CR] wire protocol: some simplification and optimization for rowwise encoding

2020-03-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15550 ) Change subject: wire_protocol: some simplification and optimization for rowwise encoding .. Patch Set 2: (2 comments)

[kudu-CR] wire protocol: some simplification and optimization for rowwise encoding

2020-03-24 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15550 to look at the new patch set (#2). Change subject: wire_protocol: some simplification and optimization for rowwise encoding

[kudu-CR] Fix some gcc warnings

2020-03-24 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15553 to review the following change. Change subject: Fix some gcc warnings .. Fix some gcc warnings This addresses an

[kudu-CR] Use popcnt instruction for Bits::Count

2020-03-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15549 ) Change subject: Use popcnt instruction for Bits::Count .. Use popcnt instruction for Bits::Count I found Bits::Count to be a

[kudu-CR] rpc: relax limit on number of sidecars

2020-03-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15547 ) Change subject: rpc: relax limit on number of sidecars .. rpc: relax limit on number of sidecars Following the example of

[kudu-CR] wire protocol: some simplification and optimization for rowwise encoding

2020-03-24 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15550 to review the following change. Change subject: wire_protocol: some simplification and optimization for rowwise encoding

[kudu-CR] Use popcnt instruction for Bits::Count

2020-03-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15549 ) Change subject: Use popcnt instruction for Bits::Count .. Patch Set 2: (1 comment)

[kudu-CR] Use popcnt instruction for Bits::Count

2020-03-24 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, Kudu Jenkins, Andrew Wong, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15549 to look at the new patch set (#2). Change subject: Use popcnt instruction for Bits::Count

[kudu-CR] Use popcnt instruction for Bits::Count

2020-03-24 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15549 to review the following change. Change subject: Use popcnt instruction for Bits::Count .. Use popcnt instruction for

[kudu-CR] rpc: relax limit on number of sidecars

2020-03-24 Thread Todd Lipcon (Code Review)
Hello Thomas Tauber-Marshall, Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15547 to look at the new patch set (#2). Change subject: rpc: relax limit on number of sidecars

[kudu-CR] Replace 'null bitmap' variable names with 'non null bitmap'

2020-03-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15548 ) Change subject: Replace 'null_bitmap' variable names with 'non_null_bitmap' .. Replace 'null_bitmap' variable names with

[kudu-CR] Replace 'null bitmap' variable names with 'non null bitmap'

2020-03-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15548 ) Change subject: Replace 'null_bitmap' variable names with 'non_null_bitmap' .. Patch Set 1: Verified+1 I'm gonna override IWYU for now

[kudu-CR] Replace 'null bitmap' variable names with 'non null bitmap'

2020-03-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: Replace 'null_bitmap' variable names with 'non_null_bitmap' .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15548 To

[kudu-CR] Replace 'null bitmap' variable names with 'non null bitmap'

2020-03-24 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15548 to review the following change. Change subject: Replace 'null_bitmap' variable names with 'non_null_bitmap' ..

[kudu-CR] rpc: relax limit on number of sidecars

2020-03-24 Thread Todd Lipcon (Code Review)
Hello Thomas Tauber-Marshall, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15547 to review the following change. Change subject: rpc: relax limit on number of sidecars ..

[kudu-CR] iwyu: standardize on libc++

2020-03-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15492 ) Change subject: iwyu: standardize on libc++ .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/15492/7//COMMIT_MSG Commit

<    1   2   3   4   5   6   7   8   9   10   >