Re: SIGSEGV while Parse::optimize_inlining an invokedynamic call.

2011-09-22 Thread Christian Thalinger
On Sep 20, 2011, at 11:05 PM, Sebastian Sickelmann wrote: Am 20.09.2011 13:19, schrieb Christian Thalinger: On Sep 19, 2011, at 11:09 AM, Christian Thalinger wrote: [Moving hotspot-runtime-dev to Bcc] On Sep 17, 2011, at 9:05 PM, Sebastian Sickelmann wrote: Hi, while doing further

Re: Finally a test case for the ClassNotFound

2011-09-22 Thread Christian Thalinger
I finally filed a CR for this error: 7093796: JSR 292: Rtalk test case fails with: NoClassDefFoundError: ri/core/rtalk/RtObject -- Christian On Aug 27, 2011, at 12:25 AM, Mark Roos wrote: Thanks Rémi I tried to put just the offending class on the boot path but that was not enough.

Re: possible fix for 7056328

2011-09-22 Thread Christian Thalinger
And I filed a CR for this bug too: 7093795: JSR 292: Seph bench/bench_arithmetic.sp fails with: NoClassDefFoundError: seph/lang/SephObject -- Christian On Jul 4, 2011, at 7:23 PM, Christian Thalinger wrote: On Jun 25, 2011, at 4:16 PM, Ola Bini wrote: Please try out the patch. I've also

Request for approval for CR 7085860

2011-09-22 Thread Christian Thalinger
CR:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7085860 Webrev:http://cr.openjdk.java.net/~twisti/7085860/ Review: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2011-September/006287.html Changeset:

Re: Request for review (L): 7087838: JSR 292: add throttling logic for optimistic call site optimizations

2011-09-21 Thread Christian Thalinger
On Sep 21, 2011, at 8:21 AM, Mark Roos wrote: From Remi Moreover, are you sure the code that contains these callsites is JITed, No, but then how would I know and what would I do if I did know. If its JITed and I do the 10th ( or whatever) invalidate in three months because of

Re: review request (S): 7077803: java.lang.InternalError in java.lang.invoke.MethodHandleNatives.init

2011-09-20 Thread Christian Thalinger
Looks good. -- Christian On Sep 20, 2011, at 12:09 AM, John Rose wrote: 7077803: java.lang.InternalError in java.lang.invoke.MethodHandleNatives.init http://cr.openjdk.java.net/~jrose/7077803/webrev.00 Remove access checking and access narrowing logic from MethodHandles.unreflectX calls,

Re: review request (L): 7030453: JSR 292 ClassValue.get method is too slow

2011-09-20 Thread Christian Thalinger
On Sep 19, 2011, at 11:58 PM, John Rose wrote: http://cr.openjdk.java.net/~jrose/7030453/webrev.00 src/share/classes/java/lang/ClassValue.java: 233 /** Value stream for for hashCodeForCache. See similar structure in ThreadLocal. */ Two for's. 578 * from the ehad of a non-null

Re: SIGSEGV while Parse::optimize_inlining an invokedynamic call.

2011-09-20 Thread Christian Thalinger
and the Dissabled TestNew2.txt should bei in the temp dir after running build.xml. ( Christian Thalingerchristian.thalin...@oracle.com schrieb: On Sep 19, 2011, at 11:09 AM, Christian Thalinger wrote: [Moving hotspot-runtime-dev to Bcc] On Sep 17, 2011, at 9:05 PM, Sebastian Sickelmann wrote: Hi

Re: SIGSEGV while Parse::optimize_inlining an invokedynamic call.

2011-09-20 Thread Christian Thalinger
On Sep 19, 2011, at 11:09 AM, Christian Thalinger wrote: [Moving hotspot-runtime-dev to Bcc] On Sep 17, 2011, at 9:05 PM, Sebastian Sickelmann wrote: Hi, while doing further investigations on my idea [0] i observed a reproducable crash of the vm. It seems to me that it happens while

Re: review request (L): 7030453: JSR 292 ClassValue.get method is too slow

2011-09-20 Thread Christian Thalinger
On Sep 19, 2011, at 11:58 PM, John Rose wrote: http://cr.openjdk.java.net/~jrose/7030453/webrev.00 src/share/classes/java/lang/ClassValue.java: 233 /** Value stream for for hashCodeForCache. See similar structure in ThreadLocal. */ Two for's. 578 * from the ehad of a non-null

Re: Request for review (L): 7087838: JSR 292: add throttling logic for optimistic call site optimizations

2011-09-19 Thread Christian Thalinger
On Sep 18, 2011, at 7:16 PM, Mark Roos wrote: In looking at my code. In general 98% of the callsites are 3 targets. Those that are larger I can catch and use a different lookup. I also believe that Charles Nutter limits his depth to 5. So the general case I see will not exceed

Re: SIGSEGV while Parse::optimize_inlining an invokedynamic call.

2011-09-19 Thread Christian Thalinger
[Moving hotspot-runtime-dev to Bcc] On Sep 17, 2011, at 9:05 PM, Sebastian Sickelmann wrote: Hi, while doing further investigations on my idea [0] i observed a reproducable crash of the vm. It seems to me that it happens while the hotspot tries to inline (i think) a invokedynamic call.

Re: SIGSEGV while Parse::optimize_inlining an invokedynamic call.

2011-09-19 Thread Christian Thalinger
On Sep 19, 2011, at 11:09 AM, Christian Thalinger wrote: [Moving hotspot-runtime-dev to Bcc] On Sep 17, 2011, at 9:05 PM, Sebastian Sickelmann wrote: Hi, while doing further investigations on my idea [0] i observed a reproducable crash of the vm. It seems to me that it happens while

Re: Hotspot loves PHP.reboot

2011-09-07 Thread Christian Thalinger
On Sep 7, 2011, at 11:15 AM, Rémi Forax wrote: On 09/07/2011 09:08 AM, John Rose wrote: On Sep 7, 2011, at 12:00 AM, Per Bothner wrote: I assume this is one reason why Kawa's IntNum is (mostly) faster than BigInteger. Yes, that's probably true. Here's a dirty secret: As you can

Re: Hotspot loves PHP.reboot

2011-09-06 Thread Christian Thalinger
On Sep 6, 2011, at 5:51 PM, Charles Oliver Nutter wrote: On Tue, Sep 6, 2011 at 10:39 AM, Rémi Forax fo...@univ-mlv.fr wrote: Yes, but don't forget that PHP.reboot has no overflow check. Did we ever figure out if it's possible to trick Hotspot into doing a JO instead of the raw bit-level

Re: Hotspot loves PHP.reboot

2011-09-05 Thread Christian Thalinger
On Sep 5, 2011, at 1:11 AM, Rémi Forax wrote: I've just compiled the hotspot (64bits server) using the hotspot-comp workspace of hotspot express (hsx) http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/ Here are the result when running PHP.reboot on fibonacci (-server is the server VM

RtalkTest examination

2011-08-31 Thread Christian Thalinger
Tom was looking into a bug with his bimorphic inlining patch and said something about massive inlining with RtalkTest so I thought I also give it a shot. One thing I can say for sure: massive inlining and huge methods! We get a lot like: @ 115 java.lang.invoke.MethodHandle::asSpreader (13

Re: Building trunk hotspot-comp

2011-08-29 Thread Christian Thalinger
No. That script just builds HotSpot as is in the hotspot-comp repository (no patches applied). -- Christian On Aug 28, 2011, at 12:44 AM, Mark Roos wrote: Charles Does this script get all of the latest mlvm patches or is there another step to pull those? What about the conditional

Re: Finally a test case for the ClassNotFound

2011-08-26 Thread Christian Thalinger
I can confirm the NCDFE. This could be a duplicate of: 7055941: JSR 292 method handle invocation causes excessive deoptimization for types not on boot class path The workaround is to put the runtime on the boot class path. I also can confirm that the second run of Hanoi is slower with JDK 7.

Re: JRuby invokedynamic updates

2011-08-24 Thread Christian Thalinger
On Aug 16, 2011, at 12:19 AM, Charles Oliver Nutter wrote: On Mon, Aug 15, 2011 at 1:01 PM, Tom Rodriguez tom.rodrig...@oracle.com wrote: On Aug 12, 2011, at 4:15 PM, Charles Oliver Nutter wrote: Well, let me play devil's advocate here: why not just discount MH chains completely? It

Re: Problem with 08/08 BSD port from Stephen, MLVM changes recently?

2011-08-24 Thread Christian Thalinger
On Aug 24, 2011, at 3:15 AM, Mark Roos wrote: In looking for my classDefNotFound bug I tried the latest build I could find for bsd port. The 0609 version worked at least past this point but the 0808 version gave a fatal error # fatal error: memory leak: allocating without

Re: FAILED: java/lang/invoke/ThrowExceptionsTest.java ... fatal error

2011-08-24 Thread Christian Thalinger
On Aug 24, 2011, at 6:07 AM, Stephen Bannasch wrote: After I build mlvm I run the running jdk/test/java/lang/invoke tests as well as jdk/test/java/dyn/CoroutineTest.java I'm getting fatal errors in Java running: java/lang/invoke/ThrowExceptionsTest.java jtreg jtr and hs_err_pid log

Re: Problem with 08/08 BSD port from Stephen, MLVM changes recently?

2011-08-24 Thread Christian Thalinger
On Aug 24, 2011, at 8:44 PM, Tom Rodriguez wrote: I made one: import java.lang.invoke.*; import static java.lang.invoke.MethodHandles.*; import static java.lang.invoke.MethodType.*; public class RM implements Runnable { public static void main(String... args) throws Throwable {

Re: Building trunk hotspot-comp

2011-08-22 Thread Christian Thalinger
That's pretty much it. If you have more that two cores increase the number for HOTSPOT_BUILD_JOBS (it's like make -j [jobs]). -- Christian On Aug 19, 2011, at 9:12 PM, Charles Oliver Nutter wrote: I've posted a gist with a script and instructions for setting up a trunk build environment for

Re: Mac Build java-1.7.0-internal-mlvm-2011_08_08 crash

2011-08-17 Thread Christian Thalinger
On Aug 17, 2011, at 2:01 PM, Jim Laskey wrote: # A fatal error has been detected by the Java Runtime Environment: # # Internal Error (/Users/stephen/dev/java/src/mlvm/sources/hotspot/src/share/vm/runtime/frame.cpp:1158), pid=1021, tid=4410376192 # Error: ShouldNotReachHere() Do you

Re: Request for review (L): 7071653: JSR 292: call site change notification should be pushed not pulled

2011-08-16 Thread Christian Thalinger
the first time as the bytecodes are quickened right after that. And in the case where a putfield isn't quickened and we call resolve_get_put it gets very expensive anyway. On 8/8/11 6:56 AM, Christian Thalinger wrote: Why on sparc you use ld_ptr() to load from cache but on X86 and X64 you use

Re: JRuby + invokedynamic on IKVM.NET

2011-08-16 Thread Christian Thalinger
On Aug 16, 2011, at 4:12 PM, Jeroen Frijters wrote: Hi Rémi, Do you have changed the argument of fib, the result is different from one post by Charles ? I didn't change anything and I get the same result with JDK 7, so something else must have changed. We usually use 5 35 as arguments

Re: Performance problem with invoke dynamic

2011-08-12 Thread Christian Thalinger
On Aug 10, 2011, at 9:10 PM, Christian Thalinger wrote: On Jul 28, 2011, at 7:29 PM, Ola Bini wrote: On 2011-07-28 10.11, Christian Thalinger wrote: On Jul 28, 2011, at 6:10 PM, Ola Bini wrote: The bad performance sounds like something is not inlined at all. How are you invoking

Re: JRuby/Seph/PHP.reboot/... SwitchPoint usage

2011-08-10 Thread Christian Thalinger
On Aug 8, 2011, at 8:21 PM, Christian Thalinger wrote: On Aug 8, 2011, at 6:39 PM, Charles Oliver Nutter wrote: On Mon, Aug 8, 2011 at 9:51 AM, Christian Thalinger christian.thalin...@oracle.com wrote: Since I have the basic push-notification of CallSites I'm now looking into push

Re: Performance problem with invoke dynamic

2011-08-10 Thread Christian Thalinger
On Jul 28, 2011, at 7:29 PM, Ola Bini wrote: On 2011-07-28 10.11, Christian Thalinger wrote: On Jul 28, 2011, at 6:10 PM, Ola Bini wrote: The bad performance sounds like something is not inlined at all. How are you invoking valueMH? Via invokedynamic or a direct MH call? valueMH

Re: Push invalidation + bimorphic fix

2011-08-09 Thread Christian Thalinger
On Aug 9, 2011, at 7:58 AM, Charles Oliver Nutter wrote: I have set up a local build against hsx hotspot compiler dev branch, thanks to Christian. I'll try to write something up with the process tomorrow. Anyway, I wanted to test out Tom's patch for GWT bimorphic inlining and Christian's

Re: Request for review (L): 7071653: JSR 292: call site change notification should be pushed not pulled

2011-08-09 Thread Christian Thalinger
, at 6:32 AM, Christian Thalinger wrote: http://cr.openjdk.java.net/~twisti/7071653 7071653: JSR 292: call site change notification should be pushed not pulled Reviewed-by: Currently every speculatively inlined method handle call site has a guard that compares the current target

JRuby/Seph/PHP.reboot/... SwitchPoint usage

2011-08-08 Thread Christian Thalinger
Since I have the basic push-notification of CallSites I'm now looking into push-notification of SwitchPoints: 7071709: JSR 292: switchpoint invalidation should be pushed not pulled Basically it should be the same, just needs some additional love in the compiler. I looked into JRuby's usage of

Re: Request for review (L): 7071653: JSR 292: call site change notification should be pushed not pulled

2011-08-08 Thread Christian Thalinger
, Christian Thalinger wrote: http://cr.openjdk.java.net/~twisti/7071653 7071653: JSR 292: call site change notification should be pushed not pulled Reviewed-by: Currently every speculatively inlined method handle call site has a guard that compares the current target of the CallSite object

Re: JRuby/Seph/PHP.reboot/... SwitchPoint usage

2011-08-08 Thread Christian Thalinger
On Aug 8, 2011, at 4:01 PM, Rémi Forax wrote: On 08/08/2011 03:51 PM, Christian Thalinger wrote: Since I have the basic push-notification of CallSites I'm now looking into push-notification of SwitchPoints: 7071709: JSR 292: switchpoint invalidation should be pushed not pulled

Request for review (L): 7071653: JSR 292: call site change notification should be pushed not pulled

2011-08-05 Thread Christian Thalinger
http://cr.openjdk.java.net/~twisti/7071653 7071653: JSR 292: call site change notification should be pushed not pulled Reviewed-by: Currently every speculatively inlined method handle call site has a guard that compares the current target of the CallSite object to the inlined one. This

Re: Performance problem with invoke dynamic

2011-07-28 Thread Christian Thalinger
On Jul 28, 2011, at 2:20 AM, Ola Bini wrote: Hi, I've hit a very annoying performance problem with invoke dynamic/method handles that makes certain benchmarks about 3 times slower for identical operations. This code is related to to variable lookup and the basic idea is that I have a

Re: Crash, unknown details, may or may not be invokedynamic-related

2011-07-11 Thread Christian Thalinger
On Jul 10, 2011, at 8:42 AM, Charles Oliver Nutter wrote: I'm attaching an error log for a crash that's reproducible for me with a recent openjdk-osx-build. It may or may not be useful depending on how far behind other fixes they are. I thought it would be interesting for MLVM list because

Re: MethodHandle lookupinvocation performance

2011-07-11 Thread Christian Thalinger
On Jul 9, 2011, at 3:27 PM, Hiroshi Nakamura wrote: Hello, Thanks for you comments. On Sat, Jul 9, 2011 at 19:01, Jochen Theodorou blackd...@gmx.org wrote: Code is here: https://raw.github.com/nahi/jsr292-sandbox/master/src/jp/gr/java_conf/jruby/MethodHandleTest.java lookup I don't

Re: Inlining heuristic trouble

2011-07-11 Thread Christian Thalinger
On Jun 21, 2011, at 3:28 AM, John Rose wrote: On Jun 20, 2011, at 12:17 PM, Tom Rodriguez wrote: On Jun 18, 2011, at 5:15 AM, Rémi Forax wrote: On 06/18/2011 03:15 AM, Tom Rodriguez wrote: On Jun 17, 2011, at 5:00 PM, John Rose wrote: On Jun 17, 2011, at 10:21 AM, Tom Rodriguez wrote:

Re: where are our performance bottlenecks?

2011-07-07 Thread Christian Thalinger
On Jul 6, 2011, at 10:49 PM, Tom Rodriguez wrote: On Jul 6, 2011, at 4:18 AM, Christian Thalinger wrote: On Jul 5, 2011, at 6:39 PM, Charles Oliver Nutter wrote: I'm not in position at this exact moment to report perf issues, but Rémi's list would be a good start. I'll return to JRuby

Re: where are our performance bottlenecks?

2011-07-07 Thread Christian Thalinger
On Jul 7, 2011, at 8:52 AM, Christian Thalinger wrote: On Jul 6, 2011, at 10:49 PM, Tom Rodriguez wrote: On Jul 6, 2011, at 4:18 AM, Christian Thalinger wrote: On Jul 5, 2011, at 6:39 PM, Charles Oliver Nutter wrote: I'm not in position at this exact moment to report perf issues

Re: Errors on OSX version with loading

2011-07-05 Thread Christian Thalinger
On Jul 5, 2011, at 4:16 AM, Mark Roos wrote: Ok here is is, a test case for our port of Smalltalk to the JVM using 292. Let me know if you can run it as this is our first outside attempt. Its a simple test, towers of Hanoi done in a recursive manner. This version only uses 20 disks

Re: Errors on OSX version with loading

2011-07-04 Thread Christian Thalinger
On Jul 1, 2011, at 6:01 AM, John Rose wrote: Do you have a website or blog you can post it on? Is it available somewhere yet? -- Christian On Jun 30, 2011, at 8:47 PM, Mark Roos wrote: John requested Yes, please. We especially love stress tests. Oscar is putting it together. Where

Re: possible fix for 7056328

2011-07-04 Thread Christian Thalinger
On Jun 25, 2011, at 4:16 PM, Ola Bini wrote: Please try out the patch. I've also updated the mlvm patches to the latest bsd-port which (quite awesomely) is b146. It runs fine for me. Hmm, this is odd. I'm just trying b147 and I still get the same problem when putting seph.jar on the

Re: PHP.reboot update?

2011-06-21 Thread Christian Thalinger
On Jun 21, 2011, at 11:35 AM, Rémi Forax wrote: Ok, fixed, convertArguments doesn't exist anymore and I forget to remove it from the backport. Awesome, thanks. This one looks weird though: $ bin/phpr.sh test/testdeadreturn.phpr null com.googlecode.phpreboot.runtime.RT$RTError: null at 7,18

Re: PHP.reboot update?

2011-06-21 Thread Christian Thalinger
On Jun 21, 2011, at 11:35 AM, Rémi Forax wrote: Ok, fixed, convertArguments doesn't exist anymore and I forget to remove it from the backport. I currently trying to push some PHP code into your web server :-) Is it possible to recognize .php files too (not only .phpr files)? -- Christian

Re: PHP.reboot update?

2011-06-21 Thread Christian Thalinger
On Jun 21, 2011, at 12:20 PM, Christian Thalinger wrote: On Jun 21, 2011, at 11:35 AM, Rémi Forax wrote: Ok, fixed, convertArguments doesn't exist anymore and I forget to remove it from the backport. I currently trying to push some PHP code into your web server :-) Is it possible

Re: PHP.reboot update?

2011-06-21 Thread Christian Thalinger
On Jun 21, 2011, at 1:02 PM, Rémi Forax wrote: On 06/21/2011 12:29 PM, Christian Thalinger wrote: On Jun 21, 2011, at 12:20 PM, Christian Thalinger wrote: On Jun 21, 2011, at 11:35 AM, Rémi Forax wrote: Ok, fixed, convertArguments doesn't exist anymore and I forget to remove it from

Re: Inlining heuristic trouble

2011-06-17 Thread Christian Thalinger
On Jun 15, 2011, at 5:26 PM, Rémi Forax wrote: // with the optimization [forax@localhost binary-operation]$ time java -cp .:classes PerfOpt real0m0.954s user0m1.030s sys0m0.087s // without [forax@localhost binary-operation]$ time java -cp .:classes Perf real0m0.378s user

Re: Inlining heuristic trouble

2011-06-15 Thread Christian Thalinger
On Jun 15, 2011, at 5:26 PM, Rémi Forax wrote: I've just finished to code a sample for the cookbook that does integer operation (+ and -) with overflow (to BigInteger). https://code.google.com/p/jsr292-cookbook/source/browse/#svn%2Ftrunk%2Fbinary-operation%2Fsrc%2Fjsr292%2Fcookbook%2Fbinop

Re: Inlining heuristic trouble

2011-06-15 Thread Christian Thalinger
On Jun 15, 2011, at 5:48 PM, Christian Thalinger wrote: On Jun 15, 2011, at 5:26 PM, Rémi Forax wrote: I've just finished to code a sample for the cookbook that does integer operation (+ and -) with overflow (to BigInteger). https://code.google.com/p/jsr292-cookbook/source/browse/#svn

Re: Indy crash

2011-06-15 Thread Christian Thalinger
version 1.7.0-ea Java(TM) SE Runtime Environment (build 1.7.0-ea-b145) Java HotSpot(TM) 64-Bit Server VM (build 21.0-b14-internal-201106142151.never.7052219, mixed mode) Transform time : 101 Can you confirm that? -- Christian On Wed, Jun 15, 2011 at 7:38 AM, Christian Thalinger christian.thalin

Re: Current Crash status

2011-06-10 Thread Christian Thalinger
On May 27, 2011, at 12:35 AM, Ola Bini wrote: On 2011-05-27 12.58, John Rose wrote: On May 27, 2011, at 12:24 AM, Ola Bini wrote: But then it crashes at the same place. Excellent! So this works in b144 but not in mlvm? Yes, that's correct. Is there any other crash you're still

Re: More performance explorations

2011-06-10 Thread Christian Thalinger
On Jun 4, 2011, at 5:19 AM, Ola Bini wrote: On 2011-06-04 01.47, John Rose wrote: On Jun 3, 2011, at 7:07 AM, Ola Bini wrote: Is there anything I can do to help out with finding this problem? I can't reproduce the VM crash yet. Like Christian, I got through problems 1 and 2, on bsd (both

Re: More performance explorations

2011-06-10 Thread Christian Thalinger
On Jun 5, 2011, at 7:23 AM, Charles Oliver Nutter wrote: OH, and FWIW, here's the LogCompilation -i output roughly around where I'd expect to see op_plus and op_lt inlining: @ 27 java.lang.invoke.MethodHandle::invokeExact (0 bytes) @ 27 java.lang.invoke.MethodHandle::invokeExact (17

Re: More performance explorations

2011-06-10 Thread Christian Thalinger
On Jun 5, 2011, at 7:23 AM, Charles Oliver Nutter wrote: OH, and FWIW, here's the LogCompilation -i output roughly around where I'd expect to see op_plus and op_lt inlining: @ 27 java.lang.invoke.MethodHandle::invokeExact (0 bytes) @ 27 java.lang.invoke.MethodHandle::invokeExact (17

Re: More performance explorations

2011-06-10 Thread Christian Thalinger
On Jun 10, 2011, at 3:37 PM, Charles Oliver Nutter wrote: On Fri, Jun 10, 2011 at 5:32 PM, Christian Thalinger christian.thalin...@oracle.com wrote: It inlines fine with the latest HotSpot and JDK7 b145. I think we're good :-) Sorry, the logic for this never actually landed on JRuby

Re: JRuby to Java invokedynamic dispatch

2011-06-09 Thread Christian Thalinger
On Jun 8, 2011, at 11:10 PM, Attila Szegedi wrote: Woo-hoo! I agree :-) On Jun 8, 2011, at 9:48 PM, Charles Oliver Nutter wrote: Hello friends! I have another update! I've just landed preliminary work to make JRuby directly bind Ruby to Java calls that were normally done via

Re: MethodHandles.constant not inlining?

2011-06-09 Thread Christian Thalinger
On Jun 7, 2011, at 10:44 PM, Charles Oliver Nutter wrote: That's pretty much it. The test I ran looks like this: def foo 1 end 100_000.times { foo } The body of the block passed to times jits (in Hotspot) and appears to inline the foo method just fine, but the body of the inlined

Re: Good news, bad news

2011-05-26 Thread Christian Thalinger
On May 26, 2011, at 10:42 AM, Christian Thalinger wrote: On May 26, 2011, at 9:15 AM, Charles Oliver Nutter wrote: On Thu, May 26, 2011 at 1:58 AM, Tom Rodriguez tom.rodrig...@oracle.com wrote: but test is some ugly goo because of boxing. It's relatively easy to get the optimizer to fold

Re: Good news, bad news

2011-05-26 Thread Christian Thalinger
On May 26, 2011, at 11:24 AM, Jochen Theodorou wrote: Am 26.05.2011 11:03, schrieb Christian Thalinger: [...] I looked at the inlining tree of fib and everything looks good and is inlined. There is one invokeExact which is: @ 43 java.lang.invoke.MethodHandle::invokeExact (42 bytes) too

Re: Good news, bad news

2011-05-25 Thread Christian Thalinger
On May 25, 2011, at 5:58 AM, Ola Bini wrote: Hi, There are at least three problems that are still there. They might be connected, or not. (I will tell you how to reproduce these at the end) I just built a new JVM: openjdk version 1.7.0-internal OpenJDK Runtime Environment (build

Re: Good news, bad news

2011-05-25 Thread Christian Thalinger
someone provide a jar file of the current MLVM JSR 292 classes (like John's meth.jar)? -- Christian Cheers On 2011-05-25 14.29, Christian Thalinger wrote: On May 25, 2011, at 5:58 AM, Ola Bini wrote: Hi, There are at least three problems that are still there. They might be connected

Re: Good news, bad news

2011-05-23 Thread Christian Thalinger
On May 21, 2011, at 1:31 AM, Charles Oliver Nutter wrote: I am still using the specialized math callsites because they inline well and an Indy-based approach was still quite a bit slower last time I tried. I am back to being worried about the inlining thresholds. With no MHs and runtime

Re: Good news, bad news

2011-05-23 Thread Christian Thalinger
On May 23, 2011, at 8:45 PM, Charles Oliver Nutter wrote: On Mon, May 23, 2011 at 11:05 AM, Christian Thalinger christian.thalin...@oracle.com wrote: I was on vacation for a couple of days but now I'm back. I looked at the inlining tree for fib_recursive and I can't see the fib_ruby method

Re: invokeinterface handle-walking unimplemented?

2011-05-16 Thread Christian Thalinger
On May 14, 2011, at 6:49 PM, Charles Oliver Nutter wrote: FYI, I assume I'm supposed to see this when I bind an interface method acquired from findVirtual to an indy call site: # # A fatal error has been detected by the Java Runtime Environment: # # Internal Error

Re: Unrecognized VM option '-UseRicochetFrames'

2011-05-12 Thread Christian Thalinger
On May 12, 2011, at 3:51 PM, Stephen Bannasch wrote: I'm getting some failures running the jtreg tests and wondered whether I needed to enable or disable Ricochet Frames in theJVM but that option is unrecognized. $ build/bsd-amd64/j2sdk-image/bin/java -XX:-UseRicochetFrame

Re: review request (XL): 6939861: JVM should handle more conversion operations

2011-05-12 Thread Christian Thalinger
On May 11, 2011, at 6:08 PM, John Rose wrote: http://cr.openjdk.java.net/~jrose/6939861/webrev.jdk.06/ src/share/classes/java/lang/invoke/AdapterMethodHandle.java: +if (false spreadArgCount SPREAD_LIMIT) +return false; +if (false slotCount +

hg: mlvm/mlvm/jdk: Test6998541 updated

2011-05-11 Thread christian . thalinger
Changeset: 961bae798841 Author:twisti Date: 2011-05-11 02:18 -0700 URL: http://hg.openjdk.java.net/mlvm/mlvm/jdk/rev/961bae798841 Test6998541 updated ! meth.patch ___ mlvm-dev mailing list mlvm-dev@openjdk.java.net

Re: Rhino+invokedynamic

2011-05-10 Thread Christian Thalinger
On May 10, 2011, at 3:25 AM, Douglas Campos (qmx) wrote: Hi folks Charles Nutter mentioned that some people were working/playing with making Rhino faster. Does anyone have pointers on what were done / has to be done? John knows more about this but there is his blog entry about JavaOne 2010:

Re: Crash running benchmarks game's binary trees bench

2011-05-09 Thread Christian Thalinger
On May 9, 2011, at 3:34 PM, Charles Oliver Nutter wrote: FYI, this produced a SIGSEGV: jruby --server bench/shootout/binarytrees.ruby-2.ruby 15 14 and lower worked ok. Crash is consistent. Running macosx build from 4/28...not sure what build of mainline it maps to... This one? stretch

Re: Crash running benchmarks game's binary trees bench

2011-05-09 Thread Christian Thalinger
On May 9, 2011, at 3:34 PM, Charles Oliver Nutter wrote: FYI, this produced a SIGSEGV: jruby --server bench/shootout/binarytrees.ruby-2.ruby 15 Is invokedynamic now used by default? -- Christian 14 and lower worked ok. Crash is consistent. Running macosx build from 4/28...not sure what

Re: Crash running benchmarks game's binary trees bench

2011-05-09 Thread Christian Thalinger
On May 9, 2011, at 4:27 PM, Christian Thalinger wrote: On May 9, 2011, at 3:34 PM, Charles Oliver Nutter wrote: FYI, this produced a SIGSEGV: jruby --server bench/shootout/binarytrees.ruby-2.ruby 15 14 and lower worked ok. Crash is consistent. Running macosx build from 4/28...not sure

Re: review request (L): 6939861: JVM should handle more conversion operations

2011-05-06 Thread Christian Thalinger
On May 5, 2011, at 1:16 PM, John Rose wrote: I have finished the last large chunk of JVM work for JDK 7 JSR 292, the implementation of so-called ricochet frames. Here it is for review: 6939861: JVM should handle more conversion operations

Re: review request (L): 6939861: JVM should handle more conversion operations

2011-05-06 Thread Christian Thalinger
On May 6, 2011, at 9:27 AM, John Rose wrote: All new header files have the wrong (Sun) copyright header. I'm backing off from introducing new header files. The only new file is methodHandles_x86.hpp. See what you think. The idea is to allow each port to control its own individual

Re: Unusually high polymorphic dispatch costs?

2011-05-05 Thread Christian Thalinger
On Apr 30, 2011, at 9:27 AM, Charles Oliver Nutter wrote: I have pushed a change to JRuby master that fails over to a simple inline cache after one failed GWT. This is not how I would want to do it long-term, but it does bring some benchmarks back in line with non-indy JRuby. Specifically,

Re: hg: mlvm/mlvm/hotspot: meth-conv: process exceptions through ricochets, improve argument spreading

2011-05-04 Thread Christian Thalinger
On May 4, 2011, at 3:08 PM, John Rose wrote: On May 4, 2011, at 5:50 AM, Christian Thalinger wrote: I don't know how you get over this: src/share/vm/prims/methodHandles.hpp:487: error: conflicting declaration ‘OopClosure* f’ src/share/vm/prims/methodHandles.hpp:487: error: ‘f’ has

Re: Assembly output from JRuby 'fib'

2011-05-03 Thread Christian Thalinger
On May 3, 2011, at 5:06 PM, Rémi Forax wrote: On 05/03/2011 03:59 PM, Christian Thalinger wrote: On May 2, 2011, at 9:55 PM, Charles Oliver Nutter wrote: On Thu, Apr 28, 2011 at 11:18 AM, Rémi Foraxfo...@univ-mlv.fr wrote: Do you specialize the overflow check depending on the callsite

Re: Initial Smalltalk execution time

2011-05-02 Thread Christian Thalinger
On May 1, 2011, at 7:39 AM, Mark Roos wrote: Now that the core works I thought I would take a quick look at the execution speed. For this I executed the same code in our current environment (OS/2 and a mid 90's Smalltalk) and again using our invokeDynamic based vm translation. The code

Re: Assembly output from JRuby 'fib'

2011-05-02 Thread Christian Thalinger
On Apr 29, 2011, at 3:44 PM, Rémi Forax wrote: On 04/29/2011 01:09 PM, Christian Thalinger wrote: On Apr 28, 2011, at 3:19 PM, Charles Oliver Nutter wrote: On Thu, Apr 28, 2011 at 5:16 AM, Christian Thalinger christian.thalin...@oracle.com wrote: I took a look at it. I used 64-bit x86 since

Re: Unusually high polymorphic dispatch costs?

2011-04-29 Thread Christian Thalinger
On Apr 28, 2011, at 9:58 PM, Charles Oliver Nutter wrote: I'm trying to figure out why polymorphic dispatch is incredibly slow in JRuby + indy. Take this benchmark, for example: class A; def foo; end; end class B; def foo; end; end a = A.new b = B.new 5.times { puts Benchmark.measure

Re: segmentation fault in the jvm

2011-04-26 Thread Christian Thalinger
[Bcc'ing jdk7-dev.] On Mar 23, 2011, at 4:10 PM, Stefanie Tellex wrote: Hi, Not sure if this is the right place to report this, The right list would be: hotspot-...@openjdk.java.net but I have a Java program that reliably seg faults the JVM when run under GDB. It doesn't seem to

Re: Review Request: Zero JSR 292 support

2011-04-26 Thread Christian Thalinger
On Apr 1, 2011, at 4:33 PM, Gary Benson wrote: Hi all, This webrev adds support for JSR 292 to Zero: http://cr.openjdk.java.net/~gbenson/zero-jsr292-01/ hotspot/src/cpu/zero/vm/cppInterpreter_zero.cpp: +// NB the x86 code for this (in methodHandles_x86.cpp, search for +//

Re: Review Request: Zero JSR 292 support

2011-04-26 Thread Christian Thalinger
On Apr 5, 2011, at 2:49 PM, Christian Thalinger wrote: Does this code pass the jtreg tests in jdk/test/java/lang/invoke/ ? It passed their previous incarnation in jdk/test/java/dyn, with this webrev applied to stop the tests disabling themselves: http://cr.openjdk.java.net/~gbenson/zero

Re: 292 Rocks, Core Smalltalk running thanks to all

2011-04-26 Thread Christian Thalinger
On Apr 12, 2011, at 2:56 PM, Ola Bini wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Since there are not many projects out there that already use JSR 292 (JRuby and phpreboot are the only real users that I know of, but maybe I missed something), the code path coverage is low and

Re: 292 Rocks, Core Smalltalk running thanks to all

2011-04-11 Thread Christian Thalinger
On Apr 11, 2011, at 3:00 PM, Mark Roos wrote: I know you are all working hard to bring 292 to a release so I thought I would take a moment to thank you all for your work and to tell you how much that work helped with our Smalltalk porting. We have about 500K lines of Smalltalk code

Re: Review Request: Zero JSR 292 support

2011-04-11 Thread Christian Thalinger
On Apr 11, 2011, at 3:16 PM, Gary Benson wrote: Christian Thalinger wrote: On Apr 5, 2011, at 3:46 PM, Gary Benson wrote: Christian Thalinger wrote: On Apr 4, 2011, at 10:34 AM, Gary Benson wrote: John Rose wrote: On Apr 1, 2011, at 7:33 AM, Gary Benson wrote: This webrev adds support

Re: Review Request: Zero JSR 292 support

2011-04-05 Thread Christian Thalinger
On Apr 5, 2011, at 4:32 PM, Gary Benson wrote: Christian Thalinger wrote: On Apr 5, 2011, at 4:04 PM, Gary Benson wrote: Christian Thalinger wrote: hotspot/src/share/vm/interpreter/bytecodeInterpreter.cpp: + assert(false, Should have thrown incompatible class change exception

Re: hg: jdk7/hotspot-comp/hotspot: 6817525: turn on method handle functionality by default for JSR 292

2011-04-04 Thread Christian Thalinger
On Apr 1, 2011, at 7:21 PM, Arthur Peters wrote: Hello there, I've been lurking for a while and watching all the work going on. Especially now that things are starting to stabilize I'd be really interested to play with it. What are the best versions for a casual watcher to play with? I'm

Re: Possible bug: JVM crash due to GC when using indy

2011-03-29 Thread Christian Thalinger
On Mar 28, 2011, at 10:20 PM, shanka@gmail.com wrote: The complete log is pasted here: http://pylonshq.com/pasties/b8c342db8d9a342d058584a958d434a4 The point where it crashes: (at the function _qformat) is where the JVM should actually invoke via invokedynamic. I have tested this

Re: JRuby test/test_crazy_blocks fails

2011-03-29 Thread Christian Thalinger
- Charlie On Mon, Mar 28, 2011 at 4:30 AM, Christian Thalinger christian.thalin...@oracle.com wrote: On Mar 24, 2011, at 4:06 PM, Christian Thalinger wrote: I reran JRuby tests today and noticed a couple of problems. One I'd like an opinion on is test/test_crazy_blocks. It fails

Re: JRuby test/test_crazy_blocks fails

2011-03-28 Thread Christian Thalinger
On Mar 24, 2011, at 4:06 PM, Christian Thalinger wrote: I reran JRuby tests today and noticed a couple of problems. One I'd like an opinion on is test/test_crazy_blocks. It fails with invokedynamic and I'm not sure if either JRuby or the JDK has a bug. Charlie, do you have an idea

Re: Possible bug: JVM crash due to GC when using indy

2011-03-28 Thread Christian Thalinger
On Mar 28, 2011, at 7:15 PM, shanka@gmail.com wrote: The complete hs_err log file is pasted here: http://pylonshq.com/pasties/4ce99d93fbe70ee1347df7fc100934d2 What else should I try? -XX:+UseSerialGC. It seems my previous email didn't make it to the list. --

Re: review request (L): 7012648/JDK: move JSR 292 to package java.lang.invoke and adjust names

2011-03-24 Thread Christian Thalinger
On Mar 24, 2011, at 6:30 AM, John Rose wrote: Thanks for the review, Christian. Here's a little bit more... Here's an updated webrev: http://cr.openjdk.java.net/~jrose/7012648/webrev.jdk.01/ http://cr.openjdk.java.net/~jrose/7012648/webrev.jdk.01.nontriv/ The nontriv version is

JRuby test/test_crazy_blocks fails

2011-03-24 Thread Christian Thalinger
I reran JRuby tests today and noticed a couple of problems. One I'd like an opinion on is test/test_crazy_blocks. It fails with invokedynamic and I'm not sure if either JRuby or the JDK has a bug. Charlie, do you have an idea? -- Christian $ bin/jruby.sh -Xcompile.invokedynamic=false

Re: Possible bug

2011-03-18 Thread Christian Thalinger
, Christian Thalinger christian.thalin...@oracle.com wrote: On Mar 14, 2011, at 2:28 PM, Christian Thalinger wrote: On Mar 7, 2011, at 10:15 AM, Howard Lovatt wrote: Hi, I got the following when trying to use CallSites on Stephen Bannasch's latest build (which isn't the latest latest build

Re: Possible bug

2011-03-18 Thread Christian Thalinger
On Mar 18, 2011, at 11:01 AM, Howard Lovatt wrote: Yes, it is a file I am using to learn/experiment with lambdas. I don't have a lambda capable javac at hand so let's wait if this problem solves itself :-) -- Christian On 18 March 2011 20:31, Christian Thalinger christian.thalin

Re: Possible bug

2011-03-17 Thread Christian Thalinger
On Mar 14, 2011, at 2:28 PM, Christian Thalinger wrote: On Mar 7, 2011, at 10:15 AM, Howard Lovatt wrote: Hi, I got the following when trying to use CallSites on Stephen Bannasch's latest build (which isn't the latest latest build and therefore this issue might have been found already

Re: Possible bug

2011-03-14 Thread Christian Thalinger
On Mar 7, 2011, at 10:15 AM, Howard Lovatt wrote: Hi, I got the following when trying to use CallSites on Stephen Bannasch's latest build (which isn't the latest latest build and therefore this issue might have been found already): # To suppress the following error report, specify this

<    1   2   3   4   5   6   7   8   9   10   >