Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/21677#discussion_r200260115
--- Diff: sql/core/benchmarks/FilterPushdownBenchmark-results.txt ---
@@ -0,0 +1,556 @@
+[ Pushdown for many distinct value
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/21677#discussion_r200246934
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/FilterPushdownBenchmark.scala
---
@@ -427,16 +245,122 @@ object
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/21556#discussion_r200246162
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
---
@@ -82,6 +120,30 @@ private[parquet] class
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21677
@HyukjinKwon Can you merge this to master first? I would like to update the
[Benchmark
results](https://github.com/apache/spark/pull/21677/files#diff-c5c0bfc86983d5779269cf75da8ed645)
of several
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/21556#discussion_r200170975
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
---
@@ -82,6 +120,30 @@ private[parquet] class
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21696
Jenkins, retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/21696#discussion_r200011264
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
---
@@ -19,187 +19,200 @@ package
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/21696#discussion_r19002
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
---
@@ -19,166 +19,186 @@ package
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/21682#discussion_r12294
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
---
@@ -42,6 +42,10 @@ private[parquet] class
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/21682#discussion_r12316
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
---
@@ -93,6 +101,10 @@ private[parquet] class
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/21682#discussion_r11024
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
---
@@ -42,6 +42,14 @@ private[parquet] class
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/21682#discussion_r199986187
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
---
@@ -42,6 +42,14 @@ private[parquet] class
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/21696#discussion_r199672805
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
---
@@ -19,166 +19,186 @@ package
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21696
cc @gatorsmile @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/21556#discussion_r199442189
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
---
@@ -359,6 +369,70 @@ class
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/21696
[SPARK-24716][SQL] Refactor ParquetFilters
## What changes were proposed in this pull request?
Replace DataFrame schema to Parquet file schema when create
`ParquetFilters`.
more
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/21682
[SPARK-24706][SQL] ByteType and ShortType support pushdown to parquet
## What changes were proposed in this pull request?
`ByteType` and `ShortType` support pushdown to parquet data source
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21681
@zhangchj1990 Looks mistakenly open. Mind closing this please?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21603
Benchmark result:
```
##[ Pushdown benchmark for InSet -> InFilters
]##
Java HotSpot(TM) 64-Bit Server VM 1.8.0_151-b12 on Mac O
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21623
Benchmark result:
```
###[ Pushdown benchmark for StringStartsWith
]###
Java HotSpot(TM) 64-Bit Server VM 1.8.0_151-b12 on Mac OS X
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21677
cc @maropu
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21556
Benchmark results:
```
###[ Pushdown benchmark for Decimal
]
Java HotSpot(TM) 64-Bit Server VM 1.8.0_151-b12 on Mac OS X
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/21677
[SPARK-24692][TESTS] Improvement FilterPushdownBenchmark
## What changes were proposed in this pull request?
1. Write the result to `benchmarks/FilterPushdownBenchmark-results.txt
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/21623#discussion_r199116993
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
---
@@ -660,6 +688,62 @@ class
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21623
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/21623#discussion_r199043411
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
---
@@ -660,6 +661,56 @@ class
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/21623#discussion_r199043210
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
---
@@ -22,16 +22,23 @@ import java.sql.Date
Github user wangyum closed the pull request at:
https://github.com/apache/spark/pull/21547
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21547
Close it because I have implement it in
[SPARK-24549](https://issues.apache.org/jira/browse/SPARK-24549).
---
-
To unsubscribe
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21556
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/21603#discussion_r198146352
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
---
@@ -270,6 +270,11 @@ private[parquet] class
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21603
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/21603#discussion_r198124578
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
---
@@ -270,6 +270,11 @@ private[parquet] class
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/21641
[SPARK-24658][SQL] Remove workaround for ANTLR bug
## What changes were proposed in this pull request?
Issue antlr/antlr4#781 has already been fixed, so the workaround of
extracting
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/21623#discussion_r197992151
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
---
@@ -660,6 +660,30 @@ class
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21623
cc @gszadovszky @nandorKollar
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/21623
[SPARK-24638][SQL] StringStartsWith support push down
## What changes were proposed in this pull request?
`StringStartsWith` support push down. About 50% savings in compute time
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/21603#discussion_r197603396
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -378,6 +378,17 @@ object SQLConf {
.booleanConf
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/21603#discussion_r197338867
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
---
@@ -270,6 +270,11 @@ private[parquet] class
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21603
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/21603#discussion_r197011649
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
---
@@ -270,6 +270,11 @@ private[parquet] class
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/21603
[SPARK-17091][SQL] Add rule to convert IN predicate to equivalent Parquet
filter
## What changes were proposed in this pull request?
Add a new optimizer rule to convert an IN predicate
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21556
cc @gatorsmile @rdblue
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/18424
@ptkool Are you still working on?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21556
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21556
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21556
Another performance test:
https://user-images.githubusercontent.com/5399861/41448622-437d029a-708e-11e8-9c18-5d9f17cd1edf.png
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21547
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21547
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/21547#discussion_r195289284
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
---
@@ -37,6 +39,23 @@ private[parquet] class
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/21556#discussion_r195283330
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
---
@@ -62,6 +62,16 @@ private[parquet] class
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/21556
[SPARK-24549][SQL] 32BitDecimalType and 64BitDecimalType support push down
## What changes were proposed in this pull request?
[32BitDecimalType](https://github.com/apache/spark/blob
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21547
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/21547
[SPARK-24538][SQL] ByteArrayDecimalType support push down to the data
sources
## What changes were proposed in this pull request?
[ByteArrayDecimalType](https://github.com/apache/spark
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21479
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21479
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/21479
[SPARK-23903][SQL] Add support for date extract
## What changes were proposed in this pull request?
Add support for date `extract`, supported field same as
[Hive](https://github.com
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21010
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21010
> Basically LGTM, but I'm wondering what if the expr2 is not like a format
string?
The same as Hive:
```sql
spark-sql> SELECT format_number(12332.123456, 'abc');
ab
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/21460
[SPARK-23442][SQL] Improvement reading from partitioned and bucketed table.
## What changes were proposed in this pull request?
For a partitioned and bucketed table. With the increasing
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21010
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21010
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21431
Yes. I have tested with `âconf spark.io.compression.codec=zstd`.
---
-
To unsubscribe, e-mail: reviews-unsubscr
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/21431
[SPARK-19112][CORE][FOLLOW-UP] Add missing shortCompressionCodecNames to
configuration.
## What changes were proposed in this pull request?
Spark provides three codecs: `lz4`, `lzf
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/21423
[SPARK-24378][SQL] Fix date_trunc function incorrect examples
## What changes were proposed in this pull request?
Fix `date_trunc` function incorrect examples.
## How
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21404
Can we remove the old hive support? such as 0.12, 0.13 and 0.14.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/20274
@srowen I have updated.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user wangyum closed the pull request at:
https://github.com/apache/spark/pull/21375
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/21375
[HOT-FIX][SQL] Fix: SQLConf.scala:1757: not found: value Utils
## What changes were proposed in this pull request?
Fix: `SQLConf.scala:1757: not found: value Utils`
## How
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21343
This problem seems to have been fixed, can you try
[v2.3.1-rc1](https://github.com/apache/spark/releases/tag/v2.3.1-rc1
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/18853
**Spark vs Teradata**:
https://user-images.githubusercontent.com/5399861/40102134-43a138e2-591c-11e8-8bf1-00fb9b72e026.png;>
https://user-images.githubusercontent.com/5399861/40102
Github user wangyum closed the pull request at:
https://github.com/apache/spark/pull/21328
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/21328
Ci
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
## How was this patch tested?
(Please explain how this patch
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21010
retest please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/21189
[SPARK-24117][SQL] Unified the getSizePerRow
## What changes were proposed in this pull request?
This pr unified the `getSizePerRow` because `getSizePerRow` is used in many
places
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21170
cc @zsxwing
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/21170
[SPARK-22732][SS][FOLLOW-UP] Fix memoryV2.scala toString error
## What changes were proposed in this pull request?
Fix `memoryV2.scala` toString error
## How was this patch tested
Github user wangyum closed the pull request at:
https://github.com/apache/spark/pull/20659
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/21077
[SPARK-21033][CORE][FOLLOW-UP] Update Spillable
## What changes were proposed in this pull request?
Update
```scala
SparkEnv.get.conf.getLong
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/21010
[SPARK-23900][SQL] format_number support user specifed format as argument
## What changes were proposed in this pull request?
`format_number` support user specifed format as argument
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/20944
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/20944
cc @jerryshao
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/20944#discussion_r179158019
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
---
@@ -188,6 +188,9 @@ private[hive] class
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/18853
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/20944
[SPARK-23831][SQL] Add org.apache.derby to IsolatedClientLoader
## What changes were proposed in this pull request?
Add `org.apache.derby` to `IsolatedClientLoader`, otherwise it may throw
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/20785
Ping @vanzin
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user wangyum closed the pull request at:
https://github.com/apache/spark/pull/20898
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/20898
It looks like
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/20866#discussion_r176906868
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/HiveDelegationTokenProvider.scala
---
@@ -92,8 +93,8 @@ private[security] class
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/20866#discussion_r176906522
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/HiveDelegationTokenProvider.scala
---
@@ -92,8 +93,8 @@ private[security] class
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/20866#discussion_r176906474
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/HiveDelegationTokenProvider.scala
---
@@ -92,8 +94,9 @@ private[security] class
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/20898
Yes, it's proxy user:
```
export HADOOP_PROXY_USER=user
spark-sql --master yarn
```
---
-
To unsubscribe, e-mail
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/20898
cc @yaooqinn @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/20898
[SPARK-23789][SQL] Shouldn't set hive.metastore.uris before invoking
HiveDelegationTokenProvider
## What changes were proposed in this pull request?
`spark-sql` can't connect to metastore
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/20866#discussion_r176902474
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/HiveDelegationTokenProvider.scala
---
@@ -92,8 +93,8 @@ private[security] class
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/20867
Please update the title.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/20866#discussion_r175859248
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -908,11 +912,39 @@ private[hive] object HiveClientImpl
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/20866#discussion_r175858111
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -908,11 +912,39 @@ private[hive] object HiveClientImpl
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/20866
[SPARK-23749][SQL] Avoid Hive.get() to compatible with different Hive
metastore
## What changes were proposed in this pull request?
Avoid `Hive.get()` to compatible with different Hive
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/20659
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
501 - 600 of 992 matches
Mail list logo
