[spark] 01/01: change SparkR maintainer

2021-05-23 Thread felixcheung
This is an automated email from the ASF dual-hosted git repository. felixcheung pushed a commit to branch r-maintainer in repository https://gitbox.apache.org/repos/asf/spark.git commit 5dbe3bbc5d29e2ba6caca022c37eb0b5a2f13202 Author: Felix Cheung AuthorDate: Sun May 23 16:49:27 2021 -0700

[spark] branch r-maintainer created (now 5dbe3bb)

2021-05-23 Thread felixcheung
This is an automated email from the ASF dual-hosted git repository. felixcheung pushed a change to branch r-maintainer in repository https://gitbox.apache.org/repos/asf/spark.git. at 5dbe3bb change SparkR maintainer This branch includes the following new commits: new 5dbe3bb

[spark-website] branch asf-site updated: Add test-hadoop3.2 phrase (#203)

2019-05-12 Thread felixcheung
This is an automated email from the ASF dual-hosted git repository. felixcheung pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/spark-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 16052cb Add test-hadoop3.2

[zeppelin] branch master updated: [ZEPPELIN-4026] document anonymous access

2019-03-03 Thread felixcheung
This is an automated email from the ASF dual-hosted git repository. felixcheung pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/zeppelin.git The following commit(s) were added to refs/heads/master by this push: new 05fdfe5 [ZEPPELIN-4026] document

[zeppelin] branch master updated: [ZEPPELIN-4012] Save paragraphs after clone

2019-02-26 Thread felixcheung
This is an automated email from the ASF dual-hosted git repository. felixcheung pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/zeppelin.git The following commit(s) were added to refs/heads/master by this push: new dd624a6 [ZEPPELIN-4012] Save paragraphs

[zeppelin] branch master updated: [ZEPPELIN-4011] Fix note path

2019-02-26 Thread felixcheung
This is an automated email from the ASF dual-hosted git repository. felixcheung pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/zeppelin.git The following commit(s) were added to refs/heads/master by this push: new 6dcc2ab [ZEPPELIN-4011] Fix note path

[spark] branch branch-2.3 updated: [R][BACKPORT-2.4] update package description

2019-02-21 Thread felixcheung
This is an automated email from the ASF dual-hosted git repository. felixcheung pushed a commit to branch branch-2.3 in repository https://gitbox.apache.org/repos/asf/spark.git The following commit(s) were added to refs/heads/branch-2.3 by this push: new 6691c04 [R][BACKPORT-2.4] update

[spark] branch branch-2.4 updated: [R][BACKPORT-2.4] update package description

2019-02-21 Thread felixcheung
This is an automated email from the ASF dual-hosted git repository. felixcheung pushed a commit to branch branch-2.4 in repository https://gitbox.apache.org/repos/asf/spark.git The following commit(s) were added to refs/heads/branch-2.4 by this push: new d8576301 [R][BACKPORT-2.4] update

[spark-website] branch asf-site updated: Update Thomas Graves Information (#179)

2019-02-11 Thread felixcheung
This is an automated email from the ASF dual-hosted git repository. felixcheung pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/spark-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 6205847 Update Thomas Graves

[zeppelin] branch branch-0.7 updated: formatting fix for LDAP realm documentation

2019-02-09 Thread felixcheung
This is an automated email from the ASF dual-hosted git repository. felixcheung pushed a commit to branch branch-0.7 in repository https://gitbox.apache.org/repos/asf/zeppelin.git The following commit(s) were added to refs/heads/branch-0.7 by this push: new 7906a5c formatting fix for LDAP

[spark] branch master updated: [SPARK-26603][K8S] Update minikube backend

2019-02-03 Thread felixcheung
This is an automated email from the ASF dual-hosted git repository. felixcheung pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/spark.git The following commit(s) were added to refs/heads/master by this push: new 196ca0c [SPARK-26603][K8S] Update minikube

[spark] branch master updated: [SPARK-26642][K8S] Add --num-executors option to spark-submit for Spark on K8S.

2019-01-20 Thread felixcheung
This is an automated email from the ASF dual-hosted git repository. felixcheung pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/spark.git The following commit(s) were added to refs/heads/master by this push: new 6c18d8d [SPARK-26642][K8S] Add --num

[zeppelin] branch master updated: [ZEPPELIN-3944] Update Dockerfiles of spark_standalone and spark_yarn_cluster (#3282)

2019-01-16 Thread felixcheung
This is an automated email from the ASF dual-hosted git repository. felixcheung pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/zeppelin.git The following commit(s) were added to refs/heads/master by this push: new 966a392 [ZEPPELIN-3944] Update

[spark] branch branch-2.3 updated: [SPARK-26120][TESTS][SS][SPARKR] Fix a streaming query leak in Structured Streaming R tests

2019-01-12 Thread felixcheung
This is an automated email from the ASF dual-hosted git repository. felixcheung pushed a commit to branch branch-2.3 in repository https://gitbox.apache.org/repos/asf/spark.git The following commit(s) were added to refs/heads/branch-2.3 by this push: new 1979712 [SPARK-26120][TESTS][SS

[spark-website] branch asf-site updated: add checker note (#168)

2019-01-12 Thread felixcheung
This is an automated email from the ASF dual-hosted git repository. felixcheung pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/spark-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 70a6071 add checker note (#168

[zeppelin] branch master updated: [ZEPPELIN-3932] spark_mesos Dockerfile should be updated (#3279)

2019-01-04 Thread felixcheung
This is an automated email from the ASF dual-hosted git repository. felixcheung pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/zeppelin.git The following commit(s) were added to refs/heads/master by this push: new 7bf79d8 [ZEPPELIN-3932] spark_mesos

[zeppelin] branch master updated: [ZEPPELIN-3914] upgrade Flink to 1.7.1 (#3266)

2018-12-31 Thread felixcheung
This is an automated email from the ASF dual-hosted git repository. felixcheung pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/zeppelin.git The following commit(s) were added to refs/heads/master by this push: new 13fd50e [ZEPPELIN-3914] upgrade Flink

[zeppelin] branch master updated: docs: fix punctuation (#3197)

2018-12-30 Thread felixcheung
This is an automated email from the ASF dual-hosted git repository. felixcheung pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/zeppelin.git The following commit(s) were added to refs/heads/master by this push: new c20c830 docs: fix punctuation (#3197

[incubator-pinot-site] 01/01: updating trademark

2018-12-28 Thread felixcheung
This is an automated email from the ASF dual-hosted git repository. felixcheung pushed a commit to branch felixcheung-tm-1 in repository https://gitbox.apache.org/repos/asf/incubator-pinot-site.git commit d11cf4bcaf40f3613ce8231a1a76d9b9d8d5b9b5 Author: Felix Cheung AuthorDate: Fri Dec 28 14:34

[zeppelin] branch master updated: [ZEPPELIN-3864] Fix Travis tests

2018-12-25 Thread felixcheung
This is an automated email from the ASF dual-hosted git repository. felixcheung pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/zeppelin.git The following commit(s) were added to refs/heads/master by this push: new 6639025 [ZEPPELIN-3864] Fix Travis

[zeppelin] branch branch-0.8 updated: [ZEPPELIN-3553] Fix URLs on "Multi-user Support" page

2018-12-25 Thread felixcheung
This is an automated email from the ASF dual-hosted git repository. felixcheung pushed a commit to branch branch-0.8 in repository https://gitbox.apache.org/repos/asf/zeppelin.git The following commit(s) were added to refs/heads/branch-0.8 by this push: new 2c2deb1 [ZEPPELIN-3553] Fix

[zeppelin] branch master updated: Revert "[ZEPPELIN-3882] Neo4jInterpreter - Support Point and Date Types" (#3270)

2018-12-20 Thread felixcheung
This is an automated email from the ASF dual-hosted git repository. felixcheung pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/zeppelin.git The following commit(s) were added to refs/heads/master by this push: new 45fa3fd Revert "[ZEPPELIN

[zeppelin] branch revert-3244-update-neo4j-datatypes created (now 7ae0e41)

2018-12-20 Thread felixcheung
This is an automated email from the ASF dual-hosted git repository. felixcheung pushed a change to branch revert-3244-update-neo4j-datatypes in repository https://gitbox.apache.org/repos/asf/zeppelin.git. at 7ae0e41 Revert "Added support for Neo4j temporal and point types" T

[zeppelin] 01/03: Revert "fix checkstyle"

2018-12-20 Thread felixcheung
This is an automated email from the ASF dual-hosted git repository. felixcheung pushed a commit to branch revert-3244-update-neo4j-datatypes in repository https://gitbox.apache.org/repos/asf/zeppelin.git commit 4ddee8579401c4bbf59f714a9972538684f555e5 Author: Felix Cheung AuthorDate: Thu Dec 20

[zeppelin] 02/03: Revert "Added support for Neo4j temporal and point types"

2018-12-20 Thread felixcheung
This is an automated email from the ASF dual-hosted git repository. felixcheung pushed a commit to branch revert-3244-update-neo4j-datatypes in repository https://gitbox.apache.org/repos/asf/zeppelin.git commit 0193be5b312845f4ea4fed737a0441b001e1b403 Author: Felix Cheung AuthorDate: Thu Dec 20

[zeppelin] 03/03: Revert "Added support for Neo4j temporal and point types"

2018-12-20 Thread felixcheung
This is an automated email from the ASF dual-hosted git repository. felixcheung pushed a commit to branch revert-3244-update-neo4j-datatypes in repository https://gitbox.apache.org/repos/asf/zeppelin.git commit 7ae0e418a15540fffb2402391d122219e6819234 Author: Felix Cheung AuthorDate: Thu Dec 20

[zeppelin] 02/03: Added support for Neo4j temporal and point types

2018-12-19 Thread felixcheung
This is an automated email from the ASF dual-hosted git repository. felixcheung pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/zeppelin.git commit b98ccea98996eda183382a332379f3cfc428c0e9 Author: Andrea Santurbano AuthorDate: Mon Nov 26 23:48:06 2018 +0100

[zeppelin] branch master updated (a6f4562 -> 5542262)

2018-12-19 Thread felixcheung
This is an automated email from the ASF dual-hosted git repository. felixcheung pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/zeppelin.git. from a6f4562 [ZEPPELIN-3902]upgrade jetty version new 0fbcd11 Added support for Neo4j temporal and point

[zeppelin] 03/03: fix checkstyle

2018-12-19 Thread felixcheung
This is an automated email from the ASF dual-hosted git repository. felixcheung pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/zeppelin.git commit 5542262568b3532fd11e2832d3168b386f35b3d6 Author: Andrea Santurbano AuthorDate: Thu Nov 29 09:44:11 2018 +0100

[zeppelin] 01/03: Added support for Neo4j temporal and point types

2018-12-19 Thread felixcheung
This is an automated email from the ASF dual-hosted git repository. felixcheung pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/zeppelin.git commit 0fbcddae980ff245eead964e8a5e0ee0f1a6 Author: Andrea Santurbano AuthorDate: Mon Nov 26 23:48:06 2018 +0100

[GitHub] zeppelin issue #3258: fix beam-runners-flink and zeppelin-scio scala version...

2018-12-18 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3258 in that case, can we make it build beam only when it has support for it. ie. build scala 2.10 - beam 2.0.0 build scala 2.11 - beam not included (but not failing) ---

[GitHub] zeppelin issue #3244: [ZEPPELIN-3882] Neo4jInterpreter - Support Point and D...

2018-12-16 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3244 merging if no more comment ---

[GitHub] zeppelin issue #3244: [ZEPPELIN-3882] Neo4jInterpreter - Support Point and D...

2018-12-16 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3244 I see it's green. not sure why the report above is not. ---

[GitHub] zeppelin issue #3258: fix beam-runners-flink and zeppelin-scio scala version...

2018-12-15 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3258 > that's what i did in: ffca03c ah, that would make different versions of beam with scala-2.10 or scala-2.11. is there a scio version that works with scala-2.11? w

[GitHub] zeppelin issue #3265: [ZEPPELIN-3910] IPython delete temp file and close str...

2018-12-15 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3265 can you check failed tests https://travis-ci.org/yx91490/zeppelin/builds/468316435 ---

[GitHub] zeppelin issue #3264: [ZEPPELIN-3908] Fix Date Sorting issue

2018-12-14 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3264 please fix description - remove `First time? Setup Travis CI as described ` ... ---

[GitHub] zeppelin issue #3258: fix beam-runners-flink and zeppelin-scio scala version...

2018-12-11 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3258 also we could upgrade beam interpreter to "require" beam 2.3 also (so it does build with scala-2.11) ---

[GitHub] zeppelin issue #3258: fix beam-runners-flink and zeppelin-scio scala version...

2018-12-11 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3258 what about we don't build beam and scio if scala-2.11? ---

[GitHub] spark pull request #23252: [SPARK-26239] File-based secret key loading for S...

2018-12-08 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/23252#discussion_r240022921 --- Diff: core/src/test/scala/org/apache/spark/SecurityManagerSuite.scala --- @@ -440,12 +473,27 @@ class SecurityManagerSuite extends SparkFunSuite

[GitHub] spark issue #23224: [SPARK-26277][SQL][TEST] WholeStageCodegen metrics shoul...

2018-12-08 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/23224 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #23256: [SPARK-24207][R] follow-up PR for SPARK-24207 to fix cod...

2018-12-08 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/23256 ideally, but really not for this PR --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #23256: [SPARK-24207][R] follow-up PR for SPARK-24207 to ...

2018-12-07 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/23256#discussion_r239997109 --- Diff: R/pkg/tests/fulltests/test_mllib_fpm.R --- @@ -84,19 +84,20 @@ test_that("spark.fpGrowth", { }) test_that("s

[GitHub] zeppelin issue #3235: [ZEPPELIN-3864] Fix Travis tests

2018-12-07 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3235 Can you please fix the tests then. We can’t merge anything that will cause all PRs to fail in Travis. Even when they “should” be ---

[GitHub] spark issue #23218: [SPARK-26266][BUILD] Update to Scala 2.12.8

2018-12-06 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/23218 do we need to relnote jvm compatibility? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #23252: [SPARK-26239] File-based secret key loading for S...

2018-12-06 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/23252#discussion_r239705869 --- Diff: core/src/test/scala/org/apache/spark/SecurityManagerSuite.scala --- @@ -440,12 +473,27 @@ class SecurityManagerSuite extends SparkFunSuite

[GitHub] zeppelin issue #3254: [ZEPPELIN-3575] Add 'Copy Column Name' to table visual...

2018-12-06 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3254 any comment on this? ---

[GitHub] zeppelin issue #3235: [ZEPPELIN-3864] Fix Travis tests

2018-12-06 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3235 as I said, travis is failing with your fix? please check this test failed? https://travis-ci.org/TinkoffCreditSystems/zeppelin/jobs/458386760 ---

[GitHub] spark issue #22305: [SPARK-24561][SQL][Python] User-defined window aggregati...

2018-12-05 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22305 I can help if this looks good to @ueshin --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #23184: [SPARK-26227][R] from_[csv|json] should accept sc...

2018-12-02 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/23184#discussion_r238120855 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/api/r/SQLUtils.scala --- @@ -225,4 +225,10 @@ private[sql] object SQLUtils extends Logging

[GitHub] spark pull request #23184: [SPARK-26227][R] from_[csv|json] should accept sc...

2018-12-02 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/23184#discussion_r238120812 --- Diff: R/pkg/R/functions.R --- @@ -2254,40 +2255,48 @@ setMethod("date_format", signature(y = "Column", x = "character"

[GitHub] zeppelin issue #3245: [ZEPPELIN-3893] Bug Fix that clear paragraphs when exe...

2018-12-02 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3245 merging if no more comment ---

[GitHub] spark pull request #23072: [SPARK-19827][R]spark.ml R API for PIC

2018-12-01 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/23072#discussion_r238087240 --- Diff: examples/src/main/scala/org/apache/spark/examples/ml/FPGrowthExample.scala --- @@ -64,4 +64,3 @@ object FPGrowthExample { spark.stop

[GitHub] zeppelin issue #3243: [ZEPPELIN-3886] Remove dependency on flatmap-stream 0....

2018-11-30 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3243 could you check again? it seems travis tests are failing for other PRs because of event-stream now ---

[GitHub] zeppelin issue #3244: [ZEPPELIN-3882] Neo4jInterpreter - Support Point and D...

2018-11-30 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3244 looks like you are blocked by https://github.com/apache/zeppelin/pull/3243 https://api.travis-ci.org/v3/job/461718800/log.txt ---

[GitHub] spark issue #23161: [SPARK-26189][R]Fix unionAll doc in SparkR

2018-11-30 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/23161 merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

spark git commit: [SPARK-26189][R] Fix unionAll doc in SparkR

2018-11-30 Thread felixcheung
Repository: spark Updated Branches: refs/heads/master 28d337440 -> 2f6e88fec [SPARK-26189][R] Fix unionAll doc in SparkR ## What changes were proposed in this pull request? Fix unionAll doc in SparkR ## How was this patch tested? Manually ran test Author: Huaxin Gao Closes #23161 from

[GitHub] spark issue #23161: [SPARK-26189][R]Fix unionAll doc in SparkR

2018-11-30 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/23161 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #23184: [SPARK-26227][R] from_[csv|json] should accept sc...

2018-11-30 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/23184#discussion_r238055143 --- Diff: R/pkg/R/functions.R --- @@ -2254,40 +2255,48 @@ setMethod("date_format", signature(y = "Column", x = "character"

[GitHub] spark pull request #23184: [SPARK-26227][R] from_[csv|json] should accept sc...

2018-11-30 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/23184#discussion_r238055087 --- Diff: R/pkg/R/functions.R --- @@ -2254,40 +2255,48 @@ setMethod("date_format", signature(y = "Column", x = "character"

[GitHub] spark pull request #23184: [SPARK-26227][R] from_[csv|json] should accept sc...

2018-11-30 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/23184#discussion_r238055126 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/api/r/SQLUtils.scala --- @@ -225,4 +225,10 @@ private[sql] object SQLUtils extends Logging

[GitHub] spark pull request #23184: [SPARK-26227][R] from_[csv|json] should accept sc...

2018-11-30 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/23184#discussion_r238055173 --- Diff: R/pkg/R/functions.R --- @@ -202,8 +202,9 @@ NULL #' \itemize{ #' \item \code{from_json}: a structType object

[GitHub] spark issue #22939: [SPARK-25446][R] Add schema_of_json() and schema_of_csv(...

2018-11-29 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22939 Error looks reasonable... --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands

[GitHub] spark pull request #23161: [SPARK-26189][R]Fix unionAll doc in SparkR

2018-11-29 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/23161#discussion_r237383462 --- Diff: R/pkg/R/DataFrame.R --- @@ -2732,13 +2732,24 @@ setMethod("union", dataFrame(unioned) })

[GitHub] zeppelin issue #3243: [ZEPPELIN-3886] Remove dependency on flatmap-stream 0....

2018-11-28 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3243 ouch, thanks for fixing this. @prabhjyotsingh @jongyoul @Leemoonsoo this is important. I checked and don't think we have released with this commit https://github.com/apache/zeppelin

[GitHub] zeppelin issue #3242: [ZEPPELIN-3882] Neo4jInterpreter - Support Point and D...

2018-11-28 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3242 can you check the failed tests? ---

[GitHub] spark pull request #23161: [SPARK-26189][R]Fix unionAll doc in SparkR

2018-11-28 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/23161#discussion_r236972877 --- Diff: R/pkg/R/DataFrame.R --- @@ -2732,14 +2732,24 @@ setMethod("union", dataFrame(unioned) })

[GitHub] spark pull request #23161: [SPARK-26189][R]Fix unionAll doc in SparkR

2018-11-28 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/23161#discussion_r236973169 --- Diff: R/pkg/R/DataFrame.R --- @@ -2732,14 +2732,24 @@ setMethod("union", dataFrame(unioned) })

[GitHub] zeppelin issue #3242: [ZEPPELIN-3882] Neo4jInterpreter - Support Point and D...

2018-11-27 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3242 perhaps we should have a min version compatible in the interpreter doc? otherwise I think it's fine not to have tested version, supported version etc in doc since then we'd need to keep

[GitHub] spark pull request #23025: [SPARK-26024][SQL]: Update documentation for repa...

2018-11-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/23025#discussion_r236970732 --- Diff: R/pkg/R/DataFrame.R --- @@ -767,6 +767,14 @@ setMethod("repartition", #' using \code{spark.sql.shuffle.

[GitHub] spark pull request #23072: [SPARK-19827][R]spark.ml R API for PIC

2018-11-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/23072#discussion_r236771417 --- Diff: docs/ml-clustering.md --- @@ -265,3 +265,44 @@ Refer to the [R API docs](api/R/spark.gaussianMixture.html) for more details

[GitHub] spark pull request #22939: [SPARK-25446][R] Add schema_of_json() and schema_...

2018-11-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22939#discussion_r236770223 --- Diff: R/pkg/R/functions.R --- @@ -2230,6 +2237,32 @@ setMethod("from_json", signature(x = "Column", schema = &q

[GitHub] zeppelin issue #3241: ZEPPELIN-3880: Code refactoring: remove class files us...

2018-11-27 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3241 tbh, this seems rather minor. I'd leave this for others to comment. ---

[GitHub] spark pull request #23145: [MINOR][Docs][WIP] Fix Typos

2018-11-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/23145#discussion_r236765511 --- Diff: docs/index.md --- @@ -67,7 +67,7 @@ Example applications are also provided in Python. For example, ./bin/spark-submit examples/src

[GitHub] spark pull request #23098: [WIP][SPARK-26132][BUILD][CORE] Remove support fo...

2018-11-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/23098#discussion_r236764795 --- Diff: R/pkg/R/sparkR.R --- @@ -269,7 +269,7 @@ sparkR.sparkContext <- function( #' sparkR.session("yarn-client", "Spa

[GitHub] spark pull request #23131: [SPARK-25908][SQL][FOLLOW-UP] Add back unionAll

2018-11-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/23131#discussion_r236763355 --- Diff: R/pkg/R/DataFrame.R --- @@ -2732,6 +2732,20 @@ setMethod("union", dataFrame(unioned) })

[GitHub] spark pull request #23025: [SPARK-26024][SQL]: Update documentation for repa...

2018-11-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/23025#discussion_r236762465 --- Diff: R/pkg/R/DataFrame.R --- @@ -767,6 +767,14 @@ setMethod("repartition", #' using \code{spark.sql.shuffle.

[GitHub] spark pull request #23131: [SPARK-25908][SQL][FOLLOW-UP] Add back unionAll

2018-11-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/23131#discussion_r236760822 --- Diff: R/pkg/R/DataFrame.R --- @@ -2732,6 +2732,20 @@ setMethod("union", dataFrame(unioned) })

[GitHub] spark pull request #23145: [MINOR][Docs] "a R interpreter" -> "an R interpre...

2018-11-26 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/23145#discussion_r236546043 --- Diff: docs/index.md --- @@ -67,7 +67,7 @@ Example applications are also provided in Python. For example, ./bin/spark-submit examples/src

[GitHub] zeppelin issue #3235: [ZEPPELIN-3864][ZP-68] Fix Travis tests

2018-11-25 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3235 this test failed? https://travis-ci.org/TinkoffCreditSystems/zeppelin/jobs/458386760 ---

[GitHub] spark issue #23089: [SPARK-26120][TESTS][SS][SPARKR]Fix a streaming query le...

2018-11-21 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/23089 Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #22939: [SPARK-25446][R] Add schema_of_json() and schema_of_csv(...

2018-11-21 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22939 Sorry for the delay, will do another pass in 1 or 2 days --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark pull request #23072: [SPARK-19827][R]spark.ml R API for PIC

2018-11-17 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/23072#discussion_r234432181 --- Diff: R/pkg/R/mllib_clustering.R --- @@ -610,3 +616,57 @@ setMethod("write.ml", signature(object = "LDAModel"

[GitHub] spark pull request #23072: [SPARK-19827][R]spark.ml R API for PIC

2018-11-17 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/23072#discussion_r234432019 --- Diff: R/pkg/R/mllib_clustering.R --- @@ -610,3 +616,57 @@ setMethod("write.ml", signature(object = "LDAModel"

[GitHub] spark pull request #23072: [SPARK-19827][R]spark.ml R API for PIC

2018-11-17 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/23072#discussion_r234432049 --- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd --- @@ -968,6 +970,17 @@ predicted <- predict(model, df) head(predic

[GitHub] spark pull request #23073: [SPARK-26104] expose pci info to task scheduler

2018-11-17 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/23073#discussion_r234431864 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/ExecutorData.scala --- @@ -27,12 +27,14 @@ import org.apache.spark.rpc.{RpcAddress

[GitHub] spark issue #23073: [SPARK-26104] expose pci info to task scheduler

2018-11-17 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/23073 please put ^ comment into PR description (because comment is not included in commit message once the PR is merged

[GitHub] spark issue #23012: [SPARK-26014][R] Deprecate R prior to version 3.4 in Spa...

2018-11-14 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/23012 Yea there are some problem with some packages we depend on that are not installable from CRAN (eg too old) so it will be hard to a new version of R and new installation. So to clarify

[GitHub] spark issue #23012: [SPARK-26014][R] Deprecate R prior to version 3.4 in Spa...

2018-11-13 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/23012 Hey shane I don’t think we are saying to test multiple R version at all. In fact quite the opposite, just the new(er) version at some point in the future. (We don’t have a better

[GitHub] spark issue #23012: [SPARK-26014][R] Deprecate R prior to version 3.4 in Spa...

2018-11-13 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/23012 I think it's easier to say unsupported if we are not testing it in jenkins or appveyer. I don't know if we any coverage at release for older R version anyway, so it's better to unsupported

[GitHub] spark issue #23017: [WIP][SPARK-26015][K8S] Set a default UID for Spark on K...

2018-11-13 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/23017 noted test issue. let's kick off test though --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #23017: [WIP][SPARK-26015][K8S] Set a default UID for Spark on K...

2018-11-13 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/23017 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #23007: [SPARK-26010][R] fix vignette eval with Java 11

2018-11-12 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/23007 merged to master/2.4 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

spark git commit: [SPARK-26010][R] fix vignette eval with Java 11

2018-11-12 Thread felixcheung
ses #23007 from felixcheung/rjavavervig. (cherry picked from commit 88c82627267a9731b2438f0cc28dd656eb3dc834) Signed-off-by: Felix Cheung Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/65e5b265 Tree: http://git-

[GitHub] spark issue #22866: WIP [SPARK-12172][SPARKR] Remove internal-only RDD metho...

2018-11-12 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22866 thx, but DO NOT MERGE - there's some nasty bug I'm still investigating.. --- - To unsubscribe, e-mail: reviews-unsubscr

spark git commit: [SPARK-26010][R] fix vignette eval with Java 11

2018-11-12 Thread felixcheung
ses #23007 from felixcheung/rjavavervig. Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/88c82627 Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/88c82627 Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/88c82

[GitHub] spark pull request #23012: [SPARK-26014][R] Deprecate R prior to version 3.4...

2018-11-12 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/23012#discussion_r232881732 --- Diff: R/pkg/R/sparkR.R --- @@ -283,6 +283,10 @@ sparkR.session <- function( enableHiveSupport = TRUE, ...) { + if (ut

[GitHub] spark pull request #23012: [SPARK-26014][R] Deprecate R prior to version 3.4...

2018-11-12 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/23012#discussion_r232882419 --- Diff: docs/index.md --- @@ -31,7 +31,8 @@ Spark runs on both Windows and UNIX-like systems (e.g. Linux, Mac OS). It's easy locally on one

[GitHub] spark pull request #23012: [SPARK-26014][R] Deprecate R prior to version 3.4...

2018-11-12 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/23012#discussion_r232882178 --- Diff: docs/index.md --- @@ -31,7 +31,8 @@ Spark runs on both Windows and UNIX-like systems (e.g. Linux, Mac OS). It's easy locally on one

[GitHub] spark pull request #23012: [SPARK-26014][R] Deprecate R prior to version 3.4...

2018-11-12 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/23012#discussion_r232881594 --- Diff: R/WINDOWS.md --- @@ -3,7 +3,7 @@ To build SparkR on Windows, the following steps are required 1. Install R (>=

[GitHub] spark issue #23012: [SPARK-26014][R] Deprecate R prior to version 3.4 in Spa...

2018-11-12 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/23012 FYI This is unused code I’m going to remove it https://github.com/apache/spark/blob/master/R/pkg/src-native/string_hash_code.c

  1   2   3   4   5   6   7   8   9   10   >