On March 22, 2014, 4:39 p.m., Olle E Johansson wrote:
I don't see what happens with the phone-context argument. Shouldn't we pass
that on as a channel variable?
Geert Van Pamel wrote:
We return this into the hostport.
Geert Van Pamel wrote:
According to RFC 3966
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3346/
---
(Updated March 24, 2014, 9:03 a.m.)
Review request for Asterisk
On March 23, 2014, 3:46 p.m., wdoekes wrote:
Minor nits. Still waiting for someone to test this.
Sure, no hurry:)
- zvision
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3346/
---
(Updated March 24, 2014, 9:11 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3346/
---
(Updated March 24, 2014, 9:11 a.m.)
Review request for Asterisk
On March 22, 2014, 4:39 p.m., Olle E Johansson wrote:
I don't see what happens with the phone-context argument. Shouldn't we pass
that on as a channel variable?
Geert Van Pamel wrote:
We return this into the hostport.
Geert Van Pamel wrote:
According to RFC 3966
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3375/
---
(Updated March 24, 2014, 9:31 a.m.)
Review request for Asterisk
On March 23, 2014, 3:26 p.m., wdoekes wrote:
http://svn.asterisk.org/svn/asterisk/branches/11/res/res_config_odbc.c,
line 533
https://reviewboard.asterisk.org/r/3375/diff/1/?file=56218#file56218line533
Please move the (non-inline) ast_odbc function call to the back so we
can
On March 23, 2014, 3:26 p.m., wdoekes wrote:
http://svn.asterisk.org/svn/asterisk/branches/11/res/res_config_odbc.c,
line 533
https://reviewboard.asterisk.org/r/3375/diff/1/?file=56218#file56218line533
Please move the (non-inline) ast_odbc function call to the back so we
can
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3375/#review11344
---
Ship it!
Looking good.
- wdoekes
On March 24, 2014, 9:52
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3377/#review11345
---
/branches/1.8/main/astobj2.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3375/
---
(Updated March 24, 2014, 10:14 a.m.)
Review request for Asterisk
On March 22, 2014, 4:39 p.m., Olle E Johansson wrote:
I don't see what happens with the phone-context argument. Shouldn't we pass
that on as a channel variable?
Geert Van Pamel wrote:
We return this into the hostport.
Geert Van Pamel wrote:
According to RFC 3966
On March 22, 2014, 4:39 p.m., Olle E Johansson wrote:
I don't see what happens with the phone-context argument. Shouldn't we pass
that on as a channel variable?
Geert Van Pamel wrote:
We return this into the hostport.
Geert Van Pamel wrote:
According to RFC 3966
On March 21, 2014, 2:05 p.m., Jonathan Rose wrote:
/branches/12/res/res_stasis.c, line 739
https://reviewboard.asterisk.org/r/3380/diff/1/?file=56309#file56309line739
It might also be appropriate to move this declaration into the loop...
but ultimately kind of pointless since it
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3354/
---
(Updated March 24, 2014, 9:14 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3381/#review11350
---
Ship it!
Looks good. No issue, just something you might have
On March 24, 2014, 11:32 a.m., Kevin Harwell wrote:
/branches/12/res/res_pjsip.c, lines 1872-1876
https://reviewboard.asterisk.org/r/3381/diff/2/?file=56314#file56314line1872
Just to make sure did you check every call to this to make sure it
wasn't being decremented by the
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3382/
---
(Updated March 24, 2014, 11:17 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3383/
---
Review request for Asterisk Developers.
Repository: testsuite
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3377/#review11352
---
/branches/1.8/utils/Makefile
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3337/#review11353
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3384/
---
Review request for Asterisk Developers.
Repository: Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3385/
---
Review request for Asterisk Developers.
Repository: testsuite
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3384/#review11357
---
Ship it!
Ship It!
- Joshua Colp
On March 24, 2014, 7:31
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3357/#review11358
---
Four of the five tests presented here (no_event_header,
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3382/#review11355
---
* I think you need to add an assert to prevent ao2 objects
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3374/#review11359
---
What are the files in the configs/ast2/ directory used for?
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3353/#review11360
---
In retrospect, since the bridge is automatically subscribed by
On March 20, 2014, 8:17 a.m., opticron wrote:
/asterisk/trunk/tests/rest_api/bridges/bridge_record/subscribe_bridge.py,
line 46
https://reviewboard.asterisk.org/r/3353/diff/1/?file=55987#file55987line46
Use the logger instead if this needs to be logged somewhere.
Just leftover
On March 20, 2014, 10:01 p.m., rmudgett wrote:
/branches/12/main/sorcery.c, lines 777-779
https://reviewboard.asterisk.org/r/3326/diff/5/?file=56181#file56181line777
Should a duplicate wizard be considered a failure here? If so we
should:
res =
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3353/
---
(Updated March 24, 2014, 5:36 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3326/
---
(Updated March 24, 2014, 10:39 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3326/#review11363
---
Ship it!
I'll say this is ready to go now. :)
- rmudgett
On March 24, 2014, 4:39 p.m., Mark Michelson wrote:
What are the files in the configs/ast2/ directory used for?
Absolutely nothing. Removing.
- Jonathan
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3374/
---
(Updated March 24, 2014, 5:54 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3386/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-23391
37 matches
Mail list logo
