[PATCH] D99675: [llvm][clang] Create new intrinsic llvm.arith.fence to control FP optimization at expression level

pengfei added inline comments. Comment at: llvm/docs/LangRef.rst:21195 +'``llvm.arithmetic_fence``' Intrinsic +^^ + Should be equal to the text? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103564: [NFC][compiler-rt][hwasan] Move allocation functions into their own file

mcgrathr added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_interceptors.cpp:171 } // namespace __hwasan +#else // #if !SANITIZER_FUCHSIA +namespace __hwasan { blank lines around `#else` and `#endif` lines. But here I think you just omit this.

[PATCH] D103750: [analyzer][WIP] Handle std::make_unique for SmartPtrModeling

NoQ added a comment. In D103750#2804438 , @RedDocMD wrote: > Nice. Looks like I have something to read up on. Turns out, I end up learning > something new in C++ every now and then.  Yeah, it's also pretty interesting ABI-wise. As you know, C++

[PATCH] D103845: [compiler-rt][hwasan] Add newline between record_addr lines on frame record dumps

vitalybuka added a comment. In D103845#2804441 , @pcc wrote: > This isn't how the output looks on Android. Are you sure this isn't a > Fuchsia-specific bug in the output formatting? I don't see from the code how android can insert \n if SymbolizePC

[PATCH] D103845: [compiler-rt][hwasan] Add newline between record_addr lines on frame record dumps

pcc requested changes to this revision. pcc added a comment. This revision now requires changes to proceed. This isn't how the output looks on Android. Are you sure this isn't a Fuchsia-specific bug in the output formatting? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103750: [analyzer][WIP] Handle std::make_unique for SmartPtrModeling

RedDocMD added a comment. Nice. Looks like I have something to read up on. Turns out, I end up learning something new in C++ every now and then.  Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103750/new/ https://reviews.llvm.org/D103750

[PATCH] D103605: [analyzer] Introduce a new interface for tracking

NoQ added a comment. In D103605#2802240 , @vsavchenko wrote: > In D103605#2801681 , @NoQ wrote: > >> > > OK, let's make a pause right here. We again start to go into other topics. These are not other topics.

[clang] f38eff7 - [AIX] Define __STDC_NO_ATOMICS__ and __STDC_NO_THREADS__

Author: Jake.Egan Date: 2021-06-07T22:45:41-04:00 New Revision: f38eff777e46f42884d82815d0b39766520ac2bf URL: https://github.com/llvm/llvm-project/commit/f38eff777e46f42884d82815d0b39766520ac2bf DIFF: https://github.com/llvm/llvm-project/commit/f38eff777e46f42884d82815d0b39766520ac2bf.diff

[clang] f97e01e - Revert "[AIX] Define __STDC_NO_ATOMICS__ and __STDC_NO_THREADS__ predefined macros"

Author: Chris Bowler Date: 2021-06-07T22:45:41-04:00 New Revision: f97e01e61af1115bb9cb68dbdc70cc7f9f884759 URL: https://github.com/llvm/llvm-project/commit/f97e01e61af1115bb9cb68dbdc70cc7f9f884759 DIFF: https://github.com/llvm/llvm-project/commit/f97e01e61af1115bb9cb68dbdc70cc7f9f884759.diff

[PATCH] D103707: [AIX] Define __STDC_NO_ATOMICS__ and __STDC_NO_THREADS__ predefined macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6629be31e67: [AIX] Define __STDC_NO_ATOMICS__ and __STDC_NO_THREADS__ predefined macros (authored by Jake-Egan, committed by cbowler

[clang] e6629be - [AIX] Define __STDC_NO_ATOMICS__ and __STDC_NO_THREADS__ predefined macros

Author: =Jake Egan Date: 2021-06-07T22:04:18-04:00 New Revision: e6629be31e67190f0a524f009752d73410894560 URL: https://github.com/llvm/llvm-project/commit/e6629be31e67190f0a524f009752d73410894560 DIFF: https://github.com/llvm/llvm-project/commit/e6629be31e67190f0a524f009752d73410894560.diff

[PATCH] D103792: [clang][AST] Set correct DeclContext in ASTImporter lookup table for template params.

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:6005 + // Template parameters for a CXXDeductionGuideDecl are re-used by the + // non-deduction-guide-decl template. That template is imported too, and Is this case covered in the tests?

[PATCH] D103707: [AIX] Define __STDC_NO_ATOMICS__ and __STDC_NO_THREADS__ predefined macros

cebowleratibm accepted this revision. cebowleratibm added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103707/new/ https://reviews.llvm.org/D103707

[PATCH] D103850: [clang] diagnose instead of assert for defaulted comparison return type deduction.

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:7876 + diag:: + err_defaulted_comparison_cannot_deduce_unsupported_builtin_type) + << Subobj.Kind << Subobj.Decl << T; I think this

[PATCH] D103495: [static initializers] Don't put ordered dynamic initializers of static variables into global_ctors

efriedma added a comment. Are there any existing optimizations that might be affected by this? In particular, I think GlobalOpt implicitly reorders functions in global_ctors. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103495/new/ https://reviews.llvm.org/D103495

[PATCH] D103184: [AArch64] handle -Wa,-march=

jcai19 added a comment. In D103184#2803768 , @thakis wrote: > FWIW the failure goes away locally if I revert this change here, so it's > definitely due to this change here. > > Things have been red for a while, probably good to revert while you >

[PATCH] D103855: [clang] Exclude function pointers on DefaultedComparisonAnalyzer

mizvekov created this revision. Herald added subscribers: manas, steakhal, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This implements a more

[PATCH] D103745: [dfsan] Add full fast8 support

gbalats added inline comments. Comment at: llvm/test/Instrumentation/DataFlowSanitizer/external_mask.ll:6 define i32 @test(i32 %a, i32* nocapture readonly %b) #0 { -; CHECK: @"dfs$test" -; CHECK: %[[RV:.*]] load{{.*}}__dfsan_shadow_ptr_mask -; CHECK: ptrtoint i32* {{.*}} to i64

[PATCH] D103745: [dfsan] Add full fast8 support

browneee accepted this revision. browneee added inline comments. Comment at: llvm/test/Instrumentation/DataFlowSanitizer/external_mask.ll:6 define i32 @test(i32 %a, i32* nocapture readonly %b) #0 { -; CHECK: @"dfs$test" -; CHECK: %[[RV:.*]] load{{.*}}__dfsan_shadow_ptr_mask -;

[PATCH] D103048: [IR] make -stack-alignment= into a module attr

nickdesaulniers updated this revision to Diff 350443. nickdesaulniers added a comment. - remove test for module without module attr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103048/new/ https://reviews.llvm.org/D103048 Files:

[PATCH] D103851: [IR] make a new ModFlagBehavior that errors when a module attribute is missing

nickdesaulniers added a comment. See also: https://reviews.llvm.org/D103048#2804089 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103851/new/ https://reviews.llvm.org/D103851 ___ cfe-commits mailing

[PATCH] D103048: [IR] make -stack-alignment= into a module attr

nickdesaulniers added inline comments. Comment at: llvm/test/Linker/stack-alignment.ll:11 +;--- main.ll +; NONE: error: linking module flags 'override-stack-alignment': IDs have conflicting values +; CHECK-16: error: linking module flags 'override-stack-alignment': IDs have

[PATCH] D103851: [IR] make a new ModFlagBehavior that errors when a module attribute is missing

nickdesaulniers abandoned this revision. nickdesaulniers added a comment. Not planning on shipping this, just a demonstration. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103851/new/ https://reviews.llvm.org/D103851

[PATCH] D103851: [IR] make a new ModFlagBehavior that errors when a module attribute is missing

nickdesaulniers created this revision. Herald added a reviewer: deadalnix. Herald added subscribers: dexonsmith, hiraditya. nickdesaulniers requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Promote override-stack-alignment

[PATCH] D103837: [clang] Apply MS ABI details on __builtin_ms_va_list on non-windows platforms on x86_64

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103837/new/ https://reviews.llvm.org/D103837 ___

[PATCH] D103495: [static initializers] Don't put ordered dynamic initializers of static variables into global_ctors

rnk added subscribers: MaskRay, mstorsjo. rnk added a comment. + various .ctors stakeholders + @MaskRay + @mstorsjo This change was my idea, so I want to make sure there is buy in from other folks who use -fno-init-array. This has the potential to break user programs that rely on the order of

[PATCH] D103564: [NFC][compiler-rt][hwasan] Move allocation functions into their own file

leonardchan updated this revision to Diff 350437. leonardchan retitled this revision from "[NFC][compiler-rt][hwasan] Wrap fork interceptor with HWASAN_WITH_INTERCEPTORS" to "[NFC][compiler-rt][hwasan] Move allocation functions into their own file". leonardchan edited the summary of this

[PATCH] D103850: [clang] diagnose instead of assert for defaulted comparison return type deduction.

mizvekov created this revision. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When deducing the return type of defaulted three-way comparison, instead of asserting in the case of unsupported builtin types, just diagnose it. For

[PATCH] D103845: [compiler-rt][hwasan] Add newline between record_addr lines on frame record dumps

leonardchan created this revision. leonardchan added reviewers: eugenis, vitalybuka. leonardchan added a project: Sanitizers. Herald added a subscriber: dberris. leonardchan requested review of this revision. Herald added a subscriber: Sanitizers. This is mostly a stylistic preference. Currently

[PATCH] D103760: [clang] use correct builtin type for defaulted comparison analyzer

mizvekov added a comment. @rsmith what do you think of the following strategy as a follow up to this patch: - First step we replace the assert at line 7866 with a `deleted` result. I don't really think it's sustainable to keep returning incorrect results / crashing for builtin types that are

[clang] 9145a3d - Revert "[AArch64] handle -Wa,-march="

Author: Jian Cai Date: 2021-06-07T14:31:07-07:00 New Revision: 9145a3d4ab7eb05d9fb113b5392e8961df629b88 URL: https://github.com/llvm/llvm-project/commit/9145a3d4ab7eb05d9fb113b5392e8961df629b88 DIFF: https://github.com/llvm/llvm-project/commit/9145a3d4ab7eb05d9fb113b5392e8961df629b88.diff

[PATCH] D103841: [compiler-rt][hwasan] Decouple use of the TLS global for getting the shadow base and using the frame record feature

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr, eugenis, vitalybuka. leonardchan added a project: Sanitizers. Herald added subscribers: hiraditya, dberris. leonardchan requested review of this revision. Herald added a project: LLVM. Herald added a subscriber:

[PATCH] D103048: [IR] make -stack-alignment= into a module attr

nickdesaulniers added a comment. In D103048#2795456 , @tejohnson wrote: >> Curiously, using ModFlagBehavior::Error doesn't error if one of two modules >> being linked together doesn't have such a module level attribute. > > Yeah, there's a Require

[PATCH] D103806: [SystemZ][z/OS] Pass OpenFlags when creating tmp files

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103806/new/ https://reviews.llvm.org/D103806

[PATCH] D103184: [AArch64] handle -Wa,-march=

thakis added a comment. FWIW the failure goes away locally if I revert this change here, so it's definitely due to this change here. Things have been red for a while, probably good to revert while you investigate by this point. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103707: [AIX] Define __STDC_NO_ATOMICS__ and __STDC_NO_THREADS__ predefined macros

Jake-Egan updated this revision to Diff 350406. Jake-Egan added a comment. Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103707/new/ https://reviews.llvm.org/D103707 Files: clang/lib/Basic/Targets/OSTargets.h

[PATCH] D54047: Check TUScope is valid before use

kimgr added a comment. This was eventually fixed in IWYU based on @jkorous' suggestion above. I believe the problem is/was: - After code is parsed and the AST is built, Sema resets its `TUScope` member to null - We use Sema to lookup and define default constructors before traversing the AST

[PATCH] D31697: Check for null before using TUScope

kimgr added a comment. This was eventually fixed in IWYU. I believe the problem is/was: - After code is parsed and the AST is built, Sema resets its `TUScope` member to null - We use Sema to lookup and define default constructors before traversing the AST using a RAV - Some

[PATCH] D103184: [AArch64] handle -Wa,-march=

thakis added a comment. In D103184#2803691 , @nickdesaulniers wrote: > In D103184#2803513 , @thakis wrote: > >> This breaks tests on arm macs: http://45.33.8.238/macm1/10931/step_7.txt > > > >>> clang: error:

[PATCH] D103611: Correct the behavior of va_arg checking in C++

efriedma added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:15775 + if (Context.typesAreCompatible(PromoteType, UnderlyingType, + /*CompareUnqualified*/ true)) PromoteType = QualType(); If we're not

[PATCH] D103707: [AIX] Define __STDC_NO_ATOMICS__ and __STDC_NO_THREADS__ predefined macros

Jake-Egan updated this revision to Diff 350400. Jake-Egan added a comment. Add C17 test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103707/new/ https://reviews.llvm.org/D103707 Files: clang/lib/Basic/Targets/OSTargets.h

[PATCH] D103184: [AArch64] handle -Wa,-march=

nickdesaulniers added a comment. In D103184#2803513 , @thakis wrote: > This breaks tests on arm macs: http://45.33.8.238/macm1/10931/step_7.txt >> clang: error: the clang compiler does not support '-Wa,--version' Wouldn't that be

[PATCH] D103241: [OpenCL] Add memory_scope_all_devices

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks. Considering that this patch doesn't add anything new to the design, I suggest we go ahead. But we should continue the discussion around -cl-ext etc elsewhere and then

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 added a comment. Ok. Given @HazardyKnusperkeks comment I'll make the default be left alignment and update the tests accordingly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.llvm.org/D101868

[PATCH] D103184: [AArch64] handle -Wa,-march=

jcai19 added a comment. In D103184#2803513 , @thakis wrote: > This breaks tests on arm macs: http://45.33.8.238/macm1/10931/step_7.txt > > Please take a look and revert for now if it takes a while to fix. Thanks, will address the breakage ASAP.

[PATCH] D103750: [analyzer][WIP] Handle std::make_unique for SmartPtrModeling

NoQ added a comment. Also congrats, sounds like you are to become the first actual user of this API! Hope it actually works 爛爛爛 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103750/new/ https://reviews.llvm.org/D103750

[PATCH] D103750: [analyzer][WIP] Handle std::make_unique for SmartPtrModeling

xazax.hun added a comment. Whoops, I totally missed your point with my suggestion (should not read it while sitting at meetings). But Artem has a great answer already. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103750/new/

[PATCH] D103837: [clang] Apply MS ABI details on __builtin_ms_va_list on non-windows platforms on x86_64

mstorsjo created this revision. mstorsjo added a reviewer: rnk. Herald added a subscriber: pengfei. mstorsjo requested review of this revision. Herald added a project: clang. This fixes inconsistencies in the ms_abi.c testcase. Also add a couple cases of missing double pointers in the windows

[PATCH] D101630: [HIP] Add --gpu-bundle-output

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/Driver.cpp:2903 bool GPUSanitize; +Optional BundleOutput; tra wrote: > We should document the behavior we expect from the `--gpu-bundle-output` >

[PATCH] D103707: [AIX] Define __STDC_NO_ATOMICS__ and __STDC_NO_THREADS__ predefined macros

Jake-Egan updated this revision to Diff 350392. Jake-Egan edited the summary of this revision. Jake-Egan added a comment. Prune positive tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103707/new/ https://reviews.llvm.org/D103707 Files:

[PATCH] D103777: [X32] Add Triple::isX32(), use it.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG75521bd9d8d1: [X32] Add Triple::isX32(), use it. (authored by hvdijk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 75521bd - [X32] Add Triple::isX32(), use it.

Author: Harald van Dijk Date: 2021-06-07T20:48:39+01:00 New Revision: 75521bd9d8d1e39b1a765a14d95c49291d2adde5 URL: https://github.com/llvm/llvm-project/commit/75521bd9d8d1e39b1a765a14d95c49291d2adde5 DIFF:

[clang] 6de45b9 - [clang] Fix reading long doubles with va_arg on x86_64 mingw

Author: Martin Storsjö Date: 2021-06-07T22:34:10+03:00 New Revision: 6de45b9e6a2c4b69ca82916a4cc1b4b8636d79b3 URL: https://github.com/llvm/llvm-project/commit/6de45b9e6a2c4b69ca82916a4cc1b4b8636d79b3 DIFF:

[PATCH] D103452: [clang] Fix reading long doubles with va_arg on x86_64 mingw

This revision was automatically updated to reflect the committed changes. Closed by commit rG6de45b9e6a2c: [clang] Fix reading long doubles with va_arg on x86_64 mingw (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D103452?vs=349517=350390#toc Repository: rG LLVM

[PATCH] D103611: Correct the behavior of va_arg checking in C++

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:15783 + // test for typesAreCompatible() will already properly consider those to + // be compatible types. + if (Context.getLangOpts().CPlusPlus && !PromoteType.isNull() &&

[PATCH] D103750: [analyzer][WIP] Handle std::make_unique for SmartPtrModeling

NoQ added a comment. In D103750#2803516 , @RedDocMD wrote: > In D103750#2803499 , @NoQ wrote: > >> Ugh, this entire `checkBind` hack was so unexpected that I didn't even >> recognize `evalCall`. What prevents

[PATCH] D103777: [X32] Add Triple::isX32(), use it.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103777/new/ https://reviews.llvm.org/D103777

[PATCH] D103750: [analyzer][WIP] Handle std::make_unique for SmartPtrModeling

xazax.hun added a comment. In D103750#2803516 , @RedDocMD wrote: > In D103750#2803499 , @NoQ wrote: > >> Ugh, this entire `checkBind` hack was so unexpected that I didn't even >> recognize `evalCall`. What

[PATCH] D103707: [AIX] Define __STDC_NO_ATOMICS__ and __STDC_NO_THREADS__ predefined macros

cebowleratibm requested changes to this revision. cebowleratibm added a comment. This revision now requires changes to proceed. Would like you to prune the new tests, then I think this will be ready to land. Comment at: clang/test/Preprocessor/init-ppc.c:726 +// RUN:

[PATCH] D103806: [SystemZ][z/OS] Pass OpenFlags when creating tmp files

abhina.sreeskantharajan updated this revision to Diff 350386. abhina.sreeskantharajan added a comment. Address rnk's comments and rename to ExtraFlags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103806/new/ https://reviews.llvm.org/D103806

[PATCH] D103806: [SystemZ][z/OS] Pass OpenFlags when creating tmp files

rnk added inline comments. Comment at: llvm/lib/Support/Path.cpp:1295 SmallString<128> ResultPath; - if (std::error_code EC = - createUniqueFile(Model, FD, ResultPath, OF_Delete, Mode)) + if (std::error_code EC = createUniqueFile(Model, FD, ResultPath, Flags,

[PATCH] D103452: [clang] Fix reading long doubles with va_arg on x86_64 mingw

mstorsjo added inline comments. Comment at: clang/test/CodeGen/mingw-long-double.c:56-58 + // GNU32: bitcast i8* %argp.cur to x86_fp80* + // GNU64: bitcast i8* %argp.cur to x86_fp80** + // MSC64: bitcast i8* %argp.cur to double* rnk wrote: > mstorsjo wrote: >

[PATCH] D103317: [Analyzer][engine][solver] Simplify complex constraints

vsavchenko added a comment. In D103317#2803238 , @ASDenysPetrov wrote: > @vsavchenko > > I appologize for my immaturity and for the audacity of my infantile > assumptions. I admit any constructive criticism. Thank you for referencing > the theory. I

[PATCH] D103452: [clang] Fix reading long doubles with va_arg on x86_64 mingw

rnk added inline comments. Comment at: clang/test/CodeGen/mingw-long-double.c:56-58 + // GNU32: bitcast i8* %argp.cur to x86_fp80* + // GNU64: bitcast i8* %argp.cur to x86_fp80** + // MSC64: bitcast i8* %argp.cur to double* mstorsjo wrote: > mstorsjo wrote: >

[PATCH] D103835: [CUDA][HIP] Fix store of vtbl in ctor

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall. yaxunl requested review of this revision. vtbl itself is in default global address space. When clang emits ctor, it gets a pointer to the vtbl field based on the `this` pointer, then stores vtbl to the pointer. Since `this`

[PATCH] D103663: [AMDGPU] Add gfx1013 target

rampitec added inline comments. Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.intersect_ray.ll:4 +; RUN: llc -global-isel -march=amdgcn -mcpu=gfx1013 -verify-machineinstrs < %s | FileCheck -check-prefix=GCN %s +; RUN: llc -global-isel -march=amdgcn -mcpu=gfx1012

[PATCH] D103663: [AMDGPU] Add gfx1013 target

bcahoon marked 4 inline comments as done. bcahoon added inline comments. Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.intersect_ray.ll:4 +; RUN: llc -global-isel -march=amdgcn -mcpu=gfx1013 -verify-machineinstrs < %s | FileCheck -check-prefix=GCN %s +; RUN: llc

[PATCH] D103750: [analyzer][WIP] Handle std::make_unique for SmartPtrModeling

RedDocMD added a comment. In D103750#2803499 , @NoQ wrote: > Ugh, this entire `checkBind` hack was so unexpected that I didn't even > recognize `evalCall`. What prevents you from doing everything in `evalCall`? > No state traits, no nothing, just

[PATCH] D103184: [AArch64] handle -Wa,-march=

thakis added a comment. This breaks tests on arm macs: http://45.33.8.238/macm1/10931/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103184/new/

[PATCH] D97085: [OpenMP] libomp: implement OpenMP 5.1 inoutset task dependence type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa1f550e05254: [OpenMP] libomp: implement OpenMP 5.1 inoutset task dependence type (authored by AndreyChurbanov). Repository: rG LLVM Github

[PATCH] D103750: [analyzer][WIP] Handle std::make_unique for SmartPtrModeling

NoQ added a comment. Ugh, this entire `checkBind` hack was so unexpected that I didn't even recognize `evalCall`. What prevents you from doing everything in `evalCall`? No state traits, no nothing, just directly take the this-region and attach the value to it? Repository: rG LLVM Github

[PATCH] D103611: Correct the behavior of va_arg checking in C++

efriedma added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:15783 + // test for typesAreCompatible() will already properly consider those to + // be compatible types. + if (Context.getLangOpts().CPlusPlus && !PromoteType.isNull() &&

[PATCH] D103495: [static initializers] Don't put ordered dynamic initializers of static variables into global_ctors

wolfgangp updated this revision to Diff 350364. wolfgangp added a comment. Herald added subscribers: llvm-commits, jdoerfert, pengfei, jrtc27, fedor.sergeev, hiraditya, jyknight, dschuff. Herald added a project: LLVM. Following the suggestion to define an order of initialization for the entries

[PATCH] D103745: [dfsan] Add full fast8 support

gbalats marked an inline comment as done. gbalats added inline comments. Comment at: clang/docs/DataFlowSanitizer.rst:172-178 assert(ij_label == 3); // Verifies all of the above +// Or, equivalently: +assert(dfsan_has_label(ij_label, i_label)); +

[PATCH] D103750: [analyzer][WIP] Handle std::make_unique for SmartPtrModeling

RedDocMD marked an inline comment as done. RedDocMD added a comment. In D103750#2801555 , @NoQ wrote: > Yes I think you should totally do an `evalCall()` here. The function has no > other side effects apart from making a pointer so it's valuable to

[PATCH] D103750: [analyzer][WIP] Handle std::make_unique for SmartPtrModeling

RedDocMD marked 3 inline comments as done. RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:337 + +bool isUniquePtrType(QualType QT) { + const auto *T = QT.getTypePtr(); NoQ wrote: > Please merge with

[PATCH] D103750: [analyzer][WIP] Handle std::make_unique for SmartPtrModeling

RedDocMD updated this revision to Diff 350362. RedDocMD added a comment. Made stylistic refactors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103750/new/ https://reviews.llvm.org/D103750 Files:

[PATCH] D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr

jankratochvil added a comment. [Dwarf-Discuss] How to map [[no_unique_address]] into DWARF: http://lists.dwarfstd.org/pipermail/dwarf-discuss-dwarfstd.org/2021-June/004825.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101237/new/

[PATCH] D89055: [analyzer] Wrong type cast occures during pointer dereferencing after type punning

chrish_ericsson_atx added inline comments. Herald added a subscriber: manas. Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:763-765 + if (const auto *ER = dyn_cast(R)) { +R = StateMgr.getStoreManager().castRegion(ER, CastTy); +return

[PATCH] D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr

jankratochvil added inline comments. Comment at: llvm/include/llvm/IR/DebugInfoFlags.def:62 +// FIXME: Move it to ReservedBit4? +HANDLE_DI_FLAG((1 << 30), IsZeroSize) This would need to be handled better if approved. Repository: rG LLVM Github Monorepo

[PATCH] D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr

jankratochvil updated this revision to Diff 350361. jankratochvil added a comment. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, sstefan1, martong, hiraditya. Herald added a reviewer: shafik. Herald added a reviewer: jdoerfert. Herald added a reviewer: shafik. Herald added

[PATCH] D103317: [Analyzer][engine][solver] Simplify complex constraints

ASDenysPetrov added a comment. @vsavchenko I appologize for my immaturity and for the audacity of my infantile assumptions. I admit any constructive criticism. Thank you for referencing the theory. I will thoroughly study the domain in all. As for the **assignments** and why I brought them

[PATCH] D103803: [analyzer] [NFC] Implement a wrapper SValBuilder::getCastedMemRegionVal for similar functionality on region cast

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Great, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103803/new/ https://reviews.llvm.org/D103803

[PATCH] D103452: [clang] Fix reading long doubles with va_arg on x86_64 mingw

mstorsjo added inline comments. Comment at: clang/test/CodeGen/mingw-long-double.c:56-58 + // GNU32: bitcast i8* %argp.cur to x86_fp80* + // GNU64: bitcast i8* %argp.cur to x86_fp80** + // MSC64: bitcast i8* %argp.cur to double* mstorsjo wrote: > rnk wrote: >

[PATCH] D103184: [AArch64] handle -Wa,-march=

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd11a26d368c: [AArch64] handle -Wa,-march= (authored by jcai19). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103184/new/ https://reviews.llvm.org/D103184

[clang] fd11a26 - [AArch64] handle -Wa,-march=

Author: Jian Cai Date: 2021-06-07T10:15:53-07:00 New Revision: fd11a26d368c5a909fb88548fef2cee7a6c2c931 URL: https://github.com/llvm/llvm-project/commit/fd11a26d368c5a909fb88548fef2cee7a6c2c931 DIFF: https://github.com/llvm/llvm-project/commit/fd11a26d368c5a909fb88548fef2cee7a6c2c931.diff

[PATCH] D103663: [AMDGPU] Add gfx1013 target

rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:4697 + if (!ST.hasGFX10_AEncoding()) { +DiagnosticInfoUnsupported BadIntrin(B.getMF().getFunction(), "intrinsic not supported on subtarget", +

[PATCH] D101630: [HIP] Add --gpu-bundle-output

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/Driver.cpp:2903 bool GPUSanitize; +Optional BundleOutput; We should document the behavior we expect from the

[PATCH] D103806: [SystemZ][z/OS] Pass OpenFlags when creating tmp files

abhina.sreeskantharajan added inline comments. Comment at: llvm/lib/Support/Path.cpp:1295 SmallString<128> ResultPath; - if (std::error_code EC = - createUniqueFile(Model, FD, ResultPath, OF_Delete, Mode)) + if (std::error_code EC = createUniqueFile(Model, FD,

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

jamieschmeiser added a comment. @rsmith I separated the C and C++ messages in response to your comments and changed the C++ message to state that "performing pointer subtraction with a null pointer may have undefined behavior" to address your concerns. Are you satisfied? @thakis, the warning

[PATCH] D103771: [clang][msvc] Define _HAS_STATIC_RTTI to 0, when compiling with -fno-rtti

rnk accepted this revision. rnk added a comment. Seems reasonable to me. Here is where it is defined in MSVC's yvals_core.h for the curious: https://github.com/microsoft/STL/blob/3cafa97eecdbfde41ea5c09126f877a7eb97f9e9/stl/inc/yvals_core.h#L569 CHANGES SINCE LAST ACTION

[PATCH] D103745: [dfsan] Add full fast8 support

stephan.yichao.zhao added a comment. How did we fix that alignment error from compiler-rt/test/dfsan/origin_ldst.c? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103745/new/ https://reviews.llvm.org/D103745

[PATCH] D103806: [SystemZ][z/OS] Pass OpenFlags when creating tmp files

rnk added a comment. I see, thanks. Comment at: llvm/lib/Support/Path.cpp:1295 SmallString<128> ResultPath; - if (std::error_code EC = - createUniqueFile(Model, FD, ResultPath, OF_Delete, Mode)) + if (std::error_code EC = createUniqueFile(Model, FD, ResultPath,

[PATCH] D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment

adamcz created this revision. adamcz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. No repro case just yet. I only observed a crash like this and noticed ArgTy-Value = 0 in coredump. Repository: rG LLVM Github Monorepo

[PATCH] D101630: [HIP] Add --gpu-bundle-output

yaxunl updated this revision to Diff 350318. yaxunl retitled this revision from "[HIP] Fix device-only compilation" to "[HIP] Add --gpu-bundle-output". yaxunl edited the summary of this revision. yaxunl added a comment. use --gpu-bundle-output to control bundling/unbundling output of HIP device

[PATCH] D97869: [OpenCL] Add OpenCL builtin test generator

svenvh added inline comments. Comment at: clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp:969 + +void OpenCLBuiltinTestEmitter::getTypeLists( +Record *Type, TypeFlags , std::vector , Anastasia wrote: > I would add a documentation for this function, it is

[PATCH] D97869: [OpenCL] Add OpenCL builtin test generator

svenvh updated this revision to Diff 350314. svenvh marked an inline comment as done. svenvh retitled this revision from "[OpenCL][Draft] Add OpenCL builtin test generator" to "[OpenCL] Add OpenCL builtin test generator". svenvh added a comment. Improve comments. CHANGES SINCE LAST ACTION

[PATCH] D103797: [clang] Use resolved path for headers in decluse diagnostics

kadircet added a comment. It is the absolute path of the header. e.g: `module TestTU does not depend on a module exporting '/work/llvm/clang-tools-extra/clangd/AST.h'` rather than `module TestTU does not depend on a module exporting 'AST.h'` Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D102822: [Clang][CodeGen] Set the size of llvm.lifetime to unknown for scalable types.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2b13ff697946: [Clang][CodeGen] Set the size of llvm.lifetime to unknown for scalable types. (authored by HsiangKai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 2b13ff6 - [Clang][CodeGen] Set the size of llvm.lifetime to unknown for scalable types.

Author: Hsiangkai Wang Date: 2021-06-07T23:30:13+08:00 New Revision: 2b13ff69794680ea0764e516f5b69b80219771b7 URL: https://github.com/llvm/llvm-project/commit/2b13ff69794680ea0764e516f5b69b80219771b7 DIFF:

  1   2   >