On Wed, 17 Apr 2024 20:46:26 GMT, Joe Darcy wrote:
> 8330458: Add missing @since tag to ClassFile.JAVA_23_VERSION
Marked as reviewed by asotona (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18828#pullrequestreview-2007907265
On Wed, 17 Apr 2024 08:46:59 GMT, Adam Sotona wrote:
> Current implementation of `LambdaMetafactory` does not allow to use lambdas
> in hidden classes. Invocation throws `NoClassDefFoundError` instead.
>
> This patch includes lambda implementation in a hidden class under the special
>
> Current implementation of `LambdaMetafactory` does not allow to use lambdas
> in hidden classes. Invocation throws `NoClassDefFoundError` instead.
>
> This patch includes lambda implementation in a hidden class under the special
> handling of `useImplMethodHandle`.
> The patch also fixes
On Wed, 17 Apr 2024 19:33:09 GMT, Jan Lahoda wrote:
>> This is an implementation of JEP JDK-8315129: Module Import Declarations
>> (Preview). Please see the JEP for details:
>> https://bugs.openjdk.org/browse/JDK-8315129
>>
>> It is mostly straightforward - the module imports are parsed, and
Add two sample configuration files:
jaxp-strict.properties: used to set strict configuration, stricter than
jaxp.properties in previous versions such as JDK 22
jaxp-compat.properties: used to regain compatibility from any more restricted
configuration than previous versions such as JDK 22
On Wed, 17 Apr 2024 20:46:26 GMT, Joe Darcy wrote:
> 8330458: Add missing @since tag to ClassFile.JAVA_23_VERSION
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18828#pullrequestreview-2007547483
On Wed, 17 Apr 2024 15:21:32 GMT, Adam Sotona wrote:
>> java.base java.lang.invoke package heavily uses ASM to generate lambdas and
>> method handles.
>>
>> This patch converts ASM calls to Classfile API.
>>
>> This PR is continuation of https://github.com/openjdk/jdk/pull/12945
>>
>> Any
On Wed, 17 Apr 2024 20:46:26 GMT, Joe Darcy wrote:
> 8330458: Add missing @since tag to ClassFile.JAVA_23_VERSION
Marked as reviewed by jjg (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18828#pullrequestreview-2007300284
On Wed, 17 Apr 2024 15:21:32 GMT, Adam Sotona wrote:
>> java.base java.lang.invoke package heavily uses ASM to generate lambdas and
>> method handles.
>>
>> This patch converts ASM calls to Classfile API.
>>
>> This PR is continuation of https://github.com/openjdk/jdk/pull/12945
>>
>> Any
8330458: Add missing @since tag to ClassFile.JAVA_23_VERSION
-
Commit messages:
- JDK-8330458: Add missing @since tag to ClassFile.JAVA_23_VERSION
Changes: https://git.openjdk.org/jdk/pull/18828/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=18828=00
Issue:
On Wed, 17 Apr 2024 12:35:54 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional
>
On Wed, 17 Apr 2024 12:35:54 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional
>
On Wed, 17 Apr 2024 17:16:55 GMT, Justin Lu wrote:
>> Please review this PR which is a large spec reformatting for
>> _java.text.NumberFormat_ and related subclasses, specifically DecimalFormat
>> and CompactNumberFormat.
>>
>> The motivation for this change was the difficulty of readability
On Wed, 17 Apr 2024 16:08:31 GMT, Adam Sotona wrote:
>> Current implementation of `LambdaMetafactory` does not allow to use lambdas
>> in hidden classes. Invocation throws `NoClassDefFoundError` instead.
>>
>> This patch includes lambda implementation in a hidden class under the
>> special
On Wed, 17 Apr 2024 19:45:02 GMT, Dean Long wrote:
>> Yudi Zheng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> address comment.
>
> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 4702:
>
>> 4700: const Register tmp5 =
On Wed, 17 Apr 2024 12:35:54 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional
>
On Wed, 17 Apr 2024 12:35:54 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional
>
> This is an implementation of JEP JDK-8315129: Module Import Declarations
> (Preview). Please see the JEP for details:
> https://bugs.openjdk.org/browse/JDK-8315129
>
> It is mostly straightforward - the module imports are parsed, and then
> expanded to import-on-demand in `TypeEnter`.
> There
On Wed, 17 Apr 2024 16:08:31 GMT, Adam Sotona wrote:
>> Current implementation of `LambdaMetafactory` does not allow to use lambdas
>> in hidden classes. Invocation throws `NoClassDefFoundError` instead.
>>
>> This patch includes lambda implementation in a hidden class under the
>> special
> Please review this PR which is a large spec reformatting for
> _java.text.NumberFormat_ and related subclasses, specifically DecimalFormat
> and CompactNumberFormat.
>
> The motivation for this change was the difficulty of readability for these
> classes. This PR consists of changes such as
On Fri, 5 Apr 2024 23:13:39 GMT, Brent Christian wrote:
>> Classes in the `java.lang.ref` package would benefit from an update to bring
>> the spec in line with how the VM already behaves. The changes would focus on
>> _happens-before_ edges at some key points during reference processing.
>>
On Wed, 21 Feb 2024 11:32:41 GMT, Suchismith Roy wrote:
> Allow support for both .a and .so files in AIX.
> If .so file is not found, allow fallback to .a extension.
> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
This pull request has now been integrated.
Changeset:
On Wed, 17 Apr 2024 11:20:24 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request
On Wed, 17 Apr 2024 05:43:12 GMT, Joe Darcy wrote:
>> Get JDK 24 underway.
>
> Joe Darcy has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Correct release date as observed in review feedback.
> - Improve javadoc of class file update.
On Wed, 17 Apr 2024 15:21:32 GMT, Adam Sotona wrote:
>> java.base java.lang.invoke package heavily uses ASM to generate lambdas and
>> method handles.
>>
>> This patch converts ASM calls to Classfile API.
>>
>> This PR is continuation of https://github.com/openjdk/jdk/pull/12945
>>
>> Any
On Wed, 17 Apr 2024 11:20:24 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request
On Wed, 17 Apr 2024 15:39:11 GMT, Paul Sandoz wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> applied suggested changes
>
> test/jdk/java/lang/invoke/defineHiddenClass/src/Lambda.java line 28:
>
>> 26: public
> Current implementation of `LambdaMetafactory` does not allow to use lambdas
> in hidden classes. Invocation throws `NoClassDefFoundError` instead.
>
> This patch includes lambda implementation in a hidden class under the special
> handling of `useImplMethodHandle`.
> The patch also fixes
On Wed, 17 Apr 2024 15:21:32 GMT, Adam Sotona wrote:
>> java.base java.lang.invoke package heavily uses ASM to generate lambdas and
>> method handles.
>>
>> This patch converts ASM calls to Classfile API.
>>
>> This PR is continuation of https://github.com/openjdk/jdk/pull/12945
>>
>> Any
On Wed, 17 Apr 2024 12:51:55 GMT, Adam Sotona wrote:
>> Current implementation of `LambdaMetafactory` does not allow to use lambdas
>> in hidden classes. Invocation throws `NoClassDefFoundError` instead.
>>
>> This patch includes lambda implementation in a hidden class under the
>> special
> This is an implementation of JEP JDK-8315129: Module Import Declarations
> (Preview). Please see the JEP for details:
> https://bugs.openjdk.org/browse/JDK-8315129
>
> It is mostly straightforward - the module imports are parsed, and then
> expanded to import-on-demand in `TypeEnter`.
> There
> We have already good JLI tracing capabilities. But GetApplicationHome and
> GetApplicationHomeFromDll lack some tracing and should be enhanced.
Matthias Baesken has updated the pull request incrementally with one additional
commit since the last revision:
adjust trace messages
On Tue, 9 Apr 2024 15:28:08 GMT, Matthias Baesken wrote:
> We have already good JLI tracing capabilities. But GetApplicationHome and
> GetApplicationHomeFromDll lack some tracing and should be enhanced.
I adjusted the trace messages a bit to make the coding more consistent to the
existing Jli
> java.base java.lang.invoke package heavily uses ASM to generate lambdas and
> method handles.
>
> This patch converts ASM calls to Classfile API.
>
> This PR is continuation of https://github.com/openjdk/jdk/pull/12945
>
> Any comments and suggestions are welcome.
>
> Please review.
>
>
On Tue, 16 Apr 2024 22:49:28 GMT, Mandy Chung wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 additional
>> commits
> This is an implementation of JEP JDK-8315129: Module Import Declarations
> (Preview). Please see the JEP for details:
> https://bugs.openjdk.org/browse/JDK-8315129
>
> It is mostly straightforward - the module imports are parsed, and then
> expanded to import-on-demand in `TypeEnter`.
> There
I've been trying the the incubating Vector API and one thing I've missed on
integer-typed vectors is having unsigned min/max operations. There is a
signed min/max operation, and unsigned comparison, but no unsigned min/max.
I guess this is for symmetry with `Math`, which only has signed
On Tue, 9 Apr 2024 11:34:45 GMT, Maurizio Cimadamore
wrote:
> This PR removes support for the string template feature from the Java
> compiler and the Java SE API, as discussed here:
>
> https://mail.openjdk.org/pipermail/amber-spec-experts/2024-April/004106.html
This pull request has now
On Mon, 15 Apr 2024 18:25:02 GMT, Sonia Zaldana Calles
wrote:
> Hi folks,
>
> This PR aims to fix
> [JDK-8329581](https://bugs.openjdk.org/browse/JDK-8329581).
>
> I think the regression got introduced in
> [JDK-8315458](https://bugs.openjdk.org/browse/JDK-8315458).
>
> In the issue
On Wed, 17 Apr 2024 09:20:24 GMT, Jan Lahoda wrote:
>> Consider code like:
>>
>> public class MainClass {
>> public MainClass() {
>> System.out.println("Constructor called!");
>> }
>> public static void main() {
>> System.out.println("main called!");
>> }
>> }
>>
On Tue, 26 Mar 2024 15:59:33 GMT, Damon Fenacci wrote:
>> Yudi Zheng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> address comment.
>
> `multiply_to_len` seems to be used by `generate_squareToLen` as well for
> aarch64 and riscv but
On Mon, 15 Apr 2024 13:58:38 GMT, Jaikiran Pai wrote:
>> Suchismith Roy has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Files copy
>
> I'll let Mandy and others familiar with this area and AIX do the formal
> review of this PR. My
On Fri, 10 Nov 2023 08:17:22 GMT, Per Minborg wrote:
>> This PR outlines a solution for making immutable maps `@ValueBased` by
>> removing cacheing of certain values in `AbstractMap`.
>>
>> By removing these caching fields in `AbstractMap`, we can make the immutable
>> maps `@ValueBased` and
On Fri, 10 Nov 2023 08:17:22 GMT, Per Minborg wrote:
>> This PR outlines a solution for making immutable maps `@ValueBased` by
>> removing cacheing of certain values in `AbstractMap`.
>>
>> By removing these caching fields in `AbstractMap`, we can make the immutable
>> maps `@ValueBased` and
On Wed, 17 Apr 2024 10:58:59 GMT, Jorn Vernee wrote:
> Do we also need to check if the parameters or return type are hidden classes?
I think this is already failing and will continue to fail. Don't think we need
special error messages for this case.
-
PR Comment:
On Wed, 17 Apr 2024 11:20:24 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request
On Tue, 9 Apr 2024 09:28:23 GMT, Jan Lahoda wrote:
>> This is a patch for javac, that adds the Derived Record Creation
>> expressions. The current draft specification for the feature is:
>> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>>
>> The
On Mon, 15 Apr 2024 18:25:02 GMT, Sonia Zaldana Calles
wrote:
> Hi folks,
>
> This PR aims to fix
> [JDK-8329581](https://bugs.openjdk.org/browse/JDK-8329581).
>
> I think the regression got introduced in
> [JDK-8315458](https://bugs.openjdk.org/browse/JDK-8315458).
>
> In the issue
> Current implementation of `LambdaMetafactory` does not allow to use lambdas
> in hidden classes. Invocation throws `NoClassDefFoundError` instead.
>
> This patch includes lambda implementation in a hidden class under the special
> handling of `useImplMethodHandle`.
> The patch also fixes
On Wed, 17 Apr 2024 09:14:31 GMT, Chen Liang wrote:
>> Current implementation of `LambdaMetafactory` does not allow to use lambdas
>> in hidden classes. Invocation throws `NoClassDefFoundError` instead.
>>
>> This patch includes lambda implementation in a hidden class under the
>> special
On Tue, 26 Mar 2024 15:59:33 GMT, Damon Fenacci wrote:
>> Yudi Zheng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> address comment.
>
> `multiply_to_len` seems to be used by `generate_squareToLen` as well for
> aarch64 and riscv but
> Moving array construction within BigInteger.implMultiplyToLen intrinsic
> candidate to its caller simplifies the intrinsic implementation in JIT
> compiler.
Yudi Zheng has updated the pull request incrementally with one additional
commit since the last revision:
address comment.
> This PR proposes to add a new method `MemorySegment::maxByteAlignment` that
> returns the maximum byte alignment of a segment (both heap and native
> segments).
>
> Clients can then use this method to determine if a segment is properly
> aligned for any given layout (e.g. following a
> Moving array construction within BigInteger.implMultiplyToLen intrinsic
> candidate to its caller simplifies the intrinsic implementation in JIT
> compiler.
Yudi Zheng has updated the pull request incrementally with one additional
commit since the last revision:
address comment.
> While `SymbolLookup` correctly uses an `Optional` return to denote whether a
> symbol has been found by the lookup or not (which enables composition of
> symbol lookups), many clients end up just calling `Optional::get`, or
> `Optional::orElseThrow()` on the result.
>
> This PR proposes to
> Allow support for both .a and .so files in AIX.
> If .so file is not found, allow fallback to .a extension.
> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
Suchismith Roy has updated the pull request incrementally with one additional
commit since the last revision:
On Wed, 10 Apr 2024 16:17:32 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix the issue
>> noted in https://bugs.openjdk.org/browse/JDK-8212895?
>>
>> As noted in that issue, the `ChronoField.INSTANT_SECONDS` currently is
>> initialized to have a
On Wed, 17 Apr 2024 08:46:59 GMT, Adam Sotona wrote:
> Current implementation of `LambdaMetafactory` does not allow to use lambdas
> in hidden classes. Invocation throws `NoClassDefFoundError` instead.
>
> This patch includes lambda implementation in a hidden class under the special
>
On Mon, 8 Apr 2024 09:52:39 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to fix the issue
> noted in https://bugs.openjdk.org/browse/JDK-8212895?
>
> As noted in that issue, the `ChronoField.INSTANT_SECONDS` currently is
> initialized to have a minimum
On Wed, 17 Apr 2024 10:42:46 GMT, Martin Doerr wrote:
> Please take a look at Mandy's suggestions. I think they make sense.
Done. Sorry i missed it. I got notified that the patch had got approved so i
went ahead with integrate.
-
PR Comment:
> Allow support for both .a and .so files in AIX.
> If .so file is not found, allow fallback to .a extension.
> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
Suchismith Roy has updated the pull request incrementally with two additional
commits since the last revision:
-
On Mon, 15 Apr 2024 16:10:38 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request
On Tue, 16 Apr 2024 07:09:55 GMT, Per Minborg wrote:
> This PR proposes to update the javadocs for `ValueLayout.JAVA_LONG` and
> `ValueLayout.JAVA_DOUBLE` to reflect the changes made in
> https://bugs.openjdk.org/browse/JDK-8326172 (we forgot to update the docs
> when that issue was fixed)
On Wed, 17 Apr 2024 05:43:12 GMT, Joe Darcy wrote:
>> Get JDK 24 underway.
>
> Joe Darcy has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Correct release date as observed in review feedback.
> - Improve javadoc of class file update.
> Consider code like:
>
> public class MainClass {
> public MainClass() {
> System.out.println("Constructor called!");
> }
> public static void main() {
> System.out.println("main called!");
> }
> }
>
> and compile and run it, with preview enabled, like:
>
> $
On Wed, 17 Apr 2024 08:51:39 GMT, Jaikiran Pai wrote:
>> Jan Lahoda has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - Reflecting code formatting suggestion.
>> - First lookup the main method, and only then the constructor.
>> -
On Wed, 17 Apr 2024 08:46:59 GMT, Adam Sotona wrote:
> Current implementation of `LambdaMetafactory` does not allow to use lambdas
> in hidden classes. Invocation throws `NoClassDefFoundError` instead.
>
> This patch includes lambda implementation in a hidden class under the special
>
On Wed, 17 Apr 2024 06:34:25 GMT, Jan Lahoda wrote:
>> Consider code like:
>>
>> public class MainClass {
>> public MainClass() {
>> System.out.println("Constructor called!");
>> }
>> public static void main() {
>> System.out.println("main called!");
>> }
>> }
>>
Current implementation of `LambdaMetafactory` does not allow to use lambdas in
hidden classes. Invocation throws `NoClassDefFoundError` instead.
This patch includes lambda implementation in a hidden class under the special
handling of `useImplMethodHandle`.
The patch also fixes
On Tue, 16 Apr 2024 13:54:53 GMT, Alan Bateman wrote:
> I think it continues to build time, it's just using some hidden jlink option.
> So yes, it similar to a previous iteration except that it doesn't run as a
> plugin the pipeline and the delta goes to the lib directory.
OK. If a hidden
On Wed, 17 Apr 2024 06:34:25 GMT, Jan Lahoda wrote:
>> Consider code like:
>>
>> public class MainClass {
>> public MainClass() {
>> System.out.println("Constructor called!");
>> }
>> public static void main() {
>> System.out.println("main called!");
>> }
>> }
>>
On Tue, 16 Apr 2024 13:26:43 GMT, Jan Lahoda wrote:
>> src/java.base/share/native/libjli/java.c line 419:
>>
>>> 417: invokeInstanceMainWithArgs(JNIEnv *env, jclass mainClass, jobjectArray
>>> mainArgs) {
>>> 418: jmethodID constructor = (*env)->GetMethodID(env, mainClass,
>>> "", "()V");
On Wed, 17 Apr 2024 06:34:25 GMT, Jan Lahoda wrote:
>> Consider code like:
>>
>> public class MainClass {
>> public MainClass() {
>> System.out.println("Constructor called!");
>> }
>> public static void main() {
>> System.out.println("main called!");
>> }
>> }
>>
> Consider code like:
>
> public class MainClass {
> public MainClass() {
> System.out.println("Constructor called!");
> }
> public static void main() {
> System.out.println("main called!");
> }
> }
>
> and compile and run it, with preview enabled, like:
>
> $
74 matches
Mail list logo