On Wed, 15 May 2024 09:39:16 GMT, serhiysachkov wrote:
> Add specific regression tests for Calendar.roll() method to explicitly
> various leap year test scenarios. This is inspired by the ambiguity which
> occurred in leap year unaware test creation as in case with Calendar.add() in
> swing
On Fri, 17 May 2024 18:04:02 GMT, Justin Lu wrote:
> Please review this PR which is a trivial update to the IANA sub tag registry
> to version 2024-05-16. Locale tests pass as expected after update.
>
> Associated announcement ->
>
On Wed, 15 May 2024 17:05:17 GMT, Naoto Sato wrote:
>> Proposing new overloaded methods in `java.io.Console` class that explicitly
>> take a `Locale` argument. Existing methods rely on the default locale, so
>> the users won't be able to format their prompts/outputs i
On Mon, 29 Apr 2024 19:40:31 GMT, Naoto Sato wrote:
> A new method on Instant to return the duration `until` another Instant is
> suggested per the following discussion thread:
>
> https://mail.openjdk.org/pipermail/core-libs-dev/2024-April/122131.html
>
> A CSR has
On Wed, 1 May 2024 17:21:20 GMT, Naoto Sato wrote:
>> A new method on Instant to return the duration `until` another Instant is
>> suggested per the following discussion thread:
>>
>> https://mail.openjdk.org/pipermail/core-libs-dev/2024-April/122131.html
>>
On Tue, 23 Apr 2024 20:35:43 GMT, Naoto Sato wrote:
> Proposing new overloaded methods in `java.io.Console` class that explicitly
> take a `Locale` argument. Existing methods rely on the default locale, so the
> users won't be able to format their prompts/outputs in a certa
> Proposing new overloaded methods in `java.io.Console` class that explicitly
> take a `Locale` argument. Existing methods rely on the default locale, so the
> users won't be able to format their prompts/outputs in a certain locale
> explicitly.
Naoto Sato has updated the
> Proposing new overloaded methods in `java.io.Console` class that explicitly
> take a `Locale` argument. Existing methods rely on the default locale, so the
> users won't be able to format their prompts/outputs in a certain locale
> explicitly.
Naoto Sato has updated the
On Mon, 13 May 2024 09:56:35 GMT, Pavel Rappo wrote:
>> Please review this PR which introduces the `java.io.IO` top-level class and
>> three methods to `java.io.Console` for [Implicitly Declared Classes and
>> Instance Main Methods (Third Preview)].
>>
>> This PR has been obtained as `git
> Making sure `restoreEcho` correctly reflects the state in the shutdown
> thread, which differs from the application's thread that issues the
> `readPassword()` method.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
copyr
> Making sure `restoreEcho` correctly reflects the state in the shutdown
> thread, which differs from the application's thread that issues the
> `readPassword()` method.
Naoto Sato has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev
On Mon, 13 May 2024 21:32:18 GMT, Naoto Sato wrote:
>> Making sure `restoreEcho` correctly reflects the state in the shutdown
>> thread, which differs from the application's thread that issues the
>> `readPassword()` method.
>
> Naoto Sato has updated the pull reques
> Proposing new overloaded methods in `java.io.Console` class that explicitly
> take a `Locale` argument. Existing methods rely on the default locale, so the
> users won't be able to format their prompts/outputs in a certain locale
> explicitly.
Naoto Sato has updated the
On Mon, 13 May 2024 21:32:18 GMT, Naoto Sato wrote:
>> Making sure `restoreEcho` correctly reflects the state in the shutdown
>> thread, which differs from the application's thread that issues the
>> `readPassword()` method.
>
> Naoto Sato has updated the pull reques
On Mon, 13 May 2024 21:32:18 GMT, Naoto Sato wrote:
>> Making sure `restoreEcho` correctly reflects the state in the shutdown
>> thread, which differs from the application's thread that issues the
>> `readPassword()` method.
>
> Naoto Sato has updated the pull reques
On Mon, 13 May 2024 17:06:32 GMT, Naoto Sato wrote:
>> Making sure `restoreEcho` correctly reflects the state in the shutdown
>> thread, which differs from the application's thread that issues the
>> `readPassword()` method.
>
> Naoto Sato has updated the pull reques
> Making sure `restoreEcho` correctly reflects the state in the shutdown
> thread, which differs from the application's thread that issues the
> `readPassword()` method.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
n addition to Instant, the LocalTime class might also benefit from adding:
public Duration until(LocalTime endExclusive)`
The API design of java.time included an emphasis on consistent naming
across the packages.
Regards, Roger
On 5/2/24 4:01 PM, Naoto Sato wrote:
`Temporal` interface is clea
On Mon, 13 May 2024 17:06:32 GMT, Naoto Sato wrote:
>> Making sure `restoreEcho` correctly reflects the state in the shutdown
>> thread, which differs from the application's thread that issues the
>> `readPassword()` method.
>
> Naoto Sato has updated the pull reques
> Making sure `restoreEcho` correctly reflects the state in the shutdown
> thread, which differs from the application's thread that issues the
> `readPassword()` method.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
> Making sure `restoreEcho` correctly reflects the state in the shutdown
> thread, which differs from the application's thread that issues the
> `readPassword()` method.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
U
Making sure `restoreEcho` correctly reflects the state in the shutdown thread,
which differs from the application's thread that issues the `readPassword()`
method.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/19184/files
Webrev:
On Fri, 10 May 2024 14:54:10 GMT, Pavel Rappo wrote:
>> src/java.base/share/classes/jdk/internal/io/JdkConsoleImpl.java line 61:
>>
>>> 59: @Override
>>> 60: public JdkConsole println(Object obj) {
>>> 61: pw.println(obj);
>>
>> Are these `println(...)` and `print(...)` methods
On Wed, 8 May 2024 20:21:50 GMT, Naoto Sato wrote:
> In order to enlighten users to not depend on a particular version of the
> locale data, putting a note into the JDK vs. CLDR version chart would be
> appropriate.
This pull request has now been integrated.
Changeset: 65abf2
On Thu, 9 May 2024 09:10:20 GMT, serhiysachkov wrote:
>> Calendar.add() tests that describe its behavior.
>
> serhiysachkov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8331646 updating impl according to review requests
LGTM.
On Thu, 9 May 2024 16:57:49 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three addi
> In order to enlighten users to not depend on a particular version of the
> locale data, putting a note into the JDK vs. CLDR version chart would be
> appropriate.
Naoto Sato has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev
On Mon, 6 May 2024 17:53:56 GMT, Naoto Sato wrote:
> This PR is to implement the `nonlikelyScript` feature that went into CLDR
> version 45 for migration purposes. In its release note, it states
> (https://cldr.unicode.org/index/downloads/cldr-45):
>
> Migration
> Change
On Wed, 8 May 2024 11:36:07 GMT, serhiysachkov wrote:
>> Calendar.add() tests that describe its behavior.
>
> serhiysachkov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8331646 consolidating test methods into ParameterizedTests
In order to enlighten users to not depend on a particular version of the locale
data, putting a note into the JDK vs. CLDR version chart would be appropriate.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/19145/files
Webrev:
On Wed, 8 May 2024 17:30:22 GMT, Claes Redestad wrote:
>> A rather large startup regression was introduced in 23-b13 from
>> [JDK-8309622](https://bugs.openjdk.org/browse/JDK-8309622). Some of that has
>> been dealt with as enhancements such as
>>
On Wed, 8 May 2024 17:30:22 GMT, Claes Redestad wrote:
>> A rather large startup regression was introduced in 23-b13 from
>> [JDK-8309622](https://bugs.openjdk.org/browse/JDK-8309622). Some of that has
>> been dealt with as enhancements such as
>>
> Proposing new overloaded methods in `java.io.Console` class that explicitly
> take a `Locale` argument. Existing methods rely on the default locale, so the
> users won't be able to format their prompts/outputs in a certain locale
> explicitly.
Naoto Sato has updated the
On Tue, 7 May 2024 17:15:43 GMT, Pavel Rappo wrote:
>> test/jdk/java/io/IO/IO.java line 99:
>>
>>> 97: System.getProperty("test.jdk") + "/bin/java",
>>> 98: "--enable-preview",
>>> 99: "-Djdk.console=gibberish",
>>
>> The test comment suggests
On Tue, 7 May 2024 09:44:09 GMT, serhiysachkov wrote:
>> Calendar.add() tests that describe its behavior.
>
> serhiysachkov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8331646 updating to ParameterizedTests according to review
On Mon, 6 May 2024 21:45:12 GMT, Pavel Rappo wrote:
> Please review this PR which introduces the `java.io.IO` top-level class and
> three methods to `java.io.Console` for [Implicitly Declared Classes and
> Instance Main Methods (Third Preview)].
>
> This PR has been obtained as `git merge
> Proposing new overloaded methods in `java.io.Console` class that explicitly
> take a `Locale` argument. Existing methods rely on the default locale, so the
> users won't be able to format their prompts/outputs in a certain locale
> explicitly.
Naoto Sato has updated the
On Mon, 6 May 2024 17:52:07 GMT, Justin Lu wrote:
>> Please review this PR which corrects an edge case bug for
>> java.text.DecimalFormat that causes incorrect parsing results for strings
>> with very large exponent values.
>>
>> When parsing values with large exponents, if the value of the
On Fri, 3 May 2024 10:31:14 GMT, serhiysachkov wrote:
> Calendar.add() tests that describe its behavior.
I would prefer those test values are parametrized.
-
PR Review: https://git.openjdk.org/jdk/pull/19082#pullrequestreview-2041403213
This PR is to implement the `nonlikelyScript` feature that went into CLDR
version 45 for migration purposes. In its release note, it states
(https://cldr.unicode.org/index/downloads/cldr-45):
Migration
Changes to parentLocales require upgrading implementations that use that
element. In
On Mon, 6 May 2024 16:09:19 GMT, Jan Lahoda wrote:
>> When JLine reads a line, there may be a prompt provided. However, JLine will
>> not interpret the prompt literally, it will handle `%` specially. As a
>> consequence, doing:
>>
>> System.console().readLine("%%s");
>>
>>
>> will not print
On Mon, 6 May 2024 16:05:58 GMT, Jan Lahoda wrote:
>>> We have a test that checks if `System.console()` returns the correct
>>> Console (or null) from the expected module
>>> (`test/jdk/java/io/Console/ModuleSelectionTest.java`)
>>>
>>
>> Good; then here we should indeed specify
On Fri, 3 May 2024 18:52:12 GMT, Pavel Rappo wrote:
> Ideally, we should have separate tests that make sure that jdk.internal.le is
> the default impl.
We have a test that checks if `System.console()` returns the correct Console
(or null) from the expected module
On Fri, 3 May 2024 18:29:23 GMT, Justin Lu wrote:
>> Please review this PR which corrects an edge case bug for
>> java.text.DecimalFormat that causes incorrect parsing results for strings
>> with very large exponent values.
>>
>> When parsing values with large exponents, if the value of the
On Fri, 3 May 2024 08:47:03 GMT, Justin Lu wrote:
> Please review this PR which corrects an edge case bug for
> java.text.DecimalFormat that causes incorrect parsing results for strings
> with very large exponent values.
>
> When parsing values with large exponents, if the value of the
On Fri, 3 May 2024 11:12:48 GMT, Pavel Rappo wrote:
>> When JLine reads a line, there may be a prompt provided. However, JLine will
>> not interpret the prompt literally, it will handle `%` specially. As a
>> consequence, doing:
>>
>> System.console().readLine("%%s");
>>
>>
>> will not
On Thu, 2 May 2024 20:54:58 GMT, Naoto Sato wrote:
> Fixing a comment in `java.io.Console`, which was a leftover from the fix to
> https://bugs.openjdk.org/browse/JDK-8308591
This pull request has now been integrated.
Changeset: cf2c80e4
Author: Naoto Sato
URL:
On Thu, 2 May 2024 20:54:58 GMT, Naoto Sato wrote:
> Fixing a comment in `java.io.Console`, which was a leftover from the fix to
> https://bugs.openjdk.org/browse/JDK-8308591
Thank you for the reviews!
-
PR Comment: https://git.openjdk.org/jdk/pull/19070#issuecomment-2093318995
> Fixing a comment in `java.io.Console`, which was a leftover from the fix to
> https://bugs.openjdk.org/browse/JDK-8308591
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Update src/java.base/share/classes/java/io/Consol
Fixing a comment in `java.io.Console`, which was a leftover from the fix to
https://bugs.openjdk.org/browse/JDK-8308591
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/19070/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=19070=00
Issue:
`Temporal` interface is clear that its `minus` methods return objects of
the same `Temporal` type, and `until` calculates the amount of time
until another `Temporal` type. Introducing `Instant.minus` that returns
`Duration` would be confusing to me.
Naoto
On 5/2/24 10:41 AM, Éamonn McManus
On Wed, 1 May 2024 17:21:20 GMT, Naoto Sato wrote:
>> A new method on Instant to return the duration `until` another Instant is
>> suggested per the following discussion thread:
>>
>> https://mail.openjdk.org/pipermail/core-libs-dev/2024-April/122131.html
>>
On Wed, 1 May 2024 20:35:10 GMT, Justin Lu wrote:
>> Please review this PR which converts _TestEncodingDecodingLength.java_ into
>> a whitebox test which allows for testing to be done without memory usage
>> issues.
>>
>> Currently, the test requires about ~2.75 `Integer.MAX_VALUE` sized byte
On Wed, 1 May 2024 18:52:06 GMT, Justin Lu wrote:
>> Please review this PR which converts _TestEncodingDecodingLength.java_ into
>> a whitebox test which allows for testing to be done without memory usage
>> issues.
>>
>> Currently, the test requires about ~2.75 `Integer.MAX_VALUE` sized byte
On Tue, 30 Apr 2024 15:02:21 GMT, Jan Lahoda wrote:
>> Consider code like:
>>
>> public class ConsoleTest {
>> public static void main(String... args) {
>> System.console().printf("Hello!");
>> }
>> }
>>
>>
>> When run as:
>>
>> $ java ConsoleTest.java >/dev/null
>>
>>
>>
On Wed, 1 May 2024 17:10:53 GMT, Roger Riggs wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressed review comments
>
> src/java.base/share/classes/java/io/ProxyingConsole.java li
> A new method on Instant to return the duration `until` another Instant is
> suggested per the following discussion thread:
>
> https://mail.openjdk.org/pipermail/core-libs-dev/2024-April/122131.html
>
> A CSR has also been drafted.
Naoto Sato has updated the pull req
On Mon, 29 Apr 2024 21:54:55 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressed review comments
>
> src/java.base/share/classes/java/io/Console.java line 193:
&
On Tue, 23 Apr 2024 20:35:43 GMT, Naoto Sato wrote:
> Proposing new overloaded methods in `java.io.Console` class that explicitly
> take a `Locale` argument. Existing methods rely on the default locale, so the
> users won't be able to format their prompts/outputs in a certa
> Proposing new overloaded methods in `java.io.Console` class that explicitly
> take a `Locale` argument. Existing methods rely on the default locale, so the
> users won't be able to format their prompts/outputs in a certain locale
> explicitly.
Naoto Sato has updated the
> A new method on Instant to return the duration `until` another Instant is
> suggested per the following discussion thread:
>
> https://mail.openjdk.org/pipermail/core-libs-dev/2024-April/122131.html
>
> A CSR has also been drafted.
Naoto Sato has updated the pull req
A new method on Instant to return the duration `until` another Instant is
suggested per the following discussion thread:
https://mail.openjdk.org/pipermail/core-libs-dev/2024-April/122131.html
A CSR has also been drafted.
-
Commit messages:
- Prefer until over between
- nonnull
On Mon, 29 Apr 2024 14:56:23 GMT, Jan Lahoda wrote:
>> Consider code like:
>>
>> public class ConsoleTest {
>> public static void main(String... args) {
>> System.console().printf("Hello!");
>> }
>> }
>>
>>
>> When run as:
>>
>> $ java ConsoleTest.java >/dev/null
>>
>>
>>
On Fri, 26 Apr 2024 18:15:12 GMT, Justin Lu wrote:
>> Correct a misleading example in the DateFormat parse documentation.
>>
>> Common usage is to use a factory instance. The original example provided
>> assumes a pattern provided by a COMPAT factory instance.
>>
>> The pattern itself should
On Thu, 25 Apr 2024 21:32:03 GMT, Joe Darcy wrote:
> Remove unnecessary setting of variable y, found by an IDE inspection noted in
> the bug report.
Marked as reviewed by naoto (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18963#pullrequestreview-2023687212
On Mon, 22 Apr 2024 18:44:33 GMT, Naoto Sato wrote:
> Upgrading the CLDR to version 45.0. We now have versions specified in the
> javadoc (`LocaleServiceProvider`), a corresponding CSR has also been drafted.
This pull request has now been integrated.
Changeset: 1c238d43
Author: Naot
Proposing new overloaded methods in `java.io.Console` class that explicitly
take a `Locale` argument. Existing methods rely on the default locale, so the
users won't be able to format their prompts/outputs in a certain locale
explicitly.
-
Commit messages:
- Not using System.err
Upgrading the CLDR to version 45.0. We now have versions specified in the
javadoc (`LocaleServiceProvider`), a corresponding CSR has also been drafted.
-
Commit messages:
- .md files
- release-45
- Fix tests for CLDR-17482 Fix million compact number issue in Italian
-
On Mon, 22 Apr 2024 14:11:41 GMT, Claes Redestad wrote:
>> This switch expression in `Locale::createLocale` is causing a somewhat large
>> startup regression on my local system. Desugaring to if statements seem like
>> the right thing to do while we investigate ways to further reduce overheads
On Fri, 19 Apr 2024 19:21:13 GMT, Jonathan Gibbons wrote:
>> Please review a set of updates to clean up use of `/**` comments in the
>> vicinity of declarations.
>>
>> There are various categories of update:
>>
>> * "Box comments" beginning with `/**`
>> * Misplaced doc comments before
On Fri, 19 Apr 2024 19:21:13 GMT, Jonathan Gibbons wrote:
>> Please review a set of updates to clean up use of `/**` comments in the
>> vicinity of declarations.
>>
>> There are various categories of update:
>>
>> * "Box comments" beginning with `/**`
>> * Misplaced doc comments before
On Thu, 18 Apr 2024 21:54:26 GMT, Joe Wang wrote:
>> Add two sample configuration files:
>>
>> jaxp-strict.properties: used to set strict configuration, stricter than
>> jaxp.properties in previous versions such as JDK 22
>>
>> jaxp-compat.properties: used to regain compatibility from any
On Wed, 17 Apr 2024 17:16:55 GMT, Justin Lu wrote:
>> Please review this PR which is a large spec reformatting for
>> _java.text.NumberFormat_ and related subclasses, specifically DecimalFormat
>> and CompactNumberFormat.
>>
>> The motivation for this change was the difficulty of readability
On Tue, 16 Apr 2024 22:30:47 GMT, Justin Lu wrote:
>> src/java.base/share/classes/java/text/CompactNumberFormat.java line 78:
>>
>>> 76: * installed. Thus, to use an instance method defined by {@code
>>> CompactNumberFormat},
>>> 77: * the {@code NumberFormat} returned by the factory method
On Tue, 16 Apr 2024 19:44:36 GMT, Roger Riggs wrote:
> The method `java.io.ObjectOutputStream.PutField.write` has been deprecated
> since 1.4 and should be deprecated for removal. The Deprecation annotation is
> updated to indicate the intention to remov the method.
Marked as reviewed by
On Tue, 16 Apr 2024 17:06:50 GMT, Justin Lu wrote:
>> Justin Lu has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains five commits:
>>
>> - merge master and add setStrict() to nFmt class spec
>> - implement suggestions from dFmt
On Tue, 16 Apr 2024 17:12:06 GMT, Justin Lu wrote:
>> Please review this PR which is a large spec reformatting for
>> _java.text.NumberFormat_ and related subclasses, specifically DecimalFormat
>> and CompactNumberFormat.
>>
>> The motivation for this change was the difficulty of readability
On Tue, 16 Apr 2024 06:08:00 GMT, Jaikiran Pai wrote:
> Naoto, Roger, should we consider a release note for this change or is the CSR
> itself enough?
I think CSR is enough, as users' chance of encountering any issue is very slim.
My $0.02
-
PR Comment:
On Mon, 15 Apr 2024 19:39:41 GMT, Naoto Sato wrote:
> Fixing a typo in the javadoc
This pull request has now been integrated.
Changeset: 2ede1433
Author: Naoto Sato
URL:
https://git.openjdk.org/jdk/commit/2ede14335a2c9133bf4f356189cfbd5839361d17
Stats: 2 lines in 1 file chan
On Mon, 15 Apr 2024 19:39:41 GMT, Naoto Sato wrote:
> Fixing a typo in the javadoc
Thanks for the reviews!
-
PR Comment: https://git.openjdk.org/jdk/pull/18788#issuecomment-2059441642
Fixing a typo in the javadoc
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/18788/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=18788=00
Issue: https://bugs.openjdk.org/browse/JDK-8330279
Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2
On Wed, 10 Apr 2024 20:16:50 GMT, Justin Lu wrote:
> Please review this PR which is a large spec reformatting for
> _java.text.NumberFormat_ and related subclasses, specifically DecimalFormat
> and CompactNumberFormat.
>
> The motivation for this change was the difficulty of readability for
On Wed, 10 Apr 2024 20:16:50 GMT, Justin Lu wrote:
> Please review this PR which is a large spec reformatting for
> _java.text.NumberFormat_ and related subclasses, specifically DecimalFormat
> and CompactNumberFormat.
>
> The motivation for this change was the difficulty of readability for
On Wed, 10 Apr 2024 20:16:50 GMT, Justin Lu wrote:
> Please review this PR which is a large spec reformatting for
> _java.text.NumberFormat_ and related subclasses, specifically DecimalFormat
> and CompactNumberFormat.
>
> The motivation for this change was the difficulty of readability for
On Thu, 11 Apr 2024 20:55:11 GMT, Justin Lu wrote:
>> Please review this PR and associated
>> [CSR](https://bugs.openjdk.org/browse/JDK-8327703) which introduces strict
>> parsing for NumberFormat.
>>
>> The concrete subclasses that will utilize this leniency value are
>> `DecimalFormat` and
On Wed, 10 Apr 2024 20:20:36 GMT, Justin Lu wrote:
>> Please review this PR and associated
>> [CSR](https://bugs.openjdk.org/browse/JDK-8327703) which introduces strict
>> parsing for NumberFormat.
>>
>> The concrete subclasses that will utilize this leniency value are
>> `DecimalFormat` and
On Wed, 10 Apr 2024 16:17:32 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix the issue
>> noted in https://bugs.openjdk.org/browse/JDK-8212895?
>>
>> As noted in that issue, the `ChronoField.INSTANT_SECONDS` currently is
>> initialized to have a
On Wed, 10 Apr 2024 01:31:36 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/java/time/temporal/ChronoField.java line 590:
>>
>>> 588: * This is necessary to ensure interoperation between calendars.
>>> 589: *
>>> 590: * Range of {@code InstantSeconds} is between {@link
On Tue, 9 Apr 2024 08:37:29 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix the issue
>> noted in https://bugs.openjdk.org/browse/JDK-8212895?
>>
>> As noted in that issue, the `ChronoField.INSTANT_SECONDS` currently is
>> initialized to have a
On Tue, 9 Apr 2024 00:52:43 GMT, Jaikiran Pai wrote:
>> The code should reference the constants in Instant.java (though may need to
>> make them package private.)
>>
>> The javadoc can/should reference Instant.MIN and Instant.MAX (as the test
>> does).
>
> Hello Roger,
>
>> The code should
On Mon, 8 Apr 2024 09:52:39 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to fix the issue
> noted in https://bugs.openjdk.org/browse/JDK-8212895?
>
> As noted in that issue, the `ChronoField.INSTANT_SECONDS` currently is
> initialized to have a minimum
On Fri, 5 Apr 2024 17:22:36 GMT, Naoto Sato wrote:
> Fix a file/class name in the `CLDRConverter` build tool, with some clean-up
> for a switch statement.
This pull request has now been integrated.
Changeset: dd930c57
Author: Naoto Sato
URL:
https://git.openjdk.org/jdk/
On Fri, 5 Apr 2024 17:22:36 GMT, Naoto Sato wrote:
> Fix a file/class name in the `CLDRConverter` build tool, with some clean-up
> for a switch statement.
Thanks for the reviews!
-
PR Comment: https://git.openjdk.org/jdk/pull/18662#issuecomment-2043177032
On Fri, 5 Apr 2024 21:57:15 GMT, Roger Riggs wrote:
> The test doesn't run quickly already due to the large chunks of memory used.
OK, never mind then, if it would take considerable time.
-
PR Comment: https://git.openjdk.org/jdk/pull/18663#issuecomment-2040706486
On Fri, 5 Apr 2024 17:44:38 GMT, Roger Riggs wrote:
> When encoding a vary large string in String.getBytes(StandardCharset.UTF_8)
> computation of the buffer size may exceed the range of a positive 32-bit
> Integer.
> If the estimated size for the result byte array is too large, pre-compute
Fix a file/class name in the `CLDRConverter` build tool, with some clean-up for
a switch statement.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/18662/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=18662=00
Issue:
On Thu, 4 Apr 2024 17:16:22 GMT, Mahendra Chhipa wrote:
>> Updated following tests to use ProcessTools methods:
>> test/jdk/java/lang/Thread/UncaughtExceptionsTest.java
>> test/jdk/java/lang/annotation/LoaderLeakTest.java
>> test/jdk/java/rmi/reliability/benchmark/bench/rmi/Main.java
>>
On Wed, 3 Apr 2024 11:47:45 GMT, Mahendra Chhipa wrote:
> Updated following tests to use ProcessTools methods:
> test/jdk/java/lang/Thread/UncaughtExceptionsTest.java
> test/jdk/java/lang/annotation/LoaderLeakTest.java
> test/jdk/java/rmi/reliability/benchmark/bench/rmi/Main.java
>
On Wed, 3 Apr 2024 19:01:14 GMT, Brian Burkhalter wrote:
> Clarify the behavior of `append` for a `null` `CharSequence` parameter and
> clean up a couple of other typos.
Marked as reviewed by naoto (Reviewer).
-
PR Review:
On Sat, 30 Mar 2024 02:26:32 GMT, Jie Fu wrote:
> Hi all,
>
> java/text/Format/MessageFormat/CompactSubFormats.java fails in our testing
> machines.
> I'm not an expert in this area and just guess it can be fixed like this.
> Please review it.
>
> Thanks.
> Best regards,
> Jie
LGTM. Thanks
1 - 100 of 1173 matches
Mail list logo