On Wed, 17 Apr 2024 12:35:54 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional
>
On Wed, 17 Apr 2024 12:35:54 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional
>
On Wed, 17 Apr 2024 19:45:02 GMT, Dean Long wrote:
>> Yudi Zheng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> address comment.
>
> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 4702:
>
>> 4700: const Register tmp5 =
On Wed, 17 Apr 2024 12:35:54 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional
>
On Wed, 17 Apr 2024 12:35:54 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional
>
On Tue, 26 Mar 2024 15:59:33 GMT, Damon Fenacci wrote:
>> Yudi Zheng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> address comment.
>
> `multiply_to_len` seems to be used by `generate_squareToLen` as well for
> aarch64 and riscv but
On Tue, 26 Mar 2024 15:59:33 GMT, Damon Fenacci wrote:
>> Yudi Zheng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> address comment.
>
> `multiply_to_len` seems to be used by `generate_squareToLen` as well for
> aarch64 and riscv but
> Moving array construction within BigInteger.implMultiplyToLen intrinsic
> candidate to its caller simplifies the intrinsic implementation in JIT
> compiler.
Yudi Zheng has updated the pull request incrementally with one additional
commit since the last revision:
address comment.
> Moving array construction within BigInteger.implMultiplyToLen intrinsic
> candidate to its caller simplifies the intrinsic implementation in JIT
> compiler.
Yudi Zheng has updated the pull request incrementally with one additional
commit since the last revision:
address comment.
On Tue, 19 Mar 2024 21:09:31 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional
>
> Moving array construction within BigInteger.implMultiplyToLen intrinsic
> candidate to its caller simplifies the intrinsic implementation in JIT
> compiler.
Yudi Zheng has updated the pull request incrementally with one additional
commit since the last revision:
address comment.
On Tue, 19 Mar 2024 19:06:36 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional
>
On Tue, 19 Mar 2024 19:06:36 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional
>
> Moving array construction within BigInteger.implMultiplyToLen intrinsic
> candidate to its caller simplifies the intrinsic implementation in JIT
> compiler.
Yudi Zheng has updated the pull request incrementally with one additional
commit since the last revision:
address comment.
On Mon, 18 Mar 2024 16:55:28 GMT, Damon Fenacci wrote:
> Quite a simplification! Have you checked if there are any performance
> differences?
Ran
https://github.com/oracle/graal/blob/master/compiler/src/org.graalvm.micro.benchmarks/src/micro/benchmarks/BigIntegerBenchmark.java
The results are
On Tue, 12 Mar 2024 10:44:54 GMT, Yudi Zheng wrote:
> Moving array construction within BigInteger.implMultiplyToLen intrinsic
> candidate to its caller simplifies the intrinsic implementation in JIT
> compiler.
src/hotspot/share/opto/library_call.cpp line 5934:
> 5932: // 'y_start'
On Tue, 12 Mar 2024 10:44:54 GMT, Yudi Zheng wrote:
> Moving array construction within BigInteger.implMultiplyToLen intrinsic
> candidate to its caller simplifies the intrinsic implementation in JIT
> compiler.
src/java.base/share/classes/java/math/BigInteger.java line 1836:
> 1834:
> 1835:
On Tue, 12 Mar 2024 10:44:54 GMT, Yudi Zheng wrote:
> Moving array construction within BigInteger.implMultiplyToLen intrinsic
> candidate to its caller simplifies the intrinsic implementation in JIT
> compiler.
Quite a simplification!
Have you checked if there are any performance differences?
Moving array construction within BigInteger.implMultiplyToLen intrinsic
candidate to its caller simplifies the intrinsic implementation in JIT compiler.
-
Commit messages:
- Simplify BigInteger.implMultiplyToLen intrinsic
Changes: https://git.openjdk.org/jdk/pull/18226/files
19 matches
Mail list logo
