Re: Apache ZooKeeper meetup May 9th in Palo Alto?

2018-04-27 Thread Brian Nixon
Thanks for setting up a broadcast! I know there's interest in following along with the meetup from Seattle so it's awesome that you're doing it. -Brian On Thu, Apr 26, 2018 at 11:40 AM, Patrick Hunt wrote: > Ok folks, here are the details. LMK if there are any questions or

Re: Improving test cases

2018-05-18 Thread Brian Nixon
Hi Prasanth, If you need somewhere to start, ZOOKEEPER-2421 ( https://issues.apache.org/jira/browse/ZOOKEEPER-2421) might be straightforward. :) It's also the case that there are a bunch of bug report jira's that would benefit from someone building a reproducer. For example, ZOOKEEPER-2776 (

Re: [ANNOUNCE] New ZooKeeper committer: Andor Molnar

2018-06-08 Thread Brian Nixon
Congratulations! Well deserved. On Fri, Jun 8, 2018 at 7:05 AM, Edward Ribeiro wrote: > Congratulations, Andor! :) > > E. > > Em sex, 8 de jun de 2018 10:48, Patrick Hunt escreveu: > > > The Apache ZooKeeper PMC recently extended committer karma to Andor and > he > > has accepted. Andor has

Re: Maven migration doc - thoughts and suggestions

2018-06-13 Thread Brian Nixon
Andor hit the points that I was going to highlight. Norbert, nice work pulling this together. No major red flags for me. +1 On Mon, Jun 11, 2018 at 3:29 AM, Andor Molnar wrote: > ​Hi team, > > Just a quick heads-up that we need your feedback in this doc even if it's > only +1 would be

Re: Move github discussions from JIRA comments to the JIRA worklog?

2018-05-01 Thread Brian Nixon
+1 from me will make parsing the comments a whole lot easier On Tue, Apr 24, 2018 at 12:45 AM, Tamas Penzes wrote: > +1 > Since we still have the same information just a bit better organised. > > On Tue, Apr 24, 2018 at 9:39 AM, Andor Molnar wrote: > >

Re: Re: [ANNOUNCE] New ZooKeeper committer: Abraham Fine

2018-01-30 Thread Brian Nixon
Congratulations, Abe! On Tue, Jan 30, 2018 at 3:23 AM, Michelle Tan wrote: > Congratulations Abe! :D > > Regards, > Michelle > > On Tue, Jan 30, 2018 at 11:18 AM, 岭秀 wrote: > > > Congratulations to Abe! A well-deserved honor > >

Re: Recent ZK Jenkins failures due to SSL protocol changes on central

2018-06-21 Thread Brian Nixon
+1 for discontinuing support for jdk1.6 On Thu, Jun 21, 2018 at 7:58 AM, Norbert Kalmar < nkal...@cloudera.com.invalid> wrote: > Hi Patrick, > > In my opinion terminating support for java 1.6 is a good idea. Even it's > extended support will end this year ( >

Re: ZooKeeper 3.4 to 3.5.x upgrade: "No snapshot found, but there are log entries. Something is broken!"

2018-06-21 Thread Brian Nixon
We're discussing some potential approaches to getting smooth upgrades from 3.4 to 3.5 on the issue ZOOKEEPER-3056 (thanks, Michael, for creating it). A few ideas have been proposed so far and I'm happy to see more perspectives represented there. As one way of unblocking those who need an upgrade

Re: ZK ACL question

2018-07-31 Thread Brian Nixon
Hi William, It's been a while since I've looked at this. You could double-check against how the kazoo client is handling encoding -> https://github.com/python-zk/kazoo/blob/master/kazoo/security.py#L61 . Does this help? -Brian On Wed, Jul 18, 2018 at 7:36 AM, William Jardine wrote: > Hey

Re: [SUGGESTION] Jute's place in the new directory structure

2018-08-28 Thread Brian Nixon
I still think it makes sense to keep it as a top level directory (would not include it in recipes). 'zookeeper-jute' is certainly a reasonable name. :) -Brian On Thu, Aug 23, 2018 at 7:59 AM Norbert Kalmar wrote: > Hi folks, > > So jute is a little bit the odd one out in ZooKeeper. It was

Re: [VOTE] Upgrade 3.5 and trunk to Java8

2018-03-24 Thread Brian Nixon
+1 (non-binding) On Fri, Mar 23, 2018 at 2:15 AM, Mark Fenes wrote: > +1 > > > On Thu, Mar 22, 2018 at 6:57 PM, Andor Molnar wrote: > > > Hi all, > > > > Let's start the vote on upgrading to Java8. > >

Re: New precommit job 'retest this please' trick

2018-09-25 Thread Brian Nixon
Excellent! On Mon, Sep 24, 2018 at 11:06 AM Andor Molnár wrote: > Awesome! > > > > On 09/24/2018 06:27 PM, Michael Han wrote: > >>> How the new process any different from that? > > Jenkins job triggered by "Rebuild" button can't write back the job result > > to github, leading to a yellow

Re: JAVA 11 build is broken on 3.5

2019-01-07 Thread Brian Nixon
Also worth consideration for the Netty fixes backport bundle: ZOOKEEPER-3131 org.apache.zookeeper.server.WatchManager resource leak Our experience with Netty has been positive so far though I don't think we have enough info to declare it is stable. It makes a lot of sense to me for 3.5 to use

Re: MetricsProvider..time to start?

2019-03-06 Thread Brian Nixon
I to MetricsProvider to make it possile to > model AvgMinMaxCounter (Summary without percentiles) > > Let's follow up on the patch > > Regards > Enrico > > Il giorno sab 26 gen 2019 alle ore 08:40 Enrico Olivelli > ha scritto: > > > > > > > > Il gi

Re: Question on ZK commit/patch policy.

2019-03-04 Thread Brian Nixon
I like having JIRAs for all changes because it allows one to track all the changes to given components through the JIRA web interface and it forces the contributor to spend some time upfront making sure their change is a single coherent unit. For trivial changes like spelling, whitespace, pruning

Re: Opening 'retest maven/ant build' to the public

2019-03-21 Thread Brian Nixon
Dropping the constraint would be much appreciated :) On Thu, Mar 21, 2019 at 10:32 AM Patrick Hunt wrote: > Seems reasonable. If it's abused we can always revert. > > Patrick > > On Thu, Mar 21, 2019 at 9:59 AM Enrico Olivelli > wrote: > > > Hi Zookeepers, > > Currently only apache committers

Re: Broken build

2019-01-30 Thread Brian Nixon
ZOOKEEPER-3240 is my patch - I'll see if I can figure out what the problem is. On Wed, Jan 30, 2019 at 7:54 AM Andor Molnar wrote: > This doesn't look good yet. > Let's give it some time (til tomorrow) to recover. > > Andor > > > > On Wed, Jan 30, 2019 at 12:08 PM Andor Molnar wrote: > > >

Re: GitHub "god" mode

2019-01-30 Thread Brian Nixon
Thanks, Andor :) On Wed, Jan 30, 2019 at 8:18 AM Andor Molnar wrote: > We're down to 4 pages of open PRs (from 7). > Sorry for the huge number of "closed pull request" emails. > > Andor > > > > On Wed, Jan 30, 2019 at 4:08 PM Camille Fournier > wrote: > > > Wow thanks Andor! > > > > On Wed,

Re: MetricsProvider..time to start?

2019-01-25 Thread Brian Nixon
Hi Enrico, Most of the major remaining contributions from the Facebook engineers around metrics are captured in https://issues.apache.org/jira/browse/ZOOKEEPER-3245 and our attention is still focused on upstreaming that and other work. We'd like to see the metrics provider work move forward

Re: [DISCUSS] Voting on pull requests

2019-06-06 Thread Brian Nixon
The community should absolutely stand by its bylaws. :) Those two pull requests (899 and 944) were mine so I'd like to sketch what I saw as a contributor and hopefully figure out a healthier way forward. Both were opened in the last two months and got reviewer action within days. There was a

Re: [ANNOUNCE] New ZooKeeper committer: Enrico Olivelli

2019-05-28 Thread Brian Nixon
Awesome! Congrats, Enrico! On Mon, May 27, 2019 at 3:56 AM Andor Molnar wrote: > Congratulations Enrico. > > Andor > > > > On Mon, May 27, 2019 at 11:04 AM Tamas Penzes > > wrote: > > > Congrats Enrico! > > > > On Sun, May 26, 2019 at 11:19 PM Patrick Hunt wrote: > > > > > The Apache

Re: [ANNOUNCE] New ZooKeeper committer: Norbert Kalmar

2019-05-28 Thread Brian Nixon
Congrats, Norbert! Well earned. On Mon, May 27, 2019 at 3:49 AM Andor Molnar wrote: > Congratulations Norbert! > > Andor > > > > On Mon, May 27, 2019 at 11:52 AM Flavio Junqueira wrote: > > > Congrats, Norbert! > > > > -Flavio > > > > > On 27 May 2019, at 11:01, Tamas Penzes > > wrote: > > >

Re: Heads up! Ant precommit disabled

2019-06-12 Thread Brian Nixon
Nice! On Wed, Jun 12, 2019 at 8:50 AM Enrico Olivelli wrote: > Hi all, > I have disabled the ant based precommit job for pull requests targeting > 'master' branch. > > A note for committers: most of pending pull requests ran the ant job. You > can ignore it > > I will update the wiki > > Enrico

Re: Broken build

2019-06-21 Thread Brian Nixon
Finally got around to looking at this issue. https://github.com/apache/zookeeper/pull/996 may suffice to address the breaking test. On Wed, Jan 30, 2019 at 2:39 PM Brian Nixon wrote: > ZOOKEEPER-3240 is my patch - I'll see if I can figure out what the problem > is. > > > On We

Re: [ANNOUNCE] New ZooKeeper PMC member: Andor Molnar

2019-04-29 Thread Brian Nixon
Awesome! Congrats, Andor, you've been doing great work! On Mon, Apr 29, 2019 at 7:31 AM Patrick Hunt wrote: > Kudos Andor! > > Patrick > > On Mon, Apr 29, 2019 at 2:07 AM Enrico Olivelli > wrote: > > > Congratulations! > > > > Enrico > > > > Il lun 29 apr 2019, 10:40 Norbert Kalmar > ha > >

Re: [Suggestion] Use Co-authored-by in commit messages

2019-05-08 Thread Brian Nixon
+1 to the idea of multiple authors, particularly for rescued code -1 to including all reviewers in the commit proper, this information is easily enough found from poking at the mail archive where "original author" requires studying a ticket on jira awesome idea! On Wed, May 8, 2019 at 6:32 AM

Re: The ZooKeeper Grafana dashboard is now available

2019-07-10 Thread Brian Nixon
Looking really good! Nice work. On Wed, Jul 10, 2019 at 3:57 AM Andor Molnar wrote: > Awesome work Justin ! > > Andor > > > > On 2019. Jul 9., at 8:41, Justin Ling Mao > wrote: > > > > - Due to the work from ZOOKEEPER-3447( > https://github.com/apache/zookeeper/pull/1008), the ZooKeeper

Re: Great talk from Ben Reed about the origins of ZooKeeper

2019-06-28 Thread Brian Nixon
It's great to hear the mindset that the ZooKeeper team was applying in the early days. Some good advice there. On Wed, Jun 26, 2019 at 8:42 PM Alexander Shraer wrote: > https://atscaleconference.com/videos/systems-scale-2019-welcome-keynote/ >

Re: Cutting Zookeeper 3.5.6

2019-08-29 Thread Brian Nixon
I agree that ZOOKEEPER-3056 would be super nice to have in 3.5.6. Don't know what shape the solution should be but don't think it requires that much code - just thinking and community agreement. On Thu, Aug 29, 2019 at 4:31 PM Michael Han wrote: > ZOOKEEPER-3056 would be nice to have, I'll

Re: [VOTE] Drop Java 9 support

2019-07-09 Thread Brian Nixon
+1 (nonbinding) On Tue, Jul 9, 2019 at 1:50 AM Enrico Olivelli wrote: > +1 > > Enrico > > Il mar 9 lug 2019, 10:43 Andor Molnar ha scritto: > > > Hi ZK dev team, > > > > Considering Enrico’s suggestion on the other thread (“Jenkins Ant > > failures”) and because Java 9 builds are all broken at

Re: Getting value as FALSE of flag clientConfig.getBoolean(ZKClientConfig.SECURE_CLIENT) in ClientCnxnSocketNetty.initChannel(SocketChannel ch)

2019-11-16 Thread Brian Nixon
Hi Mohan, I'm a bit baffled as at first glance you're doing what I expect. As you're already modifying code, could you extend your changes in ZKClientConfig:: handleBackwardCompatibility so that you print out both the value of System.getProperty(SECURE_CLIENT) but also

Re: New feature in 3.5: Audit logging

2019-10-15 Thread Brian Nixon
I'd say 3.6 and not 3.5 in order to maintain the stable character of the latter. On Sat, Oct 12, 2019 at 12:05 PM Enrico Olivelli wrote: > Il ven 11 ott 2019, 23:48 Patrick Hunt ha scritto: > > > Per recent discussions we should really push for 3.6+, esp given lessons > > learned from 3.5 and

Re: [VOTE] Apache ZooKeeper release 3.5.6 candidate 2

2019-10-02 Thread Brian Nixon
NIO is still the default server factory so I'm guessing many users of 3.4 simply aren't configuring Netty. And our recommendation for users who want Netty could be to upgrade to a 3.5 release as that should be better in every way for them. Is there a principle determining the difference between

Re: [ANNOUNCE] New ZooKeeper committer: Brian Nixon

2019-10-02 Thread Brian Nixon
Thanks everyone! I'm happy to be here. :) On Wed, Oct 2, 2019 at 8:33 AM Patrick Hunt wrote: > Kudos Brian! > > Patrick > > On Wed, Oct 2, 2019 at 3:21 AM Norbert Kalmar > > wrote: > > > Congrats Brian! :) > > > > Norbert > > > > On Wed, Oct 2, 2019 at 11:22 AM Enrico Olivelli > > wrote: > >

Re: [VOTE] Apache ZooKeeper release 3.6.0 candidate 2

2020-02-08 Thread Brian Nixon
+1 - verified tests pass on both MacOS and Windows - verified documentation Note that the branch-3.6 proper does not compile and needs the fix of https://github.com/apache/zookeeper/pull/1239 (for the same reasons). On Sat, Feb 8, 2020 at 2:43 PM Michael Han wrote: > +1. > > - verified

Re: [ANNOUNCE] Enrico Olivelli new ZooKeeper PMC Member

2020-02-08 Thread Brian Nixon
A belated congratulations Enrico! Very much deserved. On Wed, Jan 22, 2020 at 12:05 PM Mohamed Jeelani wrote: > Congratulations Enrico! __ > > On 1/21/20, 1:41 PM, "Flavio Junqueira" wrote: > > I'm pleased to announce that Enrico Olivelli recently became the > newest ZooKeeper PMC member.

Re: Keep Python 2 scripts...?

2020-03-30 Thread Brian Nixon
I agree with the consensus, maintaining a single version is preferable to maintaining two. On Mon, Mar 30, 2020 at 2:28 PM tison wrote: > Never mind. Updated pr based on the consensus. > > Best, > tison. > > > Enrico Olivelli 于2020年3月31日周二 上午2:10写道: > > > Tison, > > can you please update your

[jira] [Commented] (ZOOKEEPER-2325) Data inconsistency if all snapshots empty or missing

2017-01-06 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15805547#comment-15805547 ] Brian Nixon commented on ZOOKEEPER-2325: Any word on committing this patch? I'd love

[jira] [Commented] (ZOOKEEPER-2325) Data inconsistency if all snapshots empty or missing

2017-01-08 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15810600#comment-15810600 ] Brian Nixon commented on ZOOKEEPER-2325: Thanks [~hanm]! Glad we kept the changes

[jira] [Commented] (ZOOKEEPER-261) Reinitialized servers should not participate in leader election

2016-12-06 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727016#comment-15727016 ] Brian Nixon commented on ZOOKEEPER-261: --- Ben and I discussed this offline. When starting up

[jira] [Commented] (ZOOKEEPER-2725) Upgrading to a global session fails with a multiop

2017-03-15 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927211#comment-15927211 ] Brian Nixon commented on ZOOKEEPER-2725: I messed up the name of the pull request - meant

[jira] [Created] (ZOOKEEPER-2725) Upgrading to a global session fails with a multiop

2017-03-15 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-2725: -- Summary: Upgrading to a global session fails with a multiop Key: ZOOKEEPER-2725 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2725 Project: ZooKeeper

[jira] [Commented] (ZOOKEEPER-2325) Data inconsistency if all snapshots empty or missing

2017-04-13 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968437#comment-15968437 ] Brian Nixon commented on ZOOKEEPER-2325: When a server starts up, it should always capture

[jira] [Commented] (ZOOKEEPER-2723) ConnectStringParser does not parse correctly if quorum string has znode path

2017-04-18 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973457#comment-15973457 ] Brian Nixon commented on ZOOKEEPER-2723: I'm not seeing a reference to ConnectStringParser

[jira] [Created] (ZOOKEEPER-2872) Interrupted snapshot sync causes data loss

2017-08-10 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-2872: -- Summary: Interrupted snapshot sync causes data loss Key: ZOOKEEPER-2872 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2872 Project: ZooKeeper

[jira] [Commented] (ZOOKEEPER-2357) Unhandled errors propagating through cluster

2017-11-05 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239715#comment-16239715 ] Brian Nixon commented on ZOOKEEPER-2357: Not an expert but a couple things pop out to me. One

[jira] [Commented] (ZOOKEEPER-2773) zookeeper-service

2017-11-05 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239709#comment-16239709 ] Brian Nixon commented on ZOOKEEPER-2773: there's not enough information here to go on. Did you

[jira] [Commented] (ZOOKEEPER-3056) Fails to load database with missing snapshot file but valid transaction log file

2018-06-08 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506419#comment-16506419 ] Brian Nixon commented on ZOOKEEPER-3056: We have not run an ensemble without some form

[jira] [Commented] (ZOOKEEPER-3056) Fails to load database with missing snapshot file but valid transaction log file

2018-06-08 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506687#comment-16506687 ] Brian Nixon commented on ZOOKEEPER-3056: [~mmerli] That's a very reasonable concern and I'd

[jira] [Commented] (ZOOKEEPER-2873) print error and/or abort on invalid server definition

2018-06-18 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516514#comment-16516514 ] Brian Nixon commented on ZOOKEEPER-2873: With no one commenting in almost a year, this issue

[jira] [Commented] (ZOOKEEPER-2421) testSessionReuse is commented out

2018-06-10 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507670#comment-16507670 ] Brian Nixon commented on ZOOKEEPER-2421: [~prasanthm] This is an ancient test so someone who

[jira] [Created] (ZOOKEEPER-3068) Improve C client logging of IPv6 hosts

2018-06-22 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3068: -- Summary: Improve C client logging of IPv6 hosts Key: ZOOKEEPER-3068 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3068 Project: ZooKeeper Issue

[jira] [Commented] (ZOOKEEPER-2988) NPE triggered if server receives a vote for a server id not in their voting view

2018-04-30 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458844#comment-16458844 ] Brian Nixon commented on ZOOKEEPER-2988: [~hanm] thanks for merging it to 3.5 too, I'll shut

[jira] [Commented] (ZOOKEEPER-3056) Fails to load database with missing snapshot file but valid transaction log file

2018-06-21 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519839#comment-16519839 ] Brian Nixon commented on ZOOKEEPER-3056: As a work-around for anyone currently blocked

[jira] [Updated] (ZOOKEEPER-3056) Fails to load database with missing snapshot file but valid transaction log file

2018-06-21 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brian Nixon updated ZOOKEEPER-3056: --- Attachment: snapshot.0 > Fails to load database with missing snapshot file but va

[jira] [Commented] (ZOOKEEPER-3108) deprecated myid file and use a new property "server.id" in the zoo.cfg

2018-08-01 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565814#comment-16565814 ] Brian Nixon commented on ZOOKEEPER-3108: This seems like a good idea to me (provided myid

[jira] [Commented] (ZOOKEEPER-3082) Fix server snapshot behavior when out of disk space

2018-08-01 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565860#comment-16565860 ] Brian Nixon commented on ZOOKEEPER-3082: [~andorm] my (possibly incorrect) read on ZOOKEEPER

[jira] [Created] (ZOOKEEPER-3115) Delete snapshot file on error

2018-08-08 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3115: -- Summary: Delete snapshot file on error Key: ZOOKEEPER-3115 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3115 Project: ZooKeeper Issue Type

[jira] [Commented] (ZOOKEEPER-706) large numbers of watches can cause session re-establishment to fail

2018-08-28 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595642#comment-16595642 ] Brian Nixon commented on ZOOKEEPER-706: --- I agree that the C client is still vulnerable

[jira] [Commented] (ZOOKEEPER-3131) org.apache.zookeeper.server.WatchManager resource leak

2018-08-28 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595645#comment-16595645 ] Brian Nixon commented on ZOOKEEPER-3131: I'm not sure I follow what you're proposing. Do you

[jira] [Created] (ZOOKEEPER-3137) add a utility to truncate logs to a zxid

2018-08-31 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3137: -- Summary: add a utility to truncate logs to a zxid Key: ZOOKEEPER-3137 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3137 Project: ZooKeeper Issue

[jira] [Created] (ZOOKEEPER-3142) Extend SnapshotFormatter to dump data in json format

2018-09-10 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3142: -- Summary: Extend SnapshotFormatter to dump data in json format Key: ZOOKEEPER-3142 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3142 Project: ZooKeeper

[jira] [Created] (ZOOKEEPER-3140) Allow Followers to host Observers

2018-09-07 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3140: -- Summary: Allow Followers to host Observers Key: ZOOKEEPER-3140 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3140 Project: ZooKeeper Issue Type

[jira] [Created] (ZOOKEEPER-3082) Fix server snapshot behavior when out of disk space

2018-07-05 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3082: -- Summary: Fix server snapshot behavior when out of disk space Key: ZOOKEEPER-3082 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3082 Project: ZooKeeper

[jira] [Created] (ZOOKEEPER-3083) Remove some redundant and noisy log lines

2018-07-05 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3083: -- Summary: Remove some redundant and noisy log lines Key: ZOOKEEPER-3083 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3083 Project: ZooKeeper

[jira] [Created] (ZOOKEEPER-2988) NPE triggered if server receives a vote for a server id not in their voting view

2018-03-01 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-2988: -- Summary: NPE triggered if server receives a vote for a server id not in their voting view Key: ZOOKEEPER-2988 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2988

[jira] [Commented] (ZOOKEEPER-3140) Allow Followers to host Observers

2018-10-12 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648379#comment-16648379 ] Brian Nixon commented on ZOOKEEPER-3140: A note on future work - it would be cool to see

[jira] [Created] (ZOOKEEPER-3166) Support changing secure port with reconfig

2018-10-12 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3166: -- Summary: Support changing secure port with reconfig Key: ZOOKEEPER-3166 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3166 Project: ZooKeeper

[jira] [Commented] (ZOOKEEPER-3166) Support changing secure port with reconfig

2018-10-12 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648369#comment-16648369 ] Brian Nixon commented on ZOOKEEPER-3166: It would be cool to see the serialized format

[jira] [Comment Edited] (ZOOKEEPER-3166) Support changing secure port with reconfig

2018-10-12 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648369#comment-16648369 ] Brian Nixon edited comment on ZOOKEEPER-3166 at 10/12/18 7:45 PM

[jira] [Created] (ZOOKEEPER-3252) Extend the options for the response cache

2019-01-18 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3252: -- Summary: Extend the options for the response cache Key: ZOOKEEPER-3252 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3252 Project: ZooKeeper

[jira] [Commented] (ZOOKEEPER-3180) Add response cache to improve the throughput of read heavy traffic

2019-01-18 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16746687#comment-16746687 ] Brian Nixon commented on ZOOKEEPER-3180: Creating ZOOKEEPER-3252 as a follow up. >

[jira] [Commented] (ZOOKEEPER-3218) zk server reopened,the interval for observer connect to the new leader is too long,then session expired

2018-12-26 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729186#comment-16729186 ] Brian Nixon commented on ZOOKEEPER-3218: We had similar issues which we addressed by making

[jira] [Commented] (ZOOKEEPER-2872) Interrupted snapshot sync causes data loss

2018-12-26 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729136#comment-16729136 ] Brian Nixon commented on ZOOKEEPER-2872: Now that the patch is merged, was there any further

[jira] [Commented] (ZOOKEEPER-3197) Improve documentation in ZooKeeperServer.superSecret

2018-12-26 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729138#comment-16729138 ] Brian Nixon commented on ZOOKEEPER-3197: Password is probably the wrong term

[jira] [Commented] (ZOOKEEPER-3220) The snapshot is not saved to disk and may cause data inconsistency.

2018-12-26 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729134#comment-16729134 ] Brian Nixon commented on ZOOKEEPER-3220: I believe ZOOKEEPER-2872 addressed the fsyncing part

[jira] [Created] (ZOOKEEPER-3237) Allow IPv6 wildcard address in peer config

2019-01-08 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3237: -- Summary: Allow IPv6 wildcard address in peer config Key: ZOOKEEPER-3237 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3237 Project: ZooKeeper

[jira] [Created] (ZOOKEEPER-3240) Close socket on Learner shutdown to avoid dangling socket

2019-01-10 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3240: -- Summary: Close socket on Learner shutdown to avoid dangling socket Key: ZOOKEEPER-3240 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3240 Project

[jira] [Commented] (ZOOKEEPER-3240) Close socket on Learner shutdown to avoid dangling socket

2019-01-10 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739750#comment-16739750 ] Brian Nixon commented on ZOOKEEPER-3240: This may be the same issue as detected in ZOOKEEPER

[jira] [Commented] (ZOOKEEPER-2669) follower failed to reconnect to leader after a network error

2019-01-10 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739751#comment-16739751 ] Brian Nixon commented on ZOOKEEPER-2669: Is this related to ZOOKEEPER-3240 ? > follo

[jira] [Commented] (ZOOKEEPER-3231) Purge task may lost data when we have many invalid snapshots.

2019-01-07 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736548#comment-16736548 ] Brian Nixon commented on ZOOKEEPER-3231: It might also make sense to more aggressively delete

[jira] [Commented] (ZOOKEEPER-3232) make the log of notification about LE more readable

2019-01-03 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733820#comment-16733820 ] Brian Nixon commented on ZOOKEEPER-3232: seems reasonable to me > make the

[jira] [Created] (ZOOKEEPER-3244) Add option to snapshot based on log size

2019-01-11 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3244: -- Summary: Add option to snapshot based on log size Key: ZOOKEEPER-3244 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3244 Project: ZooKeeper Issue

[jira] [Commented] (ZOOKEEPER-3240) Close socket on Learner shutdown to avoid dangling socket

2019-01-11 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740916#comment-16740916 ] Brian Nixon commented on ZOOKEEPER-3240: [~hanm] could it be that the unclosed/unreaped

[jira] [Commented] (ZOOKEEPER-3320) Leader election port stop listen when hostname unresolvable for some time

2019-03-20 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797657#comment-16797657 ] Brian Nixon commented on ZOOKEEPER-3320: A configurable retry seems like a good idea to me

[jira] [Commented] (ZOOKEEPER-3332) TxnLogToolkit should print multi transactions readably

2019-03-25 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801274#comment-16801274 ] Brian Nixon commented on ZOOKEEPER-3332: This is a really useful change. We have a couple

[jira] [Commented] (ZOOKEEPER-3333) Detect if txnlogs and / or snapshots is deleted under a running ZK instance

2019-03-25 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801160#comment-16801160 ] Brian Nixon commented on ZOOKEEPER-: I'm assuming that the scenario in mind is a rogue

[jira] [Created] (ZOOKEEPER-3331) Automatically add IP authorization for Netty connections

2019-03-22 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3331: -- Summary: Automatically add IP authorization for Netty connections Key: ZOOKEEPER-3331 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3331 Project: ZooKeeper

[jira] [Updated] (ZOOKEEPER-3349) QuorumCnxManager socketTimeout unused

2019-04-04 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brian Nixon updated ZOOKEEPER-3349: --- Description: QuorumCnxManager member variable 'socketTimeout' is not used anywhere

[jira] [Created] (ZOOKEEPER-3349) QuorumCnxManager socketTimeout unused

2019-04-04 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3349: -- Summary: QuorumCnxManager socketTimeout unused Key: ZOOKEEPER-3349 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3349 Project: ZooKeeper Issue

[jira] [Commented] (ZOOKEEPER-3318) Add a complete backup mechanism for zookeeper internal

2019-03-28 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804453#comment-16804453 ] Brian Nixon commented on ZOOKEEPER-3318: In the interest of a compact backup, I would like

[jira] [Commented] (ZOOKEEPER-3264) Add a benchmark tool for zookeeper

2019-03-04 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783824#comment-16783824 ] Brian Nixon commented on ZOOKEEPER-3264: I know that [~breed] at one point was thinking

[jira] [Created] (ZOOKEEPER-3287) admin command to dump currently known ACLs

2019-02-21 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3287: -- Summary: admin command to dump currently known ACLs Key: ZOOKEEPER-3287 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3287 Project: ZooKeeper

[jira] [Commented] (ZOOKEEPER-3318) Add a complete backup mechanism for zookeeper internal

2019-03-18 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795253#comment-16795253 ] Brian Nixon commented on ZOOKEEPER-3318: This would be great! > Add a complete bac

[jira] [Commented] (ZOOKEEPER-3320) Leader election port stop listen when hostname unresolvable for some time

2019-03-19 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796341#comment-16796341 ] Brian Nixon commented on ZOOKEEPER-3320: This is an interesting error case! I would expect

[jira] [Created] (ZOOKEEPER-3257) Merge count and byte update of Stat

2019-01-25 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3257: -- Summary: Merge count and byte update of Stat Key: ZOOKEEPER-3257 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3257 Project: ZooKeeper Issue Type

[jira] [Commented] (ZOOKEEPER-3352) Use LevelDB For Backend

2019-04-09 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813760#comment-16813760 ] Brian Nixon commented on ZOOKEEPER-3352: We've been curious whether wiring ZooKeeper on top

[jira] [Commented] (ZOOKEEPER-3343) Add a new doc: zookeeperTools.md

2019-04-08 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812869#comment-16812869 ] Brian Nixon commented on ZOOKEEPER-3343: This will be great, thanks [~maoling]! > Add a

[jira] [Created] (ZOOKEEPER-3354) Improve efficiency of DeleteAllCommand

2019-04-08 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3354: -- Summary: Improve efficiency of DeleteAllCommand Key: ZOOKEEPER-3354 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3354 Project: ZooKeeper Issue

[jira] [Created] (ZOOKEEPER-3353) Admin commands for showing initial settings

2019-04-08 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3353: -- Summary: Admin commands for showing initial settings Key: ZOOKEEPER-3353 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3353 Project: ZooKeeper

  1   2   >