Re: Keep Python 2 scripts...?

2020-03-30 Thread Brian Nixon
I agree with the consensus, maintaining a single version is preferable to maintaining two. On Mon, Mar 30, 2020 at 2:28 PM tison wrote: > Never mind. Updated pr based on the consensus. > > Best, > tison. > > > Enrico Olivelli 于2020年3月31日周二 上午2:10写道: > > > Tison, > > can you please update your

Re: [ANNOUNCE] Enrico Olivelli new ZooKeeper PMC Member

2020-02-08 Thread Brian Nixon
A belated congratulations Enrico! Very much deserved. On Wed, Jan 22, 2020 at 12:05 PM Mohamed Jeelani wrote: > Congratulations Enrico! __ > > On 1/21/20, 1:41 PM, "Flavio Junqueira" wrote: > > I'm pleased to announce that Enrico Olivelli recently became the > newest ZooKeeper PMC member.

Re: [VOTE] Apache ZooKeeper release 3.6.0 candidate 2

2020-02-08 Thread Brian Nixon
+1 - verified tests pass on both MacOS and Windows - verified documentation Note that the branch-3.6 proper does not compile and needs the fix of https://github.com/apache/zookeeper/pull/1239 (for the same reasons). On Sat, Feb 8, 2020 at 2:43 PM Michael Han wrote: > +1. > > - verified

Re: Getting value as FALSE of flag clientConfig.getBoolean(ZKClientConfig.SECURE_CLIENT) in ClientCnxnSocketNetty.initChannel(SocketChannel ch)

2019-11-16 Thread Brian Nixon
Hi Mohan, I'm a bit baffled as at first glance you're doing what I expect. As you're already modifying code, could you extend your changes in ZKClientConfig:: handleBackwardCompatibility so that you print out both the value of System.getProperty(SECURE_CLIENT) but also

Re: New feature in 3.5: Audit logging

2019-10-15 Thread Brian Nixon
I'd say 3.6 and not 3.5 in order to maintain the stable character of the latter. On Sat, Oct 12, 2019 at 12:05 PM Enrico Olivelli wrote: > Il ven 11 ott 2019, 23:48 Patrick Hunt ha scritto: > > > Per recent discussions we should really push for 3.6+, esp given lessons > > learned from 3.5 and

Re: [VOTE] Apache ZooKeeper release 3.5.6 candidate 2

2019-10-02 Thread Brian Nixon
NIO is still the default server factory so I'm guessing many users of 3.4 simply aren't configuring Netty. And our recommendation for users who want Netty could be to upgrade to a 3.5 release as that should be better in every way for them. Is there a principle determining the difference between

Re: [ANNOUNCE] New ZooKeeper committer: Brian Nixon

2019-10-02 Thread Brian Nixon
Thanks everyone! I'm happy to be here. :) On Wed, Oct 2, 2019 at 8:33 AM Patrick Hunt wrote: > Kudos Brian! > > Patrick > > On Wed, Oct 2, 2019 at 3:21 AM Norbert Kalmar > > wrote: > > > Congrats Brian! :) > > > > Norbert > > > > On Wed, Oct 2, 2019 at 11:22 AM Enrico Olivelli > > wrote: > >

Re: Cutting Zookeeper 3.5.6

2019-08-29 Thread Brian Nixon
I agree that ZOOKEEPER-3056 would be super nice to have in 3.5.6. Don't know what shape the solution should be but don't think it requires that much code - just thinking and community agreement. On Thu, Aug 29, 2019 at 4:31 PM Michael Han wrote: > ZOOKEEPER-3056 would be nice to have, I'll

Re: The ZooKeeper Grafana dashboard is now available

2019-07-10 Thread Brian Nixon
Looking really good! Nice work. On Wed, Jul 10, 2019 at 3:57 AM Andor Molnar wrote: > Awesome work Justin ! > > Andor > > > > On 2019. Jul 9., at 8:41, Justin Ling Mao > wrote: > > > > - Due to the work from ZOOKEEPER-3447( > https://github.com/apache/zookeeper/pull/1008), the ZooKeeper

[jira] [Created] (ZOOKEEPER-3459) Add admin command to display synced state of peer

2019-07-09 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3459: -- Summary: Add admin command to display synced state of peer Key: ZOOKEEPER-3459 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3459 Project: ZooKeeper

Re: [VOTE] Drop Java 9 support

2019-07-09 Thread Brian Nixon
+1 (nonbinding) On Tue, Jul 9, 2019 at 1:50 AM Enrico Olivelli wrote: > +1 > > Enrico > > Il mar 9 lug 2019, 10:43 Andor Molnar ha scritto: > > > Hi ZK dev team, > > > > Considering Enrico’s suggestion on the other thread (“Jenkins Ant > > failures”) and because Java 9 builds are all broken at

Re: Great talk from Ben Reed about the origins of ZooKeeper

2019-06-28 Thread Brian Nixon
It's great to hear the mindset that the ZooKeeper team was applying in the early days. Some good advice there. On Wed, Jun 26, 2019 at 8:42 PM Alexander Shraer wrote: > https://atscaleconference.com/videos/systems-scale-2019-welcome-keynote/ >

Re: Broken build

2019-06-21 Thread Brian Nixon
Finally got around to looking at this issue. https://github.com/apache/zookeeper/pull/996 may suffice to address the breaking test. On Wed, Jan 30, 2019 at 2:39 PM Brian Nixon wrote: > ZOOKEEPER-3240 is my patch - I'll see if I can figure out what the problem > is. > > > On We

Re: Heads up! Ant precommit disabled

2019-06-12 Thread Brian Nixon
Nice! On Wed, Jun 12, 2019 at 8:50 AM Enrico Olivelli wrote: > Hi all, > I have disabled the ant based precommit job for pull requests targeting > 'master' branch. > > A note for committers: most of pending pull requests ran the ant job. You > can ignore it > > I will update the wiki > > Enrico

[jira] [Created] (ZOOKEEPER-3421) Better insight into Observer connections

2019-06-10 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3421: -- Summary: Better insight into Observer connections Key: ZOOKEEPER-3421 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3421 Project: ZooKeeper Issue

Re: [DISCUSS] Voting on pull requests

2019-06-06 Thread Brian Nixon
The community should absolutely stand by its bylaws. :) Those two pull requests (899 and 944) were mine so I'd like to sketch what I saw as a contributor and hopefully figure out a healthier way forward. Both were opened in the last two months and got reviewer action within days. There was a

[jira] [Created] (ZOOKEEPER-3415) convert internal logic to use java 8 streams

2019-06-05 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3415: -- Summary: convert internal logic to use java 8 streams Key: ZOOKEEPER-3415 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3415 Project: ZooKeeper

Re: [ANNOUNCE] New ZooKeeper committer: Enrico Olivelli

2019-05-28 Thread Brian Nixon
Awesome! Congrats, Enrico! On Mon, May 27, 2019 at 3:56 AM Andor Molnar wrote: > Congratulations Enrico. > > Andor > > > > On Mon, May 27, 2019 at 11:04 AM Tamas Penzes > > wrote: > > > Congrats Enrico! > > > > On Sun, May 26, 2019 at 11:19 PM Patrick Hunt wrote: > > > > > The Apache

Re: [ANNOUNCE] New ZooKeeper committer: Norbert Kalmar

2019-05-28 Thread Brian Nixon
Congrats, Norbert! Well earned. On Mon, May 27, 2019 at 3:49 AM Andor Molnar wrote: > Congratulations Norbert! > > Andor > > > > On Mon, May 27, 2019 at 11:52 AM Flavio Junqueira wrote: > > > Congrats, Norbert! > > > > -Flavio > > > > > On 27 May 2019, at 11:01, Tamas Penzes > > wrote: > > >

[jira] [Commented] (ZOOKEEPER-1523) Better logging during instance loading/syncing

2019-05-23 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847110#comment-16847110 ] Brian Nixon commented on ZOOKEEPER-1523: [~Yohan123] , I have some code stashed by the side

[jira] [Commented] (ZOOKEEPER-1147) Add support for local sessions

2019-05-22 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846245#comment-16846245 ] Brian Nixon commented on ZOOKEEPER-1147: [~larsfrancke] - just created ZOOKEEPER-3400

[jira] [Created] (ZOOKEEPER-3400) Add documentation on local sessions

2019-05-22 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3400: -- Summary: Add documentation on local sessions Key: ZOOKEEPER-3400 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3400 Project: ZooKeeper Issue Type

[jira] [Commented] (ZOOKEEPER-1147) Add support for local sessions

2019-05-20 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844382#comment-16844382 ] Brian Nixon commented on ZOOKEEPER-1147: Checking the usual places, I don't see any good

[jira] [Resolved] (ZOOKEEPER-3349) QuorumCnxManager socketTimeout unused

2019-05-20 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brian Nixon resolved ZOOKEEPER-3349. Resolution: Not A Problem Fix Version/s: 3.6.0 > QuorumCnxManager socketTime

[jira] [Assigned] (ZOOKEEPER-3349) QuorumCnxManager socketTimeout unused

2019-05-20 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brian Nixon reassigned ZOOKEEPER-3349: -- Assignee: Brian Nixon > QuorumCnxManager socketTimeout unu

[jira] [Commented] (ZOOKEEPER-3349) QuorumCnxManager socketTimeout unused

2019-05-20 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844371#comment-16844371 ] Brian Nixon commented on ZOOKEEPER-3349: This parameter is being used again as of ZOOKEEPER

[jira] [Commented] (ZOOKEEPER-1000) Provide SSL in zookeeper to be able to run cross colos.

2019-05-20 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844370#comment-16844370 ] Brian Nixon commented on ZOOKEEPER-1000: That's my take as well. Not sure what else

[jira] [Assigned] (ZOOKEEPER-3311) Allow a delay to the transaction log flush

2019-05-20 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brian Nixon reassigned ZOOKEEPER-3311: -- Assignee: Brian Nixon > Allow a delay to the transaction log fl

[jira] [Assigned] (ZOOKEEPER-3378) Set the quorum cnxn timeout independently from syncLimit

2019-05-20 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brian Nixon reassigned ZOOKEEPER-3378: -- Assignee: Brian Nixon > Set the quorum cnxn timeout independently from syncLi

[jira] [Created] (ZOOKEEPER-3396) Flaky test in RestoreCommittedLogTest

2019-05-15 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3396: -- Summary: Flaky test in RestoreCommittedLogTest Key: ZOOKEEPER-3396 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3396 Project: ZooKeeper Issue

[jira] [Created] (ZOOKEEPER-3395) Document individual admin commands in markdown

2019-05-14 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3395: -- Summary: Document individual admin commands in markdown Key: ZOOKEEPER-3395 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3395 Project: ZooKeeper

[jira] [Created] (ZOOKEEPER-3394) Delay observer reconnect when all learner masters have been tried

2019-05-13 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3394: -- Summary: Delay observer reconnect when all learner masters have been tried Key: ZOOKEEPER-3394 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3394 Project

[jira] [Created] (ZOOKEEPER-3392) Add admin command to display last snapshot information

2019-05-13 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3392: -- Summary: Add admin command to display last snapshot information Key: ZOOKEEPER-3392 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3392 Project: ZooKeeper

[jira] [Created] (ZOOKEEPER-3388) Allow client port to support plaintext and encrypted connections simultaneously

2019-05-12 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3388: -- Summary: Allow client port to support plaintext and encrypted connections simultaneously Key: ZOOKEEPER-3388 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3388

[jira] [Created] (ZOOKEEPER-3386) Add admin command to display voting view

2019-05-10 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3386: -- Summary: Add admin command to display voting view Key: ZOOKEEPER-3386 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3386 Project: ZooKeeper Issue

[jira] [Created] (ZOOKEEPER-3385) Add admin command to display leader

2019-05-10 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3385: -- Summary: Add admin command to display leader Key: ZOOKEEPER-3385 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3385 Project: ZooKeeper Issue Type

Re: [Suggestion] Use Co-authored-by in commit messages

2019-05-08 Thread Brian Nixon
+1 to the idea of multiple authors, particularly for rescued code -1 to including all reviewers in the commit proper, this information is easily enough found from poking at the mail archive where "original author" requires studying a ticket on jira awesome idea! On Wed, May 8, 2019 at 6:32 AM

[jira] [Created] (ZOOKEEPER-3378) et the quorum cnxn timeout independently from syncLimit

2019-05-07 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3378: -- Summary: et the quorum cnxn timeout independently from syncLimit Key: ZOOKEEPER-3378 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3378 Project: ZooKeeper

[jira] [Updated] (ZOOKEEPER-3378) Set the quorum cnxn timeout independently from syncLimit

2019-05-07 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brian Nixon updated ZOOKEEPER-3378: --- Description: If an ensemble requires a high sync limit to support a large data tree

[jira] [Updated] (ZOOKEEPER-3378) Set the quorum cnxn timeout independently from syncLimit

2019-05-07 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brian Nixon updated ZOOKEEPER-3378: --- Summary: Set the quorum cnxn timeout independently from syncLimit (was: et the quorum

[jira] [Commented] (ZOOKEEPER-1651) Add support for compressed snapshot

2019-05-01 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831159#comment-16831159 ] Brian Nixon commented on ZOOKEEPER-1651: This feature was accepted with ZOOKEEPER-3179. I'd

[jira] [Assigned] (ZOOKEEPER-1651) Add support for compressed snapshot

2019-05-01 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brian Nixon reassigned ZOOKEEPER-1651: -- Assignee: Brian Nixon (was: Thawan Kooburat) > Add support for compres

Re: [ANNOUNCE] New ZooKeeper PMC member: Andor Molnar

2019-04-29 Thread Brian Nixon
Awesome! Congrats, Andor, you've been doing great work! On Mon, Apr 29, 2019 at 7:31 AM Patrick Hunt wrote: > Kudos Andor! > > Patrick > > On Mon, Apr 29, 2019 at 2:07 AM Enrico Olivelli > wrote: > > > Congratulations! > > > > Enrico > > > > Il lun 29 apr 2019, 10:40 Norbert Kalmar > ha > >

[jira] [Created] (ZOOKEEPER-3359) Batch commits in the CommitProcessor

2019-04-10 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3359: -- Summary: Batch commits in the CommitProcessor Key: ZOOKEEPER-3359 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3359 Project: ZooKeeper Issue

[jira] [Commented] (ZOOKEEPER-3352) Use LevelDB For Backend

2019-04-09 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813760#comment-16813760 ] Brian Nixon commented on ZOOKEEPER-3352: We've been curious whether wiring ZooKeeper on top

[jira] [Created] (ZOOKEEPER-3354) Improve efficiency of DeleteAllCommand

2019-04-08 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3354: -- Summary: Improve efficiency of DeleteAllCommand Key: ZOOKEEPER-3354 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3354 Project: ZooKeeper Issue

[jira] [Created] (ZOOKEEPER-3353) Admin commands for showing initial settings

2019-04-08 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3353: -- Summary: Admin commands for showing initial settings Key: ZOOKEEPER-3353 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3353 Project: ZooKeeper

[jira] [Commented] (ZOOKEEPER-3343) Add a new doc: zookeeperTools.md

2019-04-08 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812869#comment-16812869 ] Brian Nixon commented on ZOOKEEPER-3343: This will be great, thanks [~maoling]! > Add a

[jira] [Updated] (ZOOKEEPER-3349) QuorumCnxManager socketTimeout unused

2019-04-04 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brian Nixon updated ZOOKEEPER-3349: --- Description: QuorumCnxManager member variable 'socketTimeout' is not used anywhere

[jira] [Created] (ZOOKEEPER-3349) QuorumCnxManager socketTimeout unused

2019-04-04 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3349: -- Summary: QuorumCnxManager socketTimeout unused Key: ZOOKEEPER-3349 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3349 Project: ZooKeeper Issue

[jira] [Commented] (ZOOKEEPER-3318) Add a complete backup mechanism for zookeeper internal

2019-03-28 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804453#comment-16804453 ] Brian Nixon commented on ZOOKEEPER-3318: In the interest of a compact backup, I would like

[jira] [Commented] (ZOOKEEPER-3332) TxnLogToolkit should print multi transactions readably

2019-03-25 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801274#comment-16801274 ] Brian Nixon commented on ZOOKEEPER-3332: This is a really useful change. We have a couple

[jira] [Commented] (ZOOKEEPER-3333) Detect if txnlogs and / or snapshots is deleted under a running ZK instance

2019-03-25 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801160#comment-16801160 ] Brian Nixon commented on ZOOKEEPER-: I'm assuming that the scenario in mind is a rogue

[jira] [Created] (ZOOKEEPER-3331) Automatically add IP authorization for Netty connections

2019-03-22 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3331: -- Summary: Automatically add IP authorization for Netty connections Key: ZOOKEEPER-3331 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3331 Project: ZooKeeper

Re: Opening 'retest maven/ant build' to the public

2019-03-21 Thread Brian Nixon
Dropping the constraint would be much appreciated :) On Thu, Mar 21, 2019 at 10:32 AM Patrick Hunt wrote: > Seems reasonable. If it's abused we can always revert. > > Patrick > > On Thu, Mar 21, 2019 at 9:59 AM Enrico Olivelli > wrote: > > > Hi Zookeepers, > > Currently only apache committers

[jira] [Commented] (ZOOKEEPER-3320) Leader election port stop listen when hostname unresolvable for some time

2019-03-20 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797657#comment-16797657 ] Brian Nixon commented on ZOOKEEPER-3320: A configurable retry seems like a good idea to me

[jira] [Commented] (ZOOKEEPER-3320) Leader election port stop listen when hostname unresolvable for some time

2019-03-19 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796341#comment-16796341 ] Brian Nixon commented on ZOOKEEPER-3320: This is an interesting error case! I would expect

[jira] [Commented] (ZOOKEEPER-3318) Add a complete backup mechanism for zookeeper internal

2019-03-18 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795253#comment-16795253 ] Brian Nixon commented on ZOOKEEPER-3318: This would be great! > Add a complete bac

[jira] [Created] (ZOOKEEPER-3311) Allow a delay to the transaction log flush

2019-03-13 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3311: -- Summary: Allow a delay to the transaction log flush Key: ZOOKEEPER-3311 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3311 Project: ZooKeeper

Re: MetricsProvider..time to start?

2019-03-06 Thread Brian Nixon
I to MetricsProvider to make it possile to > model AvgMinMaxCounter (Summary without percentiles) > > Let's follow up on the patch > > Regards > Enrico > > Il giorno sab 26 gen 2019 alle ore 08:40 Enrico Olivelli > ha scritto: > > > > > > > > Il gi

[jira] [Commented] (ZOOKEEPER-3264) Add a benchmark tool for zookeeper

2019-03-04 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783824#comment-16783824 ] Brian Nixon commented on ZOOKEEPER-3264: I know that [~breed] at one point was thinking

Re: Question on ZK commit/patch policy.

2019-03-04 Thread Brian Nixon
I like having JIRAs for all changes because it allows one to track all the changes to given components through the JIRA web interface and it forces the contributor to spend some time upfront making sure their change is a single coherent unit. For trivial changes like spelling, whitespace, pruning

[jira] [Created] (ZOOKEEPER-3287) admin command to dump currently known ACLs

2019-02-21 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3287: -- Summary: admin command to dump currently known ACLs Key: ZOOKEEPER-3287 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3287 Project: ZooKeeper

Re: Broken build

2019-01-30 Thread Brian Nixon
ZOOKEEPER-3240 is my patch - I'll see if I can figure out what the problem is. On Wed, Jan 30, 2019 at 7:54 AM Andor Molnar wrote: > This doesn't look good yet. > Let's give it some time (til tomorrow) to recover. > > Andor > > > > On Wed, Jan 30, 2019 at 12:08 PM Andor Molnar wrote: > > >

Re: GitHub "god" mode

2019-01-30 Thread Brian Nixon
Thanks, Andor :) On Wed, Jan 30, 2019 at 8:18 AM Andor Molnar wrote: > We're down to 4 pages of open PRs (from 7). > Sorry for the huge number of "closed pull request" emails. > > Andor > > > > On Wed, Jan 30, 2019 at 4:08 PM Camille Fournier > wrote: > > > Wow thanks Andor! > > > > On Wed,

Re: MetricsProvider..time to start?

2019-01-25 Thread Brian Nixon
Hi Enrico, Most of the major remaining contributions from the Facebook engineers around metrics are captured in https://issues.apache.org/jira/browse/ZOOKEEPER-3245 and our attention is still focused on upstreaming that and other work. We'd like to see the metrics provider work move forward

[jira] [Created] (ZOOKEEPER-3257) Merge count and byte update of Stat

2019-01-25 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3257: -- Summary: Merge count and byte update of Stat Key: ZOOKEEPER-3257 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3257 Project: ZooKeeper Issue Type

[jira] [Commented] (ZOOKEEPER-3180) Add response cache to improve the throughput of read heavy traffic

2019-01-18 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16746687#comment-16746687 ] Brian Nixon commented on ZOOKEEPER-3180: Creating ZOOKEEPER-3252 as a follow up. >

[jira] [Created] (ZOOKEEPER-3252) Extend the options for the response cache

2019-01-18 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3252: -- Summary: Extend the options for the response cache Key: ZOOKEEPER-3252 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3252 Project: ZooKeeper

[jira] [Commented] (ZOOKEEPER-3240) Close socket on Learner shutdown to avoid dangling socket

2019-01-11 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740916#comment-16740916 ] Brian Nixon commented on ZOOKEEPER-3240: [~hanm] could it be that the unclosed/unreaped

[jira] [Created] (ZOOKEEPER-3244) Add option to snapshot based on log size

2019-01-11 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3244: -- Summary: Add option to snapshot based on log size Key: ZOOKEEPER-3244 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3244 Project: ZooKeeper Issue

[jira] [Commented] (ZOOKEEPER-2669) follower failed to reconnect to leader after a network error

2019-01-10 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739751#comment-16739751 ] Brian Nixon commented on ZOOKEEPER-2669: Is this related to ZOOKEEPER-3240 ? > follo

[jira] [Commented] (ZOOKEEPER-3240) Close socket on Learner shutdown to avoid dangling socket

2019-01-10 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739750#comment-16739750 ] Brian Nixon commented on ZOOKEEPER-3240: This may be the same issue as detected in ZOOKEEPER

[jira] [Created] (ZOOKEEPER-3240) Close socket on Learner shutdown to avoid dangling socket

2019-01-10 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3240: -- Summary: Close socket on Learner shutdown to avoid dangling socket Key: ZOOKEEPER-3240 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3240 Project

[jira] [Created] (ZOOKEEPER-3237) Allow IPv6 wildcard address in peer config

2019-01-08 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3237: -- Summary: Allow IPv6 wildcard address in peer config Key: ZOOKEEPER-3237 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3237 Project: ZooKeeper

[jira] [Commented] (ZOOKEEPER-3231) Purge task may lost data when we have many invalid snapshots.

2019-01-07 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736548#comment-16736548 ] Brian Nixon commented on ZOOKEEPER-3231: It might also make sense to more aggressively delete

Re: JAVA 11 build is broken on 3.5

2019-01-07 Thread Brian Nixon
Also worth consideration for the Netty fixes backport bundle: ZOOKEEPER-3131 org.apache.zookeeper.server.WatchManager resource leak Our experience with Netty has been positive so far though I don't think we have enough info to declare it is stable. It makes a lot of sense to me for 3.5 to use

[jira] [Commented] (ZOOKEEPER-3232) make the log of notification about LE more readable

2019-01-03 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733820#comment-16733820 ] Brian Nixon commented on ZOOKEEPER-3232: seems reasonable to me > make the

[jira] [Commented] (ZOOKEEPER-3218) zk server reopened,the interval for observer connect to the new leader is too long,then session expired

2018-12-26 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729186#comment-16729186 ] Brian Nixon commented on ZOOKEEPER-3218: We had similar issues which we addressed by making

[jira] [Commented] (ZOOKEEPER-2872) Interrupted snapshot sync causes data loss

2018-12-26 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729136#comment-16729136 ] Brian Nixon commented on ZOOKEEPER-2872: Now that the patch is merged, was there any further

[jira] [Commented] (ZOOKEEPER-3197) Improve documentation in ZooKeeperServer.superSecret

2018-12-26 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729138#comment-16729138 ] Brian Nixon commented on ZOOKEEPER-3197: Password is probably the wrong term

[jira] [Commented] (ZOOKEEPER-3220) The snapshot is not saved to disk and may cause data inconsistency.

2018-12-26 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729134#comment-16729134 ] Brian Nixon commented on ZOOKEEPER-3220: I believe ZOOKEEPER-2872 addressed the fsyncing part

[jira] [Commented] (ZOOKEEPER-3140) Allow Followers to host Observers

2018-10-12 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648379#comment-16648379 ] Brian Nixon commented on ZOOKEEPER-3140: A note on future work - it would be cool to see

[jira] [Commented] (ZOOKEEPER-3166) Support changing secure port with reconfig

2018-10-12 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648369#comment-16648369 ] Brian Nixon commented on ZOOKEEPER-3166: It would be cool to see the serialized format

[jira] [Comment Edited] (ZOOKEEPER-3166) Support changing secure port with reconfig

2018-10-12 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648369#comment-16648369 ] Brian Nixon edited comment on ZOOKEEPER-3166 at 10/12/18 7:45 PM

[jira] [Created] (ZOOKEEPER-3166) Support changing secure port with reconfig

2018-10-12 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3166: -- Summary: Support changing secure port with reconfig Key: ZOOKEEPER-3166 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3166 Project: ZooKeeper

Re: New precommit job 'retest this please' trick

2018-09-25 Thread Brian Nixon
Excellent! On Mon, Sep 24, 2018 at 11:06 AM Andor Molnár wrote: > Awesome! > > > > On 09/24/2018 06:27 PM, Michael Han wrote: > >>> How the new process any different from that? > > Jenkins job triggered by "Rebuild" button can't write back the job result > > to github, leading to a yellow

[jira] [Created] (ZOOKEEPER-3142) Extend SnapshotFormatter to dump data in json format

2018-09-10 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3142: -- Summary: Extend SnapshotFormatter to dump data in json format Key: ZOOKEEPER-3142 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3142 Project: ZooKeeper

[jira] [Created] (ZOOKEEPER-3140) Allow Followers to host Observers

2018-09-07 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3140: -- Summary: Allow Followers to host Observers Key: ZOOKEEPER-3140 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3140 Project: ZooKeeper Issue Type

[jira] [Created] (ZOOKEEPER-3137) add a utility to truncate logs to a zxid

2018-08-31 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3137: -- Summary: add a utility to truncate logs to a zxid Key: ZOOKEEPER-3137 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3137 Project: ZooKeeper Issue

[jira] [Commented] (ZOOKEEPER-3131) org.apache.zookeeper.server.WatchManager resource leak

2018-08-28 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595645#comment-16595645 ] Brian Nixon commented on ZOOKEEPER-3131: I'm not sure I follow what you're proposing. Do you

[jira] [Commented] (ZOOKEEPER-706) large numbers of watches can cause session re-establishment to fail

2018-08-28 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595642#comment-16595642 ] Brian Nixon commented on ZOOKEEPER-706: --- I agree that the C client is still vulnerable

Re: [SUGGESTION] Jute's place in the new directory structure

2018-08-28 Thread Brian Nixon
I still think it makes sense to keep it as a top level directory (would not include it in recipes). 'zookeeper-jute' is certainly a reasonable name. :) -Brian On Thu, Aug 23, 2018 at 7:59 AM Norbert Kalmar wrote: > Hi folks, > > So jute is a little bit the odd one out in ZooKeeper. It was

[jira] [Created] (ZOOKEEPER-3115) Delete snapshot file on error

2018-08-08 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3115: -- Summary: Delete snapshot file on error Key: ZOOKEEPER-3115 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3115 Project: ZooKeeper Issue Type

[jira] [Commented] (ZOOKEEPER-3082) Fix server snapshot behavior when out of disk space

2018-08-01 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565860#comment-16565860 ] Brian Nixon commented on ZOOKEEPER-3082: [~andorm] my (possibly incorrect) read on ZOOKEEPER

[jira] [Commented] (ZOOKEEPER-3108) deprecated myid file and use a new property "server.id" in the zoo.cfg

2018-08-01 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565814#comment-16565814 ] Brian Nixon commented on ZOOKEEPER-3108: This seems like a good idea to me (provided myid

Re: ZK ACL question

2018-07-31 Thread Brian Nixon
Hi William, It's been a while since I've looked at this. You could double-check against how the kazoo client is handling encoding -> https://github.com/python-zk/kazoo/blob/master/kazoo/security.py#L61 . Does this help? -Brian On Wed, Jul 18, 2018 at 7:36 AM, William Jardine wrote: > Hey

[jira] [Created] (ZOOKEEPER-3083) Remove some redundant and noisy log lines

2018-07-05 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3083: -- Summary: Remove some redundant and noisy log lines Key: ZOOKEEPER-3083 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3083 Project: ZooKeeper

[jira] [Created] (ZOOKEEPER-3082) Fix server snapshot behavior when out of disk space

2018-07-05 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3082: -- Summary: Fix server snapshot behavior when out of disk space Key: ZOOKEEPER-3082 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3082 Project: ZooKeeper

[jira] [Created] (ZOOKEEPER-3068) Improve C client logging of IPv6 hosts

2018-06-22 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3068: -- Summary: Improve C client logging of IPv6 hosts Key: ZOOKEEPER-3068 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3068 Project: ZooKeeper Issue

  1   2   >