MIPS Built-ins

2023-09-28 Thread Ильвир Низамов via Gcc
Hello! You may call me Ilvir. I got an issue while building U-Boot for MIPS platform, because of __builtin_mips_cache needs optimization flags (like -O2) while non-literal int passed in it ("int op" at example below). Example code: static inline void mips_cache(int op, const volatile void *addr)

Re: Test with an lto-build of libgfortran.

2023-09-28 Thread Toon Moene
On 9/28/23 07:33, Thomas Koenig wrote: Hi Toon, [ I wrote: ] The full question of "lto-ing" run time libraries is more complicated than just "whether it works" as those who attended the BoF will recall. I didn't attend the Cauldron (but that discussion would have been very interesting). 

Re: GCC workshop at university

2023-09-28 Thread David Malcolm via Gcc
On Wed, 2023-09-27 at 22:20 +0200, Benjamin Priour wrote: > Hi everyone, > > I'm in my final MSc year and figured after this weekend's Q > that I could replicate David's workshop on a smaller scale within my > university. > > Would that be doable/acceptable ? That sounds like a great idea. >

Re: Test with an lto-build of libgfortran.

2023-09-28 Thread David Edelsohn via Gcc
On Thu, Sep 28, 2023 at 4:00 PM Toon Moene wrote: > On 9/28/23 21:26, Jakub Jelinek wrote: > > > It is worse than that, usually the LTO format changes e.g. any time any > > option or parameter is added on a release branch (several times a year) > and > > at other times as well. > > Though,

Re: Test with an lto-build of libgfortran.

2023-09-28 Thread Jakub Jelinek via Gcc
On Thu, Sep 28, 2023 at 09:03:39PM +0200, Toon Moene wrote: > > > The full question of "lto-ing" run time libraries is more > > > complicated than just "whether it works" as those who attended the > > > BoF will recall. > > > > I didn't attend the Cauldron (but that discussion would have been > >

Re: Test with an lto-build of libgfortran.

2023-09-28 Thread Toon Moene
On 9/28/23 21:26, Jakub Jelinek wrote: It is worse than that, usually the LTO format changes e.g. any time any option or parameter is added on a release branch (several times a year) and at other times as well. Though, admittedly GCC is the single package that actually could get away with LTO

gcc-11-20230928 is now available

2023-09-28 Thread GCC Administrator via Gcc
Snapshot gcc-11-20230928 is now available on https://gcc.gnu.org/pub/gcc/snapshots/11-20230928/ and on various mirrors, see http://gcc.gnu.org/mirrors.html for details. This snapshot has been generated from the GCC 11 git branch with the following options: git://gcc.gnu.org/git/gcc.git branch

Re: Test with an lto-build of libgfortran.

2023-09-28 Thread Richard Biener via Gcc
On Wed, Sep 27, 2023 at 11:48 PM Jeff Law via Fortran wrote: > > > > On 9/27/23 12:21, Toon Moene wrote: > > > > > The lto-ing of libgfortran did succeed, because I did get a new warning: > > > > gfortran -O3 -flto -flto-partition=none -static -o xlintstrfz zchkrfp.o > > zdrvrfp.o zdrvrf1.o

Re: Test with an lto-build of libgfortran.

2023-09-28 Thread Tobias Burnus
Hi all, the following works for me. I have only tried a normal build (where it does silence the same warning) and not an LTO build and I just believed the comment - see attached patch. Comments? On 28.09.23 08:25, Richard Biener via Fortran wrote: This particular place in libgfortran has

Re: Test with an lto-build of libgfortran.

2023-09-28 Thread Andrew Pinski via Gcc
On Wed, Sep 27, 2023 at 11:28 PM Richard Biener via Fortran wrote: > > On Wed, Sep 27, 2023 at 11:48 PM Jeff Law via Fortran > wrote: > > > > > > > > On 9/27/23 12:21, Toon Moene wrote: > > > > > > > > The lto-ing of libgfortran did succeed, because I did get a new warning: > > > > > > gfortran

Re: Test with an lto-build of libgfortran.

2023-09-28 Thread Jakub Jelinek via Gcc
On Thu, Sep 28, 2023 at 09:29:02AM +0200, Tobias Burnus wrote: > the following works for me. I have only tried a normal build (where it > does silence the same warning) and not an LTO build and I just believed > the comment - see attached patch. Comments? > > On 28.09.23 08:25, Richard Biener via

[Fortran, Patch, Coarray, PR 37336] Fix crash in finalizer when derived type coarray is already freed.

2023-09-28 Thread Andre Vehreschild
Hi all, attached patch fixes a crash in coarray programs when an allocatable derived typed coarray was freed explicitly. The generated cleanup code did not take into account, that the coarray may have been deallocated already. The patch fixes this by moving the statements accessing components

[PATCH 1/2] arm: Use deltas for Arm switch tables

2023-09-28 Thread Richard Ball
For normal optimization for the Arm state in gcc we get an uncompressed table of jump targets. This is in the middle of the text segment far larger than necessary, especially at -Os. This patch compresses the table to use deltas in a similar manner to Thumb code generation. Similar code is also

[Bug other/111629] [14 Regression] ggc_common_finalize() corrupts global memory outsuide GTY(()) objects

2023-09-28 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111629 Andrew Pinski changed: What|Removed |Added Resolution|--- |DUPLICATE

[Bug middle-end/111505] [14 Regression] Asan (address-sanitizer) bootstrap fails since r14-4003-geaa8e8541349df

2023-09-28 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111505 Andrew Pinski changed: What|Removed |Added CC||slyfox at gcc dot gnu.org --- Comment

[Bug gcov-profile/111559] [14 regression] ICE when building Python with PGO

2023-09-28 Thread sirl at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111559 --- Comment #8 from Franz Sirl --- The proposed patch on top of r14-4307 fixes the profiled bootstrap here.

Re: [PATCH v2] RISC-V: Support {U}INT64 to FP16 auto-vectorization

2023-09-28 Thread 钟居哲
LGTM. juzhe.zh...@rivai.ai From: pan2.li Date: 2023-09-28 22:15 To: gcc-patches CC: juzhe.zhong; pan2.li; yanzhang.wang; kito.cheng Subject: [PATCH v2] RISC-V: Support {U}INT64 to FP16 auto-vectorization From: Pan Li Update in v2: * Add math trap check. * Adjust some test cases.

[Bug target/111533] [14 Regression] ICE: RTL check: expected code 'reg', have 'const_int' in rhs_regno, at rtl.h:1934

2023-09-28 Thread patrick at rivosinc dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111533 Patrick O'Neill changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

[PATCH 2/7] libstdc++: Use gdb.ValuePrinter base class

2023-09-28 Thread Tom Tromey
GDB 14 will add a new ValuePrinter tag class that will be used to signal that pretty-printers will agree to the "extension protocol" -- essentially that they will follow some simple namespace rules, so that GDB can add new methods over time. A couple new methods have already been added to GDB, to

[Bug tree-optimization/111624] compile-time and memory-hog compiling RISC-V insn-emit.cc

2023-09-28 Thread rguenth at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111624 --- Comment #3 from Richard Biener --- upon early optimization finish we're at 3GB memory use, IPA doesn't add much to this, after that it's slowly creeping up.

Re: [PING][PATCH 2/2] arm: Add support for MVE Tail-Predicated Low Overhead Loops

2023-09-28 Thread Andre Vieira (lists)
Hi, On 14/09/2023 13:10, Kyrylo Tkachov via Gcc-patches wrote: Hi Stam, The arm parts look sensible but we'd need review for the df-core.h and df-core.cc changes. Maybe Jeff can help or can recommend someone to take a look? Thanks, Kyrill FWIW the changes LGTM, if we don't want these

Re: [PATCH v2] aarch64: Fine-grained ldp and stp policies with test-cases.

2023-09-28 Thread Richard Sandiford
Manos Anagnostakis writes: > Hey Richard, > > Thanks for taking the time to review this, but it has been commited since > yesterday after getting reviewed by Kyrill and Tamar. > > Discussions: > https://gcc.gnu.org/pipermail/gcc-patches/2023-September/631285.html >

[Bug other/111632] New: gcc's C++ components fail to compile against recent libc++ headers

2023-09-28 Thread dimitry at andric dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111632 Bug ID: 111632 Summary: gcc's C++ components fail to compile against recent libc++ headers Product: gcc Version: 14.0 Status: UNCONFIRMED Severity: normal

Re: [PATCH, rs6000] Enable vector compare for 16-byte memory equality compare [PR111449]

2023-09-28 Thread Richard Sandiford
HAO CHEN GUI writes: > Kewen and Richard, > Thanks for your comments. Please let me clarify it. > > 在 2023/9/27 19:10, Richard Sandiford 写道: >> Yeah, I agree there doesn't seem to be a good reason to exclude vectors. >> Sorry to dive straight into details, but maybe we should have something >>

[PATCH] Include safe-ctype.h after C++ standard headers, to avoid over-poisoning

2023-09-28 Thread Dimitry Andric
Ref: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111632 When building gcc's C++ sources against recent libc++, the poisoning of the ctype macros due to including safe-ctype.h before including C++ standard headers such as , , etc, causes many compilation errors, similar to: In file included

[Bug libstdc++/111050] [11/12/13/14 Regression] ABI break in _Hash_node_value_base since GCC 11

2023-09-28 Thread cvs-commit at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111050 --- Comment #12 from CVS Commits --- The master branch has been updated by Francois Dumont : https://gcc.gnu.org/g:2c1e3544a94c5d7354fad031e1f9731c3ce3af25 commit r14-4313-g2c1e3544a94c5d7354fad031e1f9731c3ce3af25 Author: Tim Song Date:

Re: [PATCH] RFC: Add late-combine pass [PR106594]

2023-09-28 Thread Jeff Law
On 9/26/23 10:21, Richard Sandiford wrote: This patch adds a combine pass that runs late in the pipeline. There are two instances: one between combine and split1, and one after postreload. The pass currently has a single objective: remove definitions by substituting into all uses. The

Re: [PATCH v2] aarch64: Fine-grained ldp and stp policies with test-cases.

2023-09-28 Thread Richard Sandiford
Thanks for the patch and sorry for the slow review. Manos Anagnostakis writes: > This patch implements the following TODO in gcc/config/aarch64/aarch64.cc > to provide the requested behaviour for handling ldp and stp: > > /* Allow the tuning structure to disable LDP instruction formation >

[Bug other/111629] New: [14 Regression] ggc_common_finalize() corrupts global memory outsuide GTY(()) objects

2023-09-28 Thread slyfox at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111629 Bug ID: 111629 Summary: [14 Regression] ggc_common_finalize() corrupts global memory outsuide GTY(()) objects Product: gcc Version: 14.0 Status: UNCONFIRMED

[PATCH] Simplify & expand c_readstr

2023-09-28 Thread Richard Sandiford
c_readstr only operated on integer modes. It worked by reading the source string into an array of HOST_WIDE_INTs, converting that array into a wide_int, and from there to an rtx. It's simpler to do this by building a target memory image and using native_decode_rtx to convert that memory image

[Bug c++/111630] New: Optimizing for size compiles additions to several instructions

2023-09-28 Thread christiandohn.rask at st dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111630 Bug ID: 111630 Summary: Optimizing for size compiles additions to several instructions Product: gcc Version: 12.3.0 Status: UNCONFIRMED Severity: normal

[pushed][RA]: Add flag for checking IRA in progress

2023-09-28 Thread Vladimir Makarov
I've pushed the following patch. The explanation is in commit message.  The patch was successfully bootstrapped on x86-64. commit 0c8ecbcd3cf7d7187d2017ad02b663a57123b417 Author: Vladimir N. Makarov Date: Thu Sep 28 09:41:18 2023 -0400 [RA]: Add flag for checking IRA in progress

[Bug other/111629] [14 Regression] ggc_common_finalize() corrupts global memory outsuide GTY(()) objects

2023-09-28 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111629 --- Comment #1 from Andrew Pinski --- There is a dup of this where valgrind complains.

[Bug middle-end/111630] Optimizing for size compiles additions to several instructions

2023-09-28 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111630 --- Comment #1 from Andrew Pinski --- Created attachment 56009 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56009=edit testcase Please next time attach or inline the source so we don't need to depend on external web sites.

[Bug fortran/90608] Inline non-scalar minloc/maxloc calls

2023-09-28 Thread tkoenig at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90608 Thomas Koenig changed: What|Removed |Added CC||mikael at gcc dot gnu.org --- Comment

Re: [PATCH v2] aarch64: Fine-grained ldp and stp policies with test-cases.

2023-09-28 Thread Manos Anagnostakis
No problem! I'll send a follow up with the requested changes. Thanks for the input! Manos. On Thu, Sep 28, 2023 at 4:42 PM Richard Sandiford wrote: > Manos Anagnostakis writes: > > Hey Richard, > > > > Thanks for taking the time to review this, but it has been commited since > > yesterday

[PATCH v2] RISC-V: Support {U}INT64 to FP16 auto-vectorization

2023-09-28 Thread pan2 . li
From: Pan Li Update in v2: * Add math trap check. * Adjust some test cases. Original logs: This patch would like to support the auto-vectorization from the INT64 to FP16. We take below steps for the conversion. * INT64 to FP32. * FP32 to FP16. Given sample code as below: void test_func

[Bug target/111506] RISC-V: Failed to vectorize conversion from INT64 -> _Float16

2023-09-28 Thread cvs-commit at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111506 --- Comment #1 from CVS Commits --- The master branch has been updated by Pan Li : https://gcc.gnu.org/g:88d8829e4f435bfc844db5a9df730e20faf7c2c7 commit r14-4310-g88d8829e4f435bfc844db5a9df730e20faf7c2c7 Author: Pan Li Date: Thu Sep 28

[Bug target/111506] RISC-V: Failed to vectorize conversion from INT64 -> _Float16

2023-09-28 Thread juzhe.zhong at rivai dot ai via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111506 JuzheZhong changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

[Bug tree-optimization/111622] [13 Regression] EVRP compile-time hog compiling risc-v insn-opinit.cc

2023-09-28 Thread amacleod at redhat dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111622 --- Comment #3 from Andrew Macleod --- (In reply to Richard Biener from comment #1) > Created attachment 56006 [details] > preprocessed riscv insn-opinit.cc I get i.ii:2203:11: fatal error: definition of ‘class std::initializer_list<_E>’

[Bug tree-optimization/111631] [14 Regression] Wrong code at -Os on x86_64-linux-gnu since r14-3217-g4d6132e5932

2023-09-28 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111631 Andrew Pinski changed: What|Removed |Added Target Milestone|--- |14.0 Summary|Wrong code at

[PATCH 0/7] libstdc++: Use gdb.ValuePrinter in pretty-printers

2023-09-28 Thread Tom Tromey
GDB 14 will include a gdb.ValuePrinter tag class that can be used by pretty-printers to signal they will accept any extensions that GDB happens to make over time. This series started as an attempt to change the libstdc++ printers to support this. This just involves renaming a bunch of

[PATCH 1/7] libstdc++: Show full Python stack on error

2023-09-28 Thread Tom Tromey
This changes the libstdc++ test suite to arrange for gdb to show the full Python stack if any sort of Python exception occurs. This makes debugging the printers a little simpler. libstdc++-v3/ChangeLog: * testsuite/lib/gdb-test.exp (gdb-test): Enable Python stack traces from

[PATCH 3/7] libstdc++: Remove unused Python imports

2023-09-28 Thread Tom Tromey
flake8 pointed out some unused imports. libstdc++-v3/ChangeLog: * python/libstdcxx/v6/printers.py: Don't import 'os'. * python/libstdcxx/v6/__init__.py: Don't import 'gdb'. --- libstdc++-v3/python/libstdcxx/v6/__init__.py | 2 -- libstdc++-v3/python/libstdcxx/v6/printers.py | 1

Re: [PATCH v2] aarch64: Fine-grained ldp and stp policies with test-cases.

2023-09-28 Thread Manos Anagnostakis
Hey Richard, Thanks for taking the time to review this, but it has been commited since yesterday after getting reviewed by Kyrill and Tamar. Discussions: https://gcc.gnu.org/pipermail/gcc-patches/2023-September/631285.html https://gcc.gnu.org/pipermail/gcc-patches/2023-September/631300.html

[Bug tree-optimization/111583] [13/14 Regression] Wrong code at -Os on x86_64-linux-gnu since r13-3281-g6cc3394507

2023-09-28 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111583 --- Comment #2 from Andrew Pinski --- *** Bug 111631 has been marked as a duplicate of this bug. ***

[Bug tree-optimization/111631] [14 Regression] Wrong code at -Os on x86_64-linux-gnu since r14-3217-g4d6132e5932

2023-09-28 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111631 Andrew Pinski changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

[Bug middle-end/111630] Optimizing for size compiles additions to several instructions

2023-09-28 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111630 Andrew Pinski changed: What|Removed |Added Keywords||missed-optimization Last

reverting patch to improve equiv cost calculation

2023-09-28 Thread Vladimir Makarov
I've got a lot of complaints about my recent patch to improve equiv cost calculation.  So I am reverting the patch. commit 8552dcd8e4448c02fe230662093756b75dd94399 Author: Vladimir N. Makarov Date: Thu Sep 28 11:53:51 2023 -0400 Revert "[RA]: Improve cost calculation of pseudos with

[Bug tree-optimization/111624] compile-time and memory-hog compiling RISC-V insn-emit.cc

2023-09-28 Thread rguenth at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111624 Richard Biener changed: What|Removed |Added CC||dmalcolm at gcc dot gnu.org ---

[Bug target/111600] [14 Regression] RISC-V bootstrap time regression

2023-09-28 Thread cvs-commit at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111600 --- Comment #11 from CVS Commits --- The master branch has been updated by Richard Biener : https://gcc.gnu.org/g:f194c684a28a5d449bd034a2c604d04ba465e4fe commit r14-4308-gf194c684a28a5d449bd034a2c604d04ba465e4fe Author: Richard Biener Date:

[RFC] > WIDE_INT_MAX_PREC support in wide_int and widest_int

2023-09-28 Thread Jakub Jelinek
Hi! On Tue, Aug 29, 2023 at 05:09:52PM +0200, Jakub Jelinek via Gcc-patches wrote: > On Tue, Aug 29, 2023 at 11:42:48AM +0100, Richard Sandiford wrote: > > > I'll note tree-ssa-loop-niter.cc also uses GMP in some cases, widest_int > > > is really trying to be poor-mans GMP by limiting the maximum

[Bug target/111121] AArch64: MOPS memmove operand corruption

2023-09-28 Thread cvs-commit at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=21 --- Comment #2 from CVS Commits --- The master branch has been updated by Wilco Dijkstra : https://gcc.gnu.org/g:d8b56c95782a79ec40932ca88d00fd9f2ee2 commit r14-4311-gd8b56c95782a79ec40932ca88d00fd9f2ee2 Author: Wilco Dijkstra Date:

Re: [PATCH 6/8] vect: Add vector_mode paramater to simd_clone_usable

2023-09-28 Thread Andre Vieira (lists)
On 31/08/2023 07:39, Richard Biener wrote: On Wed, Aug 30, 2023 at 5:02 PM Andre Vieira (lists) wrote: On 30/08/2023 14:01, Richard Biener wrote: On Wed, Aug 30, 2023 at 11:15 AM Andre Vieira (lists) via Gcc-patches wrote: This patch adds a machine_mode parameter to the

[PATCH 2/2] arm: move the switch tables for Arm to the RO data section.

2023-09-28 Thread Richard Ball
Follow up patch to arm: Use deltas for Arm switch tables This patch moves the switch tables for Arm from the .text section into the .rodata section. gcc/ChangeLog: * config/arm/aout.h: Change to use the Lrtx label. * config/arm/arm.h (CASE_VECTOR_PC_RELATIVE): Remove arm targets

Re: [PATCH v2] aarch64: Fine-grained ldp and stp policies with test-cases.

2023-09-28 Thread Manos Anagnostakis
Sure, I will attend to this. Manos. On Thu, Sep 28, 2023 at 4:37 PM Philipp Tomsich wrote: > Manos, > > Please submit a follow-on patch implementing the requested > improvements of the code structure (as this reduces the maintenance > burden). > > Thanks, > Philipp. > > > On Thu, 28 Sept 2023

[PATCH 4/7] libstdc++: Remove unused locals from printers.py

2023-09-28 Thread Tom Tromey
flake8 pointed out some unused local variables in the libstdc++ pretty-printers. This removes them. libstdc++-v3/ChangeLog: * python/libstdcxx/v6/printers.py (StdExpOptionalPrinter.__init__, lookup_node_type): Remove unused variables. ---

[PATCH 5/7] libstdc++: Remove std_ratio_t_tuple

2023-09-28 Thread Tom Tromey
This removes the std_ratio_t_tuple function from the Python pretty-printer code. It is not used. Apparently the relevant parts were moved to StdChronoDurationPrinter._ratio at some point in the past. libstdc++-v3/ChangeLog: * python/libstdcxx/v6/printers.py (std_ratio_t_tuple):

[PATCH 6/7] libstdc++: Fix regex escapes in pretty-printers

2023-09-28 Thread Tom Tromey
flake8 pointed out that some regexes in the pretty-printers are missing a backslash. This patch fixes these. libstdc++-v3/ChangeLog: * python/libstdcxx/v6/printers.py (StdExpAnyPrinter.__init__, StdExpOptionalPrinter.__init__): Add missing backslash. *

[PATCH 7/7] libstdc++: Use Python "not in" operator

2023-09-28 Thread Tom Tromey
flake8 warns about code like not something in "whatever" Ordinarily in Python this should be written as: something not in "whatever" This patch makes this change. libstdc++-v3/ChangeLog: * python/libstdcxx/v6/printers.py (Printer.add_version)

[PATCH] target/111600 - avoid deep recursion in access diagnostics

2023-09-28 Thread Richard Biener
pass_waccess::check_dangling_stores uses recursion to traverse the CFG. The following changes this to use a heap allocated worklist to avoid blowing the stack. Instead of using a better iteration order it tries hard to preserve the current iteration order to avoid new false positives to pop up

Re: [PATCH v2] aarch64: Fine-grained ldp and stp policies with test-cases.

2023-09-28 Thread Philipp Tomsich
Manos, Please submit a follow-on patch implementing the requested improvements of the code structure (as this reduces the maintenance burden). Thanks, Philipp. On Thu, 28 Sept 2023 at 15:33, Manos Anagnostakis wrote: > > Hey Richard, > > Thanks for taking the time to review this, but it has

[Bug tree-optimization/111624] compile-time and memory-hog compiling RISC-V insn-emit.cc

2023-09-28 Thread juzhe.zhong at rivai dot ai via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111624 JuzheZhong changed: What|Removed |Added CC||juzhe.zhong at rivai dot ai --- Comment

[Bug tree-optimization/111631] New: Wrong code at -Os on x86_64-linux-gnu since r14-3217-g4d6132e5932

2023-09-28 Thread shaohua.li at inf dot ethz.ch via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111631 Bug ID: 111631 Summary: Wrong code at -Os on x86_64-linux-gnu since r14-3217-g4d6132e5932 Product: gcc Version: 14.0 Status: UNCONFIRMED Keywords: wrong-code

Re: [PATCH] Remove poly_int_pod

2023-09-28 Thread Jakub Jelinek
On Thu, Sep 28, 2023 at 10:55:46AM +0100, Richard Sandiford wrote: > Tested on aarch64-linux-gnu & x86_64-linux-gnu. Also tested with > Jakub's vec.h patch with the static_asserts uncommented; there were > no errors from poly_int-related stuff. OK to install? LGTM (mostly as the general idea,

[Bug middle-end/56281] missed VRP optimization on i for signed i << n from undefined left shift in ISO C

2023-09-28 Thread vincent-gcc at vinc17 dot net via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56281 --- Comment #6 from Vincent Lefèvre --- (In reply to Jakub Jelinek from comment #1) > Given the amount of code in the wild that assumes 1 << 31 etc. work, I think > it would be a bad idea to try to optimize this for C99, especially when it > is

[Bug middle-end/111505] [14 Regression] Asan (address-sanitizer) bootstrap fails since r14-4003-geaa8e8541349df

2023-09-28 Thread slyfox at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111505 --- Comment #4 from Sergei Trofimovich --- In https://gcc.gnu.org/PR111629#c0 profiled bootstrap fales for a similar reason. There ggc_common_finalize() memset()s unexpected memory location #1 0x01933651 in ggc_common_finalize () at

[Bug tree-optimization/111631] [14 Regression] Wrong code at -Os on x86_64-linux-gnu since r14-3217-g4d6132e5932

2023-09-28 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111631 --- Comment #2 from Andrew Pinski --- ldist produces: b_25 = (long int) j_23; d_26 = h; _8 = (sizetype) d_26; _38 = (char *) b_25; __builtin_memset (_38, 0, _8); and also we have: [local count: 13370358]: if (j_23 != 0) goto

Re: [PATCH] [11/12/13/14 Regression] ABI break in _Hash_node_value_base since GCC 11 [PR 111050]

2023-09-28 Thread Jonathan Wakely
On Wed, 27 Sept 2023 at 05:44, François Dumont wrote: > > Still no chance to get feedback from TC ? Maybe I can commit the below > then ? I've heard back from Tim now. Please use "Tim Song " as the author. You can change the commit again using git commit --amend --author "Tim Song " OK for

[Bug other/111632] gcc's C++ components fail to compile against recent libc++ headers

2023-09-28 Thread dimitry at andric dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111632 --- Comment #1 from Dimitry Andric --- Created attachment 56010 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56010=edit Include safe-ctype.h after C++ standard headers, to avoid over-poisoning

[Bug c++/111633] New: __restrict on a member function is permitted in an inconsistent location relative to ref-qualifiers

2023-09-28 Thread richard-gccbugzilla at metafoo dot co.uk via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111633 Bug ID: 111633 Summary: __restrict on a member function is permitted in an inconsistent location relative to ref-qualifiers Product: gcc Version: 14.0 Status:

Re: [PATCH] [11/12/13/14 Regression] ABI break in _Hash_node_value_base since GCC 11 [PR 111050]

2023-09-28 Thread François Dumont
On 28/09/2023 18:18, Jonathan Wakely wrote: On Wed, 27 Sept 2023 at 05:44, François Dumont wrote: Still no chance to get feedback from TC ? Maybe I can commit the below then ? I've heard back from Tim now. Please use "Tim Song " as the author. You can change the commit again using git

Re: [PATCH] Remove poly_int_pod

2023-09-28 Thread Jason Merrill
On 9/28/23 05:55, Richard Sandiford wrote: poly_int was written before the switch to C++11 and so couldn't use explicit default constructors. This led to an awkward split between poly_int_pod and poly_int. poly_int simply inherited from poly_int_pod and added constructors, with the

Re: [committed] libstdc++: Add GDB printers for types

2023-09-28 Thread Tom Tromey
Jonathan> The changes made by black seem reasonable, though I prefer it Jonathan> with -S to disable string-normalization. It also needs an Jonathan> option to use 79 as the maximum line length. I've got some patches I'm about to send. I made a pyproject.toml to auto-configure black (and isort),

Re: [PATCH 6/7] libstdc++: Fix regex escapes in pretty-printers

2023-09-28 Thread Jonathan Wakely
On Thu, 28 Sept 2023, 18:50 Tom Tromey via Libstdc++, wrote: > flake8 pointed out that some regexes in the pretty-printers are > missing a backslash. This patch fixes these. > I already have a patch to use r'...' for these, so we only need the single backslash. I'm also refactoring all those

[Bug target/104831] RISCV libatomic LR.aq/SC.rl pair insufficient for SEQ_CST

2023-09-28 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104831 Andrew Pinski changed: What|Removed |Added Target Milestone|--- |13.3

[Bug target/111466] RISC-V: redundant sign extensions despite ABI guarantees

2023-09-28 Thread vineetg at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111466 Vineet Gupta changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Last reconfirmed|

Re: [PATCH 1/7] libstdc++: Show full Python stack on error

2023-09-28 Thread Jonathan Wakely
On Thu, 28 Sept 2023, 18:48 Tom Tromey via Libstdc++, wrote: > This changes the libstdc++ test suite to arrange for gdb to show the > full Python stack if any sort of Python exception occurs. This makes > debugging the printers a little simpler. > Oh I wish I'd known about this sooner. OK for

Re: [PATCH 4/7] libstdc++: Remove unused locals from printers.py

2023-09-28 Thread Jonathan Wakely
On Thu, 28 Sept 2023, 18:50 Tom Tromey via Libstdc++, wrote: > flake8 pointed out some unused local variables in the libstdc++ > pretty-printers. This removes them. > OK, thanks. > libstdc++-v3/ChangeLog: > > * python/libstdcxx/v6/printers.py >

Re: [PATCH 6/7] libstdc++: Fix regex escapes in pretty-printers

2023-09-28 Thread Tom Tromey
Jonathan> I already have a patch to use r'...' for these, so we only Jonathan> need the single backslash. Yeah, probably nicer. Jonathan> So please don't commit this one, I think it will be Jonathan> unnecessary in a couple of hours. No problem, I'll drop it when I rebase on top of your

[Bug rtl-optimization/111626] missed optimization combining offset of array member in struct with offset inside the array

2023-09-28 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111626 Andrew Pinski changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW

[Bug rtl-optimization/108826] Inefficient address generation on POWER and RISC-V

2023-09-28 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108826 Andrew Pinski changed: What|Removed |Added CC||lis8215 at gmail dot com --- Comment

[PATCH] ggc: do not wipe out unrelated data via gt_ggc_rtab

2023-09-28 Thread Sergei Trofimovich
From: Sergei Trofimovich There are 3 GC root tables: gt_ggc_rtab gt_ggc_deletable_rtab gt_pch_scalar_rtab `deletable` and `scalar` tables are both simple: each element always contains a pointer to the beginning of the object and it's size is the full object. `rtab` is different: it's

Re: [PATCH 2/7] libstdc++: Use gdb.ValuePrinter base class

2023-09-28 Thread Jonathan Wakely
On Thu, 28 Sept 2023 at 18:50, Tom Tromey via Libstdc++ wrote: > > GDB 14 will add a new ValuePrinter tag class that will be used to > signal that pretty-printers will agree to the "extension protocol" -- > essentially that they will follow some simple namespace rules, so that > GDB can add new

[Bug target/111466] RISC-V: redundant sign extensions despite ABI guarantees

2023-09-28 Thread vineetg at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111466 --- Comment #2 from Vineet Gupta --- (In reply to Vineet Gupta from comment #1) > #1. REE reports failure as "missing definition(s)". > > This is because function args don't have an explicit def, they are just > there. > > Cannot eliminate

Re: [PATCH] libstdc++: Ensure active union member is correctly set

2023-09-28 Thread Nathaniel Shead
On Wed, Sep 27, 2023 at 03:13:35PM +0100, Jonathan Wakely wrote: > On Sat, 23 Sept 2023 at 08:30, Nathaniel Shead via Libstdc++ > wrote: > > > > On Sat, Sep 23, 2023 at 07:40:48AM +0100, Jonathan Wakely wrote: > > > On Sat, 23 Sept 2023, 01:39 Nathaniel Shead via Libstdc++, < > > >

[Bug target/111623] __sync_synchronize compiler barrier not honored (rv64)

2023-09-28 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111623 --- Comment #1 from Andrew Pinski --- Most likely this will be closed as fixed for GCC 12. There are some riscv atomic issues which were fixed post GCC 13 too.

[RFC] expr: don't clear SUBREG_PROMOTED_VAR_P flag for a promoted subreg [target/111466]

2023-09-28 Thread Vineet Gupta
RISC-V suffers from extraneous sign extensions, despite/given the ABI guarantee that 32-bit quantities are sign-extended into 64-bit registers, meaning incoming SI function args need not be explicitly sign extended (so do SI return values as most ALU insns implicitly sign-extend too.) Existing

[Bug libstdc++/111568] std::not_fn can accept non-movable function

2023-09-28 Thread hewillk at gmail dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111568 --- Comment #1 from 康桓瑋 --- bind_front also seems to missing Mandates: https://godbolt.org/z/8WPxc44h6 #include struct OnlyMovableFun { OnlyMovableFun() = default; OnlyMovableFun(const OnlyMovableFun&) = delete;

[Bug target/111634] RISC-V vector: ICE RTL check: expected code 'reg', have 'lo_sum' in rhs_regno, at rtl.h:1934

2023-09-28 Thread patrick at rivosinc dot com via Gcc-bugs
rtl-checking-testsuite/build-rv64gcv/../gcc/configure >--target=riscv64-unknown-linux-gnu --prefix=/ >// Thread model: posix >// Supported LTO compression algorithms: zlib zstd >// gcc version 14.0.0 20230928 (experimental) (g8552dcd8e44) >// >// during RTL pass: expand >// ../gc

Re: [PATCH 5/7] libstdc++: Remove std_ratio_t_tuple

2023-09-28 Thread Jonathan Wakely
On Thu, 28 Sept 2023, 18:55 Tom Tromey via Libstdc++, wrote: > This removes the std_ratio_t_tuple function from the Python > pretty-printer code. It is not used. Apparently the relevant parts > were moved to StdChronoDurationPrinter._ratio at some point in the > past. > I think I added it at

[PATCH v3] libstdc++: Fix handling of surrogate CP in codecvt [PR108976]

2023-09-28 Thread Dimitrij Mijoski
This patch fixes the handling of surrogate code points in all standard facets for transcoding Unicode that are based on std::codecvt. Surrogate code points should always be treated as error. On the other hand surrogate code units can only appear in UTF-16 and only when they come in a proper pair.

[committed] libstdc++: Format Python docstrings according to PEP 357

2023-09-28 Thread Jonathan Wakely
Tested x86_64-linux (GDB 13.2, Python 3.11). Pushed to trunk. -- >8 -- libstdc++-v3/ChangeLog: * python/libstdcxx/v6/printers.py: Format docstrings according to PEP 257. * python/libstdcxx/v6/xmethods.py: Likewise. --- libstdc++-v3/python/libstdcxx/v6/printers.py | 177

[Bug middle-end/111505] [14 Regression] Asan (address-sanitizer) bootstrap fails since r14-4003-geaa8e8541349df

2023-09-28 Thread slyfox at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111505 --- Comment #5 from Sergei Trofimovich --- (In reply to Sergei Trofimovich from comment #4) > Is it a ggc_common_finalize() bug in assuming that `base` does not point to > the bbeginning of a struct? > Or a `gt_ggc_r_gt_cp_tree_h` bug that it

[Bug middle-end/111621] [RISC-V] Bad register allocation in vadd.vi may cause operational error

2023-09-28 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111621 --- Comment #1 from Andrew Pinski --- Created attachment 56012 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56012=edit testcase (-march=rv64imafdcv -mabi=lp64d -O3) Please next time attach the testcase (or put it inline) and not just a

Re: [committed] libstdc++: Add GDB printers for types

2023-09-28 Thread Jonathan Wakely
On Thu, 28 Sept 2023, 18:37 Tom Tromey, wrote: > Jonathan> The changes made by black seem reasonable, though I prefer it > Jonathan> with -S to disable string-normalization. It also needs an > Jonathan> option to use 79 as the maximum line length. > > I've got some patches I'm about to send. > >

Re: [PATCH 7/7] libstdc++: Use Python "not in" operator

2023-09-28 Thread Jonathan Wakely
On Thu, 28 Sept 2023, 18:54 Tom Tromey via Libstdc++, wrote: > flake8 warns about code like > > not something in "whatever" > > Ordinarily in Python this should be written as: > > something not in "whatever" > > This patch makes this change. > OK, thanks. > libstdc++-v3/ChangeLog: >

[Bug target/111634] New: RISC-V vector: ICE RTL check: expected code 'reg', have 'lo_sum' in rhs_regno, at rtl.h:1934

2023-09-28 Thread patrick at rivosinc dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111634 Bug ID: 111634 Summary: RISC-V vector: ICE RTL check: expected code 'reg', have 'lo_sum' in rhs_regno, at rtl.h:1934 Product: gcc Version: 14.0 Status: UNCONFIRMED

[committed] libstdc++: Reformat Python code

2023-09-28 Thread Jonathan Wakely
Tested x86_64-linux (GDB 13.2, Python 3.11). Pushed to trunk. -- >8 -- Some of these changes were suggested by autopep8's --aggressive option, others are for readability. Break long lines by splitting strings across multiple lines, or introducing local variables to hold results. Use raw

[committed] libstdc++: Refactor Python Xmethods to use is_specialization_of

2023-09-28 Thread Jonathan Wakely
Tested x86_64-linux (GDB 13.2, Python 3.11). Pushed to trunk. -- >8 -- This copies the is_specialization_of function from printers.py (with slight modification for versioned namespace handling) and reuses it in xmethods.py to replace repetitive re.match calls in every class. This fixes the

  1   2   >