[jira] [Commented] (FLINK-7386) Flink Elasticsearch 5 connector is not compatible with Elasticsearch 5.2+ client

[ https://issues.apache.org/jira/browse/FLINK-7386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167365#comment-16167365 ] ASF GitHub Bot commented on FLINK-7386: --- Github user zjureel commented on the issue:

[GitHub] flink issue #4675: [FLINK-7386] FIx Elasticsearch 5 connector is not compati...

Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4675 @rmetzger @tzulitai I create this PR and try to fix [https://issues.apache.org/jira/browse/FLINK-7386(https://issues.apache.org/jira/browse/FLINK-7386). In the PR I do some things as follows:

[jira] [Commented] (FLINK-7386) Flink Elasticsearch 5 connector is not compatible with Elasticsearch 5.2+ client

[ https://issues.apache.org/jira/browse/FLINK-7386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167357#comment-16167357 ] ASF GitHub Bot commented on FLINK-7386: --- GitHub user zjureel opened a pull request:

[GitHub] flink pull request #4675: [FLINK-7386] FIx Elasticsearch 5 connector is not ...

GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/4675 [FLINK-7386] FIx Elasticsearch 5 connector is not compatible with Elasticsearch 5.2+ client ## What is the purpose of the change Add flink-connector-elasticsearch5.3 to support

[jira] [Commented] (FLINK-7627) SingleElementIterable should implement with Serializable

[ https://issues.apache.org/jira/browse/FLINK-7627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167317#comment-16167317 ] ASF GitHub Bot commented on FLINK-7627: --- GitHub user hequn8128 opened a pull request:

[GitHub] flink pull request #4674: [FLINK-7627] [table] SingleElementIterable should ...

GitHub user hequn8128 opened a pull request: https://github.com/apache/flink/pull/4674 [FLINK-7627] [table] SingleElementIterable should implement with Serializable ## What is the purpose of the change *This pull request is a bugfix which implements

[jira] [Created] (FLINK-7627) SingleElementIterable should implement with Serializable

Hequn Cheng created FLINK-7627: -- Summary: SingleElementIterable should implement with Serializable Key: FLINK-7627 URL: https://issues.apache.org/jira/browse/FLINK-7627 Project: Flink Issue

[jira] [Assigned] (FLINK-5858) Support multiple sinks in same execution DAG

[ https://issues.apache.org/jira/browse/FLINK-5858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he reassigned FLINK-5858: - Assignee: godfrey he > Support multiple sinks in same execution DAG >

[jira] [Comment Edited] (FLINK-7606) CEP operator leaks state

[ https://issues.apache.org/jira/browse/FLINK-7606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167242#comment-16167242 ] Dian Fu edited comment on FLINK-7606 at 9/15/17 2:18 AM: - I think this is by

[jira] [Commented] (FLINK-7606) CEP operator leaks state

[ https://issues.apache.org/jira/browse/FLINK-7606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167242#comment-16167242 ] Dian Fu commented on FLINK-7606: I think this is by design otherwise users could not get the timed out

[jira] [Commented] (FLINK-5859) support partition pruning on Table API & SQL

[ https://issues.apache.org/jira/browse/FLINK-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167224#comment-16167224 ] ASF GitHub Bot commented on FLINK-5859: --- Github user KurtYoung commented on a diff in the pull

[GitHub] flink pull request #4667: [FLINK-5859] [table] Add PartitionableTableSource ...

Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/4667#discussion_r139049572 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/PartitionableTableSource.scala --- @@ -0,0 +1,193 @@ +/* + *

[jira] [Commented] (FLINK-5859) support partition pruning on Table API & SQL

[ https://issues.apache.org/jira/browse/FLINK-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167219#comment-16167219 ] ASF GitHub Bot commented on FLINK-5859: --- Github user KurtYoung commented on a diff in the pull

[GitHub] flink pull request #4667: [FLINK-5859] [table] Add PartitionableTableSource ...

Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/4667#discussion_r139049316 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/PartitionableTableSource.scala --- @@ -0,0 +1,193 @@ +/* + *

[jira] [Commented] (FLINK-5859) support partition pruning on Table API & SQL

[ https://issues.apache.org/jira/browse/FLINK-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167216#comment-16167216 ] ASF GitHub Bot commented on FLINK-5859: --- Github user KurtYoung commented on a diff in the pull

[GitHub] flink pull request #4667: [FLINK-5859] [table] Add PartitionableTableSource ...

Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/4667#discussion_r139048604 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/PartitionableTableSource.scala --- @@ -0,0 +1,193 @@ +/* + *

[jira] [Commented] (FLINK-4047) Fix documentation about determinism of KeySelectors

[ https://issues.apache.org/jira/browse/FLINK-4047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167214#comment-16167214 ] ASF GitHub Bot commented on FLINK-4047: --- Github user zhangminglei commented on a diff in the pull

[GitHub] flink pull request #4659: [FLINK-4047] Fix documentation about determinism o...

Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/4659#discussion_r139048412 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/functions/KeySelector.java --- @@ -36,7 +37,7 @@ public interface KeySelector

[jira] [Commented] (FLINK-5859) support partition pruning on Table API & SQL

[ https://issues.apache.org/jira/browse/FLINK-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167213#comment-16167213 ] ASF GitHub Bot commented on FLINK-5859: --- Github user KurtYoung commented on a diff in the pull

[GitHub] flink pull request #4667: [FLINK-5859] [table] Add PartitionableTableSource ...

Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/4667#discussion_r139048337 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/FilterableTableSource.scala --- @@ -55,4 +55,9 @@ trait

[jira] [Closed] (FLINK-7617) Remove string format in BitSet to improve the performance of BuildSideOuterjoin

[ https://issues.apache.org/jira/browse/FLINK-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-7617. - Resolution: Fixed Fix Version/s: 1.3.3 1.4.0 > Remove string format in BitSet

[jira] [Commented] (FLINK-7617) Remove string format in BitSet to improve the performance of BuildSideOuterjoin

[ https://issues.apache.org/jira/browse/FLINK-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167179#comment-16167179 ] ASF GitHub Bot commented on FLINK-7617: --- Github user KurtYoung commented on the issue:

[GitHub] flink issue #4668: [FLINK-7617] Remove string format in BitSet to improve th...

Github user KurtYoung commented on the issue: https://github.com/apache/flink/pull/4668 @fhueske sure ---

[jira] [Commented] (FLINK-3991) Remove deprecated configuration keys from ConfigConstants

[ https://issues.apache.org/jira/browse/FLINK-3991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167060#comment-16167060 ] Chetna Chaudhari commented on FLINK-3991: - Is it still open? Can I work on it? > Remove

[GitHub] flink issue #4673: [hotfix] [cep] Fix afterMatchStrategy parameter missing i...

Github user yestinchen commented on the issue: https://github.com/apache/flink/pull/4673 Hi @dawidwys , I just found this issue in after match feature, which causes AfterMatchSkipStrategy not work. This may be introduced while merging file conflicts. I addressed that in this PR

[jira] [Commented] (FLINK-7622) Respect local KPL queue size in FlinkKinesisProducer when adding records to KPL client

[ https://issues.apache.org/jira/browse/FLINK-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166925#comment-16166925 ] Bowen Li commented on FLINK-7622: - [~tzulitai] I think FLINK-7508 indirectly solves this issue, since

[jira] [Commented] (FLINK-7508) switch FlinkKinesisProducer to use KPL's ThreadingMode to ThreadedPool mode rather than Per_Request mode

[ https://issues.apache.org/jira/browse/FLINK-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166783#comment-16166783 ] ASF GitHub Bot commented on FLINK-7508: --- Github user bowenli86 commented on the issue:

[GitHub] flink issue #4656: [FLINK-7508][kinesis] switch FlinkKinesisProducer to use ...

Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4656 @tzulitai Thanks, Gordon! I watched your presentation on "managing state of Flink", and you did a great job explaining all details. I added an option for PER_REQUEST model since it doesn't

[jira] [Commented] (FLINK-7508) switch FlinkKinesisProducer to use KPL's ThreadingMode to ThreadedPool mode rather than Per_Request mode

[ https://issues.apache.org/jira/browse/FLINK-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166709#comment-16166709 ] ASF GitHub Bot commented on FLINK-7508: --- Github user bowenli86 commented on a diff in the pull

[GitHub] flink pull request #4656: [FLINK-7508][kinesis] switch FlinkKinesisProducer ...

Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4656#discussion_r138965647 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java --- @@ -171,8

[jira] [Commented] (FLINK-7567) DataStream#iterate() on env.fromElements() / env.fromCollection() does not work

[ https://issues.apache.org/jira/browse/FLINK-7567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166633#comment-16166633 ] ASF GitHub Bot commented on FLINK-7567: --- Github user mlipkovich commented on the issue:

[GitHub] flink issue #4655: [FLINK-7567]: Removed keepPartitioning parameter from ite...

Github user mlipkovich commented on the issue: https://github.com/apache/flink/pull/4655 The local build works fine. If you mean `mvn verify` by compatibility plugin it also worked with no issues ---

[jira] [Commented] (FLINK-4814) Remove extra storage location for externalized checkpoint metadata

[ https://issues.apache.org/jira/browse/FLINK-4814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166576#comment-16166576 ] Elias Levy commented on FLINK-4814: --- Yes please. That would be helpful. I would suggest multiple

[GitHub] flink issue #4658: [Flink-7596][Table API & SQL] fix bug when Set Operation ...

Github user Xpray commented on the issue: https://github.com/apache/flink/pull/4658 @twalthr , I've rewrite the methods, please have a look. ---

[jira] [Commented] (FLINK-7589) org.apache.http.ConnectionClosedException: Premature end of Content-Length delimited message body (expected: 159764230; received: 64638536)

[ https://issues.apache.org/jira/browse/FLINK-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166527#comment-16166527 ] Steve Loughran commented on FLINK-7589: --- bq. is there any plan to make Flink use AWS S3 SDK

[GitHub] flink issue #4665: [Flink-7611]add metrics to measure the num of data droppe...

Github user Aitozi commented on the issue: https://github.com/apache/flink/pull/4665 @aljoscha i agree that the name set to be "numLateElementsDropped", and do you mean that my result should minus the num of element that go to side output which is skipped and lateElement? ---

[GitHub] flink pull request #4673: [hotfix] [cep] Fix afterMatchStrategy parameter mi...

GitHub user yestinchen opened a pull request: https://github.com/apache/flink/pull/4673 [hotfix] [cep] Fix afterMatchStrategy parameter missing issue ## What is the purpose of the change Fix afterMatchSkipStrategy parameter missing when calling `nfa.process()`

[jira] [Commented] (FLINK-7589) org.apache.http.ConnectionClosedException: Premature end of Content-Length delimited message body (expected: 159764230; received: 64638536)

[ https://issues.apache.org/jira/browse/FLINK-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166515#comment-16166515 ] Bowen Li commented on FLINK-7589: - [~aljoscha] Yes, the job restarted successfully. Just curious - is

[GitHub] flink issue #4658: [Flink-7596][Table API & SQL] fix bug when Set Operation ...

Github user Xpray commented on the issue: https://github.com/apache/flink/pull/4658 what about overriding `leastRestrictiveSqlType` method in `FlinkTypeFactory`? ---

[jira] [Commented] (FLINK-4796) Add new Sink interface with access to more meta data

[ https://issues.apache.org/jira/browse/FLINK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166443#comment-16166443 ] Erik van Oosten commented on FLINK-4796: I am not sure why this is marked as a duplicate. The

[GitHub] flink issue #4658: [Flink-7596][Table API & SQL] fix bug when Set Operation ...

Github user Xpray commented on the issue: https://github.com/apache/flink/pull/4658 Thanks for your advice. I am considering a better way to solve this. ---

[jira] [Commented] (FLINK-4814) Remove extra storage location for externalized checkpoint metadata

[ https://issues.apache.org/jira/browse/FLINK-4814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166428#comment-16166428 ] Aljoscha Krettek commented on FLINK-4814: - Yes I think this is still a problem and I think it's

[jira] [Commented] (FLINK-4047) Fix documentation about determinism of KeySelectors

[ https://issues.apache.org/jira/browse/FLINK-4047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166401#comment-16166401 ] ASF GitHub Bot commented on FLINK-4047: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request #4659: [FLINK-4047] Fix documentation about determinism o...

Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4659#discussion_r138918167 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/functions/KeySelector.java --- @@ -36,7 +37,7 @@ public interface KeySelector

[jira] [Closed] (FLINK-4796) Add new Sink interface with access to more meta data

[ https://issues.apache.org/jira/browse/FLINK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-4796. --- Resolution: Duplicate > Add new Sink interface with access to more meta data >

[jira] [Commented] (FLINK-4796) Add new Sink interface with access to more meta data

[ https://issues.apache.org/jira/browse/FLINK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166394#comment-16166394 ] Aljoscha Krettek commented on FLINK-4796: - Ah I see, the workaround is for the NPE. > Add new

[jira] [Commented] (FLINK-4796) Add new Sink interface with access to more meta data

[ https://issues.apache.org/jira/browse/FLINK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166391#comment-16166391 ] Aljoscha Krettek commented on FLINK-4796: - Sorry, I didn't get what this workaround is for. Could

[jira] [Assigned] (FLINK-4796) Add new Sink interface with access to more meta data

[ https://issues.apache.org/jira/browse/FLINK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek reassigned FLINK-4796: --- Assignee: Aljoscha Krettek > Add new Sink interface with access to more meta data >

[jira] [Commented] (FLINK-2646) Rich functions should provide a method "closeAfterFailure()"

[ https://issues.apache.org/jira/browse/FLINK-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166387#comment-16166387 ] Aljoscha Krettek commented on FLINK-2646: - I thought about this and the new

[jira] [Commented] (FLINK-7589) org.apache.http.ConnectionClosedException: Premature end of Content-Length delimited message body (expected: 159764230; received: 64638536)

[ https://issues.apache.org/jira/browse/FLINK-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166370#comment-16166370 ] Aljoscha Krettek commented on FLINK-7589: - Yes, I think we cannot do much except wait here.

[jira] [Commented] (FLINK-7617) Remove string format in BitSet to improve the performance of BuildSideOuterjoin

[ https://issues.apache.org/jira/browse/FLINK-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166369#comment-16166369 ] ASF GitHub Bot commented on FLINK-7617: --- Github user fhueske commented on the issue:

[GitHub] flink issue #4668: [FLINK-7617] Remove string format in BitSet to improve th...

Github user fhueske commented on the issue: https://github.com/apache/flink/pull/4668 Hi @KurtYoung, do you want to merge this to the `release-1.3` branch as well? ---

[jira] [Commented] (FLINK-7567) DataStream#iterate() on env.fromElements() / env.fromCollection() does not work

[ https://issues.apache.org/jira/browse/FLINK-7567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166365#comment-16166365 ] ASF GitHub Bot commented on FLINK-7567: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #4655: [FLINK-7567]: Removed keepPartitioning parameter from ite...

Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4655 You can try and run the build locally to have a look at the file generated by the compatibility plugin. Then we can figure out why it's complaining. ---

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r138905728 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/LargeRecordHandler.java --- @@ -218,7 +221,7 @@ public long addRecord(T

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r138904204 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerConfiguration.java --- @@ -115,6 +115,13 @@ public Configuration

[jira] [Assigned] (FLINK-7617) Remove string format in BitSet to improve the performance of BuildSideOuterjoin

[ https://issues.apache.org/jira/browse/FLINK-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek reassigned FLINK-7617: --- Assignee: Jingsong Lee > Remove string format in BitSet to improve the performance

[jira] [Updated] (FLINK-7607) Web Frontend Hangs with Large Numbers of Tasks

[ https://issues.apache.org/jira/browse/FLINK-7607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-7607: Fix Version/s: 1.4.0 > Web Frontend Hangs with Large Numbers of Tasks >

[jira] [Commented] (FLINK-7606) CEP operator leaks state

[ https://issues.apache.org/jira/browse/FLINK-7606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166340#comment-16166340 ] Aljoscha Krettek commented on FLINK-7606: - Will NFAs not be cleared when the allowed "within" time

[jira] [Updated] (FLINK-7606) CEP operator leaks state

[ https://issues.apache.org/jira/browse/FLINK-7606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-7606: Summary: CEP operator leaks state (was: Memory leak on NestedMapsStateTable) > CEP

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r138899420 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/LargeRecordHandler.java --- @@ -218,7 +221,7 @@ public long addRecord(T

[jira] [Updated] (FLINK-7590) Flink failed to flush and close the file system output stream for checkpointing because of s3 read timeout

[ https://issues.apache.org/jira/browse/FLINK-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-7590: Priority: Major (was: Blocker) > Flink failed to flush and close the file system output

[jira] [Commented] (FLINK-7590) Flink failed to flush and close the file system output stream for checkpointing because of s3 read timeout

[ https://issues.apache.org/jira/browse/FLINK-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166333#comment-16166333 ] Aljoscha Krettek commented on FLINK-7590: - Agreed! > Flink failed to flush and close the file

[jira] [Commented] (FLINK-7378) Create a fix size (non rebalancing) buffer pool type for the floating buffers

[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166323#comment-16166323 ] ASF GitHub Bot commented on FLINK-7378: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7378) Create a fix size (non rebalancing) buffer pool type for the floating buffers

[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166322#comment-16166322 ] ASF GitHub Bot commented on FLINK-7378: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7378) Create a fix size (non rebalancing) buffer pool type for the floating buffers

[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166324#comment-16166324 ] ASF GitHub Bot commented on FLINK-7378: --- Github user NicoK commented on a diff in the pull request:

[jira] [Updated] (FLINK-7608) LatencyGauge change to histogram metric

[ https://issues.apache.org/jira/browse/FLINK-7608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-7608: Priority: Blocker (was: Major) > LatencyGauge change to histogram metric >

[jira] [Commented] (FLINK-7378) Create a fix size (non rebalancing) buffer pool type for the floating buffers

[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166327#comment-16166327 ] ASF GitHub Bot commented on FLINK-7378: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7378) Create a fix size (non rebalancing) buffer pool type for the floating buffers

[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166329#comment-16166329 ] ASF GitHub Bot commented on FLINK-7378: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7378) Create a fix size (non rebalancing) buffer pool type for the floating buffers

[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166328#comment-16166328 ] ASF GitHub Bot commented on FLINK-7378: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7378) Create a fix size (non rebalancing) buffer pool type for the floating buffers

[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166325#comment-16166325 ] ASF GitHub Bot commented on FLINK-7378: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7378) Create a fix size (non rebalancing) buffer pool type for the floating buffers

[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166331#comment-16166331 ] ASF GitHub Bot commented on FLINK-7378: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7378) Create a fix size (non rebalancing) buffer pool type for the floating buffers

[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166330#comment-16166330 ] ASF GitHub Bot commented on FLINK-7378: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7378) Create a fix size (non rebalancing) buffer pool type for the floating buffers

[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166326#comment-16166326 ] ASF GitHub Bot commented on FLINK-7378: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4485: [FLINK-7378][core]Create a fix size (non rebalanci...

Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4485#discussion_r138891582 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/NetworkBufferPoolTest.java --- @@ -172,44 +178,117 @@ public void

[GitHub] flink pull request #4485: [FLINK-7378][core]Create a fix size (non rebalanci...

Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4485#discussion_r138889161 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/NetworkBufferPoolTest.java --- @@ -172,44 +178,117 @@ public void

[GitHub] flink pull request #4485: [FLINK-7378][core]Create a fix size (non rebalanci...

Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4485#discussion_r13882 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/NetworkBufferPoolTest.java --- @@ -172,44 +178,117 @@ public void

[GitHub] flink pull request #4485: [FLINK-7378][core]Create a fix size (non rebalanci...

Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4485#discussion_r138879343 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/NetworkBufferPool.java --- @@ -159,23 +159,20 @@ public void

[GitHub] flink pull request #4485: [FLINK-7378][core]Create a fix size (non rebalanci...

Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4485#discussion_r13514 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/NetworkBufferPoolTest.java --- @@ -172,44 +178,117 @@ public void

[GitHub] flink pull request #4485: [FLINK-7378][core]Create a fix size (non rebalanci...

Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4485#discussion_r138897087 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java --- @@ -333,7 +333,7 @@ public void

[GitHub] flink pull request #4485: [FLINK-7378][core]Create a fix size (non rebalanci...

Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4485#discussion_r138889183 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/NetworkBufferPoolTest.java --- @@ -172,44 +178,117 @@ public void

[GitHub] flink pull request #4485: [FLINK-7378][core]Create a fix size (non rebalanci...

Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4485#discussion_r138852758 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/BufferPoolFactoryTest.java --- @@ -155,6 +156,57 @@ public void

[GitHub] flink pull request #4485: [FLINK-7378][core]Create a fix size (non rebalanci...

Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4485#discussion_r13440 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/NetworkBufferPoolTest.java --- @@ -172,44 +178,117 @@ public void

[GitHub] flink pull request #4485: [FLINK-7378][core]Create a fix size (non rebalanci...

Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4485#discussion_r138853431 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/BufferPoolFactoryTest.java --- @@ -155,6 +156,57 @@ public void

[jira] [Created] (FLINK-7626) Add some metric description about checkpoints

Hai Zhou created FLINK-7626: --- Summary: Add some metric description about checkpoints Key: FLINK-7626 URL: https://issues.apache.org/jira/browse/FLINK-7626 Project: Flink Issue Type: Bug

[GitHub] flink pull request #4658: [Flink-7596][Table API & SQL] fix bug when Set Ope...

Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4658#discussion_r138894127 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/calcite/sql/type/SqlTypeFactoryImpl.java --- @@ -0,0 +1,575 @@ +/* + * Licensed to

[GitHub] flink issue #4665: [Flink-7611]add metrics to measure the num of data droppe...

Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4665 These are not actually the places where you can count dropped data. I would suggest to add this at the very end of `processElement()` where we also check whether we should side-output late data:

[jira] [Closed] (FLINK-6331) StreamingOperatorsITCase.testAsyncWaitOperator spuriously failing on Travis

[ https://issues.apache.org/jira/browse/FLINK-6331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-6331. Resolution: Cannot Reproduce Could not reproduce the problem. Will close the issue therefore. If

[jira] [Closed] (FLINK-5205) Asynchronous remove job messages can interfere with recovered or resubmitted jobs

[ https://issues.apache.org/jira/browse/FLINK-5205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-5205. Resolution: Won't Fix Seems not to be a problem and with the Flip-6 changes obsolete. >

[jira] [Closed] (FLINK-2733) ZooKeeperLeaderElectionTest.testZooKeeperReelection fails

[ https://issues.apache.org/jira/browse/FLINK-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-2733. Resolution: Not A Problem > ZooKeeperLeaderElectionTest.testZooKeeperReelection fails >

[jira] [Commented] (FLINK-2733) ZooKeeperLeaderElectionTest.testZooKeeperReelection fails

[ https://issues.apache.org/jira/browse/FLINK-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166301#comment-16166301 ] Till Rohrmann commented on FLINK-2733: -- I think [~tonycox], you actually did not use the fixed code

[GitHub] flink issue #4672: [Flink-7621][TableAPI & SQL] Fix Inconsistency of CaseSen...

Github user twalthr commented on the issue: https://github.com/apache/flink/pull/4672 Thanks @Xpray. The changes look good, but I think if we would really want to have the correct behavior, we need to make more changes at different positions. Could you add some more tests to check

[jira] [Assigned] (FLINK-2253) ALS fails if the data flow is split up and the input is non-deterministic

[ https://issues.apache.org/jira/browse/FLINK-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-2253: Assignee: (was: Till Rohrmann) > ALS fails if the data flow is split up and the input

[jira] [Commented] (FLINK-7618) Add BINARY supported in FlinkTypeFactory

[ https://issues.apache.org/jira/browse/FLINK-7618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166294#comment-16166294 ] ASF GitHub Bot commented on FLINK-7618: --- Github user twalthr commented on the issue:

[GitHub] flink issue #4669: [FLINK-7618][table] Add BINARY supported in FlinkTypeFact...

Github user twalthr commented on the issue: https://github.com/apache/flink/pull/4669 Thanks @sunjincheng121 but we cannot merge this without tests. Adding a new type should have some tests esp. because you have to add this type at different positions. E.g. `FlinkRelNode` and in the

[jira] [Commented] (FLINK-7617) Remove string format in BitSet to improve the performance of BuildSideOuterjoin

[ https://issues.apache.org/jira/browse/FLINK-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166291#comment-16166291 ] ASF GitHub Bot commented on FLINK-7617: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #4668: [FLINK-7617] Remove string format in BitSet to imp...

Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4668 ---

[jira] [Commented] (FLINK-7491) Support COLLECT Aggregate function in Flink SQL

[ https://issues.apache.org/jira/browse/FLINK-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166289#comment-16166289 ] ASF GitHub Bot commented on FLINK-7491: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7491) Support COLLECT Aggregate function in Flink SQL

[ https://issues.apache.org/jira/browse/FLINK-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166288#comment-16166288 ] ASF GitHub Bot commented on FLINK-7491: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #4585: [FLINK-7491] [Table API & SQL] add MultiSetTypeInf...

Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4585#discussion_r13586 --- Diff: flink-core/pom.xml --- @@ -80,6 +80,13 @@ under the License. + +

  1   2   >