[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #22330: [FLINK-31635][network] Support writing records to the new tiered store architecture

2023-05-07 Thread via GitHub
TanYuxin-tyx commented on code in PR #22330: URL: https://github.com/apache/flink/pull/22330#discussion_r1187052528 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionID.java: ## @@ -23,6 +23,9 @@ import

[GitHub] [flink] pgaref commented on a diff in pull request #22520: [FLINK-31996] Chaining operators with different max parallelism prevents rescaling

2023-05-07 Thread via GitHub
pgaref commented on code in PR #22520: URL: https://github.com/apache/flink/pull/22520#discussion_r1187021736 ## flink-core/src/main/java/org/apache/flink/configuration/PipelineOptions.java: ## @@ -243,13 +243,22 @@ public class PipelineOptions {

[jira] [Updated] (FLINK-32019) EARLIEST offset strategy for partitions discoveried later based on FLIP-288

2023-05-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32019: --- Labels: pull-request-available (was: ) > EARLIEST offset strategy for partitions

[jira] [Updated] (FLINK-32021) Improvement the Javadoc for SpecifiedOffsetsInitializer and TimestampOffsetsInitializer.

2023-05-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32021: --- Labels: pull-request-available (was: ) > Improvement the Javadoc for

[GitHub] [flink-connector-kafka] loserwang1024 opened a new pull request, #29: [FLINK-32021][Connectors/Kafka] Improvement the Javadoc for SpecifiedOffsetsInitializer and TimestampOffsetsInitializer

2023-05-07 Thread via GitHub
loserwang1024 opened a new pull request, #29: URL: https://github.com/apache/flink-connector-kafka/pull/29 ### What is the purpose of the change As described in 

[GitHub] [flink-connector-kafka] loserwang1024 closed pull request #28: EARLIEST offset strategy for partitions discoveried later based on FLIP-288

2023-05-07 Thread via GitHub
loserwang1024 closed pull request #28: EARLIEST offset strategy for partitions discoveried later based on FLIP-288 URL: https://github.com/apache/flink-connector-kafka/pull/28 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink-connector-kafka] loserwang1024 opened a new pull request, #28: EARLIEST offset strategy for partitions discoveried later based on FLIP-288

2023-05-07 Thread via GitHub
loserwang1024 opened a new pull request, #28: URL: https://github.com/apache/flink-connector-kafka/pull/28 ### What is the purpose of the change As described in

[GitHub] [flink-connector-pulsar] tisonkun merged pull request #44: [FLINK-32003] Upgrade pulsar-client version to work with OAuth2

2023-05-07 Thread via GitHub
tisonkun merged PR #44: URL: https://github.com/apache/flink-connector-pulsar/pull/44 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] zhuzhurk commented on a diff in pull request #22506: [FLINK-31890][runtime] Introduce JobMaster per-task failure enrichment/labeling

2023-05-07 Thread via GitHub
zhuzhurk commented on code in PR #22506: URL: https://github.com/apache/flink/pull/22506#discussion_r1186678825 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java: ## @@ -473,26 +500,50 @@ public CompletableFuture cancel(Time timeout) {

[jira] [Commented] (FLINK-32027) Batch jobs could hang at shuffle phase when max parallelism is really large

2023-05-07 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720378#comment-17720378 ] Yun Tang commented on FLINK-32027: -- [~Weijie Guo] [~zhuzh] Please take a look at this issue. > Batch

[jira] [Created] (FLINK-32027) Batch jobs could hang at shuffle phase when max parallelism is really large

2023-05-07 Thread Yun Tang (Jira)
Yun Tang created FLINK-32027: Summary: Batch jobs could hang at shuffle phase when max parallelism is really large Key: FLINK-32027 URL: https://issues.apache.org/jira/browse/FLINK-32027 Project: Flink

[jira] [Commented] (FLINK-32023) execution.buffer-timeout cannot be set to -1 ms

2023-05-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720377#comment-17720377 ] Rui Fan commented on FLINK-32023: - Thanks [~wanglijie] 's feedback. Sorry, after my double check, I see

[jira] [Updated] (FLINK-32023) execution.buffer-timeout cannot be set to -1 ms

2023-05-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-32023: Affects Version/s: 1.16.1 1.17.0 1.18.0 Issue

[jira] [Commented] (FLINK-32023) execution.buffer-timeout cannot be set to -1 ms

2023-05-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720375#comment-17720375 ] Rui Fan commented on FLINK-32023: - Hi [~Jiangang] , thanks for your report. It's really a bug. Would you

[jira] [Updated] (FLINK-32026) jdbc-3.1.0-1.16 left join conversion error

2023-05-07 Thread xueyongyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xueyongyang updated FLINK-32026: Issue Type: Bug (was: Improvement) > jdbc-3.1.0-1.16 left join conversion error >

[jira] [Created] (FLINK-32026) jdbc-3.1.0-1.16 left join conversion error

2023-05-07 Thread xueyongyang (Jira)
xueyongyang created FLINK-32026: --- Summary: jdbc-3.1.0-1.16 left join conversion error Key: FLINK-32026 URL: https://issues.apache.org/jira/browse/FLINK-32026 Project: Flink Issue Type:

[jira] [Commented] (FLINK-32023) execution.buffer-timeout cannot be set to -1 ms

2023-05-07 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720374#comment-17720374 ] Lijie Wang commented on FLINK-32023: [~Jiangang] Thanks for reporting this. Would you like to

[GitHub] [flink] TanYuxin-tyx commented on pull request #22427: [FLINK-30815][tests] Migrate BatchAbstractTestBase and BatchTestBase to junit5

2023-05-07 Thread via GitHub
TanYuxin-tyx commented on PR #22427: URL: https://github.com/apache/flink/pull/22427#issuecomment-1537644742 @godfreyhe @JunRuiLee Thanks for helping review the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink-kubernetes-operator] X-czh commented on a diff in pull request #586: [FLINK-32002] Adjust autoscaler defaults for release

2023-05-07 Thread via GitHub
X-czh commented on code in PR #586: URL: https://github.com/apache/flink-kubernetes-operator/pull/586#discussion_r1186953244 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/config/AutoScalerOptions.java: ## @@ -87,28 +88,28

[GitHub] [flink-kubernetes-operator] X-czh commented on a diff in pull request #586: [FLINK-32002] Adjust autoscaler defaults for release

2023-05-07 Thread via GitHub
X-czh commented on code in PR #586: URL: https://github.com/apache/flink-kubernetes-operator/pull/586#discussion_r1186950803 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/config/AutoScalerOptions.java: ## @@ -68,15 +68,16

[GitHub] [flink-kubernetes-operator] X-czh commented on a diff in pull request #586: [FLINK-32002] Adjust autoscaler defaults for release

2023-05-07 Thread via GitHub
X-czh commented on code in PR #586: URL: https://github.com/apache/flink-kubernetes-operator/pull/586#discussion_r1186950803 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/config/AutoScalerOptions.java: ## @@ -68,15 +68,16

[jira] [Commented] (FLINK-31997) Update to Fabric8 6.5.1+ in flink-kubernetes

2023-05-07 Thread Thomas Weise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720364#comment-17720364 ] Thomas Weise commented on FLINK-31997: -- [~gyfora] would it be possible to also shade the fabric8

[jira] [Resolved] (FLINK-32025) Make job cancellation button on UI configurable

2023-05-07 Thread Ted Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu resolved FLINK-32025. Resolution: Duplicate > Make job cancellation button on UI configurable >

[jira] [Commented] (FLINK-32025) Make job cancellation button on UI configurable

2023-05-07 Thread Echo Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720362#comment-17720362 ] Echo Lee commented on FLINK-32025: -- It is already possible to hide the 'cancel job' button by setting

[jira] [Created] (FLINK-32025) Make job cancellation button on UI configurable

2023-05-07 Thread Ted Yu (Jira)
Ted Yu created FLINK-32025: -- Summary: Make job cancellation button on UI configurable Key: FLINK-32025 URL: https://issues.apache.org/jira/browse/FLINK-32025 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-29847) Store/cache JarUploadResponseBody

2023-05-07 Thread xiaochen zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720328#comment-17720328 ] xiaochen zhou commented on FLINK-29847: --- hi, I would like to give a try on this, can  I take this

[jira] [Commented] (FLINK-31967) SQL with LAG function NullPointerException

2023-05-07 Thread padavan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720303#comment-17720303 ] padavan commented on FLINK-31967: - [~martijnvisser] [~jark] [~lincoln.86xy]  If you need anything else,

[GitHub] [flink-connector-pulsar] reswqa merged pull request #47: [BP-3.0][hotfix] Python connector download link should refer to the url defined in externalized repository

2023-05-07 Thread via GitHub
reswqa merged PR #47: URL: https://github.com/apache/flink-connector-pulsar/pull/47 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-connector-pulsar] reswqa merged pull request #46: [hotfix] Python connector download link should refer to the url defined in externalized repository

2023-05-07 Thread via GitHub
reswqa merged PR #46: URL: https://github.com/apache/flink-connector-pulsar/pull/46 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-connector-pulsar] tisonkun merged pull request #45: [hotfix] Workaround new violations message

2023-05-07 Thread via GitHub
tisonkun merged PR #45: URL: https://github.com/apache/flink-connector-pulsar/pull/45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-connector-pulsar] reswqa commented on a diff in pull request #45: [hotfix] Workaround new violations message

2023-05-07 Thread via GitHub
reswqa commented on code in PR #45: URL: https://github.com/apache/flink-connector-pulsar/pull/45#discussion_r1186793455 ## flink-connector-pulsar/archunit-violations/f4d91193-72ba-4ce4-ad83-98f780dce581: ## @@ -10,3 +10,15 @@

[GitHub] [flink-connector-pulsar] reswqa commented on a diff in pull request #45: [hotfix] Workaround new violations message

2023-05-07 Thread via GitHub
reswqa commented on code in PR #45: URL: https://github.com/apache/flink-connector-pulsar/pull/45#discussion_r1186793455 ## flink-connector-pulsar/archunit-violations/f4d91193-72ba-4ce4-ad83-98f780dce581: ## @@ -10,3 +10,15 @@

[jira] [Updated] (FLINK-32024) Short code related to externalized connector retrieve version from its own data yaml

2023-05-07 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-32024: --- Summary: Short code related to externalized connector retrieve version from its own data yaml

[jira] [Updated] (FLINK-32024) Short code related to external connector retrieve version from its own data yaml

2023-05-07 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-32024: --- Description: Currently, we have some shortcodes specifically designed for externalized connector,

[jira] [Updated] (FLINK-32024) Short code related to external connector retrieve version from its own data yaml

2023-05-07 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-32024: --- Description: Currently, we have some shortcodes specifically designed for externalized connector,

[jira] [Created] (FLINK-32024) Short code related to external connector retrieve version from its own data yaml

2023-05-07 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-32024: -- Summary: Short code related to external connector retrieve version from its own data yaml Key: FLINK-32024 URL: https://issues.apache.org/jira/browse/FLINK-32024

[GitHub] [flink-connector-pulsar] tisonkun commented on a diff in pull request #45: [hotfix] Workaround new violations message

2023-05-07 Thread via GitHub
tisonkun commented on code in PR #45: URL: https://github.com/apache/flink-connector-pulsar/pull/45#discussion_r1186792428 ## flink-connector-pulsar/archunit-violations/f4d91193-72ba-4ce4-ad83-98f780dce581: ## @@ -10,3 +10,15 @@

[GitHub] [flink-connector-aws] reswqa opened a new pull request, #72: [hotfix] Python connector download link should refer to the url defined in externalized repository

2023-05-07 Thread via GitHub
reswqa opened a new pull request, #72: URL: https://github.com/apache/flink-connector-aws/pull/72 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink-connector-aws] reswqa opened a new pull request, #71: [hotfix] Python connector download link should refer to the url defined in externalized repository

2023-05-07 Thread via GitHub
reswqa opened a new pull request, #71: URL: https://github.com/apache/flink-connector-aws/pull/71 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink-connector-pulsar] reswqa commented on a diff in pull request #45: [hotfix] Workaround new violations message

2023-05-07 Thread via GitHub
reswqa commented on code in PR #45: URL: https://github.com/apache/flink-connector-pulsar/pull/45#discussion_r1186787932 ## flink-connector-pulsar/archunit-violations/f4d91193-72ba-4ce4-ad83-98f780dce581: ## @@ -10,3 +10,15 @@

[GitHub] [flink-connector-pulsar] reswqa commented on a diff in pull request #45: [hotfix] Workaround new violations message

2023-05-07 Thread via GitHub
reswqa commented on code in PR #45: URL: https://github.com/apache/flink-connector-pulsar/pull/45#discussion_r1186787932 ## flink-connector-pulsar/archunit-violations/f4d91193-72ba-4ce4-ad83-98f780dce581: ## @@ -10,3 +10,15 @@

[GitHub] [flink-connector-pulsar] reswqa commented on a diff in pull request #45: [hotfix] Workaround new violations message

2023-05-07 Thread via GitHub
reswqa commented on code in PR #45: URL: https://github.com/apache/flink-connector-pulsar/pull/45#discussion_r1186787331 ## flink-connector-pulsar/archunit-violations/f4d91193-72ba-4ce4-ad83-98f780dce581: ## @@ -10,3 +10,15 @@

[GitHub] [flink-connector-pulsar] reswqa commented on a diff in pull request #45: [hotfix] Workaround new violations message

2023-05-07 Thread via GitHub
reswqa commented on code in PR #45: URL: https://github.com/apache/flink-connector-pulsar/pull/45#discussion_r1186787932 ## flink-connector-pulsar/archunit-violations/f4d91193-72ba-4ce4-ad83-98f780dce581: ## @@ -10,3 +10,15 @@