lucasbru commented on code in PR #15661:
URL: https://github.com/apache/kafka/pull/15661#discussion_r1559790393
##
tests/kafkatest/services/verifiable_consumer.py:
##
@@ -135,6 +135,28 @@ def last_commit(self, tp):
else:
return None
+# This needs to be
lucasbru merged PR #15661:
URL: https://github.com/apache/kafka/pull/15661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
philipnee commented on code in PR #15661:
URL: https://github.com/apache/kafka/pull/15661#discussion_r1559662337
##
tests/kafkatest/services/verifiable_consumer.py:
##
@@ -135,6 +135,28 @@ def last_commit(self, tp):
else:
return None
+# This needs to be
lucasbru commented on code in PR #15661:
URL: https://github.com/apache/kafka/pull/15661#discussion_r1559094045
##
tests/kafkatest/services/verifiable_consumer.py:
##
@@ -135,6 +135,28 @@ def last_commit(self, tp):
else:
return None
+# This needs to be
philipnee commented on PR #15661:
URL: https://github.com/apache/kafka/pull/15661#issuecomment-2040290159
@cadonna @lucasbru - Is it possible for me to ask for a review on this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
philipnee commented on PR #15661:
URL: https://github.com/apache/kafka/pull/15661#issuecomment-2038266652
Can we change the message to : `err_msg="expecting valid assignments of %d
partitions for node %d but got: %s" % \`
--
This is an automated message from the Apache Git Service.
To
philipnee commented on PR #15661:
URL: https://github.com/apache/kafka/pull/15661#issuecomment-2038263452
Thanks for reviewing this. This is the test results:
```
SESSION REPORT (ALL TESTS)
philipnee commented on PR #15661:
URL: https://github.com/apache/kafka/pull/15661#issuecomment-2038186018
@kirktrue - This inherits from the patch you attached to the jira ticket.
Would you have time to review this PR?
--
This is an automated message from the Apache Git Service.
To
philipnee opened a new pull request, #15661:
URL: https://github.com/apache/kafka/pull/15661
The current AssignmentValidationTest only tests EAGER assignment protocol
and does not support incremental assignment like CooperativeStickyAssignor and
consumer protocol. Therefore in the