Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-26 Thread via GitHub
cadonna merged PR #15698: URL: https://github.com/apache/kafka/pull/15698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-25 Thread via GitHub
lianetm commented on PR #15698: URL: https://github.com/apache/kafka/pull/15698#issuecomment-2077313831 Thanks for the helpful comments @cadonna , all addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-25 Thread via GitHub
lianetm commented on code in PR #15698: URL: https://github.com/apache/kafka/pull/15698#discussion_r1579555839 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -469,19 +469,33 @@ public void resetTimer() {

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-25 Thread via GitHub
lianetm commented on code in PR #15698: URL: https://github.com/apache/kafka/pull/15698#discussion_r1579555219 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -164,6 +165,23 @@ public void testHeartbeatOnStartup() {

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-25 Thread via GitHub
cadonna commented on code in PR #15698: URL: https://github.com/apache/kafka/pull/15698#discussion_r1579191646 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -164,6 +165,23 @@ public void testHeartbeatOnStartup() {

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-25 Thread via GitHub
cadonna commented on code in PR #15698: URL: https://github.com/apache/kafka/pull/15698#discussion_r1579191646 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -164,6 +165,23 @@ public void testHeartbeatOnStartup() {

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-25 Thread via GitHub
cadonna commented on code in PR #15698: URL: https://github.com/apache/kafka/pull/15698#discussion_r1579191646 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -164,6 +165,23 @@ public void testHeartbeatOnStartup() {

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-25 Thread via GitHub
cadonna commented on code in PR #15698: URL: https://github.com/apache/kafka/pull/15698#discussion_r1579187392 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -164,6 +165,23 @@ public void testHeartbeatOnStartup() {

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-22 Thread via GitHub
lianetm commented on PR #15698: URL: https://github.com/apache/kafka/pull/15698#issuecomment-2069725394 Hi @cadonna, thanks for the comments! - the unit test I added initially fails on

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-22 Thread via GitHub
cadonna commented on code in PR #15698: URL: https://github.com/apache/kafka/pull/15698#discussion_r1574708196 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -482,6 +484,14 @@ public long nextHeartbeatMs(final long

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-22 Thread via GitHub
cadonna commented on code in PR #15698: URL: https://github.com/apache/kafka/pull/15698#discussion_r1574660830 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -482,6 +484,14 @@ public long nextHeartbeatMs(final long

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-18 Thread via GitHub
lianetm commented on PR #15698: URL: https://github.com/apache/kafka/pull/15698#issuecomment-2064258399 Hey @cadonna, could you take a look when you have chance? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-17 Thread via GitHub
lianetm commented on PR #15698: URL: https://github.com/apache/kafka/pull/15698#issuecomment-2062253184 Thanks for the comments @kirktrue, all addressed. Regarding your comment regarding tests [here](https://github.com/apache/kafka/pull/15698#pullrequestreview-2004676007), we have

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-17 Thread via GitHub
lianetm commented on code in PR #15698: URL: https://github.com/apache/kafka/pull/15698#discussion_r1569511540 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -231,6 +231,35 @@ public void testTimerNotDue() {

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-17 Thread via GitHub
lianetm commented on code in PR #15698: URL: https://github.com/apache/kafka/pull/15698#discussion_r1569504137 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -482,6 +482,15 @@ public long nextHeartbeatMs(final long

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-17 Thread via GitHub
lianetm commented on code in PR #15698: URL: https://github.com/apache/kafka/pull/15698#discussion_r1569498394 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -380,7 +380,7 @@ private void onErrorResponse(final

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-16 Thread via GitHub
kirktrue commented on code in PR #15698: URL: https://github.com/apache/kafka/pull/15698#discussion_r1567992301 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -482,6 +482,15 @@ public long nextHeartbeatMs(final long

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-15 Thread via GitHub
lianetm commented on code in PR #15698: URL: https://github.com/apache/kafka/pull/15698#discussion_r1565783934 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -269,6 +269,9 @@ private NetworkClientDelegate.UnsentRequest

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-15 Thread via GitHub
lianetm commented on PR #15698: URL: https://github.com/apache/kafka/pull/15698#issuecomment-2056883089 Hey @cadonna, thanks a lot for your feedback! All comments addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-15 Thread via GitHub
lianetm commented on code in PR #15698: URL: https://github.com/apache/kafka/pull/15698#discussion_r1565815246 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -482,6 +484,14 @@ public long nextHeartbeatMs(final long

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-15 Thread via GitHub
lianetm commented on code in PR #15698: URL: https://github.com/apache/kafka/pull/15698#discussion_r1565783934 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -269,6 +269,9 @@ private NetworkClientDelegate.UnsentRequest

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-12 Thread via GitHub
cadonna commented on code in PR #15698: URL: https://github.com/apache/kafka/pull/15698#discussion_r1562500382 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -269,6 +269,9 @@ private NetworkClientDelegate.UnsentRequest

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-11 Thread via GitHub
lianetm commented on PR #15698: URL: https://github.com/apache/kafka/pull/15698#issuecomment-2050401151 Hey @cadonna , could you take a look at this small fix when you have a chance? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please