kamalcph commented on PR #15241:
URL: https://github.com/apache/kafka/pull/15241#issuecomment-2074186450
Thanks for the patch @jeqo!
I was able to reproduce the exception mentioned in the ticket by calling
close in-middle of collecting the aborted transactions. The fix doesn't
showuon commented on code in PR #15744:
URL: https://github.com/apache/kafka/pull/15744#discussion_r1577340553
##
core/src/test/scala/unit/kafka/zk/AdminZkClientTest.scala:
##
@@ -194,6 +199,8 @@ class AdminZkClientTest extends QuorumTestHarness with
Logging with RackAwareTes
showuon commented on code in PR #15305:
URL: https://github.com/apache/kafka/pull/15305#discussion_r1577316104
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java:
##
@@ -533,6 +536,57 @@ public void
showuon merged PR #15787:
URL: https://github.com/apache/kafka/pull/15787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mimaison commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1577653920
##
core/src/main/scala/kafka/metrics/LinuxIoMetricsCollector.scala:
##
@@ -29,9 +29,9 @@ import scala.jdk.CollectionConverters._
*/
class
mimaison commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1577660497
##
core/src/main/scala/kafka/zookeeper/ZooKeeperClient.scala:
##
@@ -52,8 +51,8 @@ object ZooKeeperClient {
* @param sessionTimeoutMs session timeout in
chia7712 commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1577684664
##
core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala:
##
@@ -347,7 +347,7 @@ abstract class KafkaServerTestHarness extends
QuorumTestHarness {
Chia-Ping Tsai created KAFKA-16610:
--
Summary: Replace "Map#entrySet#forEach" by "Map#forEach"
Key: KAFKA-16610
URL: https://issues.apache.org/jira/browse/KAFKA-16610
Project: Kafka
Issue
Chia-Ping Tsai created KAFKA-16611:
--
Summary: Consider adding test name to "client.id" of Admin in
testing
Key: KAFKA-16611
URL: https://issues.apache.org/jira/browse/KAFKA-16611
Project: Kafka
chia7712 merged PR #15679:
URL: https://github.com/apache/kafka/pull/15679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-16612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-16612:
-
Assignee: Luke Chen
> Talking to controllers via AdminClient requires reconfiguring controller
[
https://issues.apache.org/jira/browse/KAFKA-16612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-16612:
-
Assignee: (was: Luke Chen)
> Talking to controllers via AdminClient requires reconfiguring
OmniaGM commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2074952186
> > Note: We have already RaftConfig but it seems to contain limited amount
of configs that only configure controller raft and shouldn't include configs
shared by both broker/controller
[
https://issues.apache.org/jira/browse/KAFKA-15749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840439#comment-17840439
]
Walter Hernandez commented on KAFKA-15749:
--
PR is officially stale:
[
https://issues.apache.org/jira/browse/KAFKA-16606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840469#comment-17840469
]
Igor Soarez commented on KAFKA-16606:
-
I'm inclined to agree, I think we can still do this. We are
[
https://issues.apache.org/jira/browse/KAFKA-16606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Soarez reopened KAFKA-16606:
-
Assignee: Igor Soarez
> JBOD support in KRaft does not seem to be gated by the metadata
OmniaGM commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2075131518
> just curios. Why moving to raft module can cause circle dependencies?
Currently raft doesn't depend of core or server but I just fear that mixing
quorum raft and KRaft mode related
chia7712 merged PR #15792:
URL: https://github.com/apache/kafka/pull/15792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2075158081
> If we start to move related kraft classes to raft module like
KafkaRaftManager this will be tricky as now
org.apache.kafka.raft.KafkaRaftManager needs
[
https://issues.apache.org/jira/browse/KAFKA-16610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16610:
--
Assignee: TengYao Chi (was: Chia-Ping Tsai)
> Replace "Map#entrySet#forEach" by
PoAn Yang created KAFKA-16613:
-
Summary: Remove TestUtils#subscribeAndWaitForRecords
Key: KAFKA-16613
URL: https://issues.apache.org/jira/browse/KAFKA-16613
Project: Kafka
Issue Type: Test
mumrah commented on code in PR #15754:
URL: https://github.com/apache/kafka/pull/15754#discussion_r1577998958
##
tests/kafkatest/tests/core/zookeeper_migration_test.py:
##
@@ -86,10 +87,35 @@ def do_migration(self, roll_controller = False,
downgrade_to_zk = False):
showuon commented on PR #15616:
URL: https://github.com/apache/kafka/pull/15616#issuecomment-2074547860
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
FrankYang0529 opened a new pull request, #15794:
URL: https://github.com/apache/kafka/pull/15794
After https://github.com/apache/kafka/pull/15679, we remove most of usage of
`TestUtils#subscribeAndWaitForRecords`. The only remaining case uses it is
chia7712 commented on PR #15762:
URL: https://github.com/apache/kafka/pull/15762#issuecomment-2074861414
I don't see any related failure, so I'm going to merge it to trunk and
branch 3.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
chia7712 commented on PR #15761:
URL: https://github.com/apache/kafka/pull/15761#issuecomment-2074923817
@brandboat Could you rebase code to trigger QA again? I run those tests on
my local. They pass
--
This is an automated message from the Apache Git Service.
To respond to the message,
chia7712 commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2075082750
> Personally I think the first option (which keep the pr as it is) is easier
to navigate as we know where all the config used by Kafka Raft server (maybe
renaming this to
mimaison commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1577656938
##
core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala:
##
@@ -347,7 +347,7 @@ abstract class KafkaServerTestHarness extends
QuorumTestHarness {
[
https://issues.apache.org/jira/browse/KAFKA-16610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840392#comment-17840392
]
TengYao Chi commented on KAFKA-16610:
-
I can handle this issue :)
> Replace "Map#entrySet#forEach"
Gantigmaa Selenge created KAFKA-16612:
-
Summary: Talking to controllers via AdminClient requires
reconfiguring controller listener
Key: KAFKA-16612
URL: https://issues.apache.org/jira/browse/KAFKA-16612
chia7712 commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2074832899
What about moving `KRaftConfig` to raft module? and we can moving all
configs from `RaftConfig` to `KRaftConfig`. With those changes, all
raft-related configs are in `KRaftConfig`.
[
https://issues.apache.org/jira/browse/KAFKA-16592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16592.
Fix Version/s: 3.8.0
Resolution: Fixed
> ConfigKey constructor update can break
chia7712 commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1577874954
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerRunnable.java:
##
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
[
https://issues.apache.org/jira/browse/KAFKA-15203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Owen C.H. Leung reassigned KAFKA-15203:
---
Assignee: Owen C.H. Leung
> Remove dependency on Reflections
>
[
https://issues.apache.org/jira/browse/KAFKA-15203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Owen C.H. Leung reassigned KAFKA-15203:
---
Assignee: (was: Owen C.H. Leung)
> Remove dependency on Reflections
>
johnnychhsu commented on PR #15788:
URL: https://github.com/apache/kafka/pull/15788#issuecomment-2075021540
thanks for the review and suggestions @chia7712 @OmniaGM
let me check and address it
--
This is an automated message from the Apache Git Service.
To respond to the message,
chia7712 merged PR #15793:
URL: https://github.com/apache/kafka/pull/15793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #15791:
URL: https://github.com/apache/kafka/pull/15791#issuecomment-2075129365
not sure whether we have 3.6.3 release. It seems we don't have `.3` usually
:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/KAFKA-16606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840472#comment-17840472
]
Jakub Scholz commented on KAFKA-16606:
--
Ok, thanks [~soarez] and [~mimaison].
> JBOD support in
mimaison commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1577677934
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -2192,8 +2192,8 @@ class PlaintextAdminIntegrationTest extends
kamalcph closed pull request #15141: KAFKA-16073: [Tiered] Update
localLogStartOffset before deleting segments in memory t…
URL: https://github.com/apache/kafka/pull/15141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
kamalcph commented on PR #15141:
URL: https://github.com/apache/kafka/pull/15141#issuecomment-2074558819
The patch is landed to trunk, 3.7 and 3.6 branches so closing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/KAFKA-16424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen resolved KAFKA-16424.
---
Fix Version/s: 3.8.0
Resolution: Fixed
> truncated logs will be left undeleted after alter
showuon merged PR #15616:
URL: https://github.com/apache/kafka/pull/15616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-16483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16483.
Fix Version/s: 3.8.0
Resolution: Fixed
> Apply `ClusterTestExtensions` to
>
[
https://issues.apache.org/jira/browse/KAFKA-16612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840402#comment-17840402
]
Luke Chen commented on KAFKA-16612:
---
[~cmccabe] , any thoughts about this?
> Talking to controllers
mumrah commented on code in PR #15754:
URL: https://github.com/apache/kafka/pull/15754#discussion_r1577997204
##
tests/kafkatest/services/kafka/kafka.py:
##
@@ -463,6 +463,18 @@ def reconfigure_zk_for_migration(self, kraft_quorum):
# This is not added to
CalvinConfluent commented on code in PR #15657:
URL: https://github.com/apache/kafka/pull/15657#discussion_r1578296803
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -402,6 +412,30 @@ public synchronized void
TaiJuWu opened a new pull request, #15796:
URL: https://github.com/apache/kafka/pull/15796
As title
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation
OmniaGM commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2075595461
> > > Maybe we should rename RaftConfig to QuorumConfig as all configs in
QuorumConfig have prefix QUORUM_
>
> > This is good point, maybe this can be a followup PR
>
>
OmniaGM opened a new pull request, #15797:
URL: https://github.com/apache/kafka/pull/15797
For context
https://github.com/apache/kafka/pull/15775#issuecomment-2075340243
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify
lianetm commented on code in PR #15778:
URL: https://github.com/apache/kafka/pull/15778#discussion_r1578363393
##
tests/kafkatest/tests/client/consumer_test.py:
##
@@ -242,16 +242,15 @@ def test_static_consumer_bounce(self, clean_shutdown,
static_membership, bounce_
chia7712 commented on code in PR #15797:
URL: https://github.com/apache/kafka/pull/15797#discussion_r1578498362
##
raft/src/main/java/org/apache/kafka/raft/QuorumConfigs.java:
##
@@ -47,7 +47,7 @@
* controller should be able to transition from standby to active without
[
https://issues.apache.org/jira/browse/KAFKA-16217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840502#comment-17840502
]
Calvin Liu commented on KAFKA-16217:
[~kirktrue] The cherry-pick for the 3.7 is merged. For the
Chia-Ping Tsai created KAFKA-16614:
--
Summary: Disallow `@ClusterTemplate("")`
Key: KAFKA-16614
URL: https://issues.apache.org/jira/browse/KAFKA-16614
Project: Kafka
Issue Type: Improvement
lianetm commented on code in PR #15778:
URL: https://github.com/apache/kafka/pull/15778#discussion_r1578363393
##
tests/kafkatest/tests/client/consumer_test.py:
##
@@ -242,16 +242,15 @@ def test_static_consumer_bounce(self, clean_shutdown,
static_membership, bounce_
kirktrue opened a new pull request, #15799:
URL: https://github.com/apache/kafka/pull/15799
The format of the 'describe topic' output was changed as part of KAFKA-15585
which required an update in the parsing logic used by system tests.
### Committer Checklist (excluded from commit
kirktrue commented on PR #15799:
URL: https://github.com/apache/kafka/pull/15799#issuecomment-2075814568
@lucasbru—would you mind taking a look at this change? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1578083329
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,281 @@
+/*
+ * Licensed to the Apache Software
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1578083329
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,281 @@
+/*
+ * Licensed to the Apache Software
chia7712 commented on PR #15696:
URL: https://github.com/apache/kafka/pull/15696#issuecomment-2075243743
> Thanks for the reply. I have tried the following code and received the
results. Each time I run the code, the DescribeTopicsResult gives a different
configurations of the brokers in
chia7712 commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2075295917
> KafkaConfig will move out of core and into server, however, for the time
being I don't plan to make raft depend on server for now as far as I can see
the only case I might need to do
jolshan commented on PR #15755:
URL: https://github.com/apache/kafka/pull/15755#issuecomment-2075323626
Hey @dajac thanks for taking a look. We didn't include
https://github.com/apache/kafka/commit/a8203f9c7a2c449ee59ee29d775409b2f1e00d07
in 3.7 so I feel like adding this code is
OmniaGM commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2075356299
> It seems org.apache.kafka.raft.KafkaRaftManager needs
org.apache.kafka.server.config.KafkaConfig won't happen if the 5 getters are
moved, right?
Sorry I maybe wan't clear
OmniaGM commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2075357578
> Maybe we should rename RaftConfig to QuorumConfig as all configs in
QuorumConfig have prefix QUORUM_
This is good point, maybe this can be a followup PR
--
This is an
chia7712 commented on PR #15786:
URL: https://github.com/apache/kafka/pull/15786#issuecomment-2075606243
> It looks like the previous CI build had an issue with the Java 8/Scala
2.12 pipeline. I rekicked a build.
oh, I rekicked it too :_
--
This is an automated message from the
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1578074445
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,281 @@
+/*
+ * Licensed to the Apache Software
OmniaGM commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2075270699
> > If we start to move related kraft classes to raft module like
KafkaRaftManager this will be tricky as now
org.apache.kafka.raft.KafkaRaftManager needs
chia7712 commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2075340243
> I don't think we should merge them with RaftConfig as RaftConfig should be
separate as it is only for the quorum raft and not KRAFT mode which are a bit
different in my option.
dajac commented on PR #15755:
URL: https://github.com/apache/kafka/pull/15755#issuecomment-2075368110
@jolshan That makes sense. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mimaison commented on PR #15786:
URL: https://github.com/apache/kafka/pull/15786#issuecomment-2075580384
It looks like the previous CI build had an issue with the Java 8/Scala 2.12
pipeline. I rekicked a build.
--
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/KAFKA-16614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840545#comment-17840545
]
TaiJuWu commented on KAFKA-16614:
-
Hello [~chia7712] , Could you assign this ticket to me if you don't
[
https://issues.apache.org/jira/browse/KAFKA-16614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16614:
--
Assignee: TaiJuWu (was: Chia-Ping Tsai)
> Disallow `@ClusterTemplate("")`
>
chia7712 commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2075392820
>> Maybe we should rename RaftConfig to QuorumConfig as all configs in
QuorumConfig have prefix QUORUM_
> This is good point, maybe this can be a followup PR
After renaming
jolshan commented on PR #15657:
URL: https://github.com/apache/kafka/pull/15657#issuecomment-2075537428
Thanks @CalvinConfluent I will try to take a look sometime today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
jolshan commented on code in PR #15657:
URL: https://github.com/apache/kafka/pull/15657#discussion_r1578348187
##
clients/src/main/java/org/apache/kafka/common/requests/ProduceRequest.java:
##
@@ -40,6 +40,7 @@
import static
jolshan commented on code in PR #15657:
URL: https://github.com/apache/kafka/pull/15657#discussion_r1578346148
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -979,6 +1013,13 @@ void handleCoordinatorReady() {
lianetm commented on code in PR #15737:
URL: https://github.com/apache/kafka/pull/15737#discussion_r1578381540
##
tests/kafkatest/services/verifiable_consumer.py:
##
@@ -140,22 +150,32 @@ class
IncrementalAssignmentConsumerEventHandler(ConsumerEventHandler):
def
lianetm commented on code in PR #15778:
URL: https://github.com/apache/kafka/pull/15778#discussion_r1578363393
##
tests/kafkatest/tests/client/consumer_test.py:
##
@@ -242,16 +242,15 @@ def test_static_consumer_bounce(self, clean_shutdown,
static_membership, bounce_
[
https://issues.apache.org/jira/browse/KAFKA-15743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Proven Provenzano reopened KAFKA-15743:
---
The {{registerBroker}} function in this test file needs to use the directory
UUIDs
CalvinConfluent commented on PR #15657:
URL: https://github.com/apache/kafka/pull/15657#issuecomment-2075521654
@jolshan Updated the PR
1. Reverted the KafkaApi changes. Now if the produce request with the
TransactionV2 supported version, the server will process it no matter what
lianetm commented on code in PR #15778:
URL: https://github.com/apache/kafka/pull/15778#discussion_r1578363393
##
tests/kafkatest/tests/client/consumer_test.py:
##
@@ -242,16 +242,15 @@ def test_static_consumer_bounce(self, clean_shutdown,
static_membership, bounce_
lianetm commented on code in PR #15778:
URL: https://github.com/apache/kafka/pull/15778#discussion_r1578363393
##
tests/kafkatest/tests/client/consumer_test.py:
##
@@ -242,16 +242,15 @@ def test_static_consumer_bounce(self, clean_shutdown,
static_membership, bounce_
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1578074445
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,281 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/KAFKA-16613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16613.
Fix Version/s: 3.8.0
Resolution: Fixed
> Remove
Dongnuo Lyu created KAFKA-16615:
---
Summary: JoinGroup API for upgrading ConsumerGroup
Key: KAFKA-16615
URL: https://issues.apache.org/jira/browse/KAFKA-16615
Project: Kafka
Issue Type: Sub-task
CalvinConfluent commented on code in PR #15657:
URL: https://github.com/apache/kafka/pull/15657#discussion_r1578298683
##
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##
@@ -109,7 +109,7 @@ class AddPartitionsToTxnManager(
chia7712 merged PR #15794:
URL: https://github.com/apache/kafka/pull/15794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kirktrue commented on code in PR #15737:
URL: https://github.com/apache/kafka/pull/15737#discussion_r1578634103
##
tests/kafkatest/services/verifiable_consumer.py:
##
@@ -140,22 +150,32 @@ class
IncrementalAssignmentConsumerEventHandler(ConsumerEventHandler):
def
Alyssa Huang created KAFKA-16616:
Summary: refactor mergeWith in MetadataSnapshot
Key: KAFKA-16616
URL: https://issues.apache.org/jira/browse/KAFKA-16616
Project: Kafka
Issue Type:
[
https://issues.apache.org/jira/browse/KAFKA-16164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alyssa Huang reassigned KAFKA-16164:
Assignee: Alyssa Huang
> Pre-Vote
>
>
> Key: KAFKA-16164
>
jolshan commented on PR #15685:
URL: https://github.com/apache/kafka/pull/15685#issuecomment-2076088235
Separately I need to fix the update tool. It will always say the finalized
version is 0 if the tool knows of the feature, even if the broker doesn't
include it in the list of finalized
jolshan merged PR #15739:
URL: https://github.com/apache/kafka/pull/15739
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-16610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Soarez resolved KAFKA-16610.
-
Resolution: Resolved
> Replace "Map#entrySet#forEach" by "Map#forEach"
>
showuon commented on code in PR #15801:
URL: https://github.com/apache/kafka/pull/15801#discussion_r1578771823
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -171,8 +162,8 @@ private String[]
github-actions[bot] commented on PR #15109:
URL: https://github.com/apache/kafka/pull/15109#issuecomment-2076286592
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
[
https://issues.apache.org/jira/browse/KAFKA-16584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840639#comment-17840639
]
Matthias J. Sax commented on KAFKA-16584:
-
Yes, it does required to write code. – It does also
TaiJuWu opened a new pull request, #15800:
URL: https://github.com/apache/kafka/pull/15800
As title.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation
chia7712 commented on code in PR #15800:
URL: https://github.com/apache/kafka/pull/15800#discussion_r1578597252
##
core/src/test/java/kafka/test/junit/ClusterTestExtensions.java:
##
@@ -123,8 +123,7 @@ private void processClusterTemplate(ExtensionContext
context,
[
https://issues.apache.org/jira/browse/KAFKA-15146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840595#comment-17840595
]
Igor Soarez commented on KAFKA-15146:
-
Another instance
1 - 100 of 129 matches
Mail list logo