johnnychhsu opened a new pull request, #15503:
URL: https://github.com/apache/kafka/pull/15503
## Context
TopicCommandIntegrationTest.testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress
is flaky, I would like to fix this.
Jira ticket:
FrankYang0529 opened a new pull request, #15502:
URL: https://github.com/apache/kafka/pull/15502
The `MessageConversionsTimeMs` is calculated by `Math.round` before updating
metrics, so it could be zero if it run too fast.
Modify updating logic as only updating metrics if
kamalcph commented on PR #15201:
URL: https://github.com/apache/kafka/pull/15201#issuecomment-1986704478
rebased the patch with trunk. The failed tests are unrelated.
cc @junrao @satishd
--
This is an automated message from the Apache Git Service.
To respond to the message,
chia7712 commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1518449958
##
core/src/test/scala/integration/kafka/api/OffsetOfMaxTimestampTest.scala:
##
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
OmniaGM opened a new pull request, #15501:
URL: https://github.com/apache/kafka/pull/15501
Moving KafkaConfig props out of core. The pr is big however it's mostly
renaming the props to match Java constant patterns and switching to
`org.apache.kafka.server.config.KafkaConfig` instead of the
junrao commented on code in PR #15474:
URL: https://github.com/apache/kafka/pull/15474#discussion_r1518419803
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogValidator.java:
##
@@ -417,8 +422,14 @@ public ValidationResult
junrao commented on PR #15474:
URL: https://github.com/apache/kafka/pull/15474#issuecomment-1986585552
Also, https://github.com/apache/kafka/pull/15476#discussion_r1518413083
applies to here too. We just need to fix it in one of the PRs.
--
This is an automated message from the Apache
junrao commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1518422852
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogValidator.java:
##
@@ -293,11 +293,11 @@ public ValidationResult
assignOffsetsNonCompressed(LongRef
junrao commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1518420555
##
core/src/test/scala/integration/kafka/api/OffsetOfMaxTimestampTest.scala:
##
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
jolshan commented on PR #15454:
URL: https://github.com/apache/kafka/pull/15454#issuecomment-1986575283
Can you check `testTransactionCoordinatorResolution()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jolshan commented on code in PR #15454:
URL: https://github.com/apache/kafka/pull/15454#discussion_r1518416635
##
core/src/test/scala/unit/kafka/server/AddPartitionsToTxnManagerTest.scala:
##
@@ -98,19 +99,20 @@ class AddPartitionsToTxnManagerTest {
junrao commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1518413083
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogValidator.java:
##
@@ -293,11 +293,11 @@ public ValidationResult
assignOffsetsNonCompressed(LongRef
mjsax merged PR #15500:
URL: https://github.com/apache/kafka/pull/15500
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mjsax commented on code in PR #15500:
URL: https://github.com/apache/kafka/pull/15500#discussion_r1518395847
##
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##
@@ -285,8 +285,10 @@ public class ProducerConfig extends AbstractConfig {
nizhikov commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-1986494220
@chia7712 PR merged with latest trunk and ready for review. Please, take a
look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
joel-hamill commented on PR #15500:
URL: https://github.com/apache/kafka/pull/15500#issuecomment-1986393715
cc @cherylws
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
joel-hamill opened a new pull request, #15500:
URL: https://github.com/apache/kafka/pull/15500
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
Fixed improper
[
https://issues.apache.org/jira/browse/KAFKA-16358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hector Geraldino updated KAFKA-16358:
-
Description:
When reading the [Kafka Connect
mjsax commented on PR #15494:
URL: https://github.com/apache/kafka/pull/15494#issuecomment-1986339244
Oh dear... I did commit some of these change on the wrong branch, and
committed it with a totally unrelated PR:
hgeraldino opened a new pull request, #15499:
URL: https://github.com/apache/kafka/pull/15499
Minor changes to the docs that:
* Sort transformations by name
* Adds missing `Cast`, `TimestampConverter` and `Flatten` transformations to
the list
* Adds anchor links for each
chia7712 commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-1986332968
@nizhikov please rebase it. I feel we can complete this hard work this week
:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
chia7712 commented on PR #15465:
URL: https://github.com/apache/kafka/pull/15465#issuecomment-1986332391
@nizhikov nice patch. Let us go back to #14471 :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
chia7712 merged PR #15465:
URL: https://github.com/apache/kafka/pull/15465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-16358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hector Geraldino reassigned KAFKA-16358:
Assignee: Hector Geraldino
> Update Connect Transformation documentation
>
Hector Geraldino created KAFKA-16358:
Summary: Update Connect Transformation documentation
Key: KAFKA-16358
URL: https://issues.apache.org/jira/browse/KAFKA-16358
Project: Kafka
Issue
mjsax commented on PR #12742:
URL: https://github.com/apache/kafka/pull/12742#issuecomment-1986241410
Merged to `trunk`. Thanks for the KIP and PR @calmera!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
mjsax merged PR #12742:
URL: https://github.com/apache/kafka/pull/12742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jolshan commented on PR #15486:
URL: https://github.com/apache/kafka/pull/15486#issuecomment-1986154766
I took a quick skim of the tests -- just wanted to confirm we have a test
for the old produce request + invalid txn state returned?
--
This is an automated message from the Apache Git
jolshan commented on code in PR #15486:
URL: https://github.com/apache/kafka/pull/15486#discussion_r1518065460
##
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##
@@ -49,7 +49,8 @@ object AddPartitionsToTxnManager {
*/
class
jolshan commented on code in PR #15486:
URL: https://github.com/apache/kafka/pull/15486#discussion_r1518067902
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -1007,7 +1010,8 @@ class ReplicaManager(val config: KafkaConfig,
transactionalId,
chia7712 commented on code in PR #15474:
URL: https://github.com/apache/kafka/pull/15474#discussion_r1518065927
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -52,20 +55,30 @@ public class GetOffsetShellTest {
private final int topicCount = 4;
jolshan commented on code in PR #15486:
URL: https://github.com/apache/kafka/pull/15486#discussion_r1518065460
##
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##
@@ -49,7 +49,8 @@ object AddPartitionsToTxnManager {
*/
class
jolshan commented on code in PR #15486:
URL: https://github.com/apache/kafka/pull/15486#discussion_r1518064096
##
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##
@@ -228,11 +232,17 @@ class AddPartitionsToTxnManager(
val tp = new
jolshan commented on code in PR #15486:
URL: https://github.com/apache/kafka/pull/15486#discussion_r1518064096
##
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##
@@ -228,11 +232,17 @@ class AddPartitionsToTxnManager(
val tp = new
jolshan commented on code in PR #15486:
URL: https://github.com/apache/kafka/pull/15486#discussion_r1518063503
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java:
##
@@ -3151,6 +3152,45 @@ public void testInvalidTxnStateIsAnAbortableError()
jolshan commented on code in PR #15486:
URL: https://github.com/apache/kafka/pull/15486#discussion_r1518062498
##
clients/src/main/resources/common/message/ProduceRequest.json:
##
@@ -35,7 +35,10 @@
// Version 9 enables flexible versions.
//
// Version 10 is the same
jolshan commented on code in PR #15486:
URL: https://github.com/apache/kafka/pull/15486#discussion_r1518061441
##
clients/src/main/java/org/apache/kafka/common/errors/AbortableTransactionException.java:
##
@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache Software Foundation
jolshan commented on code in PR #15474:
URL: https://github.com/apache/kafka/pull/15474#discussion_r1518058151
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -52,20 +55,30 @@ public class GetOffsetShellTest {
private final int topicCount = 4;
ijuma commented on code in PR #15474:
URL: https://github.com/apache/kafka/pull/15474#discussion_r1518055609
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -52,20 +55,30 @@ public class GetOffsetShellTest {
private final int topicCount = 4;
[
https://issues.apache.org/jira/browse/KAFKA-15649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824838#comment-17824838
]
Igor Soarez commented on KAFKA-15649:
-
That would be great, please do [~viktorsomogyi]
> Handle
Jacek Wojciechowski created KAFKA-16357:
---
Summary: Kafka Client JAR manifest breaks javac linting
Key: KAFKA-16357
URL: https://issues.apache.org/jira/browse/KAFKA-16357
Project: Kafka
Greg Harris created KAFKA-16356:
---
Summary: Remove class-name dispatch in RemoteLogMetadataSerde
Key: KAFKA-16356
URL: https://issues.apache.org/jira/browse/KAFKA-16356
Project: Kafka
Issue
divijvaidya commented on PR #15403:
URL: https://github.com/apache/kafka/pull/15403#issuecomment-1986041001
Hey @testn
Tests in the CI seem to be failing due to this change such as
divijvaidya commented on PR #15402:
URL: https://github.com/apache/kafka/pull/15402#issuecomment-1986036580
@testn congratulations on your first contribution to Apache Kafka! Hopefully
first of many more to come.
--
This is an automated message from the Apache Git Service.
To respond to
divijvaidya commented on PR #15402:
URL: https://github.com/apache/kafka/pull/15402#issuecomment-1986032863
The test failures are unrelated to this change.
@testn You can see the test failures in the orange build by clicking on the
arrow on top right. We have a flaky test suite but
divijvaidya merged PR #15402:
URL: https://github.com/apache/kafka/pull/15402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on code in PR #15474:
URL: https://github.com/apache/kafka/pull/15474#discussion_r1517951926
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -52,20 +55,30 @@ public class GetOffsetShellTest {
private final int topicCount = 4;
[
https://issues.apache.org/jira/browse/KAFKA-16126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-16126:
-
Component/s: kraft
> Kcontroller dynamic configurations may fail to apply at startup
>
[
https://issues.apache.org/jira/browse/KAFKA-16126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya resolved KAFKA-16126.
--
Resolution: Fixed
> Kcontroller dynamic configurations may fail to apply at startup
>
[
https://issues.apache.org/jira/browse/KAFKA-16126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-16126:
-
Fix Version/s: (was: 3.8.0)
> Kcontroller dynamic configurations may fail to apply at
divijvaidya commented on PR #15192:
URL: https://github.com/apache/kafka/pull/15192#issuecomment-1985996064
For completenss, the associated commit was merged to 3.6, 3.7 and trunk
3.6
-https://github.com/apache/kafka/commit/b743f6fd884132c7a5c4e9d96ed62e3aec29007f
3.7 -
[
https://issues.apache.org/jira/browse/KAFKA-16126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824828#comment-17824828
]
Divij Vaidya commented on KAFKA-16126:
--
Seems like the associated commit in the PR was merged to
[
https://issues.apache.org/jira/browse/KAFKA-16126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-16126:
-
Fix Version/s: 3.6.2
3.8.0
3.7.0
> Kcontroller dynamic
johnnychhsu commented on code in PR #15488:
URL: https://github.com/apache/kafka/pull/15488#discussion_r1517940750
##
core/src/test/scala/unit/kafka/log/LogLoaderTest.scala:
##
@@ -352,7 +353,10 @@ class LogLoaderTest {
// Intercept all segment read calls
val
divijvaidya commented on PR #15192:
URL: https://github.com/apache/kafka/pull/15192#issuecomment-1985979960
@cmccabe the test `testStartupWithNonDefaultKControllerDynamicConfiguration`
has been failing since it has been introduced to 3.6 branch. See:
divijvaidya commented on PR #15490:
URL: https://github.com/apache/kafka/pull/15490#issuecomment-1985969718
@showuon can you please take a look at this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
divijvaidya commented on PR #15490:
URL: https://github.com/apache/kafka/pull/15490#issuecomment-1985969187
The failing tests are known to be flaky for 3.6 branch, e,g,
https://ge.apache.org/scans/tests?search.relativeStartTime=P28D=kafka=3.6=Europe%2FBerlin=kafka.server.KRaftClusterTest
johnnychhsu commented on code in PR #15488:
URL: https://github.com/apache/kafka/pull/15488#discussion_r1517906750
##
core/src/test/scala/unit/kafka/log/LogLoaderTest.scala:
##
@@ -352,7 +353,10 @@ class LogLoaderTest {
// Intercept all segment read calls
val
johnnychhsu commented on code in PR #15483:
URL: https://github.com/apache/kafka/pull/15483#discussion_r1517905708
##
clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java:
##
@@ -20,6 +20,37 @@
import org.apache.kafka.common.MetricName;
import
chia7712 merged PR #15431:
URL: https://github.com/apache/kafka/pull/15431
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #15431:
URL: https://github.com/apache/kafka/pull/15431#issuecomment-1985910550
> Is there a reason why we've not merged this yet?
This PR is ready to be merged I think.
I will merge it.
--
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/KAFKA-15649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824815#comment-17824815
]
Viktor Somogyi-Vass commented on KAFKA-15649:
-
[~soarez] would you mind if I picked this up?
[
https://issues.apache.org/jira/browse/KAFKA-16355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
PoAn Yang reassigned KAFKA-16355:
-
Assignee: PoAn Yang
> ConcurrentModificationException in
>
mimaison commented on PR #15431:
URL: https://github.com/apache/kafka/pull/15431#issuecomment-1985770789
Is there a reason why we've not merged this yet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
OmniaGM commented on PR #15335:
URL: https://github.com/apache/kafka/pull/15335#issuecomment-1985757706
@soarez, @pprovenzano and @showuon can you please have a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
OmniaGM commented on code in PR #15335:
URL: https://github.com/apache/kafka/pull/15335#discussion_r1517756842
##
core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala:
##
@@ -289,13 +289,10 @@ class BrokerMetadataPublisher(
try {
// Start log
OmniaGM commented on code in PR #15335:
URL: https://github.com/apache/kafka/pull/15335#discussion_r1517754815
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -354,6 +355,14 @@ class LogManager(logDirs: Seq[File],
} else if
[
https://issues.apache.org/jira/browse/KAFKA-16355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824797#comment-17824797
]
Mickael Maison commented on KAFKA-16355:
Sure
> ConcurrentModificationException in
>
[
https://issues.apache.org/jira/browse/KAFKA-16355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824796#comment-17824796
]
PoAn Yang commented on KAFKA-16355:
---
Hi [~mimaison], I am interested in this issue. May I take it?
Phuc-Hong-Tran commented on code in PR #15188:
URL: https://github.com/apache/kafka/pull/15188#discussion_r1517714052
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java:
##
@@ -84,6 +85,9 @@ private enum SubscriptionType {
/* the
Mickael Maison created KAFKA-16355:
--
Summary: ConcurrentModificationException in
InMemoryTimeOrderedKeyValueBuffer.evictWhile
Key: KAFKA-16355
URL: https://issues.apache.org/jira/browse/KAFKA-16355
dajac commented on code in PR #15442:
URL: https://github.com/apache/kafka/pull/15442#discussion_r1517690579
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -9607,6 +9607,151 @@ public void
msn-tldr commented on PR #15498:
URL: https://github.com/apache/kafka/pull/15498#issuecomment-1985641282
@hachikuji / @ijuma can you help in merging this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
msn-tldr opened a new pull request, #15498:
URL: https://github.com/apache/kafka/pull/15498
NOTE this cherry-picks fix https://github.com/apache/kafka/pull/14522 into
3.6
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed
msn-tldr commented on PR #15493:
URL: https://github.com/apache/kafka/pull/15493#issuecomment-1985621897
@hachikuji / @ijuma would you be able to merge this?
The test failures on jenkins are flaky and unrelated.
--
This is an automated message from the Apache Git Service.
To
Phuc-Hong-Tran commented on code in PR #15188:
URL: https://github.com/apache/kafka/pull/15188#discussion_r1517646778
##
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##
@@ -494,6 +501,14 @@ public void
Phuc-Hong-Tran commented on code in PR #15188:
URL: https://github.com/apache/kafka/pull/15188#discussion_r1517636440
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java:
##
@@ -84,6 +85,9 @@ private enum SubscriptionType {
/* the
nizhikov commented on PR #15465:
URL: https://github.com/apache/kafka/pull/15465#issuecomment-1985445590
@chia7712 I've checked CI results - looks like failures unrelated to PR
changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
clolov commented on PR #15497:
URL: https://github.com/apache/kafka/pull/15497#issuecomment-1985421216
Heya @cadonna! This should be the quick follow-up of
https://github.com/apache/kafka/pull/15261 to fully move the consumer mock
--
This is an automated message from the Apache Git
moscicky opened a new pull request, #15496:
URL: https://github.com/apache/kafka/pull/15496
This PR adds `fast_commit` tuning option to EXT4 notes. We have found this
options be the most performant for EXT4 filesystem. The details of our analysis
and findings are described in a
80 matches
Mail list logo
