Re: [PR] KAFKA-13152: Kip 770 buffer size fix [kafka]

2024-04-22 Thread via GitHub
vamossagar12 commented on PR #13283: URL: https://github.com/apache/kafka/pull/13283#issuecomment-2071431998 No worries and thanks for the proposed help! There are some things which I need to close out but I do hope to close it out. -- This is an automated message from the Apache Git

Re: [PR] KAFKA-16588: broker shutdown hangs when log.segment.delete.delay.ms is zero [kafka]

2024-04-22 Thread via GitHub
showuon commented on PR #15773: URL: https://github.com/apache/kafka/pull/15773#issuecomment-2071375745 > Yeah, I tried to use unit test. However, I didn't find a good way to check whether kafka-delete-logs task has run or not. I also tried to check whether scheduler can be stopped.

[PR] KAFKA-16587: Add subscription model information to group state [kafka]

2024-04-22 Thread via GitHub
rreddy-22 opened a new pull request, #15785: URL: https://github.com/apache/kafka/pull/15785 When all the subscriptions are equal, we iterate through every member and check equality for the topic lists - very expensive when there’s more members -- This is an automated message from

Re: [PR] KAFKA-16164: Pre-Vote, modifying vote RPCs [part 1] [kafka]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #15231: URL: https://github.com/apache/kafka/pull/15231#issuecomment-2071344453 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-22 Thread via GitHub
showuon commented on code in PR #15616: URL: https://github.com/apache/kafka/pull/15616#discussion_r1575591635 ## core/src/test/scala/unit/kafka/server/AlterReplicaLogDirsRequestTest.scala: ## @@ -116,6 +124,56 @@ class AlterReplicaLogDirsRequestTest extends BaseRequestTest {

[jira] [Updated] (KAFKA-16603) Data loss when kafka connect sending data to Kafka

2024-04-22 Thread Anil Dasari (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anil Dasari updated KAFKA-16603: Description: We are experiencing a data loss when Kafka Source connector is failed to send data

[jira] [Updated] (KAFKA-16603) Data loss when kafka connect sending data to Kafka

2024-04-22 Thread Anil Dasari (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anil Dasari updated KAFKA-16603: Description: We are experiencing a data loss when Kafka Source connector is failed to send data

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-22 Thread via GitHub
FrankYang0529 commented on code in PR #15616: URL: https://github.com/apache/kafka/pull/15616#discussion_r1575583127 ## core/src/test/scala/unit/kafka/server/AlterReplicaLogDirsRequestTest.scala: ## @@ -116,6 +124,56 @@ class AlterReplicaLogDirsRequestTest extends

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-22 Thread via GitHub
FrankYang0529 commented on code in PR #15616: URL: https://github.com/apache/kafka/pull/15616#discussion_r1575583127 ## core/src/test/scala/unit/kafka/server/AlterReplicaLogDirsRequestTest.scala: ## @@ -116,6 +124,56 @@ class AlterReplicaLogDirsRequestTest extends

[jira] [Created] (KAFKA-16603) Data loss when kafka connect sending data to Kafka

2024-04-22 Thread Anil Dasari (Jira)
Anil Dasari created KAFKA-16603: --- Summary: Data loss when kafka connect sending data to Kafka Key: KAFKA-16603 URL: https://issues.apache.org/jira/browse/KAFKA-16603 Project: Kafka Issue Type:

Re: [PR] KAFKA-16073: Increment the local-log-start-offset before deleting segments in memory table [kafka]

2024-04-22 Thread via GitHub
showuon commented on code in PR #15748: URL: https://github.com/apache/kafka/pull/15748#discussion_r1575561675 ## core/src/test/scala/unit/kafka/log/LogCleanerParameterizedIntegrationTest.scala: ## @@ -121,9 +121,9 @@ class LogCleanerParameterizedIntegrationTest extends

Re: [PR] MINOR: Reduce the time taken to execute the TieredStorage tests. [kafka]

2024-04-22 Thread via GitHub
showuon merged PR #15780: URL: https://github.com/apache/kafka/pull/15780 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-22 Thread via GitHub
showuon commented on code in PR #15616: URL: https://github.com/apache/kafka/pull/15616#discussion_r1575558298 ## core/src/test/scala/unit/kafka/server/AlterReplicaLogDirsRequestTest.scala: ## @@ -116,6 +124,56 @@ class AlterReplicaLogDirsRequestTest extends BaseRequestTest {

Re: [PR] MINOR: Reduce the time taken to execute the TieredStorage tests. [kafka]

2024-04-22 Thread via GitHub
kamalcph commented on PR #15780: URL: https://github.com/apache/kafka/pull/15780#issuecomment-2071280063 Test failures are unrelated. 3 remote storage tests were failed, those are existing flaky tests. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] KAFKA-16073: Increment the local-log-start-offset before deleting segments in memory table [kafka]

2024-04-22 Thread via GitHub
kamalcph commented on PR #15748: URL: https://github.com/apache/kafka/pull/15748#issuecomment-2071274526 @showuon Test failures are fixed! Please take another look. Let me know if we have to fix the tests in 3.7 and trunk (but they weren't flaky). -- This is an automated message

[jira] [Commented] (KAFKA-16585) No way to forward message from punctuation method in the FixedKeyProcessor

2024-04-22 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839910#comment-17839910 ] Matthias J. Sax commented on KAFKA-16585: - Well, the use-case make sense, but the question is,

[jira] [Commented] (KAFKA-16567) Add New Stream Metrics based on KIP-869

2024-04-22 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839907#comment-17839907 ] Matthias J. Sax commented on KAFKA-16567: - Thanks Bruno – makes sense to me – should we move

[jira] [Updated] (KAFKA-16567) Add New Stream Metrics based on KIP-869

2024-04-22 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-16567: Priority: Major (was: Blocker) > Add New Stream Metrics based on KIP-869 >

[jira] [Updated] (KAFKA-16567) Add New Stream Metrics based on KIP-869

2024-04-22 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-16567: Fix Version/s: (was: 4.0.0) > Add New Stream Metrics based on KIP-869 >

[jira] [Commented] (KAFKA-16514) Kafka Streams: stream.close(CloseOptions) does not respect options.leaveGroup flag.

2024-04-22 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839905#comment-17839905 ] Matthias J. Sax commented on KAFKA-16514: - Well, in general we can, but the internal flag /

[jira] [Commented] (KAFKA-16466) QuorumController is swallowing some exception messages

2024-04-22 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839902#comment-17839902 ] Igor Soarez commented on KAFKA-16466: - Cherry-picked to 3.7 > QuorumController is swallowing some

Re: [PR] KAFKA-16466: add details of an internal exception to the failure message [kafka]

2024-04-22 Thread via GitHub
soarez merged PR #15701: URL: https://github.com/apache/kafka/pull/15701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16466: add details of an internal exception to the failure message [kafka]

2024-04-22 Thread via GitHub
soarez commented on PR #15701: URL: https://github.com/apache/kafka/pull/15701#issuecomment-2071198673 Failing tests are unrelated, except for `org.apache.kafka.controller.QuorumControllerTest.testBootstrapZkMigrationRecord()`

[jira] [Created] (KAFKA-16602) Flaky test – org.apache.kafka.controller.QuorumControllerTest.testBootstrapZkMigrationRecord()

2024-04-22 Thread Igor Soarez (Jira)
Igor Soarez created KAFKA-16602: --- Summary: Flaky test – org.apache.kafka.controller.QuorumControllerTest.testBootstrapZkMigrationRecord() Key: KAFKA-16602 URL: https://issues.apache.org/jira/browse/KAFKA-16602

[jira] [Created] (KAFKA-16601) Flaky test – org.apache.kafka.controller.QuorumControllerMetricsIntegrationTest.testClosingQuorumControllerClosesMetrics()

2024-04-22 Thread Igor Soarez (Jira)
Igor Soarez created KAFKA-16601: --- Summary: Flaky test – org.apache.kafka.controller.QuorumControllerMetricsIntegrationTest.testClosingQuorumControllerClosesMetrics() Key: KAFKA-16601 URL:

[PR] KAFKA-16577: New consumer fails with stop within allotted timeout in consumer_test.py system test [kafka]

2024-04-22 Thread via GitHub
kirktrue opened a new pull request, #15784: URL: https://github.com/apache/kafka/pull/15784 WIP ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including

Re: [PR] KAFKA-16555: Consumer's RequestState has incorrect logic to determine if inflight [kafka]

2024-04-22 Thread via GitHub
kirktrue commented on PR #15723: URL: https://github.com/apache/kafka/pull/15723#issuecomment-2071054599 @lucasbru, @lianetm, @philipnee—I have re-introduced the `lastSentMs` instance variable, not as a driver for logic, but for informational purposes in the logs. This is ready for

[jira] [Commented] (KAFKA-16600) Periodically receive "Failed to transition to PENDING_SHUTDOWN, current state is PENDING_SHUTDOWN" during streams close

2024-04-22 Thread Alex Leung (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839871#comment-17839871 ] Alex Leung commented on KAFKA-16600: Hi [~ableegoldman] – added a log with more context! >

[jira] [Updated] (KAFKA-16600) Periodically receive "Failed to transition to PENDING_SHUTDOWN, current state is PENDING_SHUTDOWN" during streams close

2024-04-22 Thread Alex Leung (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Leung updated KAFKA-16600: --- Attachment: kafka-16600.log > Periodically receive "Failed to transition to PENDING_SHUTDOWN,

[PR] MINOR: Fix logging of KafkaStreams close [kafka]

2024-04-22 Thread via GitHub
appchemist opened a new pull request, #15783: URL: https://github.com/apache/kafka/pull/15783 Remove a unnecessary "}" in logging of KafkaStreams close ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and

[jira] [Updated] (KAFKA-16565) IncrementalAssignmentConsumerEventHandler throws error when attempting to remove a partition that isn't assigned

2024-04-22 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16565: -- Reviewer: Lucas Brutschy Description: In {{verifiable_consumer.py}}, the

[jira] [Updated] (KAFKA-16461) New consumer fails to consume records in security_test.py system test

2024-04-22 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16461: -- Reviewer: Lucas Brutschy > New consumer fails to consume records in security_test.py system test >

Re: [PR] KAFKA-16565: IncrementalAssignmentConsumerEventHandler throws error when attempting to remove a partition that isn't assigned [kafka]

2024-04-22 Thread via GitHub
kirktrue commented on PR #15737: URL: https://github.com/apache/kafka/pull/15737#issuecomment-2070963749 @lucasbru—Can you review this change to the consumer system test harness? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] KAFKA-16565: IncrementalAssignmentConsumerEventHandler throws error when attempting to remove a partition that isn't assigned [kafka]

2024-04-22 Thread via GitHub
kirktrue commented on code in PR #15737: URL: https://github.com/apache/kafka/pull/15737#discussion_r1575365134 ## tests/kafkatest/services/verifiable_consumer.py: ## @@ -140,22 +150,32 @@ class IncrementalAssignmentConsumerEventHandler(ConsumerEventHandler): def

[jira] [Commented] (KAFKA-16600) Periodically receive "Failed to transition to PENDING_SHUTDOWN, current state is PENDING_SHUTDOWN" during streams close

2024-04-22 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839850#comment-17839850 ] A. Sophie Blee-Goldman commented on KAFKA-16600: Thanks [~aleung181] – definitely sounds

Re: [PR] KAFKA-16593: Rewrite DeleteConsumerGroupsTest by ClusterTestExtensions [kafka]

2024-04-22 Thread via GitHub
lianetm commented on code in PR #15766: URL: https://github.com/apache/kafka/pull/15766#discussion_r1575354663 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java: ## @@ -17,279 +17,448 @@ package org.apache.kafka.tools.consumer.group;

Re: [PR] KAFKA-16461: New consumer fails to consume records in security_test.py system test [kafka]

2024-04-22 Thread via GitHub
kirktrue commented on PR #15746: URL: https://github.com/apache/kafka/pull/15746#issuecomment-2070928518 @lucasbru—Can you review? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (KAFKA-16103) AsyncKafkaConsumer: Always await async commit callbacks in commitSync and close

2024-04-22 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16103: -- Summary: AsyncKafkaConsumer: Always await async commit callbacks in commitSync and close (was:

Re: [PR] KAFKA-16593: Rewrite DeleteConsumerGroupsTest by ClusterTestExtensions [kafka]

2024-04-22 Thread via GitHub
lianetm commented on code in PR #15766: URL: https://github.com/apache/kafka/pull/15766#discussion_r1575308633 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java: ## @@ -17,279 +17,448 @@ package org.apache.kafka.tools.consumer.group;

Re: [PR] KAFKA-16593: Rewrite DeleteConsumerGroupsTest by ClusterTestExtensions [kafka]

2024-04-22 Thread via GitHub
lianetm commented on code in PR #15766: URL: https://github.com/apache/kafka/pull/15766#discussion_r1575308633 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java: ## @@ -17,279 +17,448 @@ package org.apache.kafka.tools.consumer.group;

Re: [PR] MINOR: Modified System.getProperty("line.separator") to java.lang.System.lineSeparator() [kafka]

2024-04-22 Thread via GitHub
TaiJuWu commented on PR #15782: URL: https://github.com/apache/kafka/pull/15782#issuecomment-2070867568 > @TaiJuWu thanks for your contribution. Could you fix https://github.com/apache/kafka/blob/trunk/tools/src/main/java/org/apache/kafka/tools/TopicCommand.java#L776 also? Sure.

Re: [PR] MINOR: Modified System.getProperty("line.separator") to java.lang.System.lineSeparator() [kafka]

2024-04-22 Thread via GitHub
chia7712 commented on PR #15782: URL: https://github.com/apache/kafka/pull/15782#issuecomment-2070865680 @TaiJuWu thanks for your contribution. Could you fix https://github.com/apache/kafka/blob/trunk/tools/src/main/java/org/apache/kafka/tools/TopicCommand.java#L776 also? -- This is an

Re: [PR] KAFKA-16560: Refactor/cleanup BrokerNode/ControllerNode/ClusterConfig [kafka]

2024-04-22 Thread via GitHub
chia7712 commented on code in PR #15761: URL: https://github.com/apache/kafka/pull/15761#discussion_r1575290259 ## core/src/test/java/kafka/testkit/BrokerNode.java: ## @@ -66,11 +74,27 @@ public Builder setNumLogDirectories(int numLogDirectories) { return this;

[PR] MINOR: Modified System.getProperty("line.separator") to java.lang.System.lineSeparator() [kafka]

2024-04-22 Thread via GitHub
TaiJuWu opened a new pull request, #15782: URL: https://github.com/apache/kafka/pull/15782 As title ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation

Re: [PR] KAFKA-16593: Rewrite DeleteConsumerGroupsTest by ClusterTestExtensions [kafka]

2024-04-22 Thread via GitHub
lianetm commented on code in PR #15766: URL: https://github.com/apache/kafka/pull/15766#discussion_r1575295376 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java: ## @@ -17,279 +17,448 @@ package org.apache.kafka.tools.consumer.group;

Re: [PR] KAFKA-16598 Mirgrate `ResetConsumerGroupOffsetTest` to new test infra [kafka]

2024-04-22 Thread via GitHub
chia7712 commented on PR #15779: URL: https://github.com/apache/kafka/pull/15779#issuecomment-2070801312 @m1a2st Please add following server property: ```java @ClusterTestDefaults(clusterType = Type.ALL, serverProperties = { @ClusterConfigProperty(key =

[jira] [Created] (KAFKA-16600) Periodically receive "Failed to transition to PENDING_SHUTDOWN, current state is PENDING_SHUTDOWN" during streams close

2024-04-22 Thread Alex Leung (Jira)
Alex Leung created KAFKA-16600: -- Summary: Periodically receive "Failed to transition to PENDING_SHUTDOWN, current state is PENDING_SHUTDOWN" during streams close Key: KAFKA-16600 URL:

Re: [PR] KAFKA-15853: Move socket configs into org.apache.kafka.network.SocketServerConfigs [kafka]

2024-04-22 Thread via GitHub
chia7712 commented on PR #15772: URL: https://github.com/apache/kafka/pull/15772#issuecomment-2070748890 Should we move following configs to `SocketServerConfigs`? 1. `controller.listener.names`

Re: [PR] KAFKA-16598 Mirgrate `ResetConsumerGroupOffsetTest` to new test infra [kafka]

2024-04-22 Thread via GitHub
lianetm commented on PR #15779: URL: https://github.com/apache/kafka/pull/15779#issuecomment-2070678792 Hey @m1a2st , the way to get the servers' addresses is `cluster.bootstrapServers()`, you got it right, but I see you're not inheriting from `ConsumerGroupCommandTest` anymore, so that

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

2024-04-22 Thread via GitHub
vamossagar12 commented on PR #15305: URL: https://github.com/apache/kafka/pull/15305#issuecomment-2070326565 @showuon , I made some changes to the test so that we just heartbeat and not have to rely upon FindCoordinator requests. Let me know what yo think. Thanks! -- This is an automated

Re: [PR] KAFKA-16592: Add a new constructor which invokes the existing constructor with default value for alternativeString [kafka]

2024-04-22 Thread via GitHub
vamossagar12 commented on PR #15762: URL: https://github.com/apache/kafka/pull/15762#issuecomment-2070321267 Thanks @chia7712 , for now I have made the constructor added as part of https://github.com/apache/kafka/pull/13909 as private. Regarding > I guess we need a KIP to

Re: [PR] KAFKA-16592: Add a new constructor which invokes the existing constructor with default value for alternativeString [kafka]

2024-04-22 Thread via GitHub
vamossagar12 commented on code in PR #15762: URL: https://github.com/apache/kafka/pull/15762#discussion_r1575112513 ## clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java: ## @@ -1256,6 +1256,16 @@ public static class ConfigKey { public final boolean

Re: [PR] KAFKA-16560: Refactor/cleanup BrokerNode/ControllerNode/ClusterConfig [kafka]

2024-04-22 Thread via GitHub
brandboat commented on code in PR #15761: URL: https://github.com/apache/kafka/pull/15761#discussion_r1575101365 ## core/src/test/java/kafka/test/ClusterConfig.java: ## @@ -173,63 +199,104 @@ public static class Builder { private String listenerName; private

[PR] KAFKA-16526; Add quorum state v1 [kafka]

2024-04-22 Thread via GitHub
jsancio opened a new pull request, #15781: URL: https://github.com/apache/kafka/pull/15781 DRAFT - needs https://github.com/apache/kafka/pull/15671 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI

[jira] [Commented] (KAFKA-16585) No way to forward message from punctuation method in the FixedKeyProcessor

2024-04-22 Thread Stanislav Spiridonov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839791#comment-17839791 ] Stanislav Spiridonov commented on KAFKA-16585: -- If you check the example on

Re: [PR] KAFKA-16593: Rewrite DeleteConsumerGroupsTest by ClusterTestExtensions [kafka]

2024-04-22 Thread via GitHub
chia7712 commented on code in PR #15766: URL: https://github.com/apache/kafka/pull/15766#discussion_r1575079922 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java: ## @@ -17,279 +17,448 @@ package org.apache.kafka.tools.consumer.group;

[jira] [Comment Edited] (KAFKA-16585) No way to forward message from punctuation method in the FixedKeyProcessor

2024-04-22 Thread Stanislav Spiridonov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838979#comment-17838979 ] Stanislav Spiridonov edited comment on KAFKA-16585 at 4/22/24 4:47 PM:

Re: [PR] KAFKA-16560: Refactor/cleanup BrokerNode/ControllerNode/ClusterConfig [kafka]

2024-04-22 Thread via GitHub
chia7712 commented on code in PR #15761: URL: https://github.com/apache/kafka/pull/15761#discussion_r1575053494 ## core/src/test/java/kafka/test/ClusterConfig.java: ## @@ -173,63 +199,104 @@ public static class Builder { private String listenerName; private

[jira] [Comment Edited] (KAFKA-7878) Connect Task already exists in this worker when failed to create consumer

2024-04-22 Thread John Hawkins (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839784#comment-17839784 ] John Hawkins edited comment on KAFKA-7878 at 4/22/24 4:42 PM: -- I see this

[jira] [Commented] (KAFKA-7878) Connect Task already exists in this worker when failed to create consumer

2024-04-22 Thread John Hawkins (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839784#comment-17839784 ] John Hawkins commented on KAFKA-7878: - I see this quite often when I'm loading the JDBC connector. V.

[jira] [Updated] (KAFKA-7878) Connect Task already exists in this worker when failed to create consumer

2024-04-22 Thread John Hawkins (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Hawkins updated KAFKA-7878: Affects Version/s: 3.7.0 > Connect Task already exists in this worker when failed to create

Re: [PR] KAFKA-16466: add details of an internal exception to the failure message [kafka]

2024-04-22 Thread via GitHub
ilyazr commented on PR #15701: URL: https://github.com/apache/kafka/pull/15701#issuecomment-2070177669 @soarez Hi! Thanks for pointing out problems with the tests. I didn't know that. p.s: added suggested changes -- This is an automated message from the Apache Git Service. To

Re: [PR] KAFKA-16466: add details of an internal exception to the failure message [kafka]

2024-04-22 Thread via GitHub
ilyazr commented on code in PR #15701: URL: https://github.com/apache/kafka/pull/15701#discussion_r1575054055 ## metadata/src/test/java/org/apache/kafka/controller/errors/EventHandlerExceptionInfoTest.java: ## @@ -174,10 +180,18 @@ public void

Re: [PR] KAFKA-16466: add details of an internal exception to the failure message [kafka]

2024-04-22 Thread via GitHub
ilyazr commented on code in PR #15701: URL: https://github.com/apache/kafka/pull/15701#discussion_r1575051333 ## metadata/src/test/java/org/apache/kafka/controller/errors/EventHandlerExceptionInfoTest.java: ## @@ -72,6 +73,11 @@ public class EventHandlerExceptionInfoTest {

Re: [PR] KAFKA-16466: add details of an internal exception to the failure message [kafka]

2024-04-22 Thread via GitHub
ilyazr commented on code in PR #15701: URL: https://github.com/apache/kafka/pull/15701#discussion_r1575046814 ## metadata/src/main/java/org/apache/kafka/controller/errors/EventHandlerExceptionInfo.java: ## @@ -191,6 +191,10 @@ public String failureMessage( }

[jira] [Resolved] (KAFKA-16103) Review client logic for triggering offset commit callbacks

2024-04-22 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy resolved KAFKA-16103. Resolution: Fixed > Review client logic for triggering offset commit callbacks >

[jira] [Commented] (KAFKA-16103) Review client logic for triggering offset commit callbacks

2024-04-22 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839765#comment-17839765 ] Lucas Brutschy commented on KAFKA-16103: changes in legacy consumer in

[jira] [Updated] (KAFKA-16599) LegacyConsumer: Always await async commit callbacks in commitSync and close

2024-04-22 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-16599: --- Summary: LegacyConsumer: Always await async commit callbacks in commitSync and close (was:

Re: [PR] KAFKA-16082 Avoid resuming future replica if current replica is in the same directory [kafka]

2024-04-22 Thread via GitHub
gaurav-narula commented on PR #15777: URL: https://github.com/apache/kafka/pull/15777#issuecomment-2070018194 @chia7712 Rebased. PTAL :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (KAFKA-16599) Always await async commit callbacks in commitSync and close

2024-04-22 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-16599: --- Component/s: clients consumer > Always await async commit callbacks in

[jira] [Updated] (KAFKA-16599) Always await async commit callbacks in commitSync and close

2024-04-22 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-16599: --- Description: The javadoc for KafkaConsumer.commitSync says: {code:java} Note that

Re: [PR] KAFKA-16082 Avoid resuming future replica if current replica is in the same directory [kafka]

2024-04-22 Thread via GitHub
chia7712 commented on PR #15777: URL: https://github.com/apache/kafka/pull/15777#issuecomment-2070011423 #15776 is merged so please rebase code :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Assigned] (KAFKA-16599) Always await async commit callbacks in commitSync and close

2024-04-22 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy reassigned KAFKA-16599: -- Assignee: Lucas Brutschy > Always await async commit callbacks in commitSync and

[jira] [Updated] (KAFKA-16559) allow defining number of disks per broker in TestKitNodes

2024-04-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-16559: --- Fix Version/s: 3.7.1 > allow defining number of disks per broker in TestKitNodes >

Re: [PR] KAFKA-16559 allow defining number of disks per broker in TestKitNodes [kafka]

2024-04-22 Thread via GitHub
chia7712 merged PR #15776: URL: https://github.com/apache/kafka/pull/15776 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (KAFKA-16599) Always await async commit callbacks in commitSync and close

2024-04-22 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-16599: -- Summary: Always await async commit callbacks in commitSync and close Key: KAFKA-16599 URL: https://issues.apache.org/jira/browse/KAFKA-16599 Project: Kafka

Re: [PR] KAFKA-16593: Rewrite DeleteConsumerGroupsTest by ClusterTestExtensions [kafka]

2024-04-22 Thread via GitHub
chia7712 commented on code in PR #15766: URL: https://github.com/apache/kafka/pull/15766#discussion_r1575000110 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java: ## @@ -17,279 +17,448 @@ package org.apache.kafka.tools.consumer.group;

Re: [PR] KAFKA-16463 System test for reverting migration to ZK [kafka]

2024-04-22 Thread via GitHub
soarez commented on code in PR #15754: URL: https://github.com/apache/kafka/pull/15754#discussion_r1574994375 ## tests/kafkatest/tests/core/zookeeper_migration_test.py: ## @@ -86,10 +87,35 @@ def do_migration(self, roll_controller = False, downgrade_to_zk = False):

Re: [PR] MINOR: Reduce the time taken to execute the TieredStorage tests. [kafka]

2024-04-22 Thread via GitHub
kamalcph commented on PR #15780: URL: https://github.com/apache/kafka/pull/15780#issuecomment-2069948134 This PR is a follow-up of #15719. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-16560: Refactor/cleanup BrokerNode/ControllerNode/ClusterConfig [kafka]

2024-04-22 Thread via GitHub
brandboat commented on code in PR #15761: URL: https://github.com/apache/kafka/pull/15761#discussion_r1574974316 ## core/src/test/scala/unit/kafka/server/SaslApiVersionsRequestTest.scala: ## @@ -18,41 +18,58 @@ package kafka.server import java.net.Socket import

Re: [PR] KAFKA-15853: Move socket configs into org.apache.kafka.network.SocketServerConfigs [kafka]

2024-04-22 Thread via GitHub
OmniaGM commented on code in PR #15772: URL: https://github.com/apache/kafka/pull/15772#discussion_r1574953974 ## server/src/main/java/org/apache/kafka/network/SocketServerConfigs.java: ## @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-15853: Move socket configs into org.apache.kafka.network.SocketServerConfigs [kafka]

2024-04-22 Thread via GitHub
OmniaGM commented on code in PR #15772: URL: https://github.com/apache/kafka/pull/15772#discussion_r1574952989 ## server/src/main/java/org/apache/kafka/network/SocketServerConfigs.java: ## @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Commented] (KAFKA-15089) Consolidate all the group coordinator configs

2024-04-22 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839744#comment-17839744 ] Omnia Ibrahim commented on KAFKA-15089: --- I can have a look once I finish KAFKA-15853 >

[PR] MINOR: Reduce the time taken to execute the TieredStorage tests. [kafka]

2024-04-22 Thread via GitHub
kamalcph opened a new pull request, #15780: URL: https://github.com/apache/kafka/pull/15780 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including

Re: [PR] KAFKA-16559 allow defining number of disks per broker in TestKitNodes [kafka]

2024-04-22 Thread via GitHub
chia7712 commented on PR #15776: URL: https://github.com/apache/kafka/pull/15776#issuecomment-2069843217 @soarez Any concerns? The failed streams tests can get fixed by backporting #14983. Hence, I'd like to merge it :) -- This is an automated message from the Apache Git Service. To

Re: [PR] KAFKA-16598 Mirgrate `ResetConsumerGroupOffsetTest` to new test infra [kafka]

2024-04-22 Thread via GitHub
m1a2st commented on PR #15779: URL: https://github.com/apache/kafka/pull/15779#issuecomment-2069841257 @chia7712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] KAFKA-16598 Mirgrate `ResetConsumerGroupOffsetTest` to new test infra [kafka]

2024-04-22 Thread via GitHub
m1a2st opened a new pull request, #15779: URL: https://github.com/apache/kafka/pull/15779 change the ResetConsumerGroupOffsetTest first to new test framework -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-15853: Move quota configs into server-common package [kafka]

2024-04-22 Thread via GitHub
OmniaGM commented on code in PR #15774: URL: https://github.com/apache/kafka/pull/15774#discussion_r1574929931 ## server-common/src/main/java/org/apache/kafka/server/config/ServerQuotaConfigs.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Assigned] (KAFKA-16589) Consider removing `ClusterInstance#createAdminClient` since callers are not sure whether they need to call close

2024-04-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-16589: -- Assignee: PoAn Yang (was: Chia-Ping Tsai) > Consider removing

[jira] [Assigned] (KAFKA-16598) Mirgrate `ResetConsumerGroupOffsetTest` to new test infra

2024-04-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-16598: -- Assignee: 黃竣陽 (was: Chia-Ping Tsai) > Mirgrate `ResetConsumerGroupOffsetTest` to

[jira] [Commented] (KAFKA-16589) Consider removing `ClusterInstance#createAdminClient` since callers are not sure whether they need to call close

2024-04-22 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839733#comment-17839733 ] PoAn Yang commented on KAFKA-16589: --- Got it. I'm interested in the issue. May I take it? Thank you. >

[jira] [Commented] (KAFKA-16589) Consider removing `ClusterInstance#createAdminClient` since callers are not sure whether they need to call close

2024-04-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839731#comment-17839731 ] Chia-Ping Tsai commented on KAFKA-16589: {quote}  is this ticket about removing

[jira] [Commented] (KAFKA-16598) Mirgrate `ResetConsumerGroupOffsetTest` to new test infra

2024-04-22 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839730#comment-17839730 ] 黃竣陽 commented on KAFKA-16598: - I am able to handle this issue. > Mirgrate `ResetConsumerGroupOffsetTest` to

Re: [PR] MINOR: Add junit properties to display parameterized test names [kafka]

2024-04-22 Thread via GitHub
chia7712 commented on PR #14983: URL: https://github.com/apache/kafka/pull/14983#issuecomment-2069776278 When testing 3.7 branch for #15776, I encountered following error: ``` java.util.concurrent.ExecutionException: org.apache.kafka.common.errors.InvalidTopicException: Topic

[jira] [Comment Edited] (KAFKA-16589) Consider removing `ClusterInstance#createAdminClient` since callers are not sure whether they need to call close

2024-04-22 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839724#comment-17839724 ] PoAn Yang edited comment on KAFKA-16589 at 4/22/24 2:56 PM: Hi [~chia7712],

Re: [PR] KAFKA-16483: migrate DeleteOffsetsConsumerGroupCommandIntegrationTest to use ClusterTestExtensions [kafka]

2024-04-22 Thread via GitHub
FrankYang0529 commented on PR #15679: URL: https://github.com/apache/kafka/pull/15679#issuecomment-2069788585 > @FrankYang0529 thanks for updated PR. two minor comments left. PTAL Hi @chia7712, I addressed last comments. Thanks for the review. -- This is an automated message from

Re: [PR] KAFKA-16554: Online downgrade triggering and group type conversion [kafka]

2024-04-22 Thread via GitHub
dongnuo123 commented on code in PR #15721: URL: https://github.com/apache/kafka/pull/15721#discussion_r1574897141 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -10331,6 +10333,461 @@ public void

[jira] [Created] (KAFKA-16598) Mirgrate `ResetConsumerGroupOffsetTest` to new test infra

2024-04-22 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-16598: -- Summary: Mirgrate `ResetConsumerGroupOffsetTest` to new test infra Key: KAFKA-16598 URL: https://issues.apache.org/jira/browse/KAFKA-16598 Project: Kafka

[jira] [Commented] (KAFKA-16589) Consider removing `ClusterInstance#createAdminClient` since callers are not sure whether they need to call close

2024-04-22 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839724#comment-17839724 ] PoAn Yang commented on KAFKA-16589: --- Hi [~chia7712], is this ticket try to `createAdminClient` from

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-22 Thread via GitHub
lianetm commented on PR #15698: URL: https://github.com/apache/kafka/pull/15698#issuecomment-2069725394 Hi @cadonna, thanks for the comments! - the unit test I added initially fails on

  1   2   >