abhijeetk88 commented on code in PR #15625:
URL: https://github.com/apache/kafka/pull/15625#discussion_r1580515079
##
core/src/main/java/kafka/log/remote/quota/RLMQuotaManagerConfig.java:
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
appchemist commented on code in PR #15647:
URL: https://github.com/apache/kafka/pull/15647#discussion_r1580510829
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchCollector.java:
##
@@ -327,21 +327,27 @@ private void handleInitializeErrors(final
appchemist commented on code in PR #15647:
URL: https://github.com/apache/kafka/pull/15647#discussion_r1580504115
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java:
##
@@ -200,6 +200,9 @@ protected void handleFetchSuccess(final Node
appchemist commented on code in PR #15647:
URL: https://github.com/apache/kafka/pull/15647#discussion_r1580499797
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java:
##
@@ -200,6 +200,9 @@ protected void handleFetchSuccess(final Node
appchemist commented on code in PR #15647:
URL: https://github.com/apache/kafka/pull/15647#discussion_r1580504115
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java:
##
@@ -200,6 +200,9 @@ protected void handleFetchSuccess(final Node
appchemist commented on code in PR #15647:
URL: https://github.com/apache/kafka/pull/15647#discussion_r1580499797
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java:
##
@@ -200,6 +200,9 @@ protected void handleFetchSuccess(final Node
abhijeetk88 commented on code in PR #15625:
URL: https://github.com/apache/kafka/pull/15625#discussion_r1580499863
##
core/src/test/java/kafka/log/remote/quota/RLMQuotaManagerTest.java:
##
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
[
https://issues.apache.org/jira/browse/KAFKA-16584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841056#comment-17841056
]
dujian commented on KAFKA-16584:
hello [~mjsax]
before create KIP， i must create a wiki ID， but “
appchemist commented on PR #15647:
URL: https://github.com/apache/kafka/pull/15647#issuecomment-2078650601
Thanks for review! @kirktrue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
m1a2st commented on PR #15808:
URL: https://github.com/apache/kafka/pull/15808#issuecomment-2078587040
@chia7712 thanls for your comment, I have already change these code by your
comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
github-actions[bot] commented on PR #15052:
URL: https://github.com/apache/kafka/pull/15052#issuecomment-2078571664
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
FrankYang0529 commented on PR #15675:
URL: https://github.com/apache/kafka/pull/15675#issuecomment-2078515889
> btw, it would be great if you can rewrite it by new test infra.
Yeah, but this class need to assign different config to different broker. I
will wait for
chia7712 commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1580354223
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupExecutor.java:
##
@@ -132,63 +133,41 @@ public void close() throws Exception {
}
mjsax opened a new pull request, #15811:
URL: https://github.com/apache/kafka/pull/15811
Typo set's timeout way too high... Test still passes as test timeout is 10
minutes and test runs 5 minutes (with this fix, test runtime drops to 30
seconds as intended).
--
This is an automated
chia7712 commented on code in PR #15808:
URL: https://github.com/apache/kafka/pull/15808#discussion_r1580291046
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -1594,10 +1313,6 @@ object TestUtils extends Logging {
}
}
- def createIsrChangeListener():
chia7712 merged PR #15527:
URL: https://github.com/apache/kafka/pull/15527
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on PR #15804:
URL: https://github.com/apache/kafka/pull/15804#issuecomment-2078386421
> LGTM as it won't compare the undefined version
m1a2st commented on PR #15808:
URL: https://github.com/apache/kafka/pull/15808#issuecomment-2078376955
@chia7712 I resolve the conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
chia7712 commented on PR #15675:
URL: https://github.com/apache/kafka/pull/15675#issuecomment-2078363083
btw, it would be great if you can rewrite it by new test infra.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
chia7712 commented on PR #15808:
URL: https://github.com/apache/kafka/pull/15808#issuecomment-2078361586
@m1a2st Could you please fix the conflicts? thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
akhileshchg commented on code in PR #15732:
URL: https://github.com/apache/kafka/pull/15732#discussion_r1580260431
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -786,12 +773,31 @@ public void run() throws Exception {
}
dongnuo123 commented on code in PR #15798:
URL: https://github.com/apache/kafka/pull/15798#discussion_r1580243392
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1092,6 +1097,86 @@ private void
dongnuo123 commented on code in PR #15798:
URL: https://github.com/apache/kafka/pull/15798#discussion_r1580240603
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1336,6 +1422,233 @@ private
CoordinatorResult consumerGr
dongnuo123 commented on code in PR #15798:
URL: https://github.com/apache/kafka/pull/15798#discussion_r1580240603
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1336,6 +1422,233 @@ private
CoordinatorResult consumerGr
dongnuo123 commented on code in PR #15798:
URL: https://github.com/apache/kafka/pull/15798#discussion_r1580240281
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1092,6 +1097,86 @@ private void
Ritika Reddy created KAFKA-16626:
Summary: Uuid to String for subscribed topic names in assignment
spec
Key: KAFKA-16626
URL: https://issues.apache.org/jira/browse/KAFKA-16626
Project: Kafka
chia7712 commented on PR #15800:
URL: https://github.com/apache/kafka/pull/15800#issuecomment-2078284518
@TaiJuWu Could you add a new test file (`ClusterTestExtensionsUnitTest`) to
verify the function `processClusterTemplate`?
--
This is an automated message from the Apache Git Service.
dongnuo123 commented on code in PR #15798:
URL: https://github.com/apache/kafka/pull/15798#discussion_r1580210319
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1336,6 +1422,233 @@ private
CoordinatorResult consumerGr
dongnuo123 commented on code in PR #15798:
URL: https://github.com/apache/kafka/pull/15798#discussion_r1580203100
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1336,6 +1422,233 @@ private
CoordinatorResult consumerGr
chia7712 commented on PR #15761:
URL: https://github.com/apache/kafka/pull/15761#issuecomment-2078268366
@brandboat could you please fix the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Ritika Reddy created KAFKA-16625:
Summary: Reverse Lookup Partition to Member in Assignors
Key: KAFKA-16625
URL: https://issues.apache.org/jira/browse/KAFKA-16625
Project: Kafka
Issue Type:
chia7712 commented on code in PR #15803:
URL: https://github.com/apache/kafka/pull/15803#discussion_r1580186766
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -1789,6 +1791,33 @@ public void
dongnuo123 commented on code in PR #15798:
URL: https://github.com/apache/kafka/pull/15798#discussion_r1580183434
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1336,6 +1422,233 @@ private
CoordinatorResult consumerGr
dongnuo123 commented on code in PR #15798:
URL: https://github.com/apache/kafka/pull/15798#discussion_r1580183181
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1336,6 +1422,233 @@ private
CoordinatorResult consumerGr
dongnuo123 commented on code in PR #15798:
URL: https://github.com/apache/kafka/pull/15798#discussion_r1580182980
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1336,6 +1422,233 @@ private
CoordinatorResult consumerGr
chia7712 commented on code in PR #15744:
URL: https://github.com/apache/kafka/pull/15744#discussion_r1580175708
##
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala:
##
@@ -620,16 +620,19 @@ class ZkMigrationIntegrationTest {
// Alter the metadata
chia7712 commented on code in PR #15744:
URL: https://github.com/apache/kafka/pull/15744#discussion_r1580174626
##
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala:
##
@@ -852,6 +855,33 @@ class ZkMigrationIntegrationTest {
}
}
+
chia7712 merged PR #15806:
URL: https://github.com/apache/kafka/pull/15806
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #15806:
URL: https://github.com/apache/kafka/pull/15806#issuecomment-2078233197
```
./gradlew cleanTest :streams:test --tests
StreamsAssignmentScaleTest.testHighAvailabilityTaskAssignorManyStandbys
:tools:test --tests
jsancio commented on code in PR #15671:
URL: https://github.com/apache/kafka/pull/15671#discussion_r1580159998
##
clients/src/main/resources/common/message/VotersRecord.json:
##
@@ -0,0 +1,47 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+//
jsancio commented on code in PR #15671:
URL: https://github.com/apache/kafka/pull/15671#discussion_r1580158966
##
clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java:
##
@@ -807,4 +809,62 @@ private static void writeSnapshotFooterRecord(
jsancio commented on code in PR #15671:
URL: https://github.com/apache/kafka/pull/15671#discussion_r1580155319
##
clients/src/main/java/org/apache/kafka/common/record/ControlRecordType.java:
##
@@ -44,11 +44,15 @@ public enum ControlRecordType {
ABORT((short) 0),
[
https://issues.apache.org/jira/browse/KAFKA-12534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840985#comment-17840985
]
keith.paulson edited comment on KAFKA-12534 at 4/25/24 9:26 PM:
I can
[
https://issues.apache.org/jira/browse/KAFKA-12534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840985#comment-17840985
]
keith.paulson commented on KAFKA-12534:
---
I can reproduce this with kafka 3.6.0 and BCFKS
jsancio commented on code in PR #15671:
URL: https://github.com/apache/kafka/pull/15671#discussion_r1580152614
##
clients/src/main/java/org/apache/kafka/common/feature/BaseVersionRange.java:
##
@@ -26,7 +26,7 @@
/**
* Represents an immutable basic version range using 2
mumrah commented on code in PR #15744:
URL: https://github.com/apache/kafka/pull/15744#discussion_r1580150231
##
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala:
##
@@ -852,6 +855,33 @@ class ZkMigrationIntegrationTest {
}
}
+
mumrah commented on code in PR #15744:
URL: https://github.com/apache/kafka/pull/15744#discussion_r1580149700
##
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala:
##
@@ -620,16 +620,19 @@ class ZkMigrationIntegrationTest {
// Alter the metadata
rreddy-22 commented on code in PR #15785:
URL: https://github.com/apache/kafka/pull/15785#discussion_r1580133686
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/RangeAssignorTest.java:
##
@@ -687,7 +688,7 @@ public void
chia7712 commented on code in PR #15744:
URL: https://github.com/apache/kafka/pull/15744#discussion_r1580130359
##
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala:
##
@@ -950,16 +980,47 @@ class ZkMigrationIntegrationTest {
Colin McCabe created KAFKA-16624:
Summary: Don't generate useless PartitionChangeRecord on older MV
Key: KAFKA-16624
URL: https://issues.apache.org/jira/browse/KAFKA-16624
Project: Kafka
rreddy-22 commented on code in PR #15785:
URL: https://github.com/apache/kafka/pull/15785#discussion_r1580115582
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java:
##
@@ -90,17 +91,29 @@ private Map> membersPerTopic(final
kirktrue commented on PR #15750:
URL: https://github.com/apache/kafka/pull/15750#issuecomment-2078159039
I think I would limit it to the request state classes, just to keep the
changes to a minimum
--
This is an automated message from the Apache Git Service.
To respond to the message,
kirktrue commented on code in PR #15647:
URL: https://github.com/apache/kafka/pull/15647#discussion_r1580103763
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchCollector.java:
##
@@ -327,21 +327,27 @@ private void handleInitializeErrors(final
phooq commented on PR #15750:
URL: https://github.com/apache/kafka/pull/15750#issuecomment-2078128947
Thanks for the suggestion @kirktrue . I will use `toStringDetails()` then.
Would you suggest I change the methods in the `***Event` classes as well, or
just focus on `RequestState` for
[
https://issues.apache.org/jira/browse/KAFKA-16622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840966#comment-17840966
]
Edoardo Comar commented on KAFKA-16622:
---
Activating DEBUG logging
```
[2024-04-25 21:20:10,856]
Cerchie commented on code in PR #14448:
URL: https://github.com/apache/kafka/pull/14448#discussion_r1580062597
##
.github/workflows/codesee-arch-diagram.yml:
##
@@ -0,0 +1,23 @@
+# This workflow was added by CodeSee. Learn more at https://codesee.io/
Review Comment:
removed
hachikuji commented on code in PR #15671:
URL: https://github.com/apache/kafka/pull/15671#discussion_r1576879728
##
clients/src/main/java/org/apache/kafka/common/feature/BaseVersionRange.java:
##
@@ -26,7 +26,7 @@
/**
* Represents an immutable basic version range using 2
chia7712 commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1580024742
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupExecutor.java:
##
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
emasab opened a new pull request, #15809:
URL: https://github.com/apache/kafka/pull/15809
It doesn't contain all the brokers in the response: in case a broker is down
it will be listed in some partition "Replicas" but not be present in this array.
### Committer Checklist (excluded
chia7712 merged PR #15797:
URL: https://github.com/apache/kafka/pull/15797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 merged PR #15782:
URL: https://github.com/apache/kafka/pull/15782
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-16585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840907#comment-17840907
]
Matthias J. Sax commented on KAFKA-16585:
-
{quote}I can use the regular Processor, but as I
kirktrue commented on PR #15640:
URL: https://github.com/apache/kafka/pull/15640#issuecomment-2077870915
@cadonna—thanks for your review. I have made the requested changes, so
please take another pass. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the
kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1579915561
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -1338,7 +1339,14 @@ private CompletableFuture
kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1579914824
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -769,7 +730,8 @@ public void commitAsync(OffsetCommitCallback
kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1579897029
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CompletableApplicationEvent.java:
##
@@ -36,13 +36,14 @@ protected
kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1579899408
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/EventProcessor.java:
##
@@ -16,120 +16,31 @@
*/
package
kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1579897029
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CompletableApplicationEvent.java:
##
@@ -36,13 +36,14 @@ protected
splett2 commented on code in PR #15702:
URL: https://github.com/apache/kafka/pull/15702#discussion_r1579894472
##
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##
@@ -66,6 +69,7 @@ public class ConfigurationControlManager {
private
splett2 commented on code in PR #15702:
URL: https://github.com/apache/kafka/pull/15702#discussion_r1579888146
##
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##
@@ -308,6 +328,48 @@ private ApiError validateAlterConfig(ConfigResource
splett2 commented on code in PR #15702:
URL: https://github.com/apache/kafka/pull/15702#discussion_r1579886194
##
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##
@@ -308,6 +328,48 @@ private ApiError validateAlterConfig(ConfigResource
kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1579885684
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##
@@ -144,6 +166,12 @@ void runOnce() {
kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1579884608
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1270,6 +1230,20 @@ private void close(Duration timeout, boolean
splett2 commented on code in PR #15702:
URL: https://github.com/apache/kafka/pull/15702#discussion_r1579880592
##
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##
@@ -260,6 +279,7 @@ private ApiError incrementalAlterConfigResource(
splett2 commented on code in PR #15702:
URL: https://github.com/apache/kafka/pull/15702#discussion_r1579872828
##
metadata/src/main/java/org/apache/kafka/controller/BrokersToElrs.java:
##
@@ -159,4 +160,14 @@ BrokersToIsrs.PartitionsOnReplicaIterator
kirktrue commented on code in PR #15742:
URL: https://github.com/apache/kafka/pull/15742#discussion_r1579868091
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -228,13 +228,16 @@ private void process(final ErrorEvent event) {
kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1579865601
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/EventProcessor.java:
##
@@ -16,120 +16,31 @@
*/
package
kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1579864626
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CompletableApplicationEvent.java:
##
@@ -36,13 +36,14 @@ protected
jolshan merged PR #15755:
URL: https://github.com/apache/kafka/pull/15755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-16386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan updated KAFKA-16386:
---
Fix Version/s: 3.7.1
> NETWORK_EXCEPTIONs from transaction verification are not translated
kirktrue commented on code in PR #15723:
URL: https://github.com/apache/kafka/pull/15723#discussion_r1579862658
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/RequestStateTest.java:
##
@@ -48,4 +50,40 @@ public void testRequestStateSimple() {
johnnychhsu commented on PR #15788:
URL: https://github.com/apache/kafka/pull/15788#issuecomment-208202
thanks for the prompt reply @OmniaGM !
just updated to resolve the conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Kirk True created KAFKA-16623:
-
Summary: KafkaAsyncConsumer system tests warn about revoking
partitions that weren't previously assigned
Key: KAFKA-16623
URL: https://issues.apache.org/jira/browse/KAFKA-16623
m1a2st commented on PR #15808:
URL: https://github.com/apache/kafka/pull/15808#issuecomment-2077728033
@chia7712 please review this PR, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mimaison commented on code in PR #14847:
URL: https://github.com/apache/kafka/pull/14847#discussion_r1579785296
##
metadata/src/main/java/org/apache/kafka/metadata/properties/MetaProperties.java:
##
@@ -47,7 +47,7 @@ public final class MetaProperties {
/**
* The
kirktrue commented on PR #15750:
URL: https://github.com/apache/kafka/pull/15750#issuecomment-2077701719
What about `toStringDetails()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
m1a2st opened a new pull request, #15808:
URL: https://github.com/apache/kafka/pull/15808
Because TestUtils.scala has some unused method, and some methods only use in
one class, so I delete unused methods and move methods to individual class
which only one class used
--
This is an
mimaison opened a new pull request, #15807:
URL: https://github.com/apache/kafka/pull/15807
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including
mimaison opened a new pull request, #15806:
URL: https://github.com/apache/kafka/pull/15806
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including
kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1579760563
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -1338,7 +1339,14 @@ private CompletableFuture
kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1579756071
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##
@@ -144,6 +166,12 @@ void runOnce() {
kirktrue commented on PR #15750:
URL: https://github.com/apache/kafka/pull/15750#issuecomment-2077634416
Thanks for the work on this @phooq!
> I plan to, on top the current changes I have, rename the `toStringBase`
method as `getDetails`
Renaming `toStringBase()` to
kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1579735209
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1270,6 +1230,20 @@ private void close(Duration timeout, boolean
kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1579733831
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -769,7 +730,8 @@ public void commitAsync(OffsetCommitCallback
kirktrue commented on code in PR #15723:
URL: https://github.com/apache/kafka/pull/15723#discussion_r1579725251
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java:
##
@@ -98,12 +93,11 @@ public boolean canSendRequest(final long currentTimeMs)
kirktrue commented on code in PR #15737:
URL: https://github.com/apache/kafka/pull/15737#discussion_r1579722758
##
tests/kafkatest/services/verifiable_consumer.py:
##
@@ -140,22 +150,31 @@ class
IncrementalAssignmentConsumerEventHandler(ConsumerEventHandler):
def
phooq commented on PR #15750:
URL: https://github.com/apache/kafka/pull/15750#issuecomment-2077592945
Thanks so @lianetm ! Hey @kirktrue , I plan to, on top the current changes I
have, rename the `toStringBase` method as `getDetails` for `RequestState`,
does this look okay to you?
chia7712 commented on code in PR #15802:
URL: https://github.com/apache/kafka/pull/15802#discussion_r1579708062
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -169,20 +201,22 @@ private static
Edoardo Comar created KAFKA-16622:
-
Summary: Mirromaker2 first Checkpoint not emitted until consumer
group fully catches up once
Key: KAFKA-16622
URL: https://issues.apache.org/jira/browse/KAFKA-16622
chia7712 commented on code in PR #15802:
URL: https://github.com/apache/kafka/pull/15802#discussion_r1579702459
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -91,65 +91,97 @@ public void
1 - 100 of 183 matches
Mail list logo
