On Thu, 2 Mar 2023 at 17:20, Tom Lane wrote:
> Isaac Morland writes:
> > [ 0001-Remove-source-code-display-from-df-v6.patch ]
>
> Pushed after some editorialization on the test case.
>
Thanks!
One thing I noticed while testing is that if you apply \df+ to an
> aggregate f
Isaac Morland writes:
> [ 0001-Remove-source-code-display-from-df-v6.patch ]
Pushed after some editorialization on the test case.
One thing I noticed while testing is that if you apply \df+ to an
aggregate function, it will show "Internal name" of "aggregate_dummy".
W
On Sun, Jan 22, 2023 at 09:50:29PM -0500, Isaac Morland wrote:
> However, one of the jobs (Windows - Server 2019, MinGW64 - Meson) is paused
> and appears never to have run:
>
> https://cirrus-ci.com/task/6687014536347648
Yeah, mingw is currently set to run only when manually "triggered" by
the
On Sun, 22 Jan 2023 at 21:37, Justin Pryzby wrote:
> On Sun, Jan 22, 2023 at 08:23:25PM -0500, Isaac Morland wrote:
> > > Were you able to test with your own github account ?
> >
> > I haven’t had a chance to try this. I must confess to being a bit
> confused
> > by the distinction between
On Sun, Jan 22, 2023 at 08:23:25PM -0500, Isaac Morland wrote:
> > Were you able to test with your own github account ?
>
> I haven’t had a chance to try this. I must confess to being a bit confused
> by the distinction between running the CI tests and doing "make check";
> ideally I would like
your own github account ?
>
I haven’t had a chance to try this. I must confess to being a bit confused
by the distinction between running the CI tests and doing "make check";
ideally I would like to be able to run all the tests on my own machine
without any external resources. But at
On Sun, Jan 22, 2023 at 04:28:21PM -0500, Isaac Morland wrote:
> On Sun, 22 Jan 2023 at 15:04, Tom Lane wrote:
>
> > Isaac Morland writes:
> > > On Sun, 22 Jan 2023 at 14:26, Alvaro Herrera
> > > wrote:
> > >> This one would fail the sanity check that all roles created by
> > >> regression
On Sun, 22 Jan 2023 at 16:56, Justin Pryzby wrote:
> On Sun, Jan 22, 2023 at 03:04:14PM -0500, Tom Lane wrote:
>
> That's excessive. The policy Alvaro mentions applies to globally-visible
> > object names (i.e., database, role, and tablespace names), and it's there
> > to try to ensure that
On Sun, Jan 22, 2023 at 03:04:14PM -0500, Tom Lane wrote:
> Isaac Morland writes:
> > On Sun, 22 Jan 2023 at 14:26, Alvaro Herrera
> > wrote:
> >> This one would fail the sanity check that all roles created by
> >> regression tests need to have names that start with "regress_".
>
> > Thanks for
On Sun, 22 Jan 2023 at 15:04, Tom Lane wrote:
> Isaac Morland writes:
> > On Sun, 22 Jan 2023 at 14:26, Alvaro Herrera
> > wrote:
> >> This one would fail the sanity check that all roles created by
> >> regression tests need to have names that start with "regress_".
>
> > Thanks for the
Isaac Morland writes:
> On Sun, 22 Jan 2023 at 14:26, Alvaro Herrera
> wrote:
>> This one would fail the sanity check that all roles created by
>> regression tests need to have names that start with "regress_".
> Thanks for the correction. Now I feel like I've skipped some of the
> readings!
>
the notion of going with the flow and just leaving out the
> > tests but that seemed like giving up too easily.
>
> I think avoiding even more untested code is good, so +1 for keeping at
> it.
>
0001-Remove-source-code-display-from-df-v5.patch
Description: Binary data
On 2023-Jan-22, Isaac Morland wrote:
> I’ve re-written the tests to create a test-specific role and functions so
> there is no longer a dependency on the superuser name.
This one would fail the sanity check that all roles created by
regression tests need to have names that start with "regress_".
hub account.
Yes, I will try to get this working before I try to make another
contribution.
0001-Remove-source-code-display-from-df-v4.patch
Description: Binary data
On Sun, Jan 22, 2023 at 12:18:34AM -0500, Isaac Morland wrote:
> On Thu, 19 Jan 2023 at 13:02, Isaac Morland wrote:
> > On Thu, 19 Jan 2023 at 11:30, Justin Pryzby wrote:
> >> On Wed, Jan 18, 2023 at 10:27:46AM -0500, Isaac Morland wrote:
> >> >
> >> > I thought I had:
Isaac Morland writes:
> It turns out that my tests wanted the owner to be “vagrant” rather than
> “postgres”. This is apparently because I was running as that user (in a
> Vagrant VM) when running the tests. Then I took that output and just made
> it the expected output. I’ve re-worked my build
ke; I'll update. Might as well reduce the visual size of the code.
>
I did this. I’m ambivalent about this because I usually think of CASE and
similar constructs as needing to explicitly cover all possible cases but
the language does provide for the NULL default case so may as well use the
feature where applicable.
0001-Remove-source-code-display-from-df-v3.patch
Description: Binary data
On Thu, 19 Jan 2023 at 11:30, Justin Pryzby wrote:
> On Wed, Jan 18, 2023 at 10:27:46AM -0500, Isaac Morland wrote:
> >
> > I thought I had: https://commitfest.postgresql.org/42/4133/
>
> This is failing tests:
> http://cfbot.cputube.org/isaac-morland.html
>
> It seems like any "make check"
On Wed, Jan 18, 2023 at 10:27:46AM -0500, Isaac Morland wrote:
> On Wed, 18 Jan 2023 at 00:00, Pavel Stehule wrote:
>
> > út 17. 1. 2023 v 20:29 odesílatel Isaac Morland
> > napsal:
> >
> >> I welcome comments and feedback. Now to try to find something manageable
> >> to review.
> >
> > looks
st 18. 1. 2023 v 16:27 odesílatel Isaac Morland
napsal:
> On Wed, 18 Jan 2023 at 00:00, Pavel Stehule
> wrote:
>
>>
>> út 17. 1. 2023 v 20:29 odesílatel Isaac Morland
>> napsal:
>>
>>>
>>> I welcome comments and feedback. Now to try to find something manageable
>>> to review.
>>>
>>
>> looks
d description.
>
Thanks, and sorry about that, it just completely slipped my mind. I’ve
attached a revised patch with a slight update of the psql documentation.
you should to assign your patch to commitfest app
>
> https://commitfest.postgresql.org/
>
I thought I had: https://commitfest.po
Hi
út 17. 1. 2023 v 20:29 odesílatel Isaac Morland
napsal:
> On Thu, 12 Jan 2023 at 12:06, Isaac Morland
> wrote:
>
> Thanks everybody. So based on the latest discussion I will:
>>
>> 1) rename the column from “Source code” to “Internal name”; and
>> 2) change the contents to NULL except when
On Thu, 12 Jan 2023 at 12:06, Isaac Morland wrote:
Thanks everybody. So based on the latest discussion I will:
>
> 1) rename the column from “Source code” to “Internal name”; and
> 2) change the contents to NULL except when the language (identified by
> oid) is INTERNAL or C.
>
> Patch
On Thu, 12 Jan 2023 at 10:04, Magnus Hagander wrote:
We could shorten it to "See \sf" or something like that. But if we change
>>> the column header to "internal name" or the like, then the column just
>>> obviously doesn't apply for non-internal languages, so leaving it null
>>> should be
On Thu, Jan 12, 2023 at 6:23 AM Pavel Stehule
wrote:
>
>
> st 11. 1. 2023 v 22:11 odesílatel Tom Lane napsal:
>
>> Pavel Stehule writes:
>> > st 11. 1. 2023 v 19:31 odesílatel Magnus Hagander
>> > napsal:
>> >> This is only about Internal and C, isn't it? Isn't the oid of these
>> >> static,
st 11. 1. 2023 v 22:11 odesílatel Tom Lane napsal:
> Pavel Stehule writes:
> > st 11. 1. 2023 v 19:31 odesílatel Magnus Hagander
> > napsal:
> >> This is only about Internal and C, isn't it? Isn't the oid of these
> >> static, and identified by INTERNALlanguageId and ClanguageId
>
Pavel Stehule writes:
> st 11. 1. 2023 v 19:31 odesílatel Magnus Hagander
> napsal:
>> This is only about Internal and C, isn't it? Isn't the oid of these
>> static, and identified by INTERNALlanguageId and ClanguageId respectively?
>> So we could just have the query show the prosrc column if
st 11. 1. 2023 v 19:31 odesílatel Magnus Hagander
napsal:
> On Wed, Jan 11, 2023 at 7:24 PM Isaac Morland
> wrote:
>
>> On Wed, 11 Jan 2023 at 13:11, Pavel Stehule
>> wrote:
>>
>> please, don't send top post replies -
>>> https://en.wikipedia.org/wiki/Posting_style
>>>
>>
>> Sorry about that;
On Wed, Jan 11, 2023 at 7:24 PM Isaac Morland
wrote:
> On Wed, 11 Jan 2023 at 13:11, Pavel Stehule
> wrote:
>
> please, don't send top post replies -
>> https://en.wikipedia.org/wiki/Posting_style
>>
>
> Sorry about that; I do know to do it properly and usually get it right.
> GMail doesn’t
On Wed, 11 Jan 2023 at 13:11, Pavel Stehule wrote:
please, don't send top post replies -
> https://en.wikipedia.org/wiki/Posting_style
>
Sorry about that; I do know to do it properly and usually get it right.
GMail doesn’t seem to have an option (that I can find) to leave no space at
the top
Or, only show the source in \df++. But it'd be a bit unfortunate if the
C language function wasn't shown in \df+
Hi
st 11. 1. 2023 v 18:57 odesílatel Isaac Morland
napsal:
> Right, for internal or C functions it just gives a symbol name or
> something similar. I've never been annoyed seeing that, just having pages
> of PL/PGSQL (I use a lot of that, possibly biased towards the “too much”
> direction) take
Right, for internal or C functions it just gives a symbol name or something
similar. I've never been annoyed seeing that, just having pages of PL/PGSQL
(I use a lot of that, possibly biased towards the “too much” direction)
take up all the space.
A bit hacky, but what about only showing the first
st 11. 1. 2023 v 18:25 odesílatel Magnus Hagander
napsal:
>
>
> On Wed, Jan 11, 2023 at 6:19 PM Pavel Stehule
> wrote:
>
>>
>>
>> st 11. 1. 2023 v 17:50 odesílatel Isaac Morland
>> napsal:
>>
>>> I find \df+ much less useful than it should be because it tends to be
>>> cluttered up with source
On Wed, Jan 11, 2023 at 6:19 PM Pavel Stehule
wrote:
>
>
> st 11. 1. 2023 v 17:50 odesílatel Isaac Morland
> napsal:
>
>> I find \df+ much less useful than it should be because it tends to be
>> cluttered up with source code. Now that we have \sf, would it be reasonable
>> to remove the source
st 11. 1. 2023 v 17:50 odesílatel Isaac Morland
napsal:
> I find \df+ much less useful than it should be because it tends to be
> cluttered up with source code. Now that we have \sf, would it be reasonable
> to remove the source code from the \df+ display? This would make it easier
> to see
I find \df+ much less useful than it should be because it tends to be
cluttered up with source code. Now that we have \sf, would it be reasonable
to remove the source code from the \df+ display? This would make it easier
to see function permissions and comments. If somebody wants to see the full
37 matches
Mail list logo
