[GitHub] [spark] SparkQA commented on pull request #30341: [SPARK-33427][SQL] Add subexpression elimination for interpreted expression evaluation

SparkQA commented on pull request #30341: URL: https://github.com/apache/spark/pull/30341#issuecomment-727529486 **[Test build #131106 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131106/testReport)** for PR 30341 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

AmplabJenkins removed a comment on pull request #30368: URL: https://github.com/apache/spark/pull/30368#issuecomment-727527653 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

AmplabJenkins removed a comment on pull request #30368: URL: https://github.com/apache/spark/pull/30368#issuecomment-727527648 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

AmplabJenkins commented on pull request #30368: URL: https://github.com/apache/spark/pull/30368#issuecomment-727527648 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

SparkQA removed a comment on pull request #30368: URL: https://github.com/apache/spark/pull/30368#issuecomment-727323154 **[Test build #131104 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131104/testReport)** for PR 30368 at commit

[GitHub] [spark] SparkQA commented on pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

SparkQA commented on pull request #30368: URL: https://github.com/apache/spark/pull/30368#issuecomment-727527476 **[Test build #131104 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131104/testReport)** for PR 30368 at commit

[GitHub] [spark] zhouyejoe commented on a change in pull request #30163: [SPARK-32918][SHUFFLE] RPC implementation to support control plane coordination for push-based shuffle

zhouyejoe commented on a change in pull request #30163: URL: https://github.com/apache/spark/pull/30163#discussion_r523716272 ## File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalBlockStoreClient.java ## @@ -181,7 +181,8 @@ public void

[GitHub] [spark] Victsm commented on a change in pull request #30163: [SPARK-32918][SHUFFLE] RPC implementation to support control plane coordination for push-based shuffle

Victsm commented on a change in pull request #30163: URL: https://github.com/apache/spark/pull/30163#discussion_r523715366 ## File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalBlockStoreClient.java ## @@ -181,7 +181,8 @@ public void

[GitHub] [spark] Victsm commented on a change in pull request #30164: [SPARK-32919][SHUFFLE][test-maven][test-hadoop2.7] Driver side changes for coordinating push based shuffle by selecting external s

Victsm commented on a change in pull request #30164: URL: https://github.com/apache/spark/pull/30164#discussion_r523714996 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala ## @@ -657,6 +688,38 @@ class BlockManagerMasterEndpoint(

[GitHub] [spark] Victsm commented on a change in pull request #30164: [SPARK-32919][SHUFFLE][test-maven][test-hadoop2.7] Driver side changes for coordinating push based shuffle by selecting external s

Victsm commented on a change in pull request #30164: URL: https://github.com/apache/spark/pull/30164#discussion_r523713075 ## File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ## @@ -1252,6 +1254,28 @@ private[spark] class DAGScheduler(

[GitHub] [spark] Victsm commented on a change in pull request #30164: [SPARK-32919][SHUFFLE][test-maven][test-hadoop2.7] Driver side changes for coordinating push based shuffle by selecting external s

Victsm commented on a change in pull request #30164: URL: https://github.com/apache/spark/pull/30164#discussion_r523712631 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala ## @@ -360,6 +371,17 @@ class BlockManagerMasterEndpoint(

[GitHub] [spark] zhouyejoe commented on a change in pull request #30163: [SPARK-32918][SHUFFLE] RPC implementation to support control plane coordination for push-based shuffle

zhouyejoe commented on a change in pull request #30163: URL: https://github.com/apache/spark/pull/30163#discussion_r522744016 ## File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalBlockStoreClient.java ## @@ -158,6 +158,42 @@ public void

[GitHub] [spark] Victsm commented on a change in pull request #30164: [SPARK-32919][SHUFFLE][test-maven][test-hadoop2.7] Driver side changes for coordinating push based shuffle by selecting external s

Victsm commented on a change in pull request #30164: URL: https://github.com/apache/spark/pull/30164#discussion_r523711623 ## File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ## @@ -1252,6 +1254,32 @@ private[spark] class DAGScheduler(

[GitHub] [spark] Victsm commented on a change in pull request #30164: [SPARK-32919][SHUFFLE][test-maven][test-hadoop2.7] Driver side changes for coordinating push based shuffle by selecting external s

Victsm commented on a change in pull request #30164: URL: https://github.com/apache/spark/pull/30164#discussion_r523711581 ## File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ## @@ -1252,6 +1254,32 @@ private[spark] class DAGScheduler(

[GitHub] [spark] Victsm commented on a change in pull request #30164: [SPARK-32919][SHUFFLE][test-maven][test-hadoop2.7] Driver side changes for coordinating push based shuffle by selecting external s

Victsm commented on a change in pull request #30164: URL: https://github.com/apache/spark/pull/30164#discussion_r523711229 ## File path: core/src/main/scala/org/apache/spark/internal/config/package.scala ## @@ -1938,4 +1938,51 @@ package object config {

[GitHub] [spark] Victsm commented on a change in pull request #30164: [SPARK-32919][SHUFFLE][test-maven][test-hadoop2.7] Driver side changes for coordinating push based shuffle by selecting external s

Victsm commented on a change in pull request #30164: URL: https://github.com/apache/spark/pull/30164#discussion_r523710562 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala ## @@ -657,6 +681,13 @@ class BlockManagerMasterEndpoint(

[GitHub] [spark] Victsm commented on a change in pull request #30163: [SPARK-32918][SHUFFLE] RPC implementation to support control plane coordination for push-based shuffle

Victsm commented on a change in pull request #30163: URL: https://github.com/apache/spark/pull/30163#discussion_r523709402 ## File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/MergeFinalizerListener.java ## @@ -0,0 +1,41 @@ +/* + * Licensed to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination

AmplabJenkins removed a comment on pull request #30379: URL: https://github.com/apache/spark/pull/30379#issuecomment-727515493 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination

AmplabJenkins commented on pull request #30379: URL: https://github.com/apache/spark/pull/30379#issuecomment-727515493 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination

SparkQA removed a comment on pull request #30379: URL: https://github.com/apache/spark/pull/30379#issuecomment-727287912 **[Test build #131102 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131102/testReport)** for PR 30379 at commit

[GitHub] [spark] SparkQA commented on pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination

SparkQA commented on pull request #30379: URL: https://github.com/apache/spark/pull/30379#issuecomment-727515354 **[Test build #131102 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131102/testReport)** for PR 30379 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination

AmplabJenkins commented on pull request #30379: URL: https://github.com/apache/spark/pull/30379#issuecomment-727515074 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination

AmplabJenkins removed a comment on pull request #30379: URL: https://github.com/apache/spark/pull/30379#issuecomment-727515074 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination

SparkQA commented on pull request #30379: URL: https://github.com/apache/spark/pull/30379#issuecomment-727514912 **[Test build #131101 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131101/testReport)** for PR 30379 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination

AmplabJenkins removed a comment on pull request #30379: URL: https://github.com/apache/spark/pull/30379#issuecomment-727484748 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination

SparkQA removed a comment on pull request #30379: URL: https://github.com/apache/spark/pull/30379#issuecomment-727284961 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination

AmplabJenkins commented on pull request #30379: URL: https://github.com/apache/spark/pull/30379#issuecomment-727484748 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination

SparkQA commented on pull request #30379: URL: https://github.com/apache/spark/pull/30379#issuecomment-727481924 **[Test build #131100 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131100/testReport)** for PR 30379 at commit

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30283: [SPARK-24266][K8S][2.4] Restart the watcher when we receive a version changed from k8s

dongjoon-hyun commented on a change in pull request #30283: URL: https://github.com/apache/spark/pull/30283#discussion_r523705398 ## File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/LoggingPodStatusWatcher.scala ## @@ -77,9 +87,18

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30283: [SPARK-24266][K8S][2.4] Restart the watcher when we receive a version changed from k8s

dongjoon-hyun commented on a change in pull request #30283: URL: https://github.com/apache/spark/pull/30283#discussion_r523705352 ## File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/LoggingPodStatusWatcher.scala ## @@ -177,4

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30283: [SPARK-24266][K8S][2.4] Restart the watcher when we receive a version changed from k8s

AmplabJenkins removed a comment on pull request #30283: URL: https://github.com/apache/spark/pull/30283#issuecomment-727467281 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on pull request #30283: [SPARK-24266][K8S][2.4] Restart the watcher when we receive a version changed from k8s

AmplabJenkins commented on pull request #30283: URL: https://github.com/apache/spark/pull/30283#issuecomment-727467260 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30283: [SPARK-24266][K8S][2.4] Restart the watcher when we receive a version changed from k8s

AmplabJenkins removed a comment on pull request #30283: URL: https://github.com/apache/spark/pull/30283#issuecomment-727465923 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #30283: [SPARK-24266][K8S][2.4] Restart the watcher when we receive a version changed from k8s

SparkQA removed a comment on pull request #30283: URL: https://github.com/apache/spark/pull/30283#issuecomment-727439357 **[Test build #131105 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131105/testReport)** for PR 30283 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30283: [SPARK-24266][K8S][2.4] Restart the watcher when we receive a version changed from k8s

AmplabJenkins removed a comment on pull request #30283: URL: https://github.com/apache/spark/pull/30283#issuecomment-727465896 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #30283: [SPARK-24266][K8S][2.4] Restart the watcher when we receive a version changed from k8s

AmplabJenkins commented on pull request #30283: URL: https://github.com/apache/spark/pull/30283#issuecomment-727465896 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30283: [SPARK-24266][K8S][2.4] Restart the watcher when we receive a version changed from k8s

SparkQA commented on pull request #30283: URL: https://github.com/apache/spark/pull/30283#issuecomment-727465800 **[Test build #131105 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131105/testReport)** for PR 30283 at commit

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30283: [SPARK-24266][K8S][2.4] Restart the watcher when we receive a version changed from k8s

dongjoon-hyun commented on a change in pull request #30283: URL: https://github.com/apache/spark/pull/30283#discussion_r523704953 ## File path: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/submit/ClientSuite.scala ## @@ -205,6 +207,6 @@ class

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30283: [SPARK-24266][K8S][2.4] Restart the watcher when we receive a version changed from k8s

dongjoon-hyun commented on a change in pull request #30283: URL: https://github.com/apache/spark/pull/30283#discussion_r523704833 ## File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/LoggingPodStatusWatcher.scala ## @@ -177,4

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30283: [SPARK-24266][K8S][2.4] Restart the watcher when we receive a version changed from k8s

dongjoon-hyun commented on a change in pull request #30283: URL: https://github.com/apache/spark/pull/30283#discussion_r523704798 ## File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/LoggingPodStatusWatcher.scala ## @@ -177,4

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30283: [SPARK-24266][K8S][2.4] Restart the watcher when we receive a version changed from k8s

dongjoon-hyun commented on a change in pull request #30283: URL: https://github.com/apache/spark/pull/30283#discussion_r523704723 ## File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/LoggingPodStatusWatcher.scala ## @@ -177,4

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30283: [SPARK-24266][K8S][2.4] Restart the watcher when we receive a version changed from k8s

dongjoon-hyun commented on a change in pull request #30283: URL: https://github.com/apache/spark/pull/30283#discussion_r523704750 ## File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/LoggingPodStatusWatcher.scala ## @@ -177,4

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30283: [SPARK-24266][K8S][2.4] Restart the watcher when we receive a version changed from k8s

dongjoon-hyun commented on a change in pull request #30283: URL: https://github.com/apache/spark/pull/30283#discussion_r523704501 ## File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/LoggingPodStatusWatcher.scala ## @@ -77,9 +87,18

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

AmplabJenkins removed a comment on pull request #30368: URL: https://github.com/apache/spark/pull/30368#issuecomment-727439126 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30283: [SPARK-24266][K8S][2.4] Restart the watcher when we receive a version changed from k8s

dongjoon-hyun commented on a change in pull request #30283: URL: https://github.com/apache/spark/pull/30283#discussion_r523704394 ## File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/LoggingPodStatusWatcher.scala ## @@ -28,8 +29,10

[GitHub] [spark] AmplabJenkins commented on pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

AmplabJenkins commented on pull request #30368: URL: https://github.com/apache/spark/pull/30368#issuecomment-727439086 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

AmplabJenkins removed a comment on pull request #30368: URL: https://github.com/apache/spark/pull/30368#issuecomment-727439086 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30283: [SPARK-24266][K8S][2.4] Restart the watcher when we receive a version changed from k8s

dongjoon-hyun commented on a change in pull request #30283: URL: https://github.com/apache/spark/pull/30283#discussion_r523704337 ## File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala ## @@ -133,29

[GitHub] [spark] SparkQA commented on pull request #30283: [SPARK-24266][K8S][2.4] Restart the watcher when we receive a version changed from k8s

SparkQA commented on pull request #30283: URL: https://github.com/apache/spark/pull/30283#issuecomment-727439357 **[Test build #131105 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131105/testReport)** for PR 30283 at commit

[GitHub] [spark] SparkQA commented on pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

SparkQA commented on pull request #30368: URL: https://github.com/apache/spark/pull/30368#issuecomment-727438978 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35707/

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30283: [SPARK-24266][K8S][2.4] Restart the watcher when we receive a version changed from k8s

dongjoon-hyun commented on a change in pull request #30283: URL: https://github.com/apache/spark/pull/30283#discussion_r523704197 ## File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala ## @@ -133,29

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30283: [SPARK-24266][K8S][2.4] Restart the watcher when we receive a version changed from k8s

dongjoon-hyun commented on a change in pull request #30283: URL: https://github.com/apache/spark/pull/30283#discussion_r523704122 ## File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala ## @@ -133,29

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30283: [SPARK-24266][K8S][2.4] Restart the watcher when we receive a version changed from k8s

dongjoon-hyun commented on a change in pull request #30283: URL: https://github.com/apache/spark/pull/30283#discussion_r523704157 ## File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala ## @@ -133,29

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30283: [SPARK-24266][K8S][2.4] Restart the watcher when we receive a version changed from k8s

dongjoon-hyun commented on a change in pull request #30283: URL: https://github.com/apache/spark/pull/30283#discussion_r523704122 ## File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala ## @@ -133,29

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30283: [SPARK-24266][K8S][2.4] Restart the watcher when we receive a version changed from k8s

dongjoon-hyun commented on a change in pull request #30283: URL: https://github.com/apache/spark/pull/30283#discussion_r523704113 ## File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala ## @@ -133,29

[GitHub] [spark] dongjoon-hyun commented on pull request #30283: [SPARK-24266][K8S][2.4] Restart the watcher when we receive a version changed from k8s

dongjoon-hyun commented on pull request #30283: URL: https://github.com/apache/spark/pull/30283#issuecomment-727425783 Retest this please. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #30341: [SPARK-33427][SQL] Add subexpression elimination for interpreted expression evaluation

dongjoon-hyun edited a comment on pull request #30341: URL: https://github.com/apache/spark/pull/30341#issuecomment-727420586 Thanks. No need to hurry~ Take your time. I just want to give you feedback swiftly from my side. This PR will be here until next week.

[GitHub] [spark] dongjoon-hyun commented on pull request #30341: [SPARK-33427][SQL] Add subexpression elimination for interpreted expression evaluation

dongjoon-hyun commented on pull request #30341: URL: https://github.com/apache/spark/pull/30341#issuecomment-727420586 No need to hurry~ Take your time. I just want to give you feedback swiftly from my side. This is an

[GitHub] [spark] SparkQA commented on pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

SparkQA commented on pull request #30368: URL: https://github.com/apache/spark/pull/30368#issuecomment-727381008 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35707/

[GitHub] [spark] viirya commented on pull request #30341: [SPARK-33427][SQL] Add subexpression elimination for interpreted expression evaluation

viirya commented on pull request #30341: URL: https://github.com/apache/spark/pull/30341#issuecomment-727364039 @dongjoon-hyun Thanks! I will update this tonight or tomorrow. This is an automated message from the Apache Git

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30346: [SPARK-33253][PYTHON][DOCS] Migration to NumPy documentation style in Streaming (pyspark.streaming.*)

AmplabJenkins removed a comment on pull request #30346: URL: https://github.com/apache/spark/pull/30346#issuecomment-727348202 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #30346: [SPARK-33253][PYTHON][DOCS] Migration to NumPy documentation style in Streaming (pyspark.streaming.*)

SparkQA commented on pull request #30346: URL: https://github.com/apache/spark/pull/30346#issuecomment-727348157 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35706/

[GitHub] [spark] AmplabJenkins commented on pull request #30346: [SPARK-33253][PYTHON][DOCS] Migration to NumPy documentation style in Streaming (pyspark.streaming.*)

AmplabJenkins commented on pull request #30346: URL: https://github.com/apache/spark/pull/30346#issuecomment-727348202 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] dongjoon-hyun commented on pull request #30341: [SPARK-33427][SQL] Add subexpression elimination for interpreted expression evaluation

dongjoon-hyun commented on pull request #30341: URL: https://github.com/apache/spark/pull/30341#issuecomment-727331477 #30379 is merged. Could you rebased to the master and regenerate the result, @viirya . Sure, that's the exact reason I asked their opinion once more.  > Let's

[GitHub] [spark] dongjoon-hyun closed pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination

dongjoon-hyun closed pull request #30379: URL: https://github.com/apache/spark/pull/30379 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] dongjoon-hyun commented on pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination

dongjoon-hyun commented on pull request #30379: URL: https://github.com/apache/spark/pull/30379#issuecomment-727329518 Since the last commit is only for commenting and this PR already passed, I merged this. Thanks~ This is

[GitHub] [spark] viirya commented on a change in pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination

viirya commented on a change in pull request #30379: URL: https://github.com/apache/spark/pull/30379#discussion_r523676597 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SubExprEliminationBenchmark.scala ## @@ -0,0 +1,118 @@ +/* + * Licensed to the

[GitHub] [spark] viirya commented on pull request #30341: [SPARK-33427][SQL] Add subexpression elimination for interpreted expression evaluation

viirya commented on pull request #30341: URL: https://github.com/apache/spark/pull/30341#issuecomment-727325324 Thanks @dongjoon-hyun. Let's wait for @cloud-fan's comment for https://github.com/apache/spark/pull/30341#discussion_r522822589 after this weekend.

[GitHub] [spark] SparkQA commented on pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

SparkQA commented on pull request #30368: URL: https://github.com/apache/spark/pull/30368#issuecomment-727323154 **[Test build #131104 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131104/testReport)** for PR 30368 at commit

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination

dongjoon-hyun commented on a change in pull request #30379: URL: https://github.com/apache/spark/pull/30379#discussion_r523672856 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SubExprEliminationBenchmark.scala ## @@ -0,0 +1,118 @@ +/* + * Licensed to

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination

dongjoon-hyun commented on a change in pull request #30379: URL: https://github.com/apache/spark/pull/30379#discussion_r523672856 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SubExprEliminationBenchmark.scala ## @@ -0,0 +1,118 @@ +/* + * Licensed to

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination

dongjoon-hyun commented on a change in pull request #30379: URL: https://github.com/apache/spark/pull/30379#discussion_r523672856 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SubExprEliminationBenchmark.scala ## @@ -0,0 +1,118 @@ +/* + * Licensed to

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination

dongjoon-hyun commented on a change in pull request #30379: URL: https://github.com/apache/spark/pull/30379#discussion_r523670660 ## File path: sql/core/benchmarks/SubExprEliminationBenchmark-jdk11-results.txt ## @@ -0,0 +1,15 @@

[GitHub] [spark] SparkQA commented on pull request #30346: [SPARK-33253][PYTHON][DOCS] Migration to NumPy documentation style in Streaming (pyspark.streaming.*)

SparkQA commented on pull request #30346: URL: https://github.com/apache/spark/pull/30346#issuecomment-727308891 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35706/

[GitHub] [spark] ulysses-you commented on a change in pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

ulysses-you commented on a change in pull request #30368: URL: https://github.com/apache/spark/pull/30368#discussion_r523666452 ## File path: sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q92/explain.txt ## @@ -1,5 +1,5 @@ == Physical Plan ==

[GitHub] [spark] ulysses-you commented on a change in pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

ulysses-you commented on a change in pull request #30368: URL: https://github.com/apache/spark/pull/30368#discussion_r523666452 ## File path: sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q92/explain.txt ## @@ -1,5 +1,5 @@ == Physical Plan ==

[GitHub] [spark] ulysses-you commented on a change in pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

ulysses-you commented on a change in pull request #30368: URL: https://github.com/apache/spark/pull/30368#discussion_r523656874 ## File path: sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q92/explain.txt ## @@ -1,5 +1,5 @@ == Physical Plan ==

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30346: [SPARK-33253][PYTHON][DOCS] Migration to NumPy documentation style in Streaming (pyspark.streaming.*)

AmplabJenkins removed a comment on pull request #30346: URL: https://github.com/apache/spark/pull/30346#issuecomment-727297309 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #30346: [SPARK-33253][PYTHON][DOCS] Migration to NumPy documentation style in Streaming (pyspark.streaming.*)

AmplabJenkins commented on pull request #30346: URL: https://github.com/apache/spark/pull/30346#issuecomment-727297309 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #30346: [SPARK-33253][PYTHON][DOCS] Migration to NumPy documentation style in Streaming (pyspark.streaming.*)

SparkQA removed a comment on pull request #30346: URL: https://github.com/apache/spark/pull/30346#issuecomment-727295568 **[Test build #131103 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131103/testReport)** for PR 30346 at commit

[GitHub] [spark] SparkQA commented on pull request #30346: [SPARK-33253][PYTHON][DOCS] Migration to NumPy documentation style in Streaming (pyspark.streaming.*)

SparkQA commented on pull request #30346: URL: https://github.com/apache/spark/pull/30346#issuecomment-727297266 **[Test build #131103 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131103/testReport)** for PR 30346 at commit

[GitHub] [spark] SparkQA commented on pull request #30346: [SPARK-33253][PYTHON][DOCS] Migration to NumPy documentation style in Streaming (pyspark.streaming.*)

SparkQA commented on pull request #30346: URL: https://github.com/apache/spark/pull/30346#issuecomment-727295568 **[Test build #131103 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131103/testReport)** for PR 30346 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination

AmplabJenkins removed a comment on pull request #30379: URL: https://github.com/apache/spark/pull/30379#issuecomment-727294448 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination

AmplabJenkins commented on pull request #30379: URL: https://github.com/apache/spark/pull/30379#issuecomment-727294448 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination

SparkQA commented on pull request #30379: URL: https://github.com/apache/spark/pull/30379#issuecomment-727294445 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35705/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination

AmplabJenkins removed a comment on pull request #30379: URL: https://github.com/apache/spark/pull/30379#issuecomment-727293839 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination

AmplabJenkins removed a comment on pull request #30379: URL: https://github.com/apache/spark/pull/30379#issuecomment-727293087 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination

SparkQA removed a comment on pull request #30379: URL: https://github.com/apache/spark/pull/30379#issuecomment-727271125 **[Test build #131099 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131099/testReport)** for PR 30379 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination

AmplabJenkins commented on pull request #30379: URL: https://github.com/apache/spark/pull/30379#issuecomment-727293836 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination

SparkQA commented on pull request #30379: URL: https://github.com/apache/spark/pull/30379#issuecomment-727293715 **[Test build #131099 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131099/testReport)** for PR 30379 at commit

[GitHub] [spark] ulysses-you commented on a change in pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

ulysses-you commented on a change in pull request #30368: URL: https://github.com/apache/spark/pull/30368#discussion_r523596769 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -1452,11 +1452,21 @@ object

[GitHub] [spark] AmplabJenkins commented on pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination

AmplabJenkins commented on pull request #30379: URL: https://github.com/apache/spark/pull/30379#issuecomment-727293087 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination

SparkQA commented on pull request #30379: URL: https://github.com/apache/spark/pull/30379#issuecomment-727293084 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35704/

[GitHub] [spark] SparkQA commented on pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination

SparkQA commented on pull request #30379: URL: https://github.com/apache/spark/pull/30379#issuecomment-727292169 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35705/

[GitHub] [spark] SparkQA commented on pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination

SparkQA commented on pull request #30379: URL: https://github.com/apache/spark/pull/30379#issuecomment-727291002 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35704/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination

AmplabJenkins removed a comment on pull request #30379: URL: https://github.com/apache/spark/pull/30379#issuecomment-727290920 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination

AmplabJenkins commented on pull request #30379: URL: https://github.com/apache/spark/pull/30379#issuecomment-727290920 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination

SparkQA commented on pull request #30379: URL: https://github.com/apache/spark/pull/30379#issuecomment-727290918 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35703/

[GitHub] [spark] SparkQA commented on pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination

SparkQA commented on pull request #30379: URL: https://github.com/apache/spark/pull/30379#issuecomment-727288272 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35703/

[GitHub] [spark] SparkQA commented on pull request #30379: [SPARK-33455][SQL][TEST] Add SubExprEliminationBenchmark for benchmarking subexpression elimination

SparkQA commented on pull request #30379: URL: https://github.com/apache/spark/pull/30379#issuecomment-727287912 **[Test build #131102 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131102/testReport)** for PR 30379 at commit

  1   2   3   >